Commit Graph

78507 Commits

Author SHA1 Message Date
Himanshu Gupta 72297b7b81 Re-enabling a failing Tapl test for Private Space.
The test seemed to be failing due to animation issues
(settings cog and Lock text not visible)- b//339179262
Re-enabling the test as those issues are now fixed.

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: None TaplTest
Change-Id: I4053b9759cd97c721ea576965f57ef309fffaab3
2024-06-05 15:42:46 +01:00
Alex Chau 833639d8fa Fix TaskView.getThumbnailBounds not combining bounds correctly if relativeToDragLayer is true
- This was a coding error introduced in ag/27382735
- getThumbnailBounds is supposed to union all individual thumbnailBounds per TaskContainer, rather than overriding bounds over and over per TaskContainer

Bug: 339787250
Test: Swipe up to home from split apps
Flag: EXEMPT bugfix
Change-Id: I7a697620f4b4507df8f1860b4c2f9889e4be006b
2024-06-05 15:35:39 +01:00
Schneider Victor-tulias 86b9ad4ff7 Add debug logs to TopTaskTracker
Flag: NONE debug logs
Bug: 342247547
Test: checked TIS logs
Change-Id: I6c8440af122a0376ffd77df6c8c9b9aeb742d447
2024-06-05 10:34:15 -04:00
Luca Zuccarini 0f6668d011 Miscellaneous polish for new home animation.
1. Update the starting window velocity when coming from 3-button nav or
   predictive back

Before we used an arbitrary fixed velocity which goes down to basically
0 with the old implementation, but caused a noticeable jump up in the
new one when using predictive back. Now we just pass 0, since the
predictive back framework doesn't give us the actual velocity.

2. Add the scaling home reveal to the targetless (not going back to a
   specific app icon or widget) animation and 3-button nav

Bug: 298089923
Fix: 343143876
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Test: manually tested with flag on and off
Change-Id: Ied3630a51862731fad044b68f76a45dc87f2e17b
2024-06-05 13:21:46 +00:00
Alex Chau 481e3ae079 Fix icon and DWB toast focus transition
- icon and DWB toast now transition in with animation when swipe up from apps to Overview
- Refacotred focusTransition into MultiProperty, with separate control from fullScreenProgress and scaleAndDim, and get rid of "invert" parameter and iconScaleAnimStartProgress variable which is very confusing
- Added a SCALE_AND_DIM_OUT property for use with PendingAnmation during dismiss, as PendingAnimation does not support per animator interpolator
- Use height from resource in DWB toast when calcualting translation, so translation can be properly set before view is measured
- Always set bannerOffsetPercentage regardless if banner is added

Fix: 344786723
Fix: 315972057
Fix: 313644427
Flag: EXEMPT bugfix
Test: Quick switch from home, icon and DWB toast don't transition in until gesture release
Test: Quick switch from app, icon and DWB toast don't transition in until gesture release to Overview
Test: Dismiss focus task, icon and DWB toast transition in after transition settle
Test: Swipe down task, icon and DWB toast transition out with finger
Test: Launcher central task, icon and DWB toast transition out
Change-Id: Ie16a2ceff10967de38b5f66c52f4be00d0051c5f
2024-06-05 12:33:25 +01:00
Brandon Dayauon 05e963c245 Make private profile header scrollable
bug: 345007467
Test: manually video:
before: https://drive.google.com/file/d/1XzpD-R48WRKFBeDlHXU5xSGgc50ZON8o/view?usp=sharing
after: https://drive.google.com/file/d/1VBKZluzxvpP8ucs_uylk5esRlm9KzrZb/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I1db4bdf244b37b4c4cf55cb0d70d4011fee7de90
2024-06-04 17:23:43 -07:00
Android Build Coastguard Worker a107e77575 Snap for 11926388 from 2e80918e75 to 24Q3-release
Change-Id: Ie6d6fd0b06ec0b89b3dc461d4bf2d920f79d50e7
2024-06-05 00:18:15 +00:00
Jordan Silva b620e432c3 Merge "Fix split snapshot broken after rotating in fake orientation" into main 2024-06-04 22:00:10 +00:00
Andrew Cole 2c3ebd71f2 Merge "First Unit Tests for Utilities.java" into main 2024-06-04 21:28:50 +00:00
Xiaowen Lei 6c76501e0e Don't add padding for Smartspace (actual and preview).
As demonstrated in ag/27287153, the actual Smartspace doesn't have any
top padding, but the qsb_preview does.
  - Turns out, ShortcutAndWidgetContainer sets padding on its children.
  - The actual Smartspace has padding removed by overriding the
    `setPadding` method in SmartspaceViewContainer. (See ag/13562740.)

This CL updates ShortcutAndWidgetContainer.java to not add padding for
either the actual or the preview Smartspace. It makes use of
`R.id.search_container_workspace` to identify the applicable cases,
rather than checking class types or names. This way, there is no
Pixel-specific logic added.

Before: https://hsv.googleplex.com/6335187293044736?node=18
After: https://hsv.googleplex.com/5450651931770880?node=18
Actual Smartspace, for reference:
  - https://hsv.googleplex.com/6083634648842240?node=14

Note the `isChildQsb` also returns true for the QsbContainerView. Since
that class already has the same `setPadding` override:
  - https://cs.android.com/android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/qsb/QsbContainerView.java;l=147-150;drc=e58aaf1802e43f73bbd417658c1c4c42e2fe28fd
This CL does't affect its padding.

Flag: EXEMPT bugfix
Bug: 338601960
Test: Go to Wallpaper & style preview for Home screen.
Change-Id: I5b6f7752cfee556b815c83e9df85f9e74f23ab4b
2024-06-04 14:19:30 -07:00
Saumya Prakash 5365f00127 Update AllSetActivity animations for certain device types
This change updates the background animation at the All Set page for
foldables of a certain dimension.

Fix: 326231525
Fix: 335057950
Test: Run All Set page in multiple device types and observe the
background animation
Flag: EXEMPT bugfix

Change-Id: I1197d689ab76f79a80d0be46ad96ada78666c214
2024-06-04 20:31:08 +00:00
Treehugger Robot 2e80918e75 Merge "Animate RecentsView when rotating in fake orientations" into main 2024-06-04 19:05:05 +00:00
Bill Yi 1fde4f8a8e [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: b748c8e6ee -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27660191

Change-Id: If41e975c615955d48be92f4703a8b8f43423485b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-04 18:31:19 +00:00
Treehugger Robot e23256163f Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-06-04 18:04:44 +00:00
Uwais Ashraf 5580144d6b Animate RecentsView when rotating in fake orientations
Test: Manual - animations
Bug: 336704871
Flag: EXEMPT bugfix
Change-Id: I80629128a0730ca85d0313d15af806ddf840e82b
2024-06-04 17:27:59 +00:00
Jagrut Desai e263730c1e Merge "Make Taskbar Divider PopUp Menu Width Dynamic" into main 2024-06-04 17:13:36 +00:00
Brandon Dayauon 2c40b8366d Consolidate the header views updating into a single method
Call this updateView() in reset to ensure states are correct before animating.

bug: 341053089
Test: manually - video: https://drive.google.com/file/d/18ZSAEplL1Lk5ij3IHlwtRh1GQ6GhrXX1/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I2c825a7fd7d9a5faad8fbbb70d0f40294f715a42
2024-06-04 10:09:40 -07:00
Alina Zaidi c40cf8674b Merge "Add transition source for DesktopMode enter transition event originating from AppIcon press in overview" into main 2024-06-04 17:09:01 +00:00
Jordan Silva a3b66f59c2 Fix split snapshot broken after rotating in fake orientation
This CL replaces the live tile with the snapshot after rotating in fake orientation. The animateRotation function was created to extract the rotation logic to guarantee that switchToScreenshot call will only happen when there is a running task.

Fix: 326410493
Flag: EXEMPT bug fix
Test: Manual. Instructions in the bug description.
Change-Id: I9d5e1b5ca803f8f8072702b37206a73b8d8a10ed
2024-06-04 17:48:07 +01:00
Alina Zaidi f895a7b0bd Add transition source for DesktopMode enter transition event originating
from AppIcon press in overview

Test: Updated unit tests
Flag: EXEMPT not a major feature/ user visible change
Bug: b/326231756

Change-Id: I9e53cd3ec41dd2475ba90ea8fab2fb7a90f5e158
2024-06-04 13:12:04 +00:00
Jordan Silva bf5e19fcb1 Merge "Adding logs to monitor OverviewCommandHelper" into main 2024-06-04 12:49:12 +00:00
Treehugger Robot fb133bdb69 Merge "Allow DeviceProfile tests to run on TreeHugger Robolectric device" into main 2024-06-04 12:28:42 +00:00
Uwais Ashraf 801563328a Allow DeviceProfile tests to run on TreeHugger Robolectric device
Bug: 325088842
Test: Presubmit passes
Flag: EXEMPT test-only
Change-Id: Id2856b2016b2e1ba467c7b8e830631f5253d6b8c
2024-06-04 11:03:34 +00:00
Jordan Silva 11afae1bc9 Adding logs to monitor OverviewCommandHelper
This CL adds some logs to help analyzing why recents button with 3 button navigation sometimes don't open Overview.

Bug: 337954957
Test: NONE
Flag: EXEMPT Adding logs to debug issue
Change-Id: I44a799319eca667b04d4e78a38ade796fc3b69fb
2024-06-04 11:16:01 +01:00
Bill Yi b748c8e6ee Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7d47742f878876e358fec1130708bae36149f801
2024-06-03 18:20:44 -07:00
Bill Yi 4ff619a610 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4e0f4e61a5e6957bd6d52ede541d1dfe0523ab74
2024-06-03 18:20:15 -07:00
Fengjiang Li 0ebe6524f5 Merge "Animate -1 to recents" into main 2024-06-04 01:08:48 +00:00
Liam, Lee Pong Lam e48009919d [Launcher3] Hide keyboard when fastscroller scrolling down and keyboard
shown

Implement keyboard hiding logic: Hide keyboard when scrolling down (y > mLastY) unless already requested (mRequestedHideKeyboard). Track hide request state to prevent redundant calls.

New added logic: Only hide keyobard while dragging the scrollbar

result video: https://photos.app.goo.gl/e4dYUUiUN3BujNUz9

Bug: 333967597
Flag: EXEMPT bugfix
Test: Manual
Change-Id: Id672763c69cbb37aeb7a1fd3f17eb168de9f49b4
2024-06-04 00:43:30 +00:00
Liam Lee Pong Lam 61ac47e675 Merge "Revert "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard"" into main 2024-06-04 00:25:19 +00:00
Android Build Coastguard Worker 1be0377496 Snap for 11920703 from 38b9e1438e to 24Q3-release
Change-Id: I8c248849c89363c910d4b3d6123c98f3107819f2
2024-06-03 23:57:06 +00:00
Tony Wickham be10c0b10c Add flag for Recents in Taskbar
Flag: com.android.launcher3.enable_recents_in_taskbar
Test: none
Bug: 315354060
Change-Id: I5b757558ab8e5905b4142146901b68f55d0c7ef8
2024-06-03 21:12:46 +00:00
Schneider Victor-tulias 38b9e1438e Merge "Clean up unused debug logs for b/319168409" into main 2024-06-03 20:31:42 +00:00
Uwais Ashraf 000aaf649b Merge "Revert flaky FolderNameProviderTest" into main 2024-06-03 20:27:50 +00:00
Fengjiang Li 018074351c Animate -1 to recents
Fix: 343770316
Test: manual - record a video
Flag: com.android.launcher3.use_activity_overlay
Change-Id: I74346f060ea93dbc8fc0a1c3290d4996d89ec062
2024-06-03 12:59:48 -07:00
Liran Binyamin ba732a77a1 Merge "Fix bubble bar and handle visibility on first bubble" into main 2024-06-03 19:49:26 +00:00
Shamali Patwa 54d8924415 Merge changes from topic "image-previews-wrap" into main
* changes:
  Adjust previews in a row to align with each other and remove whitespace.
  Move item animator to its own class and use it only for full sheet
  Measure recommendation children using the provided available height
2024-06-03 19:47:22 +00:00
Anton Vayvod ee38224910 Guard Flags references with a check for running on Android V.
Otherwise, Launcher3 next build crashes on non-V devices.

Bug: NONE Trivial cleanup.
Test: manual
Flag: NONE The change deals with flags

Change-Id: I9d9335ea1cb0f299aa5af8095ff1ea2f98c23542
2024-06-03 19:04:41 +00:00
Liam Lee Pong Lam ee5867e980 Revert "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard"
This reverts commit 883a79db71.

Reason for revert: Revert this change because it caused other bug b/343285163

Change-Id: I1fdb21cc4a5cdcf2c22e9b1927753b290626289c
2024-06-03 19:00:14 +00:00
Ats Jenk 1507a2c59e Merge "Fix bubble position when dragged to dismiss view" into main 2024-06-03 18:30:59 +00:00
Brandon Dayauon f839b1121d Merge "Create a bug fix flag for the FloatingMaskView." into main 2024-06-03 18:18:05 +00:00
Shamali P 7a183e4051 Adjust previews in a row to align with each other and remove whitespace.
- Introduces a WidgetTableRow that identifies preview height for all of
its children while keeping them aligned with minimum whitespace
- The fullSheet's move / change animations can conflict with the resize
so, we wait for them before performing resize of the row.

Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: Id843430c7adfc228c219ba54d504baddba792df0
2024-06-03 18:07:30 +00:00
Shamali P 01d1c31ec7 Move item animator to its own class and use it only for full sheet
Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I6977e9854edcee385f5b7075f62dd1d8ff8dfdce
2024-06-03 18:07:21 +00:00
Shamali P 93ee47f729 Measure recommendation children using the provided available height
We always want to measure the pages based on the provided height.

Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I9de2ed1e0d4cc37d24435b9077e60bf5f0456091
2024-06-03 18:07:11 +00:00
Liran Binyamin 273f9ec487 Fix bubble bar and handle visibility on first bubble
When the animation of the first bubble is suppressed, immediately
stash or show the bubble bar to make sure it has been initialized
correctly.

Also we no longer automatically update the bubble bar visibility
based on its alpha value, since we're managing alpha and visibility
ourselves.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 343505267
Fixes: 343502240
Test: manually verified state for the following scenarios for the first bubble
       - in app when keyboard is open
       - in app -> open shade
       - in app -> lock device
       - on home -> open shade
       - on home -> lock device
       - in overview -> open shade
Test: manually sanity tested to make sure animations for more bubbles still work
Test: manual
       - Open test bubble app
       - Open keyboard and send a bubble
       - The bubble should animate using a HUN since the keyboard is open
       - Swipe back to hide the keyboard
       - Observe that the bubble bar no longer shows to stash into the handle
Change-Id: I754a5a9c8e961af0cdd5ccadf83d3081d4414c7e
2024-06-03 13:27:48 -04:00
Jagrut Desai 38478e74f9 Make Taskbar Divider PopUp Menu Width Dynamic
Test: Manual
Bug: 327647761
Flag: com.android.launcher3.enable_taskbar_pinning
Change-Id: Ib5c13324afee46b45b2c71e3af86c15a6384a278
2024-06-03 10:26:41 -07:00
Schneider Victor-tulias 43592a83c8 Clean up unused debug logs for b/319168409
Flag: NONE removing debug logs
Fixes: 319168409
Test: TaplDragTest#testDragAppIcon
Change-Id: I73208b042248df04281d52eaf3ed6832abbfc144
2024-06-03 12:05:40 -04:00
Uwais Ashraf 050ff39fe2 Revert flaky FolderNameProviderTest
Bug: 325088328
Test: Presubmit passes
Flag: EXEMPT test-only
Change-Id: I22c0bfdea32f552ffdb5dacc34038f7b1c668762
2024-06-03 15:35:13 +00:00
Brandon Dayauon 6b65956a5c Merge "Make PrivateSpaceSettingsButton instead of having just the imageView." into main 2024-06-03 15:02:59 +00:00
Alex Chau 5e102e4994 Handle uiMode changes in QuickstepLauncher
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity and RecentsActivity
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is affected when driving mode changes, so a recreation is ujnnecessary
- Light/dark mode changes still causes Launcher to create as expected

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly
Flag: EXEMPT bugfix
Change-Id: I3d52f0625b580a5b5a1ddbbb487c271a4bb0152b
2024-06-03 12:24:30 +01:00
Riddle Hsu 684ee34fe7 Send source rect hint to Shell via stopSwipePipToHome
Launcher has calculated it, so shell side can use it directly to
avoid inconsistency.

Bug: 331315278
Test: Assume the target app support auto-pip and it doesn't draw
      under display cutout.
      E.g. LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
      Enter PiP from 90 degrees to home with 0 degrees.
      The left side of pip should not flicker.
Change-Id: Id09efc8a30eeef14a031d9db2ab1e00b6f3034bc
2024-06-03 11:04:51 +08:00