Commit Graph

78507 Commits

Author SHA1 Message Date
Hongwei Wang 282cdebd0c Crop the center when no source rect hint
When there is no source rect hint, forge a crop that matches the given
aspect ratio and centered, therefore we can use a consolidated animation
path and fix the issue with the round corner, which was inproperly
scaled in the past.

Flag: NONE bug fix
Bug: 298409662
Test: Test the overlay in both gesture and button navigation mode,\
      with both YouTube and Google Maps,\
      in both folded and unfolded mode.
Change-Id: I8ae48b999159a51eda2ff41c49cdb3c4e1541176
2024-06-02 19:36:38 -07:00
Android Build Coastguard Worker d4154fc658 Snap for 11916023 from 9715761427 to 24Q3-release
Change-Id: Ifa76b67ec3f2b95699b03b537a544368e3cc7871
2024-06-01 21:21:49 +00:00
Android Build Coastguard Worker 62d02474a5 Snap for 11914274 from 9e496d61f8 to 24Q3-release
Change-Id: Ic18e24090a38ba4079d4ce0da7827047171f423f
2024-06-01 01:21:53 +00:00
Jeremy Sim 9715761427 Merge "Add logging for actions view" into main 2024-06-01 00:40:22 +00:00
Jeremy Sim bcaceda41a Merge "Save app pair with 50-50 snap target if snap position is SNAP_TO_NONE" into main 2024-06-01 00:39:00 +00:00
Shamali Patwa b28d9b58bd Merge "Fix test failure in post submit" into main 2024-06-01 00:12:12 +00:00
Brandon Dayauon 6f1ca642ee Merge "Rename add* to update* and call setQuietMode() itself" into main 2024-06-01 00:09:52 +00:00
Brandon Dayauon 582790c56a Merge "Fading PS container on hide." into main 2024-06-01 00:07:34 +00:00
Brandon Dayauon 736527a127 Make PrivateSpaceSettingsButton instead of having just the imageView.
This way we can keep the click listener in this PrivateSpaceSettingsButton.java class.
- Moved itemInfo creation to PrivateSpaceSettingsButton and created a test class

bug: 341053089
Test: manually - presubmit video: https://drive.google.com/file/d/1_TCGrILvwmMpxbgIcbOcpB2AxeBJbyNf/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I79cd319274f4445dd00bc257be81728360d09684
2024-05-31 17:05:13 -07:00
Jeremy Sim 2d107d8d4d Add logging for actions view
Bug: 340935208
Test: N/A
Flag: EXEMPT bugfix
Change-Id: Idb1ed848f01fc8378ae54f89ecf37cd14300ed79
2024-05-31 23:03:43 +00:00
Shamali Patwa 7c3e2ff946 Merge "Don't apply color filter on header icons if animations are disabled." into main 2024-05-31 22:00:35 +00:00
Shamali Patwa 8e7613e4c7 Fix test failure in post submit
Bug: 343937933
Change-Id: Ie989e4ce4f098a225873d13de9c6913933e5628e
Test: Unit test fix
Flag: None test fix
2024-05-31 21:59:41 +00:00
Isak Lilja 29322e82fe Save app pair with 50-50 snap target if snap position is SNAP_TO_NONE
It was not possible to save an app pair if free snap mode was enabled
and the snap position was SNAP_TO_NONE. Just default to 50-50 split if
the current divider snap position is SNAP_TO_NONE.

Cherrypicked from isak.lilja@sony.com's CL at https://partner-android-review.git.corp.google.com/c/platform/packages/apps/Launcher3/+/2835425.

Bug: 343219704
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I62347ac13440f714a493366ac66e893578a2d8d9
2024-05-31 21:52:15 +00:00
Andrew Cole 967dd54595 First Unit Tests for Utilities.java
Writing some initial unit tests for Utilities.java to get others started so they can easily add to the party.

Bug: 297950111
Test: Self
Flag: TEST_ONLY
Change-Id: I3323e6483790e2c2fbbd5c8db0281802abf0749b
2024-05-31 14:50:48 -07:00
Ats Jenk af5a393f88 Fix bubble position when dragged to dismiss view
When moving a bubble to dismiss view, use the drag translation x methods
to set the translation x values.
When bubble is moved to the dismiss view, the container will animate
back to the initial position. And we need to account for this while
bubble is in the dismiss view.

Bug: 339659499
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, drag bubble to other side and then to dismiss view,
  observe that bar moves back to original side and bubble is at the
  center of the dismiss view
Change-Id: I4c6e1be2dcd1180d985ceafccfc0f18466549347
2024-05-31 14:21:40 -07:00
Kevin Lim 9e496d61f8 Merge "[IconCache] Override persistent log method for when BaseIconCache retreived empty ApplicationInfo or default app icon" into main 2024-05-31 20:56:21 +00:00
Jagrut Desai 98eac2c1b2 Merge "Removing TWO_NEXUS_LAUNCHER_ACTIVITY_WHILE_UNLOCKING" into main 2024-05-31 20:40:54 +00:00
Federico Baron 4aa92bec7f Merge "Revert "Add screenrecord for testAllAppsFromHome()"" into main 2024-05-31 20:13:52 +00:00
Federico Baron 48c2b2b509 Merge "Add screenrecord/demote TwoPanelWokrspaceTest" into main 2024-05-31 20:13:22 +00:00
Federico Baron 4e9adbae11 Merge "Add screenrecord for testDragAppIcon" into main 2024-05-31 20:13:05 +00:00
Treehugger Robot b805620a91 [automerger skipped] Merge "Cancel manual animation if LauncherState changes during drag." into 24D1-dev am: 85e9c6f1a2 -s ours
am skip reason: Merged-In I6364dbde8aea67f5d1c525edf57ed7eb26096cf9 with SHA-1 22dee942b5 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27249862

Change-Id: Ibfe7ada5ccadbcc86a0acc61fa3ee2e950a648f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-31 19:35:52 +00:00
Andy Wickham 5e98ba57be [automerger skipped] Cancel manual animation if LauncherState changes during drag. am: 649903838e -s ours
am skip reason: Merged-In I6364dbde8aea67f5d1c525edf57ed7eb26096cf9 with SHA-1 22dee942b5 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27249862

Change-Id: I762325e36ffde2bd90452de69b35b8f303c1ded1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-31 19:35:45 +00:00
Treehugger Robot 85e9c6f1a2 Merge "Cancel manual animation if LauncherState changes during drag." into 24D1-dev 2024-05-31 19:27:25 +00:00
Brian Isganitis 8aad11912d Merge "Only stash for IME when in-app and in overview." into main 2024-05-31 19:25:31 +00:00
Kevin Lim f284f45581 [IconCache] Override persistent log method for when BaseIconCache
retreived empty ApplicationInfo or default app icon

Bug: b/343233224
Flag: NONE logging change for investigation
Test: NONE logging change for investigation
Change-Id: I5cd586a4868486c540a0497e2130764d44577ee9
2024-05-31 18:53:11 +00:00
Jagrut Desai 1eb576905a Removing TWO_NEXUS_LAUNCHER_ACTIVITY_WHILE_UNLOCKING
Test: Presubmit
Bug: 273347463
Flag: TEST_ONLY
Change-Id: Idcd49b857e6f6c2832211306c90a19c88fb2a224
2024-05-31 11:01:50 -07:00
fbaron 701eef07ab Add screenrecord for testDragAppIcon
Bug: 343953783
Test: TaplDragTest#testDragAppIcon
Flag: TEST_ONLY
Change-Id: I598fd1c7e153c077de0d5babb0eadf09cc10fa1f
2024-05-31 10:20:02 -07:00
Ats Jenk 348ac13cfe Merge "Notify pin controller about stuck to dismiss" into main 2024-05-31 16:46:54 +00:00
Shamali Patwa 9040505afb Don't apply color filter on header icons if animations are disabled.
Disabling animations altogether reduces the flakiness, however, icon's alpha seem to be changed and then cleared, and there was 1 out of 24 runs where it flaked; so, avoiding the toggle of alpha when animations are disabled.

Bug: 337916664
Test: Screenshot tests
Flag: N/A
Change-Id: I4e9d703d005e3916ee01cf74baa2a804a3c1efd1
2024-05-31 15:08:47 +00:00
Jordan Silva a74d1e419b Merge "Add Accessibility Menu support for multiple DWB banners" into main 2024-05-31 11:15:00 +00:00
Jagrut Desai 4c6913395c Merge "Accessibility Annoucement for the always show taskbar switch" into main 2024-05-31 05:33:15 +00:00
Himanshu Gupta af724fcea5 Fading PS container on hide.
This change adds a fading effect to the PS
container when Space is locked with
"hide when locked" toggle enabled.

Video: https://photos.app.goo.gl/pqhsvhfBqkTcbHXa9
GPU Profile Video: https://photos.app.goo.gl/V9yLYDH4EtAZZNrt8
before: https://drive.google.com/file/d/1bThcu34w2kgiJhgeGSmeZY_lVnMgCdsQ/view?usp=sharing
after: https://drive.google.com/file/d/1ceI3A8UXyx7GYDfHGRkN8Wkzoi-01OVh/view?usp=sharing

Bug: 299294792
Test: Manual Flash
Flag: None Animation tweak.
Change-Id: I742036f43605ca9a64f0d0a22c86b3fd69223456
2024-05-30 17:06:39 -07:00
Android Build Coastguard Worker c8dd2d2a7e Snap for 11908474 from 991a40ca92 to 24Q3-release
Change-Id: I38986697fe625519f89a9e792a8ce77aab3d0f43
2024-05-30 23:22:03 +00:00
Sihua Ma 3b2a136272 Run UiThreadTest in LauncherMultivalentJUnit
Additionally migrating DisplayControllerTest to multivalent

Flag: TEST_ONLY
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Change-Id: I9ff89218947b32f79b39bb0e6dd4beabec3b7369
2024-05-30 23:11:29 +00:00
Jagrut Desai 7570f36e28 Accessibility Annoucement for the always show taskbar switch
Test: Manual
Bug: 326012899
Flag: com.android.launcher3.enable_taskbar_pinning

Change-Id: Idad1c6349d14153468e0c660703f5ff1808ab8e5
2024-05-30 14:50:53 -07:00
Brian Isganitis d4d6388c8a Only stash for IME when in-app and in overview.
Making it a force stashed flag does not work because we do not stashing
to occur in Launcher non-overview states.

Flag: EXEMPT bugfix
Fix: 343756969
Test: Manual
Change-Id: Ib9c9e6fd1213777e66e8b48a20a2bbeb210ded8a
2024-05-30 16:02:06 -04:00
Anushree Ganjam 991a40ca92 Merge "Update the Online search Engine key to "selected_search_engine"." into main 2024-05-30 19:50:05 +00:00
Priyanka Advani 34459f0210 Merge "Revert "Always report mandatory insets for button nav"" into 24D1-dev am: 8ec05c628b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27593486

Change-Id: I6242e741fba0b4b95be4b7e47a44ad515faf64b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 18:57:33 +00:00
Priyanka Advani 8ec05c628b Merge "Revert "Always report mandatory insets for button nav"" into 24D1-dev 2024-05-30 18:50:44 +00:00
Brandon Dayauon 16cb3efa1f Rename add* to update* and call setQuietMode() itself
bug: 341053089
Test: manually - presubmit
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I7d88f18e08f45fc731f3122c55986a12e754d56a
2024-05-30 11:02:01 -07:00
Tracy Zhou 55308cadcf Merge "Support trackpad tapl tests in 3-button mode" into main 2024-05-30 17:59:13 +00:00
fbaron 09ac97fa39 Add screenrecord/demote TwoPanelWokrspaceTest
Flag: TEST_ONLY
Test: TaplTwoPanelWorkspaceTest#testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Bug: 329935119
Change-Id: I6faa8f35a2e0cd8a02d615a329baab045235ec82
2024-05-30 10:29:38 -07:00
Jordan Silva 1b487619a0 Add Accessibility Menu support for multiple DWB banners
Fix: 341672022
Flag: EXEMPT Bug fix
Test: Manual. With Talkback on, open two apps in split screen and both with DWB enabled, go to Overview, access the Accessibility Menu > Actions.
Change-Id: Iff6adf8d549aa00ea42598cbfbdaf8c7a4164b29
2024-05-30 18:22:38 +01:00
Jordan Silva 503985c663 Merge "Fix Talkback wrong label announced going from App to Overview" into main 2024-05-30 16:02:55 +00:00
Shamali Patwa c4c554139f Merge "Scale down the widget previews on similar scale as the spring load scale" into main 2024-05-30 14:58:41 +00:00
Jordan Silva 8181dfdf92 Fix Talkback wrong label announced going from App to Overview
To fix the incorrect title information being spoken after a transition state ends, a new function named getTitle is introduced in the LauncherState. This function provides the correct title for the transition state. The default accessibility label is set to R.string.home_screen. All Apps and Overview states override the getTitle function to ensure the correct accessibility label for their respective states.

Fix: 265892510
Flag: EXEMPT bugfix
Test: Manual with Talkback. With Talkback enabled, navigate from App to Overview.
Change-Id: I96b820f310f8b778a149709bca687a5912386246
2024-05-30 14:01:32 +00:00
Chaitanya Cheemala 1773b06050 Revert "Always report mandatory insets for button nav"
This reverts commit 4304a14206.

Reason for revert: Likely culprit for b/343564388  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ibc6fae27f31bcb54406da013babc76b2d5fc7f10
2024-05-30 11:44:57 +00:00
Treehugger Robot 1d9f23b1ad Merge "Fix DWB banner not showing up for split tasks" into main 2024-05-30 11:04:37 +00:00
Uwais Ashraf 9d4f5d1cc9 Merge "Replace verifyZeroInteractions with verifyNoMoreInteractions" into main 2024-05-30 10:10:13 +00:00
Jordan Demeulenaere 92e807e471 Merge "Replace ktfmt.py hook by built-in hook in Launcher3/" into main 2024-05-30 08:22:43 +00:00