- animateClose uses ObjectAnimator which is able to skip animation automatically
Fix: 332685379
Test: OverviewMenuImageTest
Test: Remove animations in Settings, open and close the menu in handheld
Flag: EXEMPT bugfix
Change-Id: I5bfe835cffc77ff7f835ff3c41bbd64fc7121ed2
- In BaseContainerInterface.calculateTaskSize, combine both portrait and landscape/seascape insets to leave space for status bar/nav bar in either orientations.
- Rotate the paddings to portrait before applying
- Don't use getOverviewActionsClaimedSpace() in fake landscape/seascape
Bug: 344727200
Test: We can't currnetly autotest fake orientaiton
Test: With gesture/3-button, rotate Overview to portriat/landscape/seascape/fake-landscape/fake-seascape, launch task and enter overview
Flag: EXEMPT bugfix
Change-Id: Icda0f483781921cae78f1ea3ef003562b60ad75a
* on rotation taskbar re-inflates it's hotseat views.
If we're already in split, then FloatingTaskView tries to do calculations
on the view's position in the window, but has a reference to the
old, pre-rotated view which is no longer in any window.
* This sets startingPosition to be an empty rect, which is used to
set LayoutParam values, which are used downstream in update() to calculate
scale, and thus we end up dividing by 0.
* TODO(b/345556328) figure out a better solution than checking for an
empty rect
Fixes: 342606096
Test: Repro steps don't cause crash
Flag: EXEMPT bugfix
Change-Id: Icb546a05d383d1997a92471fc1de3ffc37d06eca
Merged-In: Icb546a05d383d1997a92471fc1de3ffc37d06eca
(cherry picked from commit 410681a955)
* on rotation taskbar re-inflates it's hotseat views.
If we're already in split, then FloatingTaskView tries to do calculations
on the view's position in the window, but has a reference to the
old, pre-rotated view which is no longer in any window.
* This sets startingPosition to be an empty rect, which is used to
set LayoutParam values, which are used downstream in update() to calculate
scale, and thus we end up dividing by 0.
* TODO(b/345556328) figure out a better solution than checking for an
empty rect
Fixes: 342606096
Test: Repro steps don't cause crash
Flag: EXEMPT bugfix
Change-Id: Icb546a05d383d1997a92471fc1de3ffc37d06eca
Additionally, let only prediction system provide suggestions, since the
UI surface has been there for a while, adding locally filtered widgets
from app package isn't required.
Bug: 345520128
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: Ia97f0743fefeae750e07a694bb19d24a5cc11ffe
When the bubble bar collapses, explicitly set the alpha to 1
for bubbles that should not be hidden.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345283193
Test: manual
- create 3 bubbles in the bar
- tap to expand
- select the last bubble
- tap it again to collapse
- observe it is visible
Change-Id: I1aed310b66433b88b08ccaf760fc8e82923b1b64
The flake happened to be due to rebinding triggered on attachToWindow that reset the icon cache with placeholder icon
Based on what I see, instead of calling refresh and bind, just triggerring onWidgetsBound should be okay - assuming it was trying to bind view for case when theme or display size was changed while picker was open.
Bug: 337916664
Change-Id: Ic6f3ff9188e4c5eda141a948ffa0c2c7c685162e
Test: Screenshot test
Flag: EXEMPT bugfix for test
Updated logic for taskbar scrim view alpha calculation, setting it to 0
when bubble manage menu is shown.
Fixes: 337169457
Flag: NONE
Test: Visual.
For gesture navigation:
1) On foldable phone while device is being folded expand any
bubble, click mange button, then unfold. Observe no scrim view is
visible.
2) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles are open.
3) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles and mange menu is open.
4) Enable persistent taskbar. Fold device. Open bubble and click manage
button. Unfold device. Observe no scrim view is visible.
For 3 button navigation
1) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles are open.
2) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles and mange menu is open.
3) Fold device, open bubble and click manage button. Unfold device.
Observe no scrim view is visible.
Change-Id: Ic011ae9bd11801a479062cc51c60377823a926fb
This could be caused by landscape layout not receiving inset changes
Adding logs for hotseat layout info as well
Bug: 335141365
Flag: EXEMPT bugfix
Test: N/A
Change-Id: I987f8622907a10fac5375ddddac3db2c5eba41c1
Move strings to quickstep as bubble bar is in that folder.
Bug: 344670947
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, check talkback on bubble bar and bubbles
Change-Id: I2da1f0c8fc6ec13f04b2c75c9eb1a27ec598d564
Set content description on the bubble bar when it is collapsed. Only
allow focus on the bar itself. In collapsed mode, bubbles in the bar
can't be focused.
Content description for the bar matches what we have in floating mode.
We include the text for the first bubble and then how many bubbles are
there more.
Set content description on bubbles in bubble bar. When bubble bar is
expanded, only the bubbles are focusable.
Bubble content description matches the floating bubbles content
description. Includes the notification title and app name.
Bug: 344670947
Flag: com.android.wm.shell.enable_bubble_bar
Test: enable talkback, focus on bubble bar when it is collapsed, check
that only bubble bar receives focus
Test: enable talkback and expand bubble bar, check that only the bubbles
receive focus
Change-Id: Id931f0360b9ebadd01dd16b05b75546fcc4df803
Treehugger Robot
Bill Yi
Mykola Podolian
Alex Chau
Winson Chung
Vinit Nayak
Shamali P
Android Build Coastguard Worker
Xin Li
Liran Binyamin
Himanshu Gupta
Hongwei Wang
Xiaowen Lei
Saumya Prakash
Ats Jenk
Sihua Ma
Brandon Dayauon