Commit Graph

78507 Commits

Author SHA1 Message Date
Liran Binyamin 27471df69c Merge "Animate new bubble when the bar is expanded" into main 2024-06-11 20:25:15 +00:00
Treehugger Robot 0f83d92ae4 Merge "Scrolling down to locate PS after lock/unlock event." into main 2024-06-11 20:24:17 +00:00
Tracy Zhou 70041c88ad Initialize mRotationTouchHelper before onInputDeviceAdded
There is dependency there that can cause npe from mRotationTouchHelper not initialized yet

Fixes: 345893434
Test: N/A
Change-Id: Ib9009f23d71eccf6b554e21c51ba640304250af0
2024-06-11 13:06:03 -07:00
Schneider Victor-tulias 3eb4efac95 Exclude home and recents activity types when overriding recents-excluded tasks
These tasks could point to overview itself, causing a very confusing screenshot. By excluding these tasks, we will default to using the task preview

Flag: NONE bug fix
Fixes: 336334715
Test: used circle to search from home, swiped to home, then pressed "select" overview action button. also checked temp logs
Change-Id: I0b0ca50585413b479e4830f06b57b8b5e19670a8
2024-06-11 16:01:09 -04:00
Himanshu Gupta 3a4b79bf7b Scrolling down to locate PS after lock/unlock event.
This change fixes TAPL tests by:
1. Scrolling down to locate PS, in case the scrollbar moves after lock/unlock.
2. Retrying lock/unlock, as sometimes, the request is cancelled by UserManager (if the profile is already in that state)

Bug: 345556016
Test: atest TaplPrivateSpaceTest
Flag: NONE Tapl fix tweak.
Change-Id: Ic0cc3259a2f92065a699d694c47f65c5f68934b8
2024-06-11 18:15:51 +00:00
Himanshu Gupta 261a62219b Prompting the user to set Pixel/Quickstep as default Home app.
requestQuietMode API throws SecurityException in case its called
from a non-default Launcher app.
To mitigate this, we catch the exception and prompt the user
to set their default launcher to the current app.

Video(Pixel): https://photos.app.goo.gl/ni5X1c6vBbYW2JMJ9
Video(Pixel-aosp): https://photos.app.goo.gl/cYLJpTYW76Jnbonc9

Bug: 320446272
Test: Manual
Flag: NONE Bug fix tweak.
Change-Id: I6afb2ae85cabc038e1503e9c34eebd974c4f7a50
2024-06-11 19:11:21 +01:00
mpodolian 84f9cfabb9 Add outline to the bubble bar background view.
Added outline to the bubble bar background. Updated pointer
appearing/disappearing animation - now pointer moves into the bubble
bar background.
Demo: http://recall/-/gx8ASgewUeUS3QYohfrd1J/e1wZMrFZTILq73ik8wwrwx

Fixes: 345489039
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: Manual. Expand and collapse bubble bar with the light and the
dark theme.

Change-Id: I095fdc12337955aa21ee0eb622a924ad424ef186
2024-06-11 19:03:24 +01:00
Tracy Zhou 1deac6777b Fix crash from isTrackpadDevice
Apparently InputManager.getInputDevice can return null when a device is added

Fixes: 344902395
Test: N/A
Change-Id: I79c3dd3431b1d4b079b8a6863688a13ea2741602
2024-06-11 10:40:17 -07:00
Jagrut Desai 31a65a08dc Fix Taskbar All Apps Button to be Fixed in Minimal Taskbar State
Test: Manual
Bug: 346387672
Flag: NONE taskbar all apps is not behind a flag
Change-Id: Iea63ccf57354a1e2941bd51f7f6f9e69187c4545
2024-06-11 09:23:23 -07:00
Michal Brzezinski 2eff95ef6d Disabling touchpad gestures in launcher for SYSUI_STATE_TOUCHPAD_GESTURES_DISABLED state
As gestures start with checking of canStartTrackpadGesture() method, disabling it there disables all touchpad gestures.

Test: RecentsAnimationDeviceStateTest
Flag: NONE these changes are not directly flagged but usage of SYSUI_STATE_TOUCHPAD_GESTURES_DISABLED state is guarded by flag: com.android.systemui.new_touchpad_gestures_tutorial
Bug: 345207568
Change-Id: I0409475a3e006609c6b722cd3b17d75e1ebed939
2024-06-11 15:28:31 +01:00
Charlie Anderson a8f0155c89 Merge "Adding bugfix flag for archiving bug extras" into main 2024-06-11 13:58:35 +00:00
Jeremy Sim 5aa28b472a Merge "Expand touch target of split cancel button to meet a11y requirements" into main 2024-06-11 05:13:35 +00:00
Riddle Hsu 8fbf819737 Merge "Send source rect hint to Shell via stopSwipePipToHome" into main 2024-06-11 04:45:25 +00:00
Jeremy Sim dafbaa5f1b Merge "Fix flaky test" into main 2024-06-11 04:12:58 +00:00
Charlie Anderson 9e12c3f152 Adding bugfix flag for archiving bug extras
Bug: 322314760
Test: locally
Flag: com.android.launcher3.enable_first_screen_broadcast_archiving_extras
Change-Id: I33edcf09eee990727613246fb5942263feb49625
2024-06-11 00:07:24 -04:00
Jeremy Sim e94e509413 Expand touch target of split cancel button to meet a11y requirements
This CL adds a TouchDelegate to the "Cancel" button on SplitInstructionsView so that it is always at least 48dp by 48dp. I.e. if the touch target is smaller than 48dp, it expands the TouchDelegate to be at least that size.

Fixes: 323108127
Test: Manually verified that the touch target is larger
Flag: EXEMPT bugfix
Change-Id: Id14bc39660ee7767991a3b5613f1282945a2ef96
2024-06-10 19:54:50 -07:00
Treehugger Robot 9aafa6bd76 Merge changes I8411fb83,I5b757558 into main
* changes:
  Move Desktop running apps support into TaskbarRecentAppsController
  Add flag for Recents in Taskbar
2024-06-11 02:16:56 +00:00
Winson Chung 0101ae5062 [automerger skipped] Add max width to the screen instructions view text am: 3fa291e1a7 -s ours
am skip reason: Merged-In I73e889372a5c482277b0e4b61fb834304304c0a6 with SHA-1 73cf3bc3a1 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27773016

Change-Id: Id6c5fc20268b0f17c8a9558da6a72ee59c94ce9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-11 01:31:02 +00:00
Tony Wickham a2b510dc23 Move Desktop running apps support into TaskbarRecentAppsController
- Merged DesktopTaskbarRunningAppsController up into
  TaskbarRecentAppsController, which is now initialized directly
- The old TaskbarRecentAppsController was effectively a no-op
  that was always overridden, so merging the one subclass up makes
  things simpler (especially for the follow up CLs which will add
  support for switching between Running and Recent tasks using
  the same underlying data).

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: TaskbarRecentAppsControllerTest
Bug: 315354060
Change-Id: I8411fb832e5dd3d76201d2694dec0b11bd70bbf9
2024-06-11 00:18:23 +00:00
Liran Binyamin f461eab5ca Merge "Fix state after dragging bubble to dismiss" into main 2024-06-10 23:42:00 +00:00
Android Build Coastguard Worker 535a2a089e Snap for 11949167 from d655aa4dab to 24Q3-release
Change-Id: If9d194c7066ed4af5cd17a0ab8f121f2a79c2d8b
2024-06-10 23:22:38 +00:00
Treehugger Robot cf68e59c02 Merge "Finish the running recents animation when the user locks their device mid-animation." into main 2024-06-10 22:31:19 +00:00
Jeremy Sim c1470021c8 Fix flaky test
Attempts to fix a flaky test by ensuring that recents is always cleared before creating a split pair (so the split pair under test is always the same).

Bug: 340935208
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair(), testSplitTaskTapBothIconMenus()
Flag: TEST_ONLY
Change-Id: Ibc81b90fac531f0e78e93a494ff59073ab5e52cf
2024-06-10 14:51:53 -07:00
Winson Chung 3fa291e1a7 Add max width to the screen instructions view text
- This ensures that the instruction wraps if the text is too long

Fixes: 328577545
Fixes: 345128488
Flag: EXEMPT bugfix
Test: Visual inspection of instructions view in different languages/form
      factors
Change-Id: I73e889372a5c482277b0e4b61fb834304304c0a6
Merged-In: I73e889372a5c482277b0e4b61fb834304304c0a6
(cherry picked from commit 73cf3bc3a1)
2024-06-10 21:08:18 +00:00
Sihua Ma c22a8e7495 Merge "Migrate GeneratedPreviewTest to multivalent" into main 2024-06-10 20:57:00 +00:00
Liran Binyamin 48811c385c Animate new bubble when the bar is expanded
When a new bubble is added when the bubble bar is expanded,
we now scale in the new bubble.

This change only handles the case where we're not at the limit.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/hW4pwqpAttscedRMxnu5BN

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 345795791
Test: manual
      - Expand bubble bar
      - Push a new bubble and verify it scales in
Change-Id: Iafae1d0c8feb8e5a8853d54e7299db261df4ebf4
2024-06-10 16:45:22 -04:00
Pragya Bajoria d8522b7828 Update the flag check for back gesture to include tablet filtering to reduce the scope of desktop windowing logic.
Change-Id: I15edeceebfdc14569c1b98caf62c741b40049200
Bug: 346249587
Flag: EXEMPT (windowing is currently only limited to Tablet)
2024-06-10 19:29:30 +00:00
Kshitish Vyas d655aa4dab [automerger skipped] Merge "Ensure starting position rect isn't empty in FloatingTaskView" into 24D1-dev am: f309097aa8 -s ours
am skip reason: Merged-In Icb546a05d383d1997a92471fc1de3ffc37d06eca with SHA-1 410681a955 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27730882

Change-Id: Ia78fb863745ec0d95c00827b6b7168516eb6e754
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-10 19:02:14 +00:00
Vinit Nayak 92deaa9ecc [automerger skipped] Ensure starting position rect isn't empty in FloatingTaskView am: f8efb32379 -s ours
am skip reason: Merged-In Icb546a05d383d1997a92471fc1de3ffc37d06eca with SHA-1 410681a955 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27730882

Change-Id: I0758255916837fe91d0f37b884b6c0e8e04f5123
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-10 19:02:11 +00:00
Kshitish Vyas 40056d8771 [automerger skipped] Merge "Always report mandatory insets for button nav" into 24D1-dev am: 91dfdc61b8 -s ours
am skip reason: Merged-In I18d4f5d212d16c62d15d84b4842b3d20c0d8c5ae with SHA-1 762b3b4685 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27730647

Change-Id: I52bc0e5861dac8b5ba667fcd26a2c40d43b3bda5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-10 19:01:25 +00:00
Winson Chung adb1bfeded [automerger skipped] Always report mandatory insets for button nav am: 669b9c5c30 -s ours
am skip reason: Merged-In I18d4f5d212d16c62d15d84b4842b3d20c0d8c5ae with SHA-1 762b3b4685 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27730647

Change-Id: I25df7a02cfa0e9abee107d32a56e01cbee700fca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-10 19:01:22 +00:00
Kshitish Vyas f309097aa8 Merge "Ensure starting position rect isn't empty in FloatingTaskView" into 24D1-dev 2024-06-10 18:33:32 +00:00
Kshitish Vyas 91dfdc61b8 Merge "Always report mandatory insets for button nav" into 24D1-dev 2024-06-10 18:32:14 +00:00
Liam Lee Pong Lam df709d9aef Merge "[Launcher3] Hide keyboard when fastscroller scrolling down and keyboard shown" into main 2024-06-10 17:40:24 +00:00
Sihua Ma de5ef62967 Migrate GeneratedPreviewTest to multivalent
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Fix: 325088369
Flag: TEST_ONLY
Change-Id: I2c88a357c8ac5fb0171a70e850be25e8fb11de33
2024-06-10 16:49:47 +00:00
Schneider Victor-tulias e2bdd1568c Finish the running recents animation when the user locks their device mid-animation.
Flag: NONE bug fix
Fixes: 319022192
Test: locked device during home animation and checked temp logs
Change-Id: I884694a4318348259b04c3b6073d3ea37eff98fb
2024-06-10 11:48:34 -04:00
Liran Binyamin ce3bbc7b5e Fix state after dragging bubble to dismiss
After dragging a bubble in the bubble bar to dismiss it,
we remove it from the view and update the width of the bubble bar.

The issue here is that the drag state only gets cleared in
BubbleBarView after the dismiss animation is complete, so when
the width is updated, we don't reposition all the bubbles according
to the new width, and end up in a weird state.

The fix is to clear the drag state in onDragDismiss.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345482103
Test: manual
       - Add multiple bubbles to the bubble bar
       - Drag a bubble to dismiss it
       - Observe bubble bar updates correctly
       - Repeat with other bubbles
Change-Id: Ie94f8ace0f5660466686a261174b42c8d71b3e30
2024-06-10 10:17:13 -04:00
Uwais Ashraf 8e537d1ee5 Merge "Move AppFilterTest to Deviceless" into main 2024-06-10 08:22:00 +00:00
Android Build Coastguard Worker 24e10b9d09 Snap for 11945538 from 7994cff896 to 24Q3-release
Change-Id: I28ab8795fa50f51f5658f9c70a07fbfe9b457997
2024-06-08 21:22:04 +00:00
Winson Chung 7994cff896 Merge "Add max width to the screen instructions view text" into main 2024-06-08 05:06:58 +00:00
Android Build Coastguard Worker 32da275be5 Snap for 11944020 from d37d4d8b7d to 24Q3-release
Change-Id: Ic6f5f9867c23a223c4c0b91414fb9dd68ffbe5bc
2024-06-08 01:23:48 +00:00
Federico Baron 4ebc6777cb Merge "Fix folder animation clipping and RTL issue" into main 2024-06-08 00:22:45 +00:00
Shamali Patwa 7902265f77 Merge "Fix the flaky screenshot test" into main 2024-06-07 23:14:15 +00:00
Andrew Cole 8a4af691c8 Move AppFilterTest to Deviceless
Bug: 297950111
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: TEST_ONLY
Change-Id: I9e12a23966017aa2136f92e84eebb216ed8525cf
2024-06-07 15:38:17 -07:00
Brandon Dayauon 14fb9f27f4 Merge "Make private profile header scrollable" into main 2024-06-07 22:16:42 +00:00
fbaron 31d5b01ecf Fix folder animation clipping and RTL issue
Fix: 341433475
Test: NONE
Flag: EXEMPT bugfix
Change-Id: I05c1ca65efea2fdcebb6ff9435fda1f4bbafb9f1
2024-06-07 15:09:30 -07:00
Vadim Tryshev d37d4d8b7d Merge "Removing test class TaplViewInflationDuringSwipeUp" into main 2024-06-07 21:19:04 +00:00
Winson Chung 73cf3bc3a1 Add max width to the screen instructions view text
- This ensures that the instruction wraps if the text is too long

Fixes: 328577545
Fixes: 345128488
Flag: EXEMPT bugfix
Test: Visual inspection of instructions view in different languages/form
      factors
Change-Id: I73e889372a5c482277b0e4b61fb834304304c0a6
2024-06-07 20:59:07 +00:00
Vadim Tryshev e7d59d06c4 Removing test class TaplViewInflationDuringSwipeUp
The bugs for fixing the removed tests are obsolete, and it was decided to not allocate resources for fixing the tests.

Bug: 190618549, 190729479
Test: presubmit
Flag: NONE it's a test
Change-Id: I1ca3c2c054e4b598c65c86913f0ddbbc711d7f6c
2024-06-07 12:16:37 -07:00
Ats Jenk cdc0e2c9c9 Check the feature flag before showing bubbles shortcut widget
Flag: com.android.wm.shell.enable_retrievable_bubbles
Bug: 340337839
Test: manual

Change-Id: I39424de3c448a1991a62dd198c195db5418788ba
2024-06-07 11:05:10 -07:00