Commit Graph

78507 Commits

Author SHA1 Message Date
Brandon Dayauon e2d42c617f Merge "Fix private space icons disappearing from search state." into main 2024-05-30 07:19:45 +00:00
Brandon Dayauon 987efd6ea4 Fix private space icons disappearing from search state.
This is because during onBind() that the icon alpha should be set to 0 ONLY in the case
when animation + scroll is happening.

The repro cuj is this:
user has private space unlocked -> goes to toast and clicks qs tile -> onBind() happens
and animationScrolling = true -> icon alpha is now 0. Instead we should check getAnimate() && scrolling()
&& isStateTransitioning()

bug: 340836439
Test: manually -
before: https://drive.google.com/file/d/1WLZRPsz-hm1d3fVRNGXs_Ps_AcdJhkPs/view?usp=sharing
after: https://drive.google.com/file/d/1LidDKhx2ijOXmX_tcPAmng5P56WNPyyx/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation NEXTFOOD
Change-Id: I10b8ee5d8449acdb3d2c64e0e311f7dde89a464a
2024-05-29 22:41:57 -07:00
Tracy Zhou acb4a3d1e8 Support trackpad tapl tests in 3-button mode
Currently we have logic to only enable input monitor when a trackpad is connected. Tapl tests need to have infrastructure to override that logic

Bug: 335146977
Test: presubmit
Change-Id: Ib7f80c828760f8b5abd7ed2788b246e47fca6e34
2024-05-29 21:58:20 -07:00
Treehugger Robot 236bb12736 Merge "Move SettingsActivityTest to multivalent" into main 2024-05-30 04:26:56 +00:00
Tracy Zhou a27409e8b2 Merge "Register input monitor for trackpad only when trackpad is attached" into main 2024-05-30 04:12:27 +00:00
Android Build Coastguard Worker deb51362ea Snap for 11902131 from a58d468863 to 24Q3-release
Change-Id: I39ef2987c087e08fb74e3d4c3a709dfea5081bea
2024-05-29 23:22:09 +00:00
Winson Chung 50a37b33a9 Merge "Always report mandatory insets for button nav" into 24D1-dev am: 6de4b5286a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27569834

Change-Id: I2fa88ec94e77fc7ecf4086b8de28c9602a9a85cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 23:01:24 +00:00
Winson Chung 6de4b5286a Merge "Always report mandatory insets for button nav" into 24D1-dev 2024-05-29 22:56:05 +00:00
Shamali P 3dabf391f2 Scale down the widget previews on similar scale as the spring load scale
Currently entire workspace scales down, but the original view sticks
to user's finger at same size as before. This makes the view look larger
obstructing the view of workspace behind it - specifically, when the
widgets are of larger size.

Additionally, with this scaling change, the preview images that aren't
of same aspect ratio don't break the transition to final widget as
before.

Bug: 338290585
Test: Unit test
Flag: None bugfix
Change-Id: I1d1818e60506898c7b28074f01cee91282032a94
2024-05-29 22:38:22 +00:00
Sihua Ma 9d093d5b57 Replace verifyZeroInteractions with verifyNoMoreInteractions
Also migrating LockedUserStateTest and AbstractFloatingViewHelperTest
to multivalent

Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: TEST_ONLY
Bug: 297950111
Change-Id: Ic476de791109e7892c86bf5ae77727fc0506f0b9
2024-05-29 22:03:43 +00:00
Xin Li bb2436ce0b Merge "[automerger skipped] Merge Android 24Q2 Release (ab/11526283) to aosp-main-future am: 4e3992b067 -s ours" into main 2024-05-29 21:49:57 +00:00
Brandon Dayauon c1a7d51870 Merge "Remove animatorSet's duration" into main 2024-05-29 21:16:22 +00:00
Xin Li d23f1e702a [automerger skipped] Merge Android 24Q2 Release (ab/11526283) to aosp-main-future am: 4e3992b067 -s ours
am skip reason: Merged-In Ie439b2d661617f10bbc31afada187a313dd52af7 with SHA-1 3e64dabb46 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27273786

Change-Id: I83ec34c9cdf95caebd46ba6cb99962840518804d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 20:49:31 +00:00
Anushree Ganjam 34c4605cf1 Update the Online search Engine key to "selected_search_engine".
Test steps:
1. Execute adb shell settings put secure selected_search_engine <search_engine_package_name> (Ex: com.duckduckgo.mobile.android)
2. Install the app and verify the search widget on launcher is updated.
3. Uninstall the app and verify the search widget is replaced by
   placeholder

When we change the search engine setting after the app is installed , we need to force-stop launcher app for the new settings to take effect.

Bug: 333029477
Flag: EXEMPT bugfix
Test: Manual
Change-Id: If127dcc87c5278a98177b83514cddb09a4124223
2024-05-29 13:40:41 -07:00
Vinit Nayak ca6fd26b72 Merge "Address jank and memory issues with OverviewActionsView" into 24D1-dev am: c5d3fcb655
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27580011

Change-Id: I12b8ab8e79c95f0d9fdc044f945715f37f16cb95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 20:25:57 +00:00
Vinit Nayak c5d3fcb655 Merge "Address jank and memory issues with OverviewActionsView" into 24D1-dev 2024-05-29 20:23:44 +00:00
Bill Yi a58d468863 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-29 19:23:10 +00:00
Brandon Dayauon 3f5437e14e Remove animatorSet's duration
Setting this animationDuration slows down the individual animations.
This is fine as the individual animations already has the timings that will add up to spec.

bug: 343493101
Test: before: https://drive.google.com/file/d/1nuS1c143HUosaVdhde3GW8Ryz04gUW7x/view?usp=sharing
after: https://drive.google.com/file/d/1yNcYLqBFD0di-YISNMUpryzBhqNZdncm/view?usp=sharing
Flag: None Animation tweak.
Change-Id: I5f10388fdecd934801ca208a46cc6ba93094c56f
2024-05-29 11:51:19 -07:00
Bill Yi 86c2677d82 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 6dc980e09e -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27569823

Change-Id: Iee535c4544946392e090f39f3e5b19bb6f181529
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-29 18:46:35 +00:00
Vadim Tryshev d3ef050bc3 Merge "Removing high-level events mismatch diagnostics." into main 2024-05-29 18:42:47 +00:00
Jeremy Sim 1abc4761cc Address jank and memory issues with OverviewActionsView
Attempt to improve jank and memory regressions by simplifying the view layout of OverviewActionsView.

Bug: 339688091
Bug: 339853741
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair()
Flag: EXEMPT bugfix
Change-Id: Ib4a7c5a813b221c0a083144e7fb1e1c5f3fedb1c
2024-05-29 18:15:32 +00:00
Alex Chau e081914fb1 Fix DWB banner not showing up for split tasks
- Remove DWB banner and thumbnailView from TaskView when being recycled to avoid multiple banners from staying
- Extracted DWB toastg splitbounds update to not be called whenever task icon is loaded
- Refactor DWB toast to remove unused variable, and extract mSplitBannerConfig to be a getter

Fix: 343212887
Test: OverviewImageTest.digitalWellbeingToast
Flag: EXEMPT bugfix
Change-Id: I2dbdc483a7b99de009c9e2a946e1b026c5e4817f
2024-05-29 16:44:48 +01:00
Jordan Demeulenaere 8e9da3c79c Replace ktfmt.py hook by built-in hook in Launcher3/
This CL replaces the ktfmt.py hook of this repository by the builtin
ktfmt hook. This will allow to delete our custom hook and provide
features like automatic fixup (see http://screen/5uXuuPgs7oL83c2).

Note that this also means that this CL is upgrading ktfmt from v0.43 to
v0.49, so it is expected to see some minor formatting diffs on existing
files after this CL is submitted.

Bug: 342153000
Test: N/A
Flag: NONE Repohook Update
Change-Id: I66ae0443e6d5c45c771791b4182e610a20675815
2024-05-29 16:36:46 +02:00
Uwais Ashraf 3661e3f655 Merge "Add snapshot state to TaskThumbnailView and ViewModel" into main 2024-05-29 14:21:28 +00:00
Charlie Anderson 73edd795c1 Merge "Makes testDragAppIconToMultipleWorkspaceCells more concise to avoid test timout." into main 2024-05-29 14:08:41 +00:00
Uwais Ashraf bad2e24f72 Add snapshot state to TaskThumbnailView and ViewModel
Bug: 334825222
Test: TaskThumbnailViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I829c346861a6f437b2c53dadb3a7f98084d3c962
2024-05-29 10:47:05 +00:00
Alex Chau 09ae3694e3 Merge "Address jank and memory issues with OverviewActionsView" into main 2024-05-29 09:36:37 +00:00
Winson Chung 4304a14206 Always report mandatory insets for button nav
Fixes: 340134342
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Change-Id: Iee9d5ca9f12ff63f856e7aa94227e5b8273e02a4
2024-05-29 06:39:57 +00:00
Bill Yi 6dc980e09e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9dbd0e2b4accbdcdf7c44d12022a3d5af717f9e3
2024-05-28 21:10:44 -07:00
Bill Yi 13c451a207 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4c9b78973564ccba55665b7ee93f67bcd3298334
2024-05-28 21:10:15 -07:00
Ats Jenk 2b0efdb621 Notify pin controller about stuck to dismiss
Based on changes to the base controller we now only need to notify when
a dragged item is stuck to the dismiss view.

Bug: 339659499
Test: manual
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I82c5c4946b955b06cfba91179931e690d0591107
2024-05-28 16:37:06 -07:00
Android Build Coastguard Worker 02ad1b866d Snap for 11896415 from 7a0088096f to 24Q3-release
Change-Id: I2d393107a513a02010f06ebe4627cf757d75b735
2024-05-28 23:22:22 +00:00
Brandon Dayauon e16a2725d2 Create a bug fix flag for the FloatingMaskView.
Need to create a bug-fix flag since feature flags can't reach nextfood in time for V. We do this by renaming
the current flag.

According to https://g3doc.corp.google.com/company/teams/android-core-experiments/trunk-stable/gantry-stages/bug-fix.md?cl=head

After a flag declaration has been merged, it's no longer possible to change its purpose. If the purpose of a flag changes over time, simply rename the flag; this will create a new workflow and invalidate the previous workflow.
In cases where renaming is not possible, please file a bug for the ACE oncall. Even when re-using the name of a flag for a new purpose, please note that all the progress in the pre-existing workflow will be lost; the new bug-fix workflow will start from scratch.

bug: 339850589
Test: Presubmit/locally adb shell device_config put launcher_search com.android.launcher3.private_space_add_floating_mask_view true
Flag: ACONFIG com.android.launcher3.private_space_add_floating_mask_view STAGING
Change-Id: Iffbc6a93c4ef6bbe121e0c8fb83250174f367b9d
2024-05-28 15:49:58 -07:00
Vinit Nayak 6b905584bc [automerger skipped] Merge "Return false for isSplitSelectionActive() if controller not initialized" into 24D1-dev am: b34cc291d0 -s ours
am skip reason: Merged-In I9d7d54d5f7571286778c0e82ef4082f9b5843c1d with SHA-1 b449116345 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27556735

Change-Id: I0848a3b6f577c0decb311564ed71ffe94ab50a1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-28 20:43:41 +00:00
Vinit Nayak 718ef4a2b4 [automerger skipped] Return false for isSplitSelectionActive() if controller not initialized am: f9b81f24a4 -s ours
am skip reason: Merged-In I9d7d54d5f7571286778c0e82ef4082f9b5843c1d with SHA-1 b449116345 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27556735

Change-Id: I991e21b9423eaaf4854e0a1732468100376c5fa4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-28 20:43:38 +00:00
Vinit Nayak 72a4d092af [automerger skipped] Merge "Disable gestures when split apps are animating in from shell" into 24D1-dev am: 364d784242 -s ours
am skip reason: Merged-In Ic770bdf5ae6f847b1deca3b1d7e5a389ddd6663e with SHA-1 13dea8cbc9 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27471780

Change-Id: I7da63ba6ce7930e23dd6212fbe0c455520ab9173
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-28 20:41:57 +00:00
Vinit Nayak efc17f6025 [automerger skipped] Disable gestures when split apps are animating in from shell am: f08e1afa37 -s ours
am skip reason: Merged-In Ic770bdf5ae6f847b1deca3b1d7e5a389ddd6663e with SHA-1 13dea8cbc9 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27471780

Change-Id: I8e4d1c8218a3de1231277188259b6efc8d9c2e90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-28 20:41:54 +00:00
Vinit Nayak b34cc291d0 Merge "Return false for isSplitSelectionActive() if controller not initialized" into 24D1-dev 2024-05-28 20:39:58 +00:00
Vadim Tryshev 314c35c410 Removing high-level events mismatch diagnostics.
They hide actual sequences, are not necessary for Tigers who are power users and require maintenance.

Bug: 187761685
Test: presubmit
Flag: NONE for test
Change-Id: I5d4b3d80a916845fcf8c08a0ecd135527466fa5a
2024-05-28 13:36:19 -07:00
Vinit Nayak 364d784242 Merge "Disable gestures when split apps are animating in from shell" into 24D1-dev 2024-05-28 20:21:53 +00:00
Vinit Nayak f9b81f24a4 Return false for isSplitSelectionActive() if controller not initialized
Test: unable to repro
Fixes: 342716244
Flag: EXEMPT bugfix
Change-Id: I9d7d54d5f7571286778c0e82ef4082f9b5843c1d
(cherry picked from commit b449116345)
Merged-In: I9d7d54d5f7571286778c0e82ef4082f9b5843c1d
2024-05-28 20:19:46 +00:00
Vinit Nayak e3f3118bfa Merge "Return false for isSplitSelectionActive() if controller not initialized" into main 2024-05-28 20:19:26 +00:00
Jeremy Sim 1ab32a7942 Address jank and memory issues with OverviewActionsView
Attempt to improve jank and memory regressions by simplifying the view layout of OverviewActionsView.

Bug: 339688091
Bug: 339853741
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair()
Flag: EXEMPT bugfix
Change-Id: Ib4a7c5a813b221c0a083144e7fb1e1c5f3fedb1c
2024-05-28 13:16:52 -07:00
Kevin Liu a39a4695af Merge "Add strict_mode: false" into main 2024-05-28 20:09:05 +00:00
Bill Yi 7a0088096f [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 704883eafa -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27546786

Change-Id: Ie2a5feaf69fa4de97ce36483d17d1f4e94bb5e16
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-28 18:58:58 +00:00
Andy Wickham 28cc86ee38 Merge "Revert "[omni] Handle touch slop for LPAA."" into main 2024-05-28 18:54:08 +00:00
Bill Yi f55d613d13 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-28 18:45:19 +00:00
Vinit Nayak b449116345 Return false for isSplitSelectionActive() if controller not initialized
Test: unable to repro
Fixes: 342716244
Flag: EXEMPT bugfix
Change-Id: I9d7d54d5f7571286778c0e82ef4082f9b5843c1d
2024-05-28 11:23:37 -07:00
Sihua Ma 350c29a5f6 Move SettingsActivityTest to multivalent
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: None Test migration
Bug: 297950111
Fix: 325089136

Change-Id: I85a2ed62453088941cb12fee9067acb076819dc5
2024-05-28 18:05:14 +00:00
Xin Li 667b7f5d7a Merge 2024-06 Release (ab/AP2A.240605.024) to aosp-main-future
Bug: 343100748
Merged-In: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
Change-Id: Ib58ffbc33000d37eb9066354f217c95ca56091ac
2024-05-28 10:52:34 -07:00