Commit Graph

16725 Commits

Author SHA1 Message Date
Jeremy Sim c94f4b779b Allows Launcher to recover gracefully into OverviewSplitSelect state
When Launcher restarts (as the result of a UiModeChange or something else), it attempts to recover its previous state. However, the OverviewSplitSelect state is unique because it requires some additional information to recover properly (the taskId of the staged task and so on). This change makes it so that the relevant information is passed forward in the recovery bundle. Launcher will now restart in the base Overview state, and then immediately apply the saved data to recover the OverviewSplitSelect state.

Fixes: 233019928
Test: Manual
Change-Id: Ie6123ef9c374be000268f82857b696c49213c541
Merged-In: Ie6123ef9c374be000268f82857b696c49213c541
2022-07-01 00:07:54 +00:00
Jeremy Sim fbb19cf016 Allows Launcher to recover gracefully into OverviewSplitSelect state
When Launcher restarts (as the result of a UiModeChange or something else), it attempts to recover its previous state. However, the OverviewSplitSelect state is unique because it requires some additional information to recover properly (the taskId of the staged task and so on). This change makes it so that the relevant information is passed forward in the recovery bundle. Launcher will now restart in the base Overview state, and then immediately apply the saved data to recover the OverviewSplitSelect state.

Fixes: 233019928
Test: Manual
Change-Id: Ie6123ef9c374be000268f82857b696c49213c541
2022-06-30 21:18:42 +00:00
Sunny Goyal abaf468766 Merge "Fixing widget accessibility node order" into tm-qpr-dev am: cb31a64299 am: 0ef2251b40
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19119907

Change-Id: Iab6f0979a2bc15d0cdb71c53a4cd393eb3ca6a30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-30 19:57:33 +00:00
Sunny Goyal cb31a64299 Merge "Fixing widget accessibility node order" into tm-qpr-dev 2022-06-30 19:22:26 +00:00
Tony Wickham 539c2703ea Move TEST_HARNESS_TRIGGER_TIMEOUT to MotionPauseDetector directly
- Removed TestProtocol.sForcePauseTimeout and
  TestProtocol.REQUEST_SET_FORCE_PAUSE_TIMEOUT
- Instead, add MotionPauseDetector.TEST_HARNESS_TRIGGER_TIMEOUT, which
  is used when Utilities.IS_RUNNING_IN_TEST_HARNESS.

Test: unbundled/launcher/launcher3_test_platform
Fixes: 232548865
Change-Id: I224e99042b41375cab6bffd555434217518958c5
2022-06-30 12:16:08 -07:00
Abhilasha Chahal ac0d54dd02 Merge "Allow overriding DragController and drag use cases" into tm-qpr-dev am: a8dcd442fe am: 9ef8af1d3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19117748

Change-Id: I1b0e8ba25e8ad30bd5398edb81c3e0ba5905b728
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-30 10:41:44 +00:00
Abhilasha Chahal a8dcd442fe Merge "Allow overriding DragController and drag use cases" into tm-qpr-dev 2022-06-30 10:04:07 +00:00
TreeHugger Robot 72c5f330bf Merge "Add TAPL API for adding app icon to hotseat" into tm-qpr-dev 2022-06-30 05:28:14 +00:00
Sihua Ma ff327e6d0e Merge "Fill the fade-in ImageView with its content for the cross fade animation" into tm-qpr-dev am: 9ce586b3cb am: 91187fb9cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19016434

Change-Id: I229d9cadcb210d41c838f8a87cc1ecee3abc9f80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-29 23:03:03 +00:00
Sihua Ma 9ce586b3cb Merge "Fill the fade-in ImageView with its content for the cross fade animation" into tm-qpr-dev 2022-06-29 22:17:20 +00:00
Sunny Goyal 4827a7d5a9 Fixing widget accessibility node order
Making sure that that search and prediction bar are on top of
RecyclerView/PagedView. This is determined by the widget of the
drawn width of the views if their top matches

Bug: 209579563
Test: Verified that the tite is focused first when opening widgets
Change-Id: Ib800b3743ece915ac4894029462d5776d389ff3f
2022-06-29 11:32:36 -07:00
Abhilasha Chahal cb32935281 Allow overriding DragController and drag use cases
Test: Manually verified Launcher3 works fine
Bug: 233864888
Change-Id: Ifb2fe19c0a2b332862b36b1ac0100e0f5301a5a6
2022-06-29 17:29:47 +00:00
Sunny Goyal 1db6188f06 Merge "Fixing nullpointer exception when accessing StatsLogger before initialization" into tm-qpr-dev am: 24d7de43fb am: 104bb034ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19087430

Change-Id: Id259b32db17f33f6d6d8217a18c9231bc34d1110
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-29 17:03:40 +00:00
Sunny Goyal 24d7de43fb Merge "Fixing nullpointer exception when accessing StatsLogger before initialization" into tm-qpr-dev 2022-06-29 16:17:55 +00:00
Jeremy Sim 4e0e3b87cc Merge "Prevents split thumbnails from flipping when entering Overview in fake seascape" into tm-qpr-dev am: 9b7280bd70 am: 0c693832d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19071744

Change-Id: Icacab0cbfdd36da02c31793b154cb36cdadfdbdd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-29 06:14:37 +00:00
Jeremy Sim 9b7280bd70 Merge "Prevents split thumbnails from flipping when entering Overview in fake seascape" into tm-qpr-dev 2022-06-29 05:47:09 +00:00
Vinit Nayak aa882e8820 Merge "Close all open views for 1P and 3P launchers" into tm-qpr-dev am: 6b05c8ce1f am: 68a4da89d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18916005

Change-Id: I174474451a02ab92efcc748ff00653ab2e2d9710
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-28 16:48:58 +00:00
Vinit Nayak 6b05c8ce1f Merge "Close all open views for 1P and 3P launchers" into tm-qpr-dev 2022-06-28 16:24:16 +00:00
TreeHugger Robot ebef0661c0 Merge "Fixing widget size cache loop end-boundary" into tm-qpr-dev am: 5d749d93e6 am: f2ad0f246f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19087388

Change-Id: I968f0912f84df2eb4eafde38854153b496c69504
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-28 06:04:57 +00:00
TreeHugger Robot 5d749d93e6 Merge "Fixing widget size cache loop end-boundary" into tm-qpr-dev 2022-06-28 05:19:32 +00:00
Jeremy Sim 96c2aad623 Prevents split thumbnails from flipping when entering Overview in fake seascape
Fixes a bug where the user would see the splitscreen thumbnails swap position when entering Overview from fake seascape.

The bug arose because Overview's layout in fake seascape previously respected the primary-top secondary-bottom rule for placing splitscreen thumbnails. Actually, this needs to be flipped to preserve left-right orientation: If the user sees Task A on the left, it should always be on the left no matter how they rotate their device.

Fixed by swapping thumbnail and icon positions in SeascapePagedViewHandler#setSplitTaskSwipeRect() and setSplitIconParams(). Fake seascape will now show primary thumbnail on the "bottom" of the screen and secondary on "top."

This patch also corrects a minor calculation bug affecting icon alignment.

Fixes: 221133532
Test: Manual
Change-Id: Id587cf3815e64792d758d0e352da1e1e38cb4348
2022-06-27 22:33:30 +00:00
Pinyao Ting f6fc56bfc7 Merge "Cache and reuses LauncherAppWidgetHostView when launcher resumes" into tm-qpr-dev am: 6c7361fb46 am: 1d6add6c85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18801673

Change-Id: Ibca945d73376bdad01d28a1839735b28da8b9727
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-27 21:24:08 +00:00
Pinyao Ting 6c7361fb46 Merge "Cache and reuses LauncherAppWidgetHostView when launcher resumes" into tm-qpr-dev 2022-06-27 20:51:22 +00:00
Sunny Goyal 977838b568 Fixing nullpointer exception when accessing StatsLogger before initialization
Bug: 236227523
Test: Manual
Change-Id: I2caaa143ab2ddd4442d5c56152c7b4a7c723b92b
2022-06-27 13:16:19 -07:00
Sunny Goyal 008238ef43 Fixing widget size cache loop end-boundary
Bug: 236961658
Test: Verified on device
Change-Id: Ied629cd875a01abc45a7d055edfde5e156de53ea
2022-06-27 11:25:57 -07:00
Tony Wickham 5ce98a18f4 Merge "Log when MotionPauseDetector detects onMotionPauseChanged" into tm-qpr-dev am: c4405218ca am: b653ac621b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19036576

Change-Id: Ie360f187fcae3078baf6ba8701547bb8e0e1e689
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-27 18:10:25 +00:00
Tony Wickham c4405218ca Merge "Log when MotionPauseDetector detects onMotionPauseChanged" into tm-qpr-dev 2022-06-27 17:28:17 +00:00
Alex Chau aacfa2b285 Merge "In AllApps search mode, only consume touch over visible container" into tm-qpr-dev am: 7cbe51c22f am: 1c3b2c017e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18994756

Change-Id: I5f4c0ebdbf280aaf8a5ad6d305e87eb301ee1957
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-27 10:27:17 +00:00
Chilun Huang 7662dae663 Add TAPL API for adding app icon to hotseat
Please refer to go/tapl-add-icon-to-hotseat for more details.

Bug: 231400119
Test: atest NexusLauncherTests:TaplTestsQuickstep#testAddDeleteShortcutOnHotseat
Change-Id: I8cadecbe742413e3ce35ff269c0f78057331532c
Merged-In: I8cadecbe742413e3ce35ff269c0f78057331532c
2022-06-27 11:10:21 +08:00
Chilun Huang 22e829eb2f Merge "Add TAPL API for adding app icon to hotseat" 2022-06-27 02:33:04 +00:00
Sunny Goyal 46e368f755 Removing tabWidth calculation and using DeviceProfile directly
This removes some dependency on FloatingHeaderView, making it
easier to replace

Bug: 234008165
Test: Verified that the UI does not change
Change-Id: I363c98c23f84fe570ea9cb1a40128359f5b67c9f
2022-06-24 13:32:42 -07:00
Alex Chau a3070ea61d In AllApps search mode, only consume touch over visible container
Bug: 236360930
Test: Tap on deadzone to dismiss AllApps in search mode
Test: touch outside recycler view inside container, doesn't swipe left/right
Change-Id: I18498ea50f217231c3bb4489d6d9e95fc0e7da53
2022-06-24 11:51:11 +01:00
Luca Zuccarini 9797a234f2 Merge "Unify the source of truth for NORMAL <> ALL_APPS transitions." into tm-qpr-dev am: 4a0129fa5f am: 0e12609cb2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18911769

Change-Id: I0c9d5f68008c4018e76db5121ff42f4af8315c66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-24 10:41:08 +00:00
Alex Chau aef83ce2a0 Merge "Disable header protection on tablets" into tm-qpr-dev am: f6674c27f7 am: 352e59ff3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19034929

Change-Id: I2be7027ad8fa64af832573bb49dd2e85eba49c8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-24 10:39:47 +00:00
Luca Zuccarini 4a0129fa5f Merge "Unify the source of truth for NORMAL <> ALL_APPS transitions." into tm-qpr-dev 2022-06-24 10:25:49 +00:00
Alex Chau f6674c27f7 Merge "Disable header protection on tablets" into tm-qpr-dev 2022-06-24 10:02:51 +00:00
Sebastián Franco 13d5b412cb Merge "Make Talkback anounce which page is the icon being move on." into tm-qpr-dev am: 578fbee848 am: 563d85ea48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18918709

Change-Id: I16a78c864d2073812921939b4c63b6f2bb721a59
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-24 07:39:44 +00:00
Sunny Goyal e79ec7b842 Merge "Moving widget padding to drawable instead of using itemDecorator" into tm-qpr-dev am: 1f5cc67c13 am: 0d9e46bbd5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19053219

Change-Id: I9a6ad31bdae09dff297a4213337af4e1bb3ac9fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-24 06:56:41 +00:00
Sebastián Franco 578fbee848 Merge "Make Talkback anounce which page is the icon being move on." into tm-qpr-dev 2022-06-24 04:54:31 +00:00
Sunny Goyal 1f5cc67c13 Merge "Moving widget padding to drawable instead of using itemDecorator" into tm-qpr-dev 2022-06-24 04:39:23 +00:00
Sebastián Franco 53e78a20e8 Merge "Added a content call to emulate the other devices displays" into tm-qpr-dev am: 1e2454eb85 am: 93e3d7bb0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18935140

Change-Id: Id5fe56fcbcd35b3b6b26dd80c41ff41b7015bc2e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-24 00:30:32 +00:00
Sebastián Franco 1e2454eb85 Merge "Added a content call to emulate the other devices displays" into tm-qpr-dev 2022-06-23 23:41:28 +00:00
Sunny Goyal 23dca1500b Merge "Fixing wrong flags used by AllAppsController in SystemUiController" into tm-qpr-dev am: c3a5c4b16e am: 062861eddc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19037687

Change-Id: I4c089c7b71faa32e5604e2cbf95be7a7e592fd55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-23 23:37:08 +00:00
Sunny Goyal c3a5c4b16e Merge "Fixing wrong flags used by AllAppsController in SystemUiController" into tm-qpr-dev 2022-06-23 22:52:11 +00:00
Brandon Dayauon a766a0c68e Merge "Fix work toggle button that gets blocked by threeButton nav bar on TABLETS" into tm-qpr-dev am: 0130315860 am: 118f4fb708
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18798069

Change-Id: If39d45886e1700ab58192e4ba65c75f05392e967
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-23 22:28:00 +00:00
Tony Wickham c214335eba Log when MotionPauseDetector detects onMotionPauseChanged
Test: verified logging locally
Bug: 232548865
Change-Id: I587481a380148127f715c5b1b59436b2cbc1533e
2022-06-23 15:05:42 -07:00
Brandon Dayauon 0130315860 Merge "Fix work toggle button that gets blocked by threeButton nav bar on TABLETS" into tm-qpr-dev 2022-06-23 21:45:12 +00:00
Sunny Goyal ed681548fc Moving widget padding to drawable instead of using itemDecorator
ItemDecorator uses item position which is not stable during animations.
Moving it to the background allows the padding to be stable

Bug: 236961658
Test: Verified that the app doesn't crash.
Change-Id: Ied12077de4097e827c5c4157f5196346a301f185
2022-06-23 14:37:17 -07:00
Chilun Huang a518e034f7 Add TAPL API for adding app icon to hotseat
Please refer to go/tapl-add-icon-to-hotseat for more details.

Bug: 231400119
Test: atest NexusLauncherTests:TaplTestsQuickstep#testAddDeleteShortcutOnHotseat
Change-Id: I8cadecbe742413e3ce35ff269c0f78057331532c
2022-06-23 19:24:18 +08:00
Sebastian Franco 930531f669 Make Talkback anounce which page is the icon being move on.
Adding a third argument for the talkback string.

Fix: 230593493
Test: Move an item using Talkback and it should mention the row,
column and page where you can drop the item.

Change-Id: Id3d4435e9ef3348278643e6e2a1cd1e8bf5157b7
2022-06-22 17:17:38 -07:00