Commit Graph

16725 Commits

Author SHA1 Message Date
Becky Qiu 88bc0c4dc2 Merge "Hide keyboard when thumb scroller is visible." into tm-dev am: d6d0dc3ca8 am: ae9ab8a8bf am: 4b748464e0 am: e2331247e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18819707

Change-Id: I9b744ab62644d02aa4a9fcf7788d9014dab0d26a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 03:25:22 +00:00
Becky Qiu e2331247e4 Merge "Hide keyboard when thumb scroller is visible." into tm-dev am: d6d0dc3ca8 am: ae9ab8a8bf am: 4b748464e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18819707

Change-Id: I32baa32d48248ecc7ed4419ec7fa9fb8de9af384
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 03:06:06 +00:00
Becky Qiu b35ca57046 Merge "Hide keyboard when thumb scroller is visible." into tm-dev am: d6d0dc3ca8 am: a95e5116d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18819707

Change-Id: Ie6b938fcb5faebeea986950c39a20ff0ca513259
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 02:49:54 +00:00
Becky Qiu d6d0dc3ca8 Merge "Hide keyboard when thumb scroller is visible." into tm-dev 2022-06-11 01:45:36 +00:00
Brandon Dayauon 9d87b0c317 Fix work toggle button to be placed where it should be.
Previously, the implementation used the entire screen width
within it's calculations to determine where the button should be placed.
This is wrong because allApps have it's own container which we should
take the width from. The current implementation works fine because
the width of the screen for phones is the same width as the allApps container
BUT this implemention is WRONG for tablets. With now using the
allApps width for the calculation .. it works for both tablets/phones.

Bug: 235054324
Test: Photos in bug thread
Change-Id: I4c771d310a5d33646ad618e9c241cb5662493747
2022-06-10 15:57:01 -07:00
TreeHugger Robot 94ac97457e Merge "Fix NPE when user swipes back in All Apps and no matching view found" into tm-dev am: a49ba25353 am: f2afc1fcd1 am: 5f270a1c48 am: c71b70c598
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18821198

Change-Id: I833a30187321484ac31a75e621a70e684848dff4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 22:14:50 +00:00
TreeHugger Robot c71b70c598 Merge "Fix NPE when user swipes back in All Apps and no matching view found" into tm-dev am: a49ba25353 am: f2afc1fcd1 am: 5f270a1c48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18821198

Change-Id: I7179fa0f3bc76bb97de26817bb7ecb2901dbb0e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 21:29:48 +00:00
Becky Qiu 24c77a5ff5 Hide keyboard when thumb scroller is visible.
Bug: 235497706
Test: manual
Change-Id: Id3202300650949d079b9209e30b2bfc4f80979cd
2022-06-10 13:58:09 -07:00
Andy Wickham 1550127f67 Merge "Fixes Search bar padding when work profile not present." into tm-dev am: 34e8c3364a am: ef4136ad4e am: aade3dc637 am: bbd4414e0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18789522

Change-Id: Id34bd0b79e2f1bbc0f51204806d894e509c8435e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 20:38:46 +00:00
TreeHugger Robot a1d5677e51 Merge "Fix NPE when user swipes back in All Apps and no matching view found" into tm-dev am: a49ba25353 am: 9336589d01
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18821198

Change-Id: I04e84d8319ea66427965782ddef9bda9fa5933cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 20:32:16 +00:00
Andy Wickham aade3dc637 Merge "Fixes Search bar padding when work profile not present." into tm-dev am: 34e8c3364a am: ef4136ad4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18789522

Change-Id: I2db55aaab2e0ad4ad8b2f3388f0cc7fe404a2aec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 19:41:29 +00:00
TreeHugger Robot a49ba25353 Merge "Fix NPE when user swipes back in All Apps and no matching view found" into tm-dev 2022-06-10 19:05:32 +00:00
Becky Qiu fa317f4420 [Toast] Add a new type fields for user visible cold status.
Bug: 235249335
Test: manual
Change-Id: I58eee38e740e746e8a3d6065d4ef57cc5569a837
2022-06-10 12:03:56 -07:00
Sunny Goyal 5d81584e1f Merge "Clone the drawable lazily instead of on the UI thread while initializing" into tm-dev am: ad7e199e52 am: 41fda6802e am: 91956ee223 am: 350d6f6d70
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18818891

Change-Id: I4e0ef779a7c69e8268f482bd4b2c33837ed8cc84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 17:21:13 +00:00
Andy Wickham 34e8c3364a Merge "Fixes Search bar padding when work profile not present." into tm-dev 2022-06-10 17:07:43 +00:00
Sunny Goyal 350d6f6d70 Merge "Clone the drawable lazily instead of on the UI thread while initializing" into tm-dev am: ad7e199e52 am: 41fda6802e am: 91956ee223
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18818891

Change-Id: Ibedf868855cfe1ce412224248a32a50683967afe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 17:03:35 +00:00
Sunny Goyal 03c59ea519 Merge "Clone the drawable lazily instead of on the UI thread while initializing" into tm-dev am: ad7e199e52 am: 41fda6802e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18818891

Change-Id: Ib335350b03490d7da681b8ca93271a11af36e685
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 16:19:53 +00:00
Jon Miranda f26bdcb4c1 Fix NPE when user swipes back in All Apps and no matching view found
This crash will occur every time user swipes back and
there is not a view to return to

Introduced in I56cda07f3eccc11e8909f7fb28210f65cc6e0f1d

Bug: 235494234
Test: manual
Change-Id: I1261afcefec8fed4be20ab9ef439a50bc706d464
2022-06-10 16:00:18 +00:00
Sunny Goyal ad7e199e52 Merge "Clone the drawable lazily instead of on the UI thread while initializing" into tm-dev 2022-06-10 15:28:30 +00:00
Becky Qiu 74b1b66308 Merge "[Toast] Add a new latency type as FAIL." into tm-dev am: f13d3cca63 am: af6f7458f0 am: 64dd650cf2 am: 7c149d85b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18781402

Change-Id: Iecc63204501e2aa9f1bbf3874e23086b22925b39
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 00:10:17 +00:00
Becky Qiu 7c149d85b9 Merge "[Toast] Add a new latency type as FAIL." into tm-dev am: f13d3cca63 am: af6f7458f0 am: 64dd650cf2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18781402

Change-Id: Ieeb30583e222ec04d14a10de0bfbb25b10096a3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 23:51:05 +00:00
Brian Isganitis 5cd02fb852 Merge "Update download app icon treatment to latest mocks." into tm-qpr-dev am: 4aab0fdafc am: e69783e586
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18590244

Change-Id: I42bb68c5b347f4828b474f0eb3e2a1800cd0a033
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 23:12:35 +00:00
Becky Qiu a23df13d29 Merge "[Toast] Add a new latency type as FAIL." into tm-dev am: f13d3cca63 am: af6f7458f0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18781402

Change-Id: I27bd591aebedae351aa4eeb056e604903a4fc754
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 23:12:17 +00:00
Brian Isganitis 4aab0fdafc Merge "Update download app icon treatment to latest mocks." into tm-qpr-dev 2022-06-09 22:44:10 +00:00
Andy Wickham 7a89bb644f Updates keyboard option feature flag name. am: 918ba0c9f2 am: 845d34d210 am: b17399e54c am: eba3d70b19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18818901

Change-Id: I76f2d1856c838440838c0c28c6b44bd4cbc0381e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 22:38:16 +00:00
Andy Wickham e6b5bb4c23 Merge "Fixes issue where personal/work tabs could overlap search reasults." into tm-dev am: e44b026880 am: 0d15bf446c am: d362cd7207 am: 29e951b181
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18801671

Change-Id: I46f4f21256d0f3faa3d9460af1d1e9446838464d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 22:37:46 +00:00
Becky Qiu f13d3cca63 Merge "[Toast] Add a new latency type as FAIL." into tm-dev 2022-06-09 22:28:09 +00:00
Andy Wickham 29e951b181 Merge "Fixes issue where personal/work tabs could overlap search reasults." into tm-dev am: e44b026880 am: 0d15bf446c am: d362cd7207
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18801671

Change-Id: Ie41cb5dcd7634ab462b73be32f205f5e96a29d64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 22:18:12 +00:00
Andy Wickham b17399e54c Updates keyboard option feature flag name. am: 918ba0c9f2 am: 845d34d210
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18818901

Change-Id: I0ec4213c3716e7b47ea1529e82bfbf7e1a9ae0ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 22:07:37 +00:00
Andy Wickham 25912b1dde Merge "Fixes issue where personal/work tabs could overlap search reasults." into tm-dev am: e44b026880 am: 0753483188
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18801671

Change-Id: Id46077cfb799c40a4282c1da3abb4a0c1ade2f81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 22:07:25 +00:00
hyunyoungs e5f265c76e Workspace should not receive touch events
Bug: 234648831
Test: touch outside recycler view inside container, doesn't swipe left/right

TL;DR;;
As the definition of ActiveRecyclerView changed in latest refactor,
scrollbar existence is no longer a condition to consume
touch event if user is in isSearching state.

Change-Id: Iec97fb036ad45796a77c59d35f329744398d4953
2022-06-09 15:04:37 -07:00
Andy Wickham 918ba0c9f2 Updates keyboard option feature flag name.
This should ignore any value previously stored for the old flag.

Fix: 235440407
Test: Manual
Change-Id: Ib0b21442443575e88153f5a13ea945bfad3fa9f0
2022-06-09 11:02:39 -07:00
Andy Wickham e44b026880 Merge "Fixes issue where personal/work tabs could overlap search reasults." into tm-dev 2022-06-09 17:47:54 +00:00
Alex Chau 1965e1309c Merge "Use DISPLAY_CATEGORY_ALL_INCLUDING_DISABLED for getDisplays" into tm-dev 2022-06-09 17:40:07 +00:00
Sunny Goyal 0d88d0088a Clone the drawable lazily instead of on the UI thread while initializing
Bug: 234764579
Test: Manually
Change-Id: I557a532e4f71475e9294854d17068007a2eb7338
2022-06-09 09:59:42 -07:00
Alex Chau 3783778a14 Merge "Use normalized CachedDisplayInfo as key" into tm-qpr-dev am: cbde3a3a8d am: f290797184
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18754331

Change-Id: Id0cf035044f5cd9aa8cc10e9492abbc85f543e06
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 16:01:31 +00:00
Alex Chau cbde3a3a8d Merge "Use normalized CachedDisplayInfo as key" into tm-qpr-dev 2022-06-09 15:10:27 +00:00
Luca Zuccarini 1701ae3b60 Merge "Add support for text color animations in PropertySetter." into tm-qpr-dev am: 4618d3471f am: 58f3475b70
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18717287

Change-Id: I20f674e6ee7d6e4949b6af00cd9349c83003c158
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 12:22:10 +00:00
Alex Chau 2545e92264 Use DISPLAY_CATEGORY_ALL_INCLUDING_DISABLED for getDisplays
Bug: 227459045
Bug: 221071695
Test: manual
Change-Id: I8c1587e05a30abf75a01a84ebda6522606abb99b
2022-06-09 12:12:57 +00:00
Luca Zuccarini 4618d3471f Merge "Add support for text color animations in PropertySetter." into tm-qpr-dev 2022-06-09 11:26:17 +00:00
Alex Chau 661f02de18 Use normalized CachedDisplayInfo as key
- For system Launcher, migrate to use getPossibleMaximumWindowMetrics instead of getDisplays
- Removed usage of displayId
- In estimateInternalDisplayBounds, use CachedDisplayInfo directly as a key
- When cache retunrs null for the current display (e.g. the 3P launcher case), invalidate the cache and estimate again, and only add to supportedBounds if current display is not found in the new cache

Bug: 227459045
Bug: 198965093
Test: manual
Change-Id: Ibcc05ba483ed31a40d16e3cf49c3f3d43af68cf6
2022-06-09 11:36:47 +01:00
Andy Wickham ce647cc9ae Fixes issue where personal/work tabs could overlap search reasults.
When you start searching, the header is set to "collapsed" mode.
This normally hides the tabs indirectly if the height of the
header changed as a result, which happens if there is a prediction
row because the previous height is non-zero but is considered 0
after the collapse. However, if there was no prediction row, the
height was already 0, so the header was not re-initialized, which
is where the tab visibility takes effect.

Fix: 235299156
Test: Manually with and without app predictions enabled and
keyboard default on/off.

Change-Id: I192a700ac83776f30d3207f92636113bdb8a86c5
2022-06-08 14:46:46 -07:00
Andy Wickham 5a476da75c Fixes Search bar padding when work profile not present.
The full padding was accounted for between the search bar and the
work/personal tabs, but only part of it was there when the tabs
were not shown.

Screenshot: https://screenshot.googleplex.com/8axV9QQ5Qy8MaUn.png

Test: Manually with and without work profile added. In the latter
case, nothing changed. The screenshot reflects the former case.
Fix: 233010483

Change-Id: I11b3c8cc814be48c25cbd9f454c3e122fff96fa0
2022-06-08 13:32:41 -07:00
Becky Qiu 68a63e0b73 [Toast] Add a new latency type as FAIL.
Bug: 227696256
Test: no need to test.
Change-Id: I84cdbbfc605494062ba07d79bee96a006e7ea7a5
2022-06-08 19:00:33 +00:00
Becky Qiu 013ea78b95 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev am: fe83fce489 am: 40059b55cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18783028

Change-Id: Ie18546e63867101d9ac6db9bc0534042864b956a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 18:53:22 +00:00
Becky Qiu 9074e97780 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev am: fe83fce489 am: f9dfd06424
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18783028

Change-Id: I339a468a49fc8490154dd0dc4d6266ab6e41f90e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 18:52:38 +00:00
Pat Manning d7da112185 Hide both drop target icons if either text goes to two lines. am: e3d74b496e am: 56ee9a90d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18795367

Change-Id: I456bf3b573ba94db51657000fff933fcff233403
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 18:18:31 +00:00
Becky Qiu fe83fce489 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev 2022-06-08 18:02:07 +00:00
Pat Manning e3d74b496e Hide both drop target icons if either text goes to two lines.
Fix: 235088140
Test: manual
Change-Id: I582b8b771d859402b932193251690e5a4ffecbae
2022-06-08 16:33:05 +01:00
Jon Miranda 2245de7674 Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev am: 2dac4f7f4c am: dfe3b8b755
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18673700

Change-Id: Ib4dd2fdbc93a7ac05e9d141183770cb33db26db6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 01:07:18 +00:00