Commit Graph

16725 Commits

Author SHA1 Message Date
Sukesh Ram 8b248a601e Merge "Fix SecondaryDisplayLauncher crash by initializing OnBoardingPrefs after initializing UI" 2022-07-15 20:21:09 +00:00
Sebastián Franco 024e668aa2 Merge "Fixing findNearestArea to account for the padding." into tm-qpr-dev am: cd195b6c0a am: d22853f042
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19107254

Change-Id: I7911c12d875ad062738c334e2dd641f7f75f5b4c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-15 17:35:23 +00:00
Sebastián Franco cd195b6c0a Merge "Fixing findNearestArea to account for the padding." into tm-qpr-dev 2022-07-15 16:53:50 +00:00
Sihua Ma f8ca2c76f2 Merge "Added functions to pass launcher widget span info to preview" into tm-qpr-dev am: 68c6b81d2a am: efc1cb7beb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19268917

Change-Id: I0d89b0bc6aa14b3bb96b44248d16c8bbbc518bec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-15 11:44:16 +00:00
Sihua Ma 68c6b81d2a Merge "Added functions to pass launcher widget span info to preview" into tm-qpr-dev 2022-07-15 11:06:02 +00:00
Sukesh Ram 29b1890fca Fix SecondaryDisplayLauncher crash by initializing OnBoardingPrefs after initializing UI
Bug: 238325716
Test: Manual
Change-Id: I66a85eb79cda89a63c3116a56a52b51526720158
2022-07-14 16:02:25 -07:00
Sihua Ma dfd8bfc7e0 Added functions to pass launcher widget span info to preview
To calculate the widget scales correctly for the launcher preview in different grids, the span info of the widgets in the launcher is necessary. Querying the launcher widget info in the database and passing it to the preview render.

Test: Verified that no exceptions were happening when changing preview grid layouts
Bug: 228328759
Change-Id: I681d21b176c8fe5208431a79009d9ba8279cda6a
2022-07-14 20:17:19 +00:00
Sunny Goyal 063024d5a1 Merge "Fixing Launcher crash if activity restarts while resixing widget" into tm-qpr-dev am: 615f2edb76 am: e8cff04346
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19281892

Change-Id: I05998fb5a458feb2085449774cb07c34d0363943
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-14 19:29:45 +00:00
Sunny Goyal 615f2edb76 Merge "Fixing Launcher crash if activity restarts while resixing widget" into tm-qpr-dev 2022-07-14 18:40:27 +00:00
Sebastian Franco b57c0b2762 Fixing findNearestArea to account for the padding.
The function findNearestArea calculates the corner of the
cell but in that calculation it doesn't account for the padding
in the cells.

Also, change ignoreOccupied because the name says one thing and
the code does the oposite so I change all true calls for false
calls and change the if to !ignoreOccupied so the description of
the parameter match the behaviour of the method.

Also, removing unused method.

Fix: 236134208
Fix: 236129504
Test: visualizing the components of findNearestArea in ag/19248816.
Change-Id: Iac50fbc76b4fa2acda21894ecb976ba612d468fe
2022-07-13 15:38:00 -07:00
Sunny Goyal cd89ca36b6 Fixing Launcher crash if activity restarts while resixing widget
When activity restarts, the widgetView gets onDetachFromWindow first
which inturn removes the AppWidgetResizeFrame from drawLayer while
the dispatchAttachToWindow was still in progress in DragLayer

Bug: 238416508
Test: Verified no crash after the change
Change-Id: I6359840c9fb3ae2719056845818620af19d3c94d
2022-07-13 12:22:01 -07:00
Pat Manning 89d0073c08 Merge "Add DeviceProfile tests on all attributes across different configurations." into tm-qpr-dev am: e700efde22 am: 980bbf0f3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19197012

Change-Id: I5e9e8117bd6546e3485318853899cbfc8bd166b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-13 11:38:54 +00:00
Pat Manning e700efde22 Merge "Add DeviceProfile tests on all attributes across different configurations." into tm-qpr-dev 2022-07-13 10:45:50 +00:00
Sunny Goyal dea1af0c3e Merge "Generalizing the PredicitonScroll view so that in can be used in all-apps" into tm-qpr-dev am: eb966492f7 am: e16fc5c878
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19089102

Change-Id: I25d7b3a854acd67bf674331d4ed64528f4a5f054
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-12 22:04:58 +00:00
Sunny Goyal eb966492f7 Merge "Generalizing the PredicitonScroll view so that in can be used in all-apps" into tm-qpr-dev 2022-07-12 21:33:17 +00:00
András Klöczl 3299478f1f Merge "Fix flaky/failing two panel TAPL tests" 2022-07-12 14:43:01 +00:00
Thales Lima 93097809a7 Merge "Take account of IME insets" into tm-qpr-dev am: 8693d0a52f am: f074e39a62
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19193075

Change-Id: Iae8fe39981c6daf88ca7c3cb83a67d175b1e8b26
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-12 13:20:54 +00:00
Alex Chau 2f98748b1b Merge "Make workspace and hotseat scale down in widgets picker" into tm-qpr-dev am: fbd9ebd0a0 am: 252ab19883
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19222026

Change-Id: Ia06c9e56e9676b91c31fe8311381c0fc8e7b0e19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-12 13:20:05 +00:00
Pat Manning 26f70f777e Add DeviceProfile tests on all attributes across different configurations.
Fix: 237542518
Test: DeviceProfilePhoneTest.kt
Test: DeviceProfileVerticalBarTest.kt
Test: DeviceProfilePhone3ButtonTest.kt
Test: DeviceProfileVerticalBar3ButtonTest.kt
Test: DeviceProfileTabletLandscapeTest.kt
Test: DeviceProfileTabletPortraitTest.kt
Test: DeviceProfileTabletLandscape3ButtonTest.kt
Test: DeviceProfileTabletPortrait3ButtonTest.kt
Test: DeviceProfileTwoPanelLandscapeTest.kt
Test: DeviceProfileTwoPanelPortraitTest.kt
Test: DeviceProfileTwoPanelLandscape3ButtonTest.kt
Test: DeviceProfileTwoPanelPortrait3ButtonTest.kt
Change-Id: I1596dcd1fb8c9b353cdfcab224d7670d88bed716
2022-07-12 14:17:18 +01:00
Thales Lima 8693d0a52f Merge "Take account of IME insets" into tm-qpr-dev 2022-07-12 10:34:42 +00:00
Alex Chau fbd9ebd0a0 Merge "Make workspace and hotseat scale down in widgets picker" into tm-qpr-dev 2022-07-12 10:08:20 +00:00
Sunny Goyal 1536d2a3a7 Merge "Adding support for continously capturing view hierarcy in Launcher" into tm-qpr-dev am: c9e5c2bd2a am: 885e616cc5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19199836

Change-Id: I2b24aec986ea3bd9904d3aa2392b46ba0d83c6a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-12 06:49:05 +00:00
Sunny Goyal 0064de97bd Merge "Fixing tab width and panner not aligned with the all-apps icons" into tm-qpr-dev am: 0eb857666c am: c6bcfb058b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19240901

Change-Id: I5c2d3c764ec7cd7ac48a8b633be0579b05957d50
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-12 06:48:42 +00:00
Sunny Goyal c9e5c2bd2a Merge "Adding support for continously capturing view hierarcy in Launcher" into tm-qpr-dev 2022-07-12 05:56:36 +00:00
Sunny Goyal 0eb857666c Merge "Fixing tab width and panner not aligned with the all-apps icons" into tm-qpr-dev 2022-07-12 05:55:43 +00:00
Chilun Huang 3fc3e6bebb Workaround to return 1/3 of the position am: ac57ddeb4c am: 4e033bb5bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19220863

Change-Id: Ia786004d4c60296ec674769b298aaa3498d234a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-12 04:22:41 +00:00
Sunny Goyal 25972b1f2f Adding support for continously capturing view hierarcy in Launcher
Bug: 238243939
Test: Verified data being captured and dumped
Change-Id: Ibe069d39ccf728f7b953f85085e58976be6e05ac
2022-07-11 15:43:54 -07:00
Sunny Goyal eab51677ae Fixing tab width and panner not aligned with the all-apps icons
Bug: 234008165
Test: Verified on device
Change-Id: Ibec3eed4aef730439d79b086d6ae23b63b66361e
2022-07-11 15:39:32 -07:00
Andras Kloczl 486f7c8766 Fix flaky/failing two panel TAPL tests
Since Cuttlefish emulators are quite slow, some
of the two panel related TAPL tests were failing
due to multiple page changes instead of single ones.

Test: atest -c NexusLauncherTests:com.android.launcher3.ui.workspace.TwoPanelWorkspaceTest
Bug: 236136463
Change-Id: Ib154cf97040fcea3b4d2d7082352c06de74f8c2a
2022-07-11 13:09:13 +00:00
Chilun Huang ac57ddeb4c Workaround to return 1/3 of the position
Some devices in portrait mode have the same symptoms as b/234322284.
Simply return 1/3 of the position like the X axis to solve the problem.

Bug: 238202110
Test: atest Launcher3Tests:TaplTestsLauncher3#testAddDeleteShortcutOnHotseat
Change-Id: Ic7d3756cfbda6673a62b266c6093745b8311e6ac
2022-07-11 15:19:16 +08:00
Alex Chau 0c4e11b479 Make workspace and hotseat scale down in widgets picker
- Also centralized workspace content scale percentage to DeviceProfile

Test: manual
Fix: 231699666
Change-Id: I3f8dcb9921e0cd93ad391d51120b189005ad07df
2022-07-08 19:03:48 +01:00
Sunny Goyal 0c4f199019 Merge "Removing tabWidth calculation and using DeviceProfile directly" into tm-qpr-dev am: 251ee0a066 am: f0ee118786
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19038314

Change-Id: Idf7439d7900f69ac5bf75c8567dd9279b0c4bed5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-08 16:25:28 +00:00
Sunny Goyal 251ee0a066 Merge "Removing tabWidth calculation and using DeviceProfile directly" into tm-qpr-dev 2022-07-08 15:39:30 +00:00
Becky Qiu 5cb363638b Merge "[Toast] Add a feature flag to use local overrides for search timeout." into tm-qpr-dev am: 5672b0991e am: 0849216d9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19067225

Change-Id: I33cd306cd1df26677b9d24e605c9e27518ce2684
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-07 17:54:50 +00:00
Thales Lima f0c633bc48 Take account of IME insets
Fix: 233159032
Test: manual
Change-Id: I2a23c13f7b2bcd8b0c758140dd1fdd5bb800f3f1
2022-07-07 11:57:04 +01:00
Sunny Goyal 9b458a0012 Generalizing the PredicitonScroll view so that in can be used in all-apps
Bug: 234008165
Test: Verified no-functionality-change on device
Change-Id: Ie17d58148b9bdcb08847beb24114b0494437b30e
2022-07-06 12:29:01 -07:00
Alex Chau c61db0515d Merge "Clean up DisplayController logs" into tm-qpr-dev am: 420ab0a45b am: 9666f6ae27
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19167626

Change-Id: I867228d33df346b0f2bd7bd6e6b91d0df3fb4204
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-06 18:21:35 +00:00
Becky Qiu da6a8fab1b [Toast] Add a feature flag to use local overrides for search timeout.
Bug: 229038631
Test: manual
Change-Id: I131ee7fc9bd7d09d7a4d4ee3f4577110ed75c0d4
2022-07-06 11:16:00 -07:00
Alex Chau 420ab0a45b Merge "Clean up DisplayController logs" into tm-qpr-dev 2022-07-06 17:27:29 +00:00
Tony Wickham 6bb2945f78 Merge "Proper fix for gesture nav flicker using runOnPageScrollsInitialized()" into tm-qpr-dev am: 4b2bf90f2c am: 7b0cba0590
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18902861

Change-Id: I7dee6e8d4d42aba10cecd9b57a00b40f90010de8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-06 17:17:25 +00:00
Tony Wickham 7d6a09b873 Merge "Move TEST_HARNESS_TRIGGER_TIMEOUT to MotionPauseDetector directly" into tm-qpr-dev am: 0c8ceda6e7 am: 5397c871da
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19136583

Change-Id: Id2f8ba91596a7ade5b2337db6687be5fc787cbe6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-06 17:08:56 +00:00
Tony Wickham 4b2bf90f2c Merge "Proper fix for gesture nav flicker using runOnPageScrollsInitialized()" into tm-qpr-dev 2022-07-06 16:30:01 +00:00
Tony Wickham 0c8ceda6e7 Merge "Move TEST_HARNESS_TRIGGER_TIMEOUT to MotionPauseDetector directly" into tm-qpr-dev 2022-07-06 16:25:03 +00:00
Thales Lima 92a1e7f1de Add new hotseat bottom margin options am: b8c0595d42 am: a70b07d04c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18605485

Change-Id: I42e901c26b8b34f52e2ba5c8b0edfc8cfcd3ac9f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-06 11:05:01 +00:00
Thales Lima b8c0595d42 Add new hotseat bottom margin options
This changes how the hotseat height is calculated and by consequence how spaces are distributed in the workspace as well. This is the first of a series of changes that will improve and streamline workspace calculations.

Bug: 228998463
Fix: 234023782
Fix: 230191631
Fix: 232914299
Fix: 236238226
Test: manual, HSV and comparing to mocks
Change-Id: If021e8ba2c7c24c0bf9f27a1aa7aa946792ed04f
2022-07-05 15:33:47 +01:00
Pat Manning 94a437c2a9 Merge "Simplify vertical bar hotseat bottom calculation for spring loaded state." into tm-qpr-dev am: 0f8bbef729 am: e73e245ba4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19084089

Change-Id: Id2c80742c36708d3974fdea1144fd26a2b70f2f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-05 11:27:50 +00:00
Pat Manning 0f8bbef729 Merge "Simplify vertical bar hotseat bottom calculation for spring loaded state." into tm-qpr-dev 2022-07-05 10:28:10 +00:00
Alex Chau 0adc36623d Clean up DisplayController logs
- Moved debug logs under DEBUG flag which defaults to false
- Moved info+ logs to permanent log tags

Fix: 198965093
Test: manual
Change-Id: Iea99f053da08e921542a8f532a9837997e10de5e
2022-07-04 13:13:44 +01:00
Pat Manning a7335bccdc Simplify vertical bar hotseat bottom calculation for spring loaded state.
Fix: 236941743
Test: manual.
Change-Id: I7f110fea48eb88e7f941a64c17a65feec14531f3
2022-07-04 12:45:40 +01:00
Jeremy Sim e19aab9010 Merge "Allows Launcher to recover gracefully into OverviewSplitSelect state" into tm-qpr-dev 2022-07-01 21:40:34 +00:00