Commit Graph

16725 Commits

Author SHA1 Message Date
Sebastián Franco 33edba1006 Merge "[Cherry pick merge conflict] Updating visibility of some members for easier extensibility" into tm-qpr-dev 2022-07-29 17:23:46 +00:00
Alex Chau 6209af67d3 Listen to DisplayController for ignoreAutoRotateSettings
- Also skip most of initDeviceProfile/onIdpChanged if DeviceProfile didn't actually change to effectively skip the 2nd unexpected onConfigurationChangeded caused by setRequestedOrientation (b/211763738)

Test: Change display size while in app or at home screen
Fix: 240019605
Change-Id: If307742639bd269622140a7da0dc900887c67937
2022-07-29 13:09:17 +01:00
Sunny Goyal af95ddbadc Fixing search behavior in Launcher3
> Showing no-result found only when there are no results
> Removing unnecessary view inflation in RecyclerViewPool for
  various search vide types
> Removing unused market-search link and no-empty-result illustration

Bug: 240343082
Bug: 207573083
Test: Verified Launcher3
Change-Id: Ia44799cd2385ea5dc837ef25732ca237975abde7
2022-07-28 22:05:30 -07:00
Schneider Victor-tulias 62511de74e Add logging to help debug additional app infos being updated by CacheDataUpdatedTask
Bug: 239465630
Test: ran test locally.
Change-Id: I1b31cfaeb697f87acd99d787284f55d7e6b75b54
2022-07-28 23:09:39 +00:00
Jeremy Sim 1cfe6d490a Update calculation method for Overview UI placement on tablets
This update slightly changes the calculation method for Overview UI placement, in order to line up better with spec. (The previous calculation caused a small 30dp divergence on tablets.)

Bug: 236760307
Test: Manual by measuring pixels and comparing to spec
Change-Id: I94e9e7b5a6a24c37693425ac8ec71cd066003658
2022-07-28 14:05:24 -07:00
Andy Wickham dacf259451 Merge "Only bind fast scrollbar when attached if not already bound." into tm-qpr-dev am: f61e7bb4a2 am: 82f02caceb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19225719

Change-Id: I158932f262fd17610f17e9ef847cf2016798b4d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-27 23:17:15 +00:00
Andy Wickham f61e7bb4a2 Merge "Only bind fast scrollbar when attached if not already bound." into tm-qpr-dev 2022-07-27 22:27:25 +00:00
Andy Wickham 87a9bf7c15 Only bind fast scrollbar when attached if not already bound.
This was overriding the previously bound RecyclerView if multiple
were attached simultaneously. Instead, the appropriate container
(All Apps / Widgets) should bind the active RecyclerView whenever
it changes, with the onAttach serving as a fallback to ensure
the scrollbar has an initial RV to avoid NPEs.

Fix: 234591523
Bug: 235476489
Test: Manually checked All Apps from Launcher and Taskbar, as well
as Widget bottom sheet. Also ran relevant Tapl tests.

Change-Id: I06e27d2f66f9778087711a566817b6806ec7218b
2022-07-27 21:02:34 +00:00
Shikha Malhotra bc9b08fdd1 [Cherry pick merge conflict] Updating visibility of some members for easier extensibility
This change is causing a merge conflict with ag/19441591. Hopefully only a cherrypick is needed.

Bug: b/218186980
Test: Manual Testing that Launcher3 compiles and works
Change-Id: Id85486ef763ce9a04b83fef44542b2eb3e0e599d
(cherry picked from commit c487e1b4c5)
2022-07-27 20:33:29 +00:00
vadimt f6ef879cf4 Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877, 234414088
Test: presubmit
Change-Id: I3d923ea4b54d1a4c3d2b345be09692727d30433e
2022-07-27 20:18:46 +00:00
Sukesh Ram 1ea641ae1e Merge "Fix crash on long press of prediction row icons" 2022-07-27 17:55:37 +00:00
Sukesh Ram c4430c9cd7 Fix crash on long press of prediction row icons
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.

Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
2022-07-27 00:05:35 +00:00
vadimt 47f347b1cf Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877
Test: presubmit
Change-Id: I95c267e46cf675ac44dc27b07d0a1143ab761e35
2022-07-26 15:43:00 -07:00
Schneider Victor-tulias 2d1a071f16 Merge "Fade out the taskbar icons when animating to overview in 3 button nav." into tm-qpr-dev am: f6003ff070 am: de490c6bb1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19051009

Change-Id: I3c105a7632851acbb36be8607b51c23d9d3b2a0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 19:05:19 +00:00
Schneider Victor-tulias f6003ff070 Merge "Fade out the taskbar icons when animating to overview in 3 button nav." into tm-qpr-dev 2022-07-26 17:29:33 +00:00
TreeHugger Robot d33659576c Merge "Space out 3 button nav on taskbar" into tm-qpr-dev am: 5e6fe32818 am: 2a8906bfba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19272533

Change-Id: I2ea492fac54d0fabf1af92500e2ad102855c4c79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 17:21:17 +00:00
TreeHugger Robot 5e6fe32818 Merge "Space out 3 button nav on taskbar" into tm-qpr-dev 2022-07-26 16:32:06 +00:00
Alex Chau 2a9dafcce1 Merge "Revert "Move BaseActivityInterface task size methods to DevicePr..."" into tm-qpr-dev am: 66bac181ac am: eed67e721e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19398184

Change-Id: If4406214f9853f055719deda5674ea0e1fc3e958
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-26 10:29:02 +00:00
Alex Chau 66bac181ac Merge "Revert "Move BaseActivityInterface task size methods to DevicePr..."" into tm-qpr-dev 2022-07-26 09:36:18 +00:00
Sukesh Ram 02f0ba7569 Merge "Drag from appDrawer & pin onto secondary display homescreen" 2022-07-25 22:53:49 +00:00
Sukesh Ram 189554616c Drag from appDrawer & pin onto secondary display homescreen
Bug: 239246505
Test: Manual

Change-Id: I817d8ef700f2d7caec6fa63123935502f17f2d2f
2022-07-25 21:04:25 +00:00
TreeHugger Robot 1e354d1667 Merge "Fixing icon label not updated during bulk load" into tm-qpr-dev am: 9fb9ae1a9e am: 7fee505a70
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19387603

Change-Id: I0bc4922666ebc9bc19ddb24069e1d9c120a68ba3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-25 20:23:02 +00:00
Vinit Nayak c7293179d0 Space out 3 button nav on taskbar
* Add additional margin on nav buttons if
there's overlap w/ contextual button
* End spacing is dependent on grid layout

Bug: 223724516
Test: Tested on unfolded with different
grid sizes.

Change-Id: Ie814f35cd1f35629744050ee3f7242c5a8599883
2022-07-25 13:15:11 -07:00
Alex Chau 62572c04e2 Revert "Move BaseActivityInterface task size methods to DevicePr..."
Revert "Move BaseActivityInterface task size methods to DevicePr..."

Revert submission 19279487-baseactivityinterface

Reason for revert: As per discussion in ag/19341332, make sure DeviceProfile can properly react to inset changes before moving task size calculations there
Reverted Changes:
I30324d34c:Move BaseActivityInterface task size methods to De...
Ia9c1d0387:Move BaseActivityInterface task size methods to De...

Bug: 238593212
Change-Id: I0d40fdd4a5d4468494e30cef32a284479ddd2feb
2022-07-25 18:38:03 +00:00
Hyunyoung Song 395752bd3a Merge "Fix testSearchDeadzoneForTablets failure" into tm-qpr-dev am: 026ddc4460 am: a1c7d95b22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19397561

Change-Id: Ie02e76ef361c18159d90ce76da659cf1455d91c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-25 17:41:53 +00:00
Sunny Goyal 412f0d26fa Fixing icon label not updated during bulk load
The label was being updated to default in Loader cursor
which prevented eventual final update of the label

Bug: 220645719
Test: Verified on device
Change-Id: I2559804eb885663387bd1f5afe9e3337130a9fe3
2022-07-25 17:24:34 +00:00
Hyunyoung Song 026ddc4460 Merge "Fix testSearchDeadzoneForTablets failure" into tm-qpr-dev 2022-07-25 16:59:00 +00:00
hyunyoungs 4ba188aa5f Fix testSearchDeadzoneForTablets failure
Bug: 239868630
Bug: 240116666
Test: testSearchDeadzoneForTablets passes

Change-Id: I8b20cf56191058b6033ae929be6726a2c88825c8
2022-07-25 09:53:25 +00:00
Grace 170911d823 Create Flag for Region Sampling in Smartspace
This change adds a feature flag to control region sampling for
the homescreen smartspace. The flag helps developers toggle the
feature on and off during debugging.

Bug: 202758428
Test: N/A
Change-Id: I99e795408f5550b4a535ef181744f029e09c4436
2022-07-22 19:58:00 +00:00
Jeremy Sim e5ba8fa7a5 Update animations for TM-QPR: OverviewSplitSelect > Home transition
The animation from OverviewSplitSelect to Home is now updated to the latest spec. See bug for details.
- New timings
- FloatingTaskView now translates out, instead of fading
- FloatingTaskView and SplitInstructionsView now disappear concurrently with the rest of Overview, instead of afterward

Fixes: 236761067
Test: Manual on tablet and phone
Change-Id: Iaa1c804a60859232f331950098b67968cc187e82
2022-07-21 20:46:43 -07:00
Hyunyoung Song 005a68e42e Merge "Move hideKeyboard call to end of the all apps transition controller animation" into tm-qpr-dev am: d963c70df3 am: 949e8eb10c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19279052

Change-Id: Ie8495616780a9d85d543f05a83076863af6f405c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-21 21:07:23 +00:00
Hyunyoung Song d963c70df3 Merge "Move hideKeyboard call to end of the all apps transition controller animation" into tm-qpr-dev 2022-07-21 20:29:56 +00:00
Andras Kloczl a9ecc3d1bd Fix flaky two panel TAPL tests v2
Cuttlefish emulators are getting slower and slower and some
of the two panel related TAPL tests were failing
due to multiple page changes instead of single ones, so
we need to increase the page change hover time in the tests.

Test: atest -c NexusLauncherTests:com.android.launcher3.ui.workspace.TwoPanelWorkspaceTest
Bug: 236136463
Change-Id: I8007a73a17089a7f7a639ce615af52695b55002c
2022-07-21 07:29:13 +00:00
Pinyao Ting 974d77056c Merge "Include additional logs for widget removal" into tm-qpr-dev am: 033f8df497 am: 07c8ab050d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19346921

Change-Id: I4f181874595f9867498a1c770c01a34b975f2ca9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-20 18:02:00 +00:00
Pinyao Ting 033f8df497 Merge "Include additional logs for widget removal" into tm-qpr-dev 2022-07-20 17:11:25 +00:00
hyunyoungs eef16895a6 Move hideKeyboard call to end of the all apps transition controller animation
Bug: 236685775
Bug: 235951830

Test: manual
Change-Id: Iae808a82eb4a10a554aef1cb5d87fc806efb0279
2022-07-20 00:21:03 -07:00
Andy Wickham c3936a5257 Merge "Notifies All Apps header when profile tab switches." into tm-qpr-dev am: a2e9ce3b68 am: dc14f88b54
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19225205

Change-Id: I331275861c9817e72a8ff51e35a9cb7e3327ece4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-20 00:04:48 +00:00
Andy Wickham a2e9ce3b68 Merge "Notifies All Apps header when profile tab switches." into tm-qpr-dev 2022-07-19 23:22:51 +00:00
Pinyao Ting 415740978b Include additional logs for widget removal
It isn't clear what causes widgets to be removed when restoring on a new
device. This CL included additional error message, which hopefully would
reveal the root cause.

Bug: 235923862
Test: manual
Change-Id: I8601d8fe598072dc9def0549796d1e527e167e23
2022-07-19 14:43:32 -07:00
Sebastián Franco 0a8a529f15 Merge "Adding test for the Widgets reordering." into tm-qpr-dev am: df1c1c84b5 am: e8cba5fc8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18875278

Change-Id: I56fe28a97509df8e573f5c41b31dd4bf6c955613
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-19 21:14:17 +00:00
Pat Manning 762a930942 Merge "Move BaseActivityInterface task size methods to DeviceProfile." into tm-qpr-dev am: 01a7bcc665 am: 80cb0fa02b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19279487

Change-Id: I4c0f8cb53bade850f1beddda1efc943a1064c69d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-19 20:24:05 +00:00
Sunny Goyal 02d21c33be Merge "Removing unnecessary work adapter wrapper" into tm-qpr-dev am: 7dcc9831e2 am: 740a19fd08
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19292690

Change-Id: Icc0acefbdff90cd03df0687d13176fa07299b3b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-19 19:57:44 +00:00
Schneider Victor-tulias 3f6c473164 Fade out the taskbar icons when animating to overview in 3 button nav.
Bug: 231213105
Test: from home, opened recents, then went back home, then went back to recents, resumed an app, then went back to recents and resumed the same app (both in 3-button and gesture nav)

Change-Id: I83b1b33cafb95353f36a126b93fcaf3b536d3bf4
2022-07-19 11:35:37 -07:00
Sebastián Franco df1c1c84b5 Merge "Adding test for the Widgets reordering." into tm-qpr-dev 2022-07-19 16:36:31 +00:00
Pat Manning 01a7bcc665 Merge "Move BaseActivityInterface task size methods to DeviceProfile." into tm-qpr-dev 2022-07-19 10:31:51 +00:00
Sebastian Franco 5cba476362 Adding test for the Widgets reordering.
TAPL design chagnes at https://docs.google.com/document/d/1PdJZZIn-85-UMRFGZuqj-tJgruIWcg31lZnrb34iBTY/edit?resourcekey=0-uAZuiLCDFV9YhOtLB7wQHQ

The tests consist of a board representing the widgets on
the CellLayout a position to move the main widget (m) to
and the resulting board.

iiiii    iiiii
-----    --x--
-xxx- -> -xmx-
--m--    -----
-----    -----

Move m to 2,2.

Then whe make sure the device corresponds with the resulting
board.

I had to add the event TestLogging.recordEvent(TestProtocol.SEQUENCE_MAIN, "Widgets.onLongClick");
on ItemLongClickListener because the tests where not expecting
a long press on a widget after is being place on the
workspace.

Also, I needed to add the option to drag a widget
to a specific point instead of the previous option
of only dragging to the workspace.

Fix: 231449779
Test: Run the test and make sure they pass.
Change-Id: I58183b7ce2ca64c999e21073cce5e0ba6e6f3a9e
2022-07-18 11:52:12 -07:00
Pat Manning 4e73e5e352 Move BaseActivityInterface task size methods to DeviceProfile.
Fix: 238593212
Test: DeviceProfilePhoneTest.kt
Test: DeviceProfileVerticalBarTest.kt
Test: DeviceProfilePhone3ButtonTest.kt
Test: DeviceProfileVerticalBar3ButtonTest.kt
Test: DeviceProfileTabletLandscapeTest.kt
Test: DeviceProfileTabletPortraitTest.kt
Test: DeviceProfileTabletLandscape3ButtonTest.kt
Test: DeviceProfileTabletPortrait3ButtonTest.kt
Test: DeviceProfileTwoPanelLandscapeTest.kt
Test: DeviceProfileTwoPanelPortraitTest.kt
Test: DeviceProfileTwoPanelLandscape3ButtonTest.kt
Test: DeviceProfileTwoPanelPortrait3ButtonTest.kt
Change-Id: I30324d34ca119a467f530b590949743c2ba7b91a
2022-07-18 16:35:02 +01:00
Sukesh Ram c0650e7725 Made getOnBoardingPrefs @Nullable & avoid NPE
Bug: 236679197
Test: Manual
Change-Id: I3cbb0891cbfcf7cab956a4e05a28dbbcc2b33e19
2022-07-15 17:29:26 -07:00
Sunny Goyal cba5f9a64e Removing unnecessary work adapter wrapper
Simplifying view type constants to make it easier to add new view types

Bug: 234008165
Test: Verified on device
Change-Id: I96589ceba362ea7e75afdfc3fe8da3be214aa682
2022-07-15 16:24:31 -07:00
Andy Wickham 85f9ce48ef Notifies All Apps header when profile tab switches.
This fixes scroll listeners which control the header from Taskbar.
In other instances of the All Apps container (i.e. from Launcher),
the search bar indirectly updates the header because resetSearch
is called, which also resets the header. Separately, I would like
to clean that up so that AllAppsContainerView does not get
controlled by the search bar (maybe as part of a larger reset
cleanup).

Fix: 236812759
Test: Manual on device with Taskbar
Change-Id: I9921e89c87d5e18e4b28854fbb373f24b4189014
2022-07-15 15:02:28 -07:00