Commit Graph

16725 Commits

Author SHA1 Message Date
Federico Baron f834cfe954 Merge "Autohide and autoshow pagination in workspace" into tm-qpr-dev 2022-10-25 19:44:35 +00:00
Tracy Zhou 6d8afb2187 Allow two finger gesture from trackpad to pull down notification from home
Fixes: 255602235
Test: manual
Change-Id: I99742320b322a1e7b04bad0e374fcc48f8871ce1
2022-10-25 19:03:52 +00:00
Holly Jiuyu Sun ba1c20d2a3 Merge "Log a-z apps count." into tm-qpr-dev am: 381ba3319d am: 52cebe3a69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029946

Change-Id: I1e8520025c91510c711cd378431b51e281a8048c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-25 18:17:12 +00:00
Holly Jiuyu Sun 52cebe3a69 Merge "Log a-z apps count." into tm-qpr-dev am: 381ba3319d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029946

Change-Id: Iedca65de9f046fba4d3d4595970adeb0f4ebc24f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-25 18:14:39 +00:00
Federico Baron cfa0f833f6 Add new flag for dot pagination
Here we add a flag for adding the dot pagination (same as currently in folders) to workspace

Bug: 254769710
Test: N/A
Change-Id: Id5fc33f61b9814f73afea8c5119c7d8d4ee24756
2022-10-25 18:00:03 +00:00
Holly Jiuyu Sun 381ba3319d Merge "Log a-z apps count." into tm-qpr-dev 2022-10-25 17:50:19 +00:00
Federico Baron 98db0df4ab Hide QSB (toast) when editing workspace
Here we hide QSB when we enter drag mode in order to follow the guidelines set by https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229

Bug: 251259222
Test: Enter edit mode with SHOW_HOME_GARDENING flag on, notice how QSB disappears when we enter drag
Change-Id: If1a00ac62cec21a641295494d3a2dbb1f267bd62
2022-10-25 10:47:48 -07:00
Federico Baron 69c5f2d840 Add flag for moving the workspace edit buttons to bottom
This flag is for moving the workspace edit buttons to the bottom as per https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229.

Bug: 255586768
Test: N/A
Change-Id: I5b23307081333f80f3a8a1f23aa9a09c5425129d
2022-10-25 10:44:36 -07:00
Sihua Ma af210f70fd Merge "Get rid of setInteractionHandler call to the host in launcher" into tm-qpr-dev am: 4421353ce8 am: 82eba8a3bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20274922

Change-Id: I1c6327a673d0444d317d5983255c80d2b823d596
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-25 04:01:22 +00:00
Sihua Ma 82eba8a3bf Merge "Get rid of setInteractionHandler call to the host in launcher" into tm-qpr-dev am: 4421353ce8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20274922

Change-Id: Ib5219481f120ed86021b59c80509303bd1073f97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-25 03:25:37 +00:00
Sihua Ma 4421353ce8 Merge "Get rid of setInteractionHandler call to the host in launcher" into tm-qpr-dev 2022-10-25 02:44:16 +00:00
Tracy Zhou 6445fc9102 Merge "Support swipe gesture on trackpad to swipe up from app" 2022-10-25 01:41:54 +00:00
Federico Baron 74c1830733 Merge "Rename first page pinned widget to mFirstPagePinnedWidget" into tm-qpr-dev am: f748755a4f am: 574a986cb3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20227193

Change-Id: Iaaaf3567d8fd40c2f33fea89e5a920f70d23cccd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-25 01:25:32 +00:00
Federico Baron 574a986cb3 Merge "Rename first page pinned widget to mFirstPagePinnedWidget" into tm-qpr-dev am: f748755a4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20227193

Change-Id: I4063cd9de96fbf2b1e29c1461f601d34f0c93a0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-25 00:48:15 +00:00
Federico Baron f748755a4f Merge "Rename first page pinned widget to mFirstPagePinnedWidget" into tm-qpr-dev 2022-10-25 00:25:34 +00:00
Sihua Ma 8ca56fe1cd Get rid of setInteractionHandler call to the host in launcher
Bug: 235358918
Test: N/A
Change-Id: I0defac1831825bf0a13a601dd1502b4ca022bc2e
2022-10-24 14:56:11 -07:00
Sunny Goyal d859060860 Merging MultiValueAlpha with MultiPropertyFactory
Bug: 246644619
Test: Presubmi
Change-Id: Id5abc5f3169544656f1139ae17ca59e34ac65dac
2022-10-24 14:38:18 -07:00
Federico Baron d457d4cbaf Merge "Set smartspace to 30% visibility on workspace edit for home gardening" into tm-qpr-dev am: 2c97e58933 am: a3e6ee5f88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20193069

Change-Id: If1a631cb9dc6369ce3fead6ee93fe753e198ca0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 20:22:38 +00:00
Sunny Goyal 85cf449fcc Merge "Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""" into tm-qpr-dev am: 0cf401d0eb am: 1baaac662b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20260484

Change-Id: I38c6cec592377e77294e02c70af28ab72d70e90c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 20:16:56 +00:00
Federico Baron a3e6ee5f88 Merge "Set smartspace to 30% visibility on workspace edit for home gardening" into tm-qpr-dev am: 2c97e58933
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20193069

Change-Id: I9043741edf0af77bea640767ca95f8dc46a14f73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 20:14:21 +00:00
Federico Baron 2c97e58933 Merge "Set smartspace to 30% visibility on workspace edit for home gardening" into tm-qpr-dev 2022-10-24 19:17:29 +00:00
Sunny Goyal 1baaac662b Merge "Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""" into tm-qpr-dev am: 0cf401d0eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20260484

Change-Id: Id4c1db6904257ca67756dde0ea198c907f0d0e79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 18:11:33 +00:00
Mady Mellor 344a5974cd Merge "Hide launcher when freeform tasks are visible" into tm-qpr-dev am: b5c2565447 am: f602559b25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017950

Change-Id: Ie285233ddb6e8bf53c1482c7385a04b9629519b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 18:04:24 +00:00
Sunny Goyal 0cf401d0eb Merge "Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""" into tm-qpr-dev 2022-10-24 17:38:42 +00:00
Mady Mellor f602559b25 Merge "Hide launcher when freeform tasks are visible" into tm-qpr-dev am: b5c2565447
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20017950

Change-Id: I1605450eac52bed58566c55259246009c59b27b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-24 17:21:45 +00:00
Mady Mellor b5c2565447 Merge "Hide launcher when freeform tasks are visible" into tm-qpr-dev 2022-10-24 16:04:59 +00:00
Sunny Goyal f34811d3a3 Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""
Test: ABTD
https://android-build.googleplex.com/builds/abtd/run/L52600000956969786

This reverts commit cee6ddf3de.

Reason for revert: Fixed in ag/20239136

Change-Id: I0e8446e66d9a86a94b40fcbd6de14da07abe8e5c
2022-10-22 15:37:47 +00:00
Tracy Zhou daad3fefea Support swipe gesture on trackpad to swipe up from app
Bug: 254783214
Test: https://recall.googleplex.com/projects/3388b17c-d22f-46f8-b140-a102690377b4/sessions/92d385dd-bad5-49ea-a0b4-b4bf4010aabb
Change-Id: I74ba4a9e5c5096aaf6475f9cb8f1dc30de48024d
2022-10-22 07:18:16 +00:00
Becky Qiu 4ed3dfc28a [Toast] Use a BaseSearchConfig for launcher3 to read allapps device config.
Bug: 251387263
Test: local
Change-Id: I92c52caff377e627305bc7999ae0205fe6269968
2022-10-21 17:11:38 -07:00
Ling Wo 7c35298a40 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev am: ac29981a42 am: 12949e8abb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20158848

Change-Id: I3f79292d7c813808a61ca82ea31121daa5ee3eba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 22:44:45 +00:00
Ling Wo 12949e8abb Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev am: ac29981a42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20158848

Change-Id: I6cf20bc024261f138bc845e17a40d330f6ecb524
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 21:58:07 +00:00
Ling Wo ac29981a42 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev 2022-10-21 21:44:35 +00:00
Sunny Goyal 64453ae482 Introducing feature flag for optimizing overlay service connection
Bug: 254903450
Test: n/a
Change-Id: I2286be8583cc6dc46921b9ba8ef5505e5b8f0bf8
2022-10-21 14:07:16 -07:00
Sunny Goyal 2e0bdd4f49 Merge "Optimizing some icon generation code:" into tm-qpr-dev am: 415fe0c183 am: ef188e8c23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040405

Change-Id: Ia9595c728b3ab46b8530a689598bb6cc7c433477
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 20:04:34 +00:00
Federico Baron 0abfda8f2f Rename first page pinned widget to mFirstPagePinnedWidget
mQsb is the name used for the first page pinned widget. This variable name is bad since in some launchers the first page pinned widget is a qsb but sometimes it is a smartspace. Renaming the variable to mFirstPagePinnedWidget is a more accurate name for this variable.

Bug: 251259222
Test: N/A
Change-Id: I6d3c74163995d2267510ee546924917062c4955c
2022-10-21 13:01:24 -07:00
Federico Baron a56f08e677 Set smartspace to 30% visibility on workspace edit for home gardening
Here we set the smartspace to have 30% visibility to follow the guidelines set by https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229

Bug: 251259222
Test: Enter drag mode in workspace with SHOW_HOME_GARDENING flag on to see the changes
Change-Id: Ia2ef4f1a49549fef9f8fbea7c007db8b81972f71
2022-10-21 13:00:58 -07:00
Sunny Goyal ef188e8c23 Merge "Optimizing some icon generation code:" into tm-qpr-dev am: 415fe0c183
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040405

Change-Id: Id325662e61d5cdcc625923536a8458eb44fdd9b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 19:17:35 +00:00
Schneider Victor-tulias ee0bc03d58 Decrease TAPL All Apps scrolling flakiness
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.

Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
2022-10-21 12:12:38 -07:00
Sunny Goyal 415fe0c183 Merge "Optimizing some icon generation code:" into tm-qpr-dev 2022-10-21 18:27:54 +00:00
Federico Baron 79cc65d133 Autohide and autoshow pagination in workspace
Added code similar to WorkspacePageIndicator.java in order to autoshow and autohide the pagination in Workspace using PageIndicatorDots.java

Bug: 249773534
Test: Manual
Change-Id: I3b26d929d71510cf2f9d5342ee4c59007b8429cd
2022-10-21 10:55:26 -07:00
Mady Mellor 9a90c2d521 Hide launcher when freeform tasks are visible
This CL introduces a new controller to manage the visibility of the
launcher workspace when desktop mode is active and freeform tasks
are visible.

This controller will be notified when the sysui state flag related
to freeform task visibility is changed.

The controller will modify the workspace visibility as well as
the flags on the activity indicating if it's been paused / resumed
based on freeform tasks being visible or not.

Bug: 245569277
Test: manual -  enable desktop mode and open some freeform tasks
             => observe that the contents of launcher is hidden and
                taskbar shows
             -  remove all of the freeform tasks
             => observe that the contents of launcher reappears along
                with the hotseat.
Change-Id: I378ab97b40cbb954a06f4e2426b195efddad905c
2022-10-21 10:06:54 -07:00
Vinit Nayak 61d94834f7 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev am: b9b7c38d55 am: 05e238ff32
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20169868

Change-Id: I5c1a164b627794f1f25007ce467bd33bcc26c84f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 01:16:27 +00:00
Vinit Nayak 05e238ff32 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev am: b9b7c38d55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20169868

Change-Id: I2d4308adb3a6396732b663a2f05e9af115318261
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-21 00:43:22 +00:00
Vinit Nayak b9b7c38d55 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev 2022-10-21 00:07:53 +00:00
Treehugger Robot 5f65096bfe Merge "Fix errorprone warnings that should be errors" am: 35157974d4 am: 533b937fd3 am: 14946c1fa3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: Id765742b2e4767888137a01116f2bad1bba859a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:32:40 +00:00
Brian Isganitis 7ed3c82636 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev am: 2bcc3f8599
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19930974

Change-Id: Id1010f7f19454d51b19a11b1d5ed72fe39632332
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:31:44 +00:00
Vinit Nayak eba71a1c8f Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev am: e690ef7f80 am: c136a1f837
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20232996

Change-Id: If5447ddb1e7b0c8f2bad456c82a6993e56f97a7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:18:29 +00:00
Treehugger Robot 14946c1fa3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4 am: 533b937fd3
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I748f2372116aa8bba282a0f1925e3968a9fed0ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 23:16:08 +00:00
Sukesh Ram c6d4df87f0 Added Tests for Secondary Display Launcher
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
Merged-In: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
2022-10-20 22:58:46 +00:00
Brian Isganitis 2bcc3f8599 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev 2022-10-20 22:54:06 +00:00