Commit Graph

16725 Commits

Author SHA1 Message Date
TreeHugger Robot 429f6e880f Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev am: bcc14682e0 am: cd271794c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20345841

Change-Id: I7aacbf9285271710a08a1356cc363391636106c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 14:05:09 +00:00
TreeHugger Robot cd271794c8 Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev am: bcc14682e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20345841

Change-Id: I6f5ca6b81c51b91743384b8fc187788202fbec95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-03 13:30:30 +00:00
TreeHugger Robot bcc14682e0 Merge "Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"" into tm-qpr-dev 2022-11-03 11:27:12 +00:00
Sebastián Franco c55ec5c580 Merge "Return the right radius to start reorder when dragging a Widget" into tm-qpr-dev am: ef24d5954c am: 251567d87b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20317221

Change-Id: I4b2aa1a6b453f79655edfa546be8041850100ab0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 22:21:47 +00:00
Holly Sun a793fc6e2c Bring up IME and focus on input when scroll to top.
Do this behind a feature flag AND only when "Always show keyboard" is selected or in prefix state.

Bug: 218846025
Test: keyboard shown when swiping up for QSB and AA+ (both main and work). Keyboard not shown when either the feature flag or Always show keyboard is disabled.
Change-Id: I3df2e0e44a8313eaf749cd6b91b7f9d0b9b80ec3
2022-11-02 15:19:23 -07:00
Sebastian Franco 4a92267d1d Making code more readable by removing global variable used for optimizations
Using the stack was more efficient because it prevented the creation
of new rectangles but it makes the code harder to read and prone to
bugs if the global state of the stack of rectangles gets corrupted
in any way.

When this optimization was written in 2008 it was necessary but now I
don't think it would have a big impact. The stack size is on average
of 30 and the rectangles are only created when doing the reorder which
runs about once per second if the user moves the finger too quickly.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I35d8ee8d92f01035e72fe5763a7de47f4b6a73de
2022-11-02 22:10:14 +00:00
Sebastián Franco 251567d87b Merge "Return the right radius to start reorder when dragging a Widget" into tm-qpr-dev am: ef24d5954c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20317221

Change-Id: I4d0343b12e67e11b0b4fc2a4e5d017f7cfdeeae4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 21:49:34 +00:00
Sebastián Franco ef24d5954c Merge "Return the right radius to start reorder when dragging a Widget" into tm-qpr-dev 2022-11-02 21:19:44 +00:00
Alex Chau 5dfd939d41 Reland "Add logs for InvariantDeviceProfile.getDeviceProfile"
This reverts commit b065b4b05a.

Bug: 253338238
Change-Id: Idea32130c8ec535f848ded5cff0269d97ea064e2
Test: manual
2022-11-02 17:40:05 +00:00
Tony Wickham 0d3f247ac6 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev am: 6b32ce07b1 am: cbfc9a1f0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19560161

Change-Id: Ia4c7f142e2263361ae7d9d0b03735956adb8aa81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 16:57:47 +00:00
Tony Wickham cbfc9a1f0b Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev am: 6b32ce07b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19560161

Change-Id: I01104af26034497aa989b81e856495aa1454f9e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 16:25:32 +00:00
Tony Wickham 6b32ce07b1 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev 2022-11-02 15:39:45 +00:00
Sunny Goyal 4393a125a3 Merge "Updating widget prediction handling:" into tm-qpr-dev am: 04356a26c3 am: 69a7ad6097
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20312120

Change-Id: I62f3d68bdb369cc296003bad7a2b668b04427787
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 10:04:17 +00:00
Sunny Goyal 69a7ad6097 Merge "Updating widget prediction handling:" into tm-qpr-dev am: 04356a26c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20312120

Change-Id: Ib62a982fffc72968a741e0e07c5dc3cfdfd19088
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 09:19:01 +00:00
Sunny Goyal 3c7054f0d2 Updating widget prediction handling:
When handling widget prediction, first match the full provider names
Only if no widgets are found, match any widget in the package

Bug: 256202399
Test: atest WidgetsPredicationUpdateTaskTest
Change-Id: I5337618d935f8b926803aeefede46059545de72d
2022-11-02 02:24:21 +00:00
Sebastián Franco e4e5c1e3be Merge "No code changes, this cl only reorganizes the functions" into tm-qpr-dev am: 1b14a73223 am: 3b559eb5f6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20305602

Change-Id: I0eb81eb6e997d72dd7f665630a9e18e81d43cd50
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 00:51:36 +00:00
Sebastián Franco 3b559eb5f6 Merge "No code changes, this cl only reorganizes the functions" into tm-qpr-dev am: 1b14a73223
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20305602

Change-Id: Ie2d8b2774892813f52f99c72ae95f621ad8e9d07
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 00:18:12 +00:00
Sebastián Franco 1b14a73223 Merge "No code changes, this cl only reorganizes the functions" into tm-qpr-dev 2022-11-01 23:43:30 +00:00
Federico Baron 255fd6ab2d Merge "Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling." into tm-qpr-dev am: 120c99f440 am: b66773656e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068658

Change-Id: I900a4e60f447d19b5b1121168197e48f4663dcef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 18:53:17 +00:00
Sebastian Franco 9cab1c3ece No code changes, this cl only reorganizes the functions
This is done such that future cls are easier to visualize.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: I749d21b517dada97887d5b5e7cb5e2ac644d0030
2022-11-01 18:24:43 +00:00
Federico Baron b66773656e Merge "Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling." into tm-qpr-dev am: 120c99f440
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068658

Change-Id: Ic0c4c3428ca226a6dbd2a12a8ae9254f40b1aad0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 18:19:52 +00:00
Federico Baron 120c99f440 Merge "Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling." into tm-qpr-dev 2022-11-01 17:56:50 +00:00
Tracy Zhou ac9a011062 Merge "Support split from fullscreen with shortcuts" into tm-qpr-dev am: 0c853991fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20206366

Change-Id: I0709750372123eeaafb66477fd9c6d78f258fad2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 17:41:10 +00:00
Tracy Zhou 0c853991fd Merge "Support split from fullscreen with shortcuts" into tm-qpr-dev 2022-11-01 17:17:33 +00:00
Luca Zuccarini 350fdc6ec6 Merge "Make sure that PropertySetter applies the final state." into tm-qpr-dev am: 938dde8111 am: a20c6df786
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20298523

Change-Id: Iae18b1b3bacca6ccebe7905f10dd7538603b3ba2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 13:36:12 +00:00
Luca Zuccarini a20c6df786 Merge "Make sure that PropertySetter applies the final state." into tm-qpr-dev am: 938dde8111
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20298523

Change-Id: Iea1793aa1d7f0f7f037f36fe7b3b3318e9be49d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 13:04:04 +00:00
Luca Zuccarini 938dde8111 Merge "Make sure that PropertySetter applies the final state." into tm-qpr-dev 2022-11-01 12:28:54 +00:00
TreeHugger Robot f56fe1758b Merge "Move DropTargetBar to bottom" into tm-qpr-dev am: 86dc1edbf8 am: 004c11d7d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20283568

Change-Id: I9279dcd7805b5cc5110e46fd462b189b819c7a3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 08:26:10 +00:00
TreeHugger Robot 004c11d7d4 Merge "Move DropTargetBar to bottom" into tm-qpr-dev am: 86dc1edbf8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20283568

Change-Id: Ia9c7815cf47463ebaba1170e1c5bc27c8bae8f7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 07:52:04 +00:00
TreeHugger Robot 86dc1edbf8 Merge "Move DropTargetBar to bottom" into tm-qpr-dev 2022-11-01 07:21:31 +00:00
TreeHugger Robot a09e7f49dd Merge "Add dot pagination in workspace" into tm-qpr-dev am: d20e6676b1 am: b4293273df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20251840

Change-Id: I76fcda067c80cea327ab732191e3db32d7e20638
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 05:26:46 +00:00
TreeHugger Robot b4293273df Merge "Add dot pagination in workspace" into tm-qpr-dev am: d20e6676b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20251840

Change-Id: Icaba792ef48f244f08f35bb68a87db217b0739b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 04:53:10 +00:00
TreeHugger Robot d20e6676b1 Merge "Add dot pagination in workspace" into tm-qpr-dev 2022-11-01 04:33:29 +00:00
Tracy Zhou ba0b5952c8 Support split from fullscreen with shortcuts
Recording: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/978a3a55-2982-4026-9726-2a73cb694258

TODO: improve transition animation

Bug: 246661484
Test: manual
Change-Id: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
Merged-In: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
2022-11-01 04:30:39 +00:00
Tracy Zhou 5b07f1d145 Merge "Support split from fullscreen with shortcuts" 2022-11-01 04:29:29 +00:00
Sebastián Franco f5615dda63 Merge "Decoupling finding the solution and animation of a reorder in CellLayout" into tm-qpr-dev am: 0c3f990b34 am: c55ae777db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20284695

Change-Id: I73db3a8b39044d308f9cf91ae3c6449f5ad92477
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-01 00:11:45 +00:00
Sebastián Franco c55ae777db Merge "Decoupling finding the solution and animation of a reorder in CellLayout" into tm-qpr-dev am: 0c3f990b34
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20284695

Change-Id: Ib528d4b9ee676cd2da976eeaeaa5f82c60fa2ab7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 23:39:14 +00:00
Sebastián Franco 0c3f990b34 Merge "Decoupling finding the solution and animation of a reorder in CellLayout" into tm-qpr-dev 2022-10-31 23:02:44 +00:00
Federico Baron 8bf1bca59a Tapping on a "folder" on the Homescreen right after returning home results in it starting to open, then canceling.
Fix: 243531200, 253264925
Test: manual
Change-Id: I180300e8333536346ad07ce7bc9956d3b84d82e6
2022-10-31 15:12:17 -07:00
Holly Jiuyu Sun 1194a6156c Merge "Log sub event type to latency logger." into tm-qpr-dev am: c5f43eb9f7 am: 1acb878078
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20296334

Change-Id: Ief1c24b7af455e0e1daba155f3cf8291e91bb564
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 20:57:29 +00:00
Holly Jiuyu Sun 1acb878078 Merge "Log sub event type to latency logger." into tm-qpr-dev am: c5f43eb9f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20296334

Change-Id: Ib77b601b328cdc102beb57cb8c4c0674e9a4cd30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 20:25:58 +00:00
Holly Jiuyu Sun c5f43eb9f7 Merge "Log sub event type to latency logger." into tm-qpr-dev 2022-10-31 19:28:27 +00:00
Sunny Goyal 66a2d8cf67 Merge "Fixing flakyness in widget tests" into tm-qpr-dev am: 276e72c249 am: d23fc2405f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20312118

Change-Id: Iaec13e95b7c8793705e4b9a7cde7eb85da17da3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 17:25:55 +00:00
Sebastian Franco c8392ea881 Return the right radius to start reorder when dragging a Widget
Currently the radius is only one cell but in the case of a widget
we want the radius of the whole widget.

Fix: 255421400
Test: this case only happens when dagging comming from outside of the cell layuot in the corners dragging a widget
Change-Id: I3fe294d18283dbecb27df1a2d4748dd44db9b956
2022-10-31 10:20:53 -07:00
Sunny Goyal d23fc2405f Merge "Fixing flakyness in widget tests" into tm-qpr-dev am: 276e72c249
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20312118

Change-Id: I94f52325e89138ecdd9352e6b18e350a6b44ad94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-31 16:53:12 +00:00
Sunny Goyal 276e72c249 Merge "Fixing flakyness in widget tests" into tm-qpr-dev 2022-10-31 16:23:08 +00:00
Tracy Zhou b9baae22bc Support split from fullscreen with shortcuts
Recording: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/978a3a55-2982-4026-9726-2a73cb694258

TODO: improve transition animation

Bug: 246661484
Test: manual
Change-Id: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
2022-10-31 06:36:26 +00:00
Jeff Sharkey 1090fe96cf Merge "RemoteActionShortcut: try avoiding Activity leaks." 2022-10-29 15:25:25 +00:00
Jeff Sharkey d081c041c3 RemoteActionShortcut: try avoiding Activity leaks.
Hold a WeakReference into the closure, allowing the Activity to be
GC'ed if nobody else is keeping it alive.

Bug: 255833934
Test: atest --rerun-until-failure 100 NexusLauncherTests:WellbeingTests
Change-Id: Ica06d10a442390fe499d4d75e985d3510e2e63e1
2022-10-28 19:56:16 -06:00
Holly Jiuyu Sun 2750fa19bc Merge "[QL-v2] Use subtitle as hint if title doesn't apply." into tm-qpr-dev am: 35b0378d45 am: c9196b45d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20142072

Change-Id: I950807bb528f6afb1d52c00ebfb4e164bcbfc63b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-28 21:06:32 +00:00