Commit Graph

16725 Commits

Author SHA1 Message Date
Vinit Nayak e690ef7f80 Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev 2022-10-20 22:49:57 +00:00
Treehugger Robot 533b937fd3 Merge "Fix errorprone warnings that should be errors" am: 35157974d4
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2254242

Change-Id: I6b47e8706afe05f5fdac403e79c87a533fbcc2c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 22:45:27 +00:00
Jeremy Sim 9c6a7abf9c Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev am: 8edca84cd5 am: 0c1d05a636
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20155090

Change-Id: I849721e96b7ba080b2367d1dddfd057878108776
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-20 22:02:28 +00:00
Jeremy Sim 8edca84cd5 Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev 2022-10-20 20:59:49 +00:00
Sukesh Ram aee55077cc Fix crash on long press of prediction row icons
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.

Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
Merged-In: I9a4679ba82cacb5e2648481274876dbfc95d80ce
2022-10-20 18:11:15 +00:00
Brian Isganitis ddbe35cc87 Merge "Drag from appDrawer & pin onto secondary display homescreen" into tm-qpr-dev 2022-10-20 18:08:07 +00:00
Sunny Goyal fc1928e324 Optimizing some icon generation code:
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
2022-10-20 10:40:54 -07:00
Thales Lima ed8c69baca Make all handheld grids scalable
Also increase the icon size in the XML until the icon is sized correctly.

Fix: 239419094
Bug: 235886078
Test: manual
Change-Id: I0c7d75181a61177cc5993ba7002c3ccc8fd60fbf
2022-10-20 11:51:59 +01:00
Vinit Nayak 981034687a Scale screenWidth for split proportionally for thumbnail matrix
* Instead of passing in screenWidth to be that
of entire screen when using split, scale screenWidth
to that of only the amount that the given split app
is taking.
* Created TODO(b/254378592) to consolidate different
SplitBounds classes

Fixes: 250817893
Test: Checked phone/tablet swiping quickswitching
portrait and landscape

Change-Id: I5c3b2076110e358366284b2c794fd8df8a79f034
2022-10-19 21:39:50 -07:00
TreeHugger Robot 771c658e94 Merge "Add scroll up and scroll down logging." into tm-qpr-dev am: 821ef94974 am: 0967d53cf5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20181861

Change-Id: I476bfd2bf672e4c840e87e1a29aee14bcbdd827c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 21:47:35 +00:00
Federico Baron 50b9039137 Merge changes I03636e28,I6cf6d52e into tm-qpr-dev am: 41235d529b am: 5ff03db6a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20095896

Change-Id: Ia3bc6db3d148ca74ff863b43fcec8aac0cb5cd57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 20:33:40 +00:00
TreeHugger Robot 821ef94974 Merge "Add scroll up and scroll down logging." into tm-qpr-dev 2022-10-19 20:31:54 +00:00
Federico Baron 41235d529b Merge changes I03636e28,I6cf6d52e into tm-qpr-dev
* changes:
  Fix page indicator dots height in workspace
  Change delightful pagination flag and use it for workspace
2022-10-19 19:33:18 +00:00
Andy Wickham 88b795e54c Merge "More robust fix to BubbleTextViews appearing on multiple rows." into tm-qpr-dev am: a57bff8473 am: f4abbadb21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20105877

Change-Id: Iae7177d1cb278930881e56c4a087aa7e7e11cc1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 18:34:20 +00:00
Sukesh Ram b066f41fa3 Drag from appDrawer & pin onto secondary display homescreen
Bug: 239246505
Test: Manual
Change-Id: I817d8ef700f2d7caec6fa63123935502f17f2d2f
Merged-In: I817d8ef700f2d7caec6fa63123935502f17f2d2f
2022-10-19 18:22:01 +00:00
Anushree Ganjam 0de35265c1 Add scroll up and scroll down logging.
Bug: 247601175
Test: Manual. https://paste.googleplex.com/5757099224072192

Change-Id: Iec1697e1580c75572c9e77ec349942301ee87694
2022-10-19 18:00:45 +00:00
Andy Wickham a57bff8473 Merge "More robust fix to BubbleTextViews appearing on multiple rows." into tm-qpr-dev 2022-10-19 17:40:52 +00:00
TreeHugger Robot 1aaca4097e Merge "Implement overlay window for Taskbar EDU and All Apps." into tm-qpr-dev am: c9928a1ddf am: 08092b2cfb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20154536

Change-Id: Ifad418ad73a6bf4a98d6bdfce80d0cbbdfb90790
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 15:00:57 +00:00
Pat Manning 4b1961c76e Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev am: ded9a7485e am: 986e5dde13
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19697622

Change-Id: I388e72836de3213a06e638f8c329836c79fc3296
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 15:00:08 +00:00
TreeHugger Robot c9928a1ddf Merge "Implement overlay window for Taskbar EDU and All Apps." into tm-qpr-dev 2022-10-19 14:01:56 +00:00
Pat Manning ded9a7485e Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev 2022-10-19 13:36:56 +00:00
Alex Chau ce226c65b5 Merge changes from topic "widget_blur" into tm-qpr-dev am: 8dac89d235 am: 95759878e5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20225103

Change-Id: Icf87c7e1a762d2ba531006ae2599ae75e7e05749
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 10:50:53 +00:00
Alex Chau f643a9b683 Fix STATE_DEPTH stuck at 1 after setting wallpaper am: 950a10738b am: 7b815365ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967480

Change-Id: I1751b4a746d91ad6a4206114437b483b9b14d4a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 10:50:51 +00:00
Alex Chau 7b815365ea Fix STATE_DEPTH stuck at 1 after setting wallpaper am: 950a10738b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967480

Change-Id: I00d40ac79fd33db656ae72fe492964cc1e46f8c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 10:01:18 +00:00
Alex Chau 8dac89d235 Merge changes from topic "widget_blur" into tm-qpr-dev
* changes:
  Enable wallpaper blur for widget picker
  Fix STATE_DEPTH stuck at 1 after setting wallpaper
2022-10-19 09:37:39 +00:00
Federico Baron 056fc9ba1a Merge "Get rid of spring loaded mode for home gardening design" into tm-qpr-dev am: ee5827d96e am: 608cca982f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20191502

Change-Id: Icdf82b1393b36f95659da76185b8ccbd114a6fed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 23:30:22 +00:00
Holly Sun dbd01bf6f9 Log a-z apps count.
Test: manual
Bug: 247432075
Change-Id: I9538a75bc3cb3d1e8e9089fc5e27d5d770cafb62
2022-10-18 15:57:53 -07:00
Federico Baron 1028a726ef Get rid of spring loaded mode for home gardening design
For the new home gardening mode, we plan on not having a spring loaded mode where the overlay shrinks, so when we have the flag for home gardening on, we won't be having the workspace have the green overlay and the icons shrink

Bug: 251259222
Test: Hold on an icon in workspace to enter edit workspace mode, notice how we no longer shrink the workspace
Change-Id: Ibf1c38eecc117a838eca20a860d47c355955b513
2022-10-18 13:49:37 -07:00
TreeHugger Robot 2af1a22e73 Merge "Fixes ITEM_TYPE_SEARCH_ACTION to have a unique value." into tm-qpr-dev am: 7798fb6e30 am: 724963448f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20125070

Change-Id: Ieb1076e0d199e830f220afc57124fde051753834
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 18:31:37 +00:00
TreeHugger Robot 7798fb6e30 Merge "Fixes ITEM_TYPE_SEARCH_ACTION to have a unique value." into tm-qpr-dev 2022-10-18 17:34:23 +00:00
Alex Chau 1852459977 Enable wallpaper blur for widget picker
Fix: 240580498
Test: Go to walppaper&style, set new wallpaper, then go to widget picker, wallpaper depth should transition smoothly
Change-Id: Iadabd0e755f861fb1e8967209dd647faed6e4916
2022-10-18 17:07:47 +01:00
Alex Chau 950a10738b Fix STATE_DEPTH stuck at 1 after setting wallpaper
- Made BaseDepthController.setDepth/mDepth private, all get/set should be done through STATE_DEPTH or WIDGET_DEPTH
- Generified ClampedDepthProperty into Utilities.ClampedProperty to apply on STATE_DEPTH

Bug: 240580498
Test: Go to walppaper&style, set new wallpaper, then go to widget picker, wallpaper depth should transition smoothly
Change-Id: I53cdedf970fd7ffba6a952c4edf4b34251b01f07
2022-10-18 17:07:17 +01:00
Andy Wickham 9345681737 Fixes ITEM_TYPE_SEARCH_ACTION to have a unique value.
It previously was the same as ITEM_TYPE_TASK.

Test: N/A
Bug: 254138853
Bug: 254140269
Change-Id: I6f09818e3c5c05cbcbb451147cf310d59c7064e0
2022-10-17 17:11:25 -07:00
Andy Wickham c17c3171c5 More robust fix to BubbleTextViews appearing on multiple rows.
This is the more comprehensive version of ag/20119299.
Improvements compared to that change:
 - Icons on the same row animate together (as opposed to the
   first icon on the row animating separately)
 - Multiple rows of predicted apps are supported (any beyond
   the first row are animated like everything else)

--- Original description ---

Example BubbleTextView: WhatsApp/Gmail conversation shortcuts.

The issue was we were treating these the same as the top app
row, but we were assuming there would only be 1 such row, which
messed up the measurement logic. At the same time, the logic
specific to that app row was redundant with the new logic for
rows containing mulitple items.

This solution does 2 things:
 - Removes special logic for app row (it now uses the same
   logic as other rows with multiple items, i.e. uses the span
   index to determine the height of the row)
 - Keeps the scale/alpha at 1 for the first row of app icons.
   This currently only applies to predicted apps, but if there
   were multiple app rows in the future, the additional rows
   would animate the same way as other rows (see demo videos
   for an example with double predicted apps in 0 state). In
   the conversation case, the other icons are deep shortcuts.

The result is the app row still does what it did before (stays
fixed at full size/opacity), and deep shortcuts like the ones
used for WhatsApp and Gmail animate like other rows of items,
such as screenshots.

Demo videos: https://drive.google.com/drive/folders/1GPQNIwMfuj9ZdAbRrh-K75C5xJYT4Gzo?resourcekey=0-ojO6VGetEBy5YTq4roFmlw&usp=sharing

Test: Manual with and without inject_web_top (which moves app row)
for WhatsApp and Gmail with AiAi fishfood.
Bug: 239927522

Change-Id: Ib2ca97b93798cb57eb55545eeba8be9322484f7d
2022-10-17 16:47:27 -07:00
Vinit Nayak 90eff11fee Merge "Landscape 3 button nav on taskbar phone supported" into tm-qpr-dev 2022-10-17 22:30:05 +00:00
Hui Kang 70765883c5 Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev am: 2a28ae8a3f am: da45ddb921
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20213328

Change-Id: Ib0198ed6d4c19b1889bde9144ed33b30a0dedae7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 22:24:43 +00:00
Hui Kang 2a28ae8a3f Merge "Revert "Updating the scroll calculation from recyclerView to avoid view inflation"" into tm-qpr-dev 2022-10-17 21:20:09 +00:00
Vinit Nayak d6c5147524 Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
Merged-In: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-17 13:59:18 -07:00
Hui Kang cee6ddf3de Revert "Updating the scroll calculation from recyclerView to avoid view inflation"
This reverts commit 20bbe95ddb.

Reason for revert: Causing flake in Ironwood test: b/248295569

Test: ABTD
Before: Flaky, 14/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L33900000956890639

Revert: 50/50 PASSED
https://android-build.googleplex.com/builds/abtd/run/L49200000956887317

Change-Id: I41f4428c74e581323f90c716a7852b5e553ae27d
2022-10-17 20:37:49 +00:00
Vinit Nayak 391b79c084 Merge "Landscape 3 button nav on taskbar phone supported" 2022-10-17 20:14:36 +00:00
TreeHugger Robot 17ccbb9058 Merge "Revert "Enable taskbar in overview by default"" into tm-qpr-dev am: 126d178358 am: 5b9e0cf902
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20207527

Change-Id: Id785ae174b5c77844457da44bf949280e689fcc9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 18:40:13 +00:00
TreeHugger Robot 126d178358 Merge "Revert "Enable taskbar in overview by default"" into tm-qpr-dev 2022-10-17 17:40:17 +00:00
Alex Chau 6f0b0fe742 Revert "Enable taskbar in overview by default"
This reverts commit 517131ae1c.

Reason for revert: Reverting until b/251747761 is addressed
Bug: 245320601

Change-Id: Ic5ebc071f092c8f91ff879a59d89c3be4326c90e
2022-10-17 14:38:09 +00:00
Pat Manning 5889bc3729 Add launcher metrics for tracking kids nav mode change events.
Fix: 241762670
Test: wwdebug && wwlogcat
Change-Id: I24432f2cd0dddbcc5991645b60a1a8e91dc431e5
2022-10-17 14:06:38 +01:00
Cole Faust 50ec4afe25 Fix errorprone warnings that should be errors
This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: If17d2944bfd3e7ab10592a4c74c956203c356f81
2022-10-16 13:35:16 -07:00
Brian Isganitis 2d6371aa34 Implement overlay window for Taskbar EDU and All Apps.
Having EDU in the same window as Taskbar causes it to be above All Apps
and other system views such as the notification tray. This change
refactors the existing All Apps window to accomodate more AFVs so that
EDU can also exist in it.

Demo: http://shortn/_Qcki3gwvf7

Test: Manual
Fix: 232177330
Change-Id: I1bef31d798041a90a0c3e033e71be63898fa5fbc
2022-10-14 22:36:14 +00:00
Sebastián Franco 8f357c149e Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev am: 73b8ee9390 am: 5e8c248e1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20122918

Change-Id: I51de393340bf6fa5537a145a71ec9d46d4e2beff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 21:46:41 +00:00
Sebastián Franco 73b8ee9390 Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev 2022-10-14 20:43:34 +00:00
Alex Chau 632e69b801 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev am: 41ab3f3e14 am: d8465a72cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20139153

Change-Id: I50ed52d8dca4108e57b6ed964e26da28227073d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 01:40:32 +00:00
Alex Chau 41ab3f3e14 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev 2022-10-14 00:31:32 +00:00