Commit Graph

16725 Commits

Author SHA1 Message Date
Vinit Nayak 831a4f0e1d Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-13 23:22:38 +00:00
Vinit Nayak 0f6526e0c4 Improve TaskMenuView layouts for split pairs
* Instead of basing calculations on the TaskView view,
use the TaskThumbnailView as the anchor.
This helps us prevent having to re-calculate positions
that were already done to layout the thumbnails
* TODO: Gracefully handle re-positioning task menu view
on rotation

Bug: 249693334
Test: Manual, opening task menu view in
land/seascape in portrait, w/ and w/o home rotation

Change-Id: I02da96d2735657d5340e23056de69392ff8452c4
2022-10-13 14:15:14 -07:00
Vinit Nayak 71b3b458e1 Merge "Fix casts to Math.round() in real landscape" into tm-qpr-dev am: 0bc70442d6 am: d955e318c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20179629

Change-Id: Ibe69a9b9dd9034a70dae1e3ebfb8b63142c5c133
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 21:13:22 +00:00
Vinit Nayak 0bc70442d6 Merge "Fix casts to Math.round() in real landscape" into tm-qpr-dev 2022-10-13 20:02:05 +00:00
Vinit Nayak b26664800e Fix casts to Math.round() in real landscape
Fixes: 248575056
Test: Wallpaper no longer bleeds through on split
animation in real landscape.

Change-Id: Ia59efda737de94a4b64f9d0a1f84cd116539107b
2022-10-13 13:01:39 -07:00
Federico Baron 284cfb6491 Merge "Fix bug where pagination animation comes in from outside the folder when opening folder after swiping back home from another app (left to right swipe)" into tm-qpr-dev am: 922bde1df3 am: b9afac3a26
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20177132

Change-Id: Ib3d2c505344db9637bd2b181a7ea26f394cf5c1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 18:49:20 +00:00
Federico Baron 922bde1df3 Merge "Fix bug where pagination animation comes in from outside the folder when opening folder after swiping back home from another app (left to right swipe)" into tm-qpr-dev 2022-10-13 17:48:40 +00:00
Ling Wo 5c239ba4f7 Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion
Bug: 242246407
Test: atest
Change-Id: Icde0185c82b1d34570d83bd8b9750acb57a8e39c
2022-10-13 01:46:45 +00:00
Federico Baron c722e7d814 Fix bug where pagination animation comes in from outside the folder when opening folder after swiping back home from another app (left to right swipe)
Fix: 249814494
Test: Manual
Change-Id: I03008dd24ddb9a0ba4c5a44878cbdf04c65de435
2022-10-12 15:42:34 -07:00
TreeHugger Robot 09b3d0609f Merge "Desktop tile that is a snapshot of desktop" into tm-qpr-dev am: 24dd3f57b2 am: 97c4e6d04d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20027847

Change-Id: I412f8cd5ce2fc3383e9f7f08e254ff42efddd78b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 21:51:23 +00:00
TreeHugger Robot 24dd3f57b2 Merge "Desktop tile that is a snapshot of desktop" into tm-qpr-dev 2022-10-12 21:10:16 +00:00
Sebastian Franco d468299c0f Moving the class LayoutParams to a file outside CellLayout
I'm moving the LayoutParams to another file to start the decoupling
of the Reorder outside of the CellLayout.

Also, I change the name from LayoutParams to LauncherLayoutParams to prevent confusion with ViewGroup.LayoutParams making it explicit that this are different LayoutParams.

Bug: 188081026
Test: atest ReorderWidget
Change-Id: I92251c5540ffcf5ece7b933e6f6c836eb825c997
2022-10-12 16:14:42 +00:00
TreeHugger Robot 92d7ca5fe9 Merge "Enable taskbar in overview by default" into tm-qpr-dev am: 2613431914 am: afda58246e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20111701

Change-Id: I82afb64f29c925a4e39c5ab1bb2b0304733bfd43
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-12 13:22:02 +00:00
TreeHugger Robot 2613431914 Merge "Enable taskbar in overview by default" into tm-qpr-dev 2022-10-12 12:21:14 +00:00
Jeremy Sim 0ac4708396 Prevent doubling up on split placeholder insets
This patch makes it so that the split placeholder uses only one inset for buffering the top of the icon: either the default split placeholder inset, or the device's built-in screen inset.

Currently, when we determine the size of the split placeholder, we add the placeholder's default inset to the device's built-in screen inset (camera cutouts, etc.). On some devices, this causes a very large combined inset, and it doesn't leave enough room for all the other UI elements, especially when 3-button mode is active. This patch cuts out one of the insets by selecting only one of the insets to respect (the larger one).

Fixes: 241164191
Test: Manual, checked all emulated inset types on a variety of screen sizes
Change-Id: Ica0e791bf4b8b757ad3fb87ab1cf3105b97a61dc
2022-10-11 21:26:43 -07:00
Brandon Dayauon 1e5fcc1909 Merge "Scale icons from search to make app icons big like AA -> workspace" into tm-qpr-dev am: 956851e7ca am: 215ddb9b92
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19774829

Change-Id: Id68d31a6f91dd99b85bf4943998834d4fa25a917
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 23:39:30 +00:00
Brandon Dayauon 956851e7ca Merge "Scale icons from search to make app icons big like AA -> workspace" into tm-qpr-dev 2022-10-11 22:40:13 +00:00
Sebastián Franco 41abc6d89b Merge "Prevent double touch inputs in the BaseDragLayer" into tm-qpr-dev am: 73049b14b9 am: bd484f174a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040579

Change-Id: I4861646ea4b134560d572d14df5c9750f144b186
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 21:29:27 +00:00
Brandon Dayauon d3755f46cc Scale icons from search to make app icons big like AA -> workspace
when dragging from search.

To scale the icon during dragging (instead of long press) I created a scale variable within DragOptions
so that right before dragStart gets called in DragController.java (in callOnDragStart())
the dragview scales before dragging..
 * note: the scale from search is 1.687 and the scale from allApps is 1.107
- included searchResult and smallSearchResult
- Added animation for scaling icon (used Interpolators.EMPHASIZED 500ms as suggested by motion designer)
- Cancel animation when drag finishes

bug: 222666176
test: Manual - after: https://drive.google.com/file/d/1ZZHnXlzdTxlM-RUIdJ6EOYkPPg6tCUxC/view?usp=sharing
before: https://drive.google.com/file/d/1NpBz3kT_slHXtpXObr_G8K6SZYG9_bLX/view?usp=sharing

Change-Id: I01309a3be928987ba00422ad947b80a3df865973
2022-10-11 13:29:35 -07:00
Sebastián Franco 73049b14b9 Merge "Prevent double touch inputs in the BaseDragLayer" into tm-qpr-dev 2022-10-11 20:22:45 +00:00
Alex Chau 517131ae1c Enable taskbar in overview by default
- Also changed expectation in test that taskbar is visible in overview

Fix: 245320601
Test: presubmit
Change-Id: If1ed44f542e5907860f7ab8182e4b45172346f3f
2022-10-11 18:48:45 +01:00
Alex Chau de1d8456d3 Merge "Fix positioning of split instruction and share targets with taskbar in overview" into tm-qpr-dev am: e2791f0cf6 am: 94183eeaf9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20132885

Change-Id: I67023a798eeba419834cdc91a89b3dc2e3b9aee1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 15:05:01 +00:00
Sebastian Franco 68fc44ffad Prevent double touch inputs in the BaseDragLayer
If you hold a long press and while pressing you start another
long press again with another finger, then a new onLongPress event
will trigger and in some cases we are not processing that case.

By ignoring the evetns with the flag ACTION_OUTSIDE we can prevent
such cases.

Fix: 247477725
Test: ReorderWidgets
Change-Id: I31833bc54db2771809562bd1f92c8523eb2f05ab
2022-10-11 09:54:46 -05:00
Alex Chau e2791f0cf6 Merge "Fix positioning of split instruction and share targets with taskbar in overview" into tm-qpr-dev 2022-10-11 14:04:57 +00:00
Alex Chau 0733ebd3c1 Run setCurrentPage in applyLoadPlan after scroll initialized
- Also combined the 2 setCurrentPage call in applyLoadPlan into 1
- Otherwise setCurrentTask may set to page 1 unexpectedly due to page 0's scroll being invalid and out of range

Bug: 246283207
Bug: 238461210
Test: Split screen with 2 apps, click back, go to overview again, should snap to focsued task
Change-Id: I3b57655c810668fe244659437fbd4a745ca02d21
2022-10-11 12:36:35 +01:00
Jon Miranda 23252222e7 Add ENABLE_TRANSIENT_TASKBAR feature flag. am: efd41a717e am: 0a69f652ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20159824

Change-Id: I547e3fd9770bf965cdadeb69c8decffdd81bbe61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 06:00:03 +00:00
Jon Miranda efd41a717e Add ENABLE_TRANSIENT_TASKBAR feature flag.
Bug: 252905206
Test: N/A
Change-Id: I7995e4fc0a181aee6932e0bee041b74a4241053e
2022-10-10 18:46:19 -07:00
Ats Jenk 3c59d9b345 Desktop tile that is a snapshot of desktop
Create a desktop recents tile that shows a snapshot of the freeform
tasks running on desktop.
Scales them down and positions them in the same location as they would
be on the desktop.

Bug: 244348395
Test: manual
Change-Id: Ieb5830a331691844769003189f557c4b7e4cd35c
2022-10-10 15:50:31 -07:00
Federico Baron 55dfd41b6d Merge "Add flags for new home gardening mode" into tm-qpr-dev am: 3c8ae3efff am: 71f32b4f20
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20123118

Change-Id: I483a2742d4d5efe1b33dd6fcf62eb0437de01ac4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:35:19 +00:00
TreeHugger Robot d2ee73ff28 Merge "Round split layout values instead of using int cast" into tm-qpr-dev am: 803f88b89e am: b3d89f0fbe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20142330

Change-Id: I91f232509bdfe56a3c848edb9fcb836b3fbd448e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:35:09 +00:00
Vinit Nayak 2d0d43ceb7 Merge "Improve splitscreen recents animation in seascape" into tm-qpr-dev am: 8addaad158 am: 9388213c9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20105878

Change-Id: I3fde4dfb5611f854d7a52e7f793295379575c879
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:34:40 +00:00
TreeHugger Robot 461d85dcfa Merge "Fix repeated empty workspaces after changing the grid size." into tm-qpr-dev am: 1f7b2f9a7a am: ec7229e94b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18470799

Change-Id: If60cb3b2c0de474134356dc768c8e65d2c250735
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:32:49 +00:00
Luca Zuccarini 7a321c4df5 Merge "[Toast] Switch to using device config to control keyboard sync." into tm-qpr-dev am: 82469ea23b am: bf7afbcfc8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20085413

Change-Id: I9159a788f74f6b108d90f3814645453bd956b097
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 21:30:39 +00:00
Federico Baron 3c8ae3efff Merge "Add flags for new home gardening mode" into tm-qpr-dev 2022-10-10 19:59:14 +00:00
TreeHugger Robot 803f88b89e Merge "Round split layout values instead of using int cast" into tm-qpr-dev 2022-10-10 17:51:52 +00:00
Vinit Nayak 8addaad158 Merge "Improve splitscreen recents animation in seascape" into tm-qpr-dev 2022-10-10 17:49:54 +00:00
TreeHugger Robot 1f7b2f9a7a Merge "Fix repeated empty workspaces after changing the grid size." into tm-qpr-dev 2022-10-10 16:57:59 +00:00
Alex Chau 21064ef82a Merge "Fix flaky/failing two panel TAPL tests" into tm-qpr-dev 2022-10-10 15:59:37 +00:00
Andras Kloczl 0e4f04d85f Fix flaky/failing two panel TAPL tests
Since Cuttlefish emulators are quite slow, some
of the two panel related TAPL tests were failing
due to multiple page changes instead of single ones.

Test: atest -c NexusLauncherTests:com.android.launcher3.ui.workspace.TwoPanelWorkspaceTest
Bug: 236136463
Fix: 252747355
Change-Id: Ib154cf97040fcea3b4d2d7082352c06de74f8c2a
(cherry picked from commit 486f7c8766)
Merged-In: Ib154cf97040fcea3b4d2d7082352c06de74f8c2a
2022-10-10 10:52:16 +00:00
Luca Zuccarini 82469ea23b Merge "[Toast] Switch to using device config to control keyboard sync." into tm-qpr-dev 2022-10-10 10:22:27 +00:00
Brandon Dayauon f18f58c438 Merge "Add variable to check if button should apply keyboard insets" into tm-qpr-dev am: 926d04ec14 am: b38f5045ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20129357

Change-Id: I3a04e0e5930e10280345d7d0a28dac47e2f9e2c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-08 13:23:14 +00:00
Brandon Dayauon 926d04ec14 Merge "Add variable to check if button should apply keyboard insets" into tm-qpr-dev 2022-10-08 12:15:26 +00:00
Alex Chau 8949c583ee Fix positioning of split instruction and share targets with taskbar in overview
- When taskbar is in overview, overview actions has dedicated space and no need to align to nav buttons
- Add a bottom margin to split instruction and share targetse that is equal to the space below overview actions

Bug: 245320601
Test: Test split select and share target with different screen sizes
Change-Id: I6aec325da9cc4c43c84ba8bed5f0e087c57d6925
2022-10-08 10:15:58 +01:00
Holly Sun 9b024eb01f [QL-v2] Use subtitle as hint if title doesn't apply.
Test: manual
Change-Id: Ib5ace9acda9618de905a85854d92e6f865f5fad0
2022-10-07 16:40:38 -07:00
Brandon Dayauon b1840e3f36 Add variable to check if button should apply keyboard insets
bug: 251460671
test: manual
Change-Id: I90045c96c0fbf385ad8dd5978089491f3f106dd8
2022-10-07 15:32:23 -07:00
Vinit Nayak 8f54d597bf Round split layout values instead of using int cast
* Silly us, we forgot that int casting always floors.
Math.round() does a mathematical round.

Fixes: 248575056
Test: Wallpaper no longer bleeds through on split
animation.

Change-Id: I068c030ce6b86fc12faee7778c0d87a0d5aea487
2022-10-07 14:46:25 -07:00
Andy Wickham 09e4c86b4c Merge "Differentiate between app row and shortcut icons." into tm-qpr-dev am: 1874371aab am: 299b025b9f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20119299

Change-Id: Ic4188160e10e6c394be66a31ece6162d881a6351
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-07 21:38:56 +00:00
Andy Wickham 1874371aab Merge "Differentiate between app row and shortcut icons." into tm-qpr-dev 2022-10-07 20:42:51 +00:00
Andy Wickham 22a2af82be Merge "Hide FloatingHeaderView while in Search state." into tm-qpr-dev am: 2c5f545d0b am: b089ed4d94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20104878

Change-Id: Ia0517f6eea842155ac62a5de95929d1fd7d2cacd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-07 18:38:59 +00:00
Holly Jiuyu Sun 6705c89207 Merge "Quick launch v2." into tm-qpr-dev am: 6fa0562aee am: 3760ce9774
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20075881

Change-Id: Id851534638fe499513e1ce0e47d17a4186c21d8e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-07 17:25:32 +00:00