In reality just makes shapes load asynchronously when applying, to unblock users.
In the future we may want to at least wait for preview to load, and handle case where users leave picker early.
Bug: 404486355
Test: tested applying each shape in picker and measuring the elapsed time
Flag: com.android.launcher3.enable_launcher_icon_shapes
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: Ic844a3519a8d7ecde80b72c0616a9e08edceb310
This prevents old scopes still being active when new TaskView state emissions are being sent to main. They were previously cancelled in time but still result in empty continuations occuring on main.
Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces
Change-Id: I539a6fde8c9315ceeac74c9bf622d1e2dca1403a
Surface reparenting was happening on every frame since we call
applyDepthAndBlur on each frame during animation. Instead we can do it
only when base surface is set. mBlurSurface should always be parented to
mBaseSurface so no point in calling it again and again.
Relative layer changes only when we either draw above or recents. While
drawing above recents, mBaseSurface relative layer should be used.
mBaseSurfaceOverride otherwise. No point to call this during animation.
Added perfetto traces comparison home->all apps, alongwith all other
generic overview scenarios which possibly could have caused jank is
added here:
https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing
Bug: 404647629
Test: Manual. Enter overview from Desktop tile / home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9dae7c5ece37e51664d82c680ea247f89bb5664b
We were checking whether recents is visible or not while opening all
apps and calling RecentsView#reset. Since Recents is not visible, we
were always calling reset which was making additional blur. Adding check
here of what current state is, will reduce these calls.
Added perfetto traces comparison here
https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing
Bug: 404647629
Test: Manual. Launcher home -> all apps.
Flag: EXEMPT bugfix
Change-Id: If0e31638adee50d36974abd7a4c809e3747f37a0
This reverts commit adb3bf5a8d.
Reason for revert: Likely culprit for b/406159877 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: I9bad89e9ffa082bc8a1505e699048a7739aaf24d
Screenshot test will be updated when build flag is moved to staging
Bug: 393610557
Flag: com.android.launcher3.gsf_res
Test: on device
Change-Id: Ide96093555b7f4592952a2c111cc14062c8d41e7
This fixes an issue with the desktop task view unexpectedly jumping
first to the right, and then back to the left. See the bug for more
information.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug=399822967
Change-Id: I3713b20effa2a7f25ca04ed83ed524772d23ca2f
Remove the wallpaper task and tasks below from
`TopTaskTracker.getCachedTopTask` thus the empty task can be
really empty.
Also update the usage of the cached top task to avoid crash
because it can be empty now.
Bug: 402218420
Flag: EXEMPT refactor
Test: m
Change-Id: I15835ec3bf84b9ea5b6b2aba731f9f5b8a17353f
The emissions of each TaskView on Overview open are usually:
1. task exists
2. icon loaded
3. then thumbnail loaded
If the 3 updates above come in quick succession, then ideally the first 2 will be debounced and the last one will be consumed immediately.
Debouncing only when thumbnails are not present gives the best results. This is because thumbnail loading is a decent predictor of there being no more emissions to come as they are typically the last emission for a TaskView.
Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: ABTD run of failing metric
Change-Id: Ib57d6dc7d9f58b7bb37ec1177b23d89360c24c0e
- If onPrepareGestureEndAnimation is called with null aniamtorSet, plays the dismiss animator directly with 0 duration
Fix: 405368787
Flag: EXEMPT bugfix
Test: manual, adb shell input keyevent KEYCODE_APP_SWITCH or Window + Tab with keybnoard from home
Change-Id: I16048f9454f79e2828c6a4a75b788b9838e886ab
Let `isGestureBlockedTask` return false directly if
`mGestureBlockingTaskId` is not valid. This can avoid
the caller go to create incorrect InputConsumer when
the chekcing `taskId` is also invalid.
Bug: 402218420
Flag: EXEMPT bug fix
Test: m
Change-Id: Ia0cde8ee2b97fc92028458d01487d958f2e87a80
Bug: 404582684
Flag: EXEMPT bugfix
Test: Manually verified that values are same as before even after changing refresh rate `adb shell settings put system peak_refresh_rate [30/60/90/120]`
Change-Id: I5d5468d8ab81a9a5e8d8cd67a9097423b750edb3
Flag: com.android.launcher3.enable_launcher_overview_in_window
Fixes: 405201109
Bug: 377678992
Test: used quick switch gesture from home with flag enabled. presubmit tests on temporary test cl
Change-Id: I8dbd3a41c350aba6c785aa0b2c8f20da7a468998
Added scrim in overview over blur.
Bug: 404479758
Test: Manual. Enter overview from home with and without tasks in handheld devices.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: If8cb37099f2e2b1fa8bed1611ed359b49f255d64
This way any subsequent state changes during the animation will
cancel it. Previously swiping up to All Apps immediately after
going home would cause the 2 depth animations to interleave,
ending with a depth of 0, for example. Now the workspace depth is
cancelled and the All Apps depth is correctly applied.
Demo: https://drive.google.com/file/d/1R1BwYAsxj31FDgAeIZqZdJbuSz7s9PZy/view?usp=sharing&resourcekey=0-4UyZfAMxecSHWAyqyeNZmg
Fix: 405836159
Test: Manual (swipe home and immediately to all apps)
Flag: EXEMPT bugfix
Change-Id: Iac32f2a03a5cbbb297c71ebd9cfedc8ee6e8cae7
This shows up if the launcher is in a sw600dp-or-greater configuration.
Test: AspectRatioSystemShortcutTests
Test: OverviewMenuImageTest
Test: Manual check on phone, tablet, and inner/outer fold screens.
Flag: com.android.window.flags.universal_resizable_by_default
Bug: 357141415
Change-Id: I1bcbf9299d28ce68cccd636d92ed7195d64736eb
Charlie Anderson
Uwais Ashraf
Brandon Dayauon
Pat Manning
vinayjoglekar
Shamali Patwa
Alex Chau
Treehugger Robot
Chaitanya Cheemala (xWF)
Daniel Andersson
minch
Vinit Nayak
Bill Yi
Suhua Lei
Sunny Goyal
Schneider Victor-Tulias
Massimo Carli
Andy Wickham
Robin Lee
Wei Sheng Shih