PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Improve reliability of cleanup done in onDestroy."

Browse Source 
This reverts commit 9cf28d1772.

Reason for revert: Fix in ag/32425180

Change-Id: I714665944384db6f68634de529272e618bccdad9
This commit is contained in:
Shamali Patwa
2025-03-24 08:46:36 -07:00
committed by Android (Google) Code Review
parent 9cf28d1772
commit cfcb27aa9d
1 changed files with 11 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
quickstep/src/com/android/launcher3/uioverrides/QuickstepLauncher.java
+11 -35
View File
@@ -86,7 +86,6 @@ import android.os.Trace;
import android.os.UserHandle;
import android.text.TextUtils;
import android.util.AttributeSet;
import android.util.Log;
import android.view.Display;
import android.view.HapticFeedbackConstants;
import android.view.KeyEvent;
@@ -227,7 +226,6 @@ import java.util.stream.Stream;
public class QuickstepLauncher extends Launcher implements RecentsViewContainer,
SystemShortcut.BubbleActivityStarter {
private static final String TAG = "QuickstepLauncher";
private static final boolean TRACE_LAYOUTS =
SystemProperties.getBoolean("persist.debug.trace_layouts", false);
private static final String TRACE_RELAYOUT_CLASS =
@@ -563,35 +561,20 @@ public class QuickstepLauncher extends Launcher implements RecentsViewContainer,
@Override
public void onDestroy() {
// wrap non-trivial clean up blocks in try-catch to avoid stopping clean up of rest of
// objects
if (mAppTransitionManager != null) {
try {
mAppTransitionManager.onActivityDestroyed();
} catch (Exception e) {
Log.e(TAG, "Failed to destroy mAppTransitionManager", e);
}
mAppTransitionManager.onActivityDestroyed();
}
mAppTransitionManager = null;
mIsPredictiveBackToHomeInProgress = false;
if (mUnfoldTransitionProgressProvider != null) {
try {
SystemUiProxy.INSTANCE.get(this).setUnfoldAnimationListener(null);
mUnfoldTransitionProgressProvider.destroy();
} catch (Exception e) {
Log.e(TAG, "Failed to destroy mUnfoldTransitionProgressProvider", e);
}
SystemUiProxy.INSTANCE.get(this).setUnfoldAnimationListener(null);
mUnfoldTransitionProgressProvider.destroy();
}
OverviewComponentObserver.INSTANCE.get(this)
.removeOverviewChangeListener(mOverviewChangeListener);
try {
mTISBindHelper.onDestroy();
} catch (Exception e) {
Log.e(TAG, "Failed to destroy mTISBindHelper", e);
}
mTISBindHelper.onDestroy();
if (mLauncherUnfoldAnimationController != null) {
mLauncherUnfoldAnimationController.onDestroy();
@@ -601,22 +584,15 @@ public class QuickstepLauncher extends Launcher implements RecentsViewContainer,
mSplitSelectStateController.onDestroy();
}
try {
RecentsView recentsView = getOverviewPanel();
if (recentsView != null) {
recentsView.destroy();
}
} catch (Exception e) {
Log.e(TAG, "Failed to destroy RecentsView", e);
RecentsView recentsView = getOverviewPanel();
if (recentsView != null) {
recentsView.destroy();
}
try {
super.onDestroy();
} finally { // trivial close operations in finally.
mHotseatPredictionController.destroy();
if (mViewCapture != null) mViewCapture.close();
removeBackAnimationCallback(mSplitSelectStateController.getSplitBackHandler());
}
super.onDestroy();
mHotseatPredictionController.destroy();
if (mViewCapture != null) mViewCapture.close();
removeBackAnimationCallback(mSplitSelectStateController.getSplitBackHandler());
}
@Override