Commit Graph

83004 Commits

Author SHA1 Message Date
Jordan Silva 41992efa95 Merge "Center Task Menu icons and text vertically" into main 2025-03-26 08:40:16 -07:00
Jordan Silva ec18b825e4 Merge "Adjust IconAppChipView chip width based on state" into main 2025-03-26 08:36:26 -07:00
Alex Chau fc5a07e40b Revert "Remove unnecessary call to RecentsView.reset when switching from any non-overview state."
This reverts commit 162a85e777.

Reason for revert: b/406430367

Change-Id: I1be60513d8f034d6aab9489a95f98a7a0f16d26d
2025-03-26 07:41:36 -07:00
Shamali Patwa a8455409f6 Merge changes from topic "dwb-refactor-data" into main
* changes:
  Add a useCase to get the remaining app time rounded down to minutes
  Add a repository to fetch the remaining time for DWB
2025-03-26 06:02:52 -07:00
Will Osborn 347aff1a5d Fix for applyLoadPlan being called after RecentsView is destroyed.
Bug: 404920951
Test: locally tested on Tangor
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I82bf6033df70c1122d88bba2ef226cc6b7b8623a
2025-03-26 12:48:29 +00:00
Jordan Silva 20dd848b29 Center Task Menu icons and text vertically
Bug: 403193877
Flag: EXEMPT bug fix
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: OverviewActionsMenuHoverImageTest
Change-Id: Idba732b64260e7e3e00d4742d2ea6ccd9228ab01
2025-03-26 05:23:31 -07:00
Treehugger Robot dd7d89d7e1 Merge "Account for Recents Scale when computing dismiss length to take task off screen." into main 2025-03-26 05:09:07 -07:00
Treehugger Robot 8292d26063 Merge "Snap to Large tile or first grid task when they are the next page." into main 2025-03-26 05:07:40 -07:00
Jordan Silva 3451ddddd1 Adjust IconAppChipView chip width based on state
This CL will fix the issue when the app chip is bigger than the TaskView and doesn't respect its maxWidth value.
Also fixes the bug when the first chip expands when taps over the second app chip.

Fix: 406225230
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Id1c806a320522e6d5bda3d4d8712a43637c57834
2025-03-26 04:38:32 -07:00
Jordan Silva f4b5725ef0 Merge "Add marquee for AppChip and simplify text view handling in IconAppChipView" into main 2025-03-26 04:28:26 -07:00
Ajinkya Chalke 28b50a21a5 Move querying focus display to TIS
- Move the logic to query for focused displayId from
  OverviewCommandHelper to TouchInteractionService.
- This way the OverviewCommandHelper code always uses command.displayId
  in its code.

Bug: 404757863
Test: manual run CUJ
Flag: com.android.launcher3.enable_alt_tab_kqs_on_connected_displays
Change-Id: Ia9b05e64b549895f029bc5204169cf84474af125
2025-03-26 09:43:56 +00:00
Li Lin 95dc69f7ce Merge "Growth Framework nudge resource changes." into main 2025-03-26 00:21:28 -07:00
Treehugger Robot b4a37aed36 Merge "Remove unnecessary call to RecentsView.reset when switching from any non-overview state." into main 2025-03-26 00:12:42 -07:00
Bill Yi cd8b136526 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Icbac1b72885a5e5a13bb1be037fbe0fe19b9a847
2025-03-26 06:25:55 +00:00
Bill Yi c1928b8f0a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1bc70b18b9e537de8db7a22aee29a7a7765328e0
2025-03-26 06:24:46 +00:00
Vinay Joglekar 6b59446c58 Merge "Add logs for debugging to overview blur" into main 2025-03-25 21:58:52 -07:00
Vinay Joglekar fe5b8108b5 Merge "Reduce calls to surface reparenting and set relative layer." into main 2025-03-25 21:58:28 -07:00
Winson Chung 07cd067daf Extend logic to clear visibility of occluded tasks in top task tracker
- With com.android.window.flags.enable_task_stack_observer_in_shell
  enabled, the correct task visibilty is reported to TTT, which in
  combination with the incomplete TaskStackListener signals results
  in tasks being reported as visible when they shouldn't be.  This is
  most apparent when the top task is excluded from recents, which
  results in us attempting to pull the next visible non-excluded task
  to show as the current running task (resulting in the live tile/
  thumbnail being shown on the wrong task).

  Instead, we're expanding the workaround behavior to also check for
  any fullscreen task that fills its parent (ie. is not transparent)
  and using that as a signal to reset the visiblity of tasks behind it.

Bug: 390564114
Flag: EXEMPT bugfix
Test: Manual, expand PIP above another task and ensure that the other
      task's visibility (as reporting in TTT) is invisible if the
      expanded PIP task occludes it
Change-Id: Ieaa5460c2671d91f30b75aaf5317ab5ddb42315b
2025-03-26 04:51:36 +00:00
Li Lin 4a947f8209 Growth Framework nudge resource changes.
These resources changes will be used in a follow up CL that implement
the nudge view.

Note that most of the values and layout are temporarily placeholder and  subject
to change in follow up CL as the mock is being finalized.

Bug: 398033012
Test: Manual
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I1d88da404637200b44bd2a3a5719f52d68011fbf
2025-03-25 19:58:52 -07:00
Wen-Chien Wang 0f0df91430 pin-shortcut: Make single recent task pinnable from taskbar
With this change, we can now using long-press menu to pin a single
task to the taskbar.

Note that some of the code in this cl is filtered by the flag.

Bug: 375648361
Test: Adding in the next cl
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: Id0f2a9dce03a6c94da2cf8bd0deffd4c48656a7a
2025-03-26 00:49:27 +00:00
Treehugger Robot eddb50613d Merge "Update icon override map when theme changes" into main 2025-03-25 17:12:42 -07:00
Shamali P 258d1297fe Add a useCase to get the remaining app time rounded down to minutes
The flag will be applied at the code using this use case.

Bug: 405974619
Fix: 405974619
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: GetRemainingAppTimerDurationUseCaseTest
Change-Id: I939b3447b93e7e84eb69032aa0f67c1629f916c1
2025-03-25 23:50:20 +00:00
Shamali P 24ba38b393 Add a repository to fetch the remaining time for DWB
The usage of this chain will be flagged

Bug: 405359454
Fix: 405359454
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: AppTimersRepositoryTest
Change-Id: Ife0db79175dd30982a0cb179369a3cea470ef7ba
2025-03-25 23:41:46 +00:00
Daniel Andersson aeca730761 desktop-exploded-view: Fix glitch with thumbnailView.outlineBounds
This is a follow up to ag/32333172. With that change, task thumbnails
are immediately placed in the exploded position and then transformed
into the intermediate positions/sizes that is controlled by the explode
progress.

This CL fixes a glitch where thumbnailView.outlineBounds was not
computed properly. The bounds are now computed per frame (since the task
may animate in from a position that is partially off-screen). The
intersection with the screen bounds rectangle is now done with the
per-frame position of the task window and then crucially scaled to
account for the transformation that is applied to the thumbnail itself.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
BUG=399822967

Change-Id: I66d6d9f662f0e70e86ea1befcec4c43d2434fb35
2025-03-25 16:28:09 -07:00
Treehugger Robot 4a22d06f6a Merge "Fix split chip wrong translation in Fake Landscape" into main 2025-03-25 15:56:55 -07:00
Sebastian Franco fd53f5ad60 Make sure QSB size is correct when inline in phones
Bug: 402519661
Test: HomeScreenImageTest
Test: DumptTests
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ibed11b505bc9e8bdcce5719d414605f91a306e22
2025-03-25 15:35:12 -07:00
Treehugger Robot 2032de9d20 Merge "Fix miscellaneous TAPL testing issue" into main 2025-03-25 15:24:28 -07:00
Jon Miranda 9bf65787e9 Prevent NPE when syncing app launch with taskbar stash.
This can happen because when callback is ran after onDestroy.
We call the runnable as part of the cleanup process to avoid
a leak.

Bug: 319162553
Fixes: 405316024
Test: Launch an app, note the two animations are synced
      Verified by locally introducing a startDelay (since otherwise it is hard to tell)
Flag: com.android.launcher3.sync_app_launch_with_taskbar_stash
Change-Id: I961b9a185b2751a8a908d1a7b2cbfdb8bfe0b8f9
2025-03-25 15:18:03 -07:00
Sihua Ma 44e9645719 Update icon override map when theme changes
Fix: 391970288
Bug: 406240868
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I458e5892b819a4599476017eac71eddf0a92a16f
2025-03-25 21:43:46 +00:00
Treehugger Robot be8869060d Merge "Use up-to-date hover tooltip text for recents." into main 2025-03-25 14:28:16 -07:00
Treehugger Robot 3aef4250b3 Merge "Deflaking ShortcutsChangedTaskTest by not using an active model" into main 2025-03-25 14:20:23 -07:00
Jagrut Desai 64d448a8db Fix Taskbar Flicker with Recents or Running Apps Present
Test: Manual, Presubmit
Bug: 404772481
Flag: EXEMPT bugfix
Change-Id: If3b87474e6e85fabf24a42ac2a3e4ac6a19a4358
2025-03-25 14:16:12 -07:00
Toni Barzic b831f59d6c Layout freeform display taskbar using actual icon sizes
The taskbar shown on freeform display taskbar when
enable_desktop_taskbar_on_freeform_displays feature is enabled is
expected to remain in persistent taskbar state (and never
transition to transient taskbar). Given that transitions to transient
taskbar is not expected, use actual peristent taskbar sizing to layout
the taskbar in this case (similar to three-button navigation taskbar).

Bug: 390665752
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: manual on desktop device - keep opening apps in desktop mode, and
      verify that taskbar does not enter overflow based on transient
      taskbar icon dimensions (i.e. that taskbar keeps filling up until
      it hits intended horizontal margins)
Change-Id: If6cdadccf0fe4da1462b437a13def78f6050e3bb
2025-03-25 21:03:27 +00:00
Priyanka Advani (xWF) 6e32188c4f Merge "Revert "Notify StateManager of workspace reveal animations."" into main 2025-03-25 13:35:54 -07:00
Jordan Silva 5c5028bf0b Fix split chip wrong translation in Fake Landscape
This change will prevent the split menu and app chip translation when in Fake Landscape and Fake Seascape.

Fix: 406239562
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: Manual. Instructions in the bug.
Change-Id: Id4aade8ce15cc51e81d5b1b7a82597924cdce7ca
2025-03-25 13:34:41 -07:00
Jordan Silva 7e676c6a40 Add marquee for AppChip and simplify text view handling in IconAppChipView
- Consolidates the two TextViews (collapsed and expanded) in `IconAppChipView` into a single `appTitle` TextView.
- Updates the app name's width based on the current chip status (expanded/collapsed)
- Removes the `icon_text_collapsed` and `icon_text_expanded` from layout and uses only `icon_title`.
- Adds marquee support to handle text ellipsis in the collapsed state.
- Refactors text width calculation for collapsed state to take into account maximum available width.
- Updates text animations to use the new `appTitle`.
- Updates the maximum width to not be set to less than the min width.

Bug: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ic82790d0a79b65adb7ba14dad7848748cd568f62
2025-03-25 20:31:28 +00:00
Toni Barzic 1f4b265dde Prefer launching desktop tasks on freeform display
Update usages of TaskbarActivityContext.inDesktopMode to account for a
possibility of a desktop flavour taskbar (i.e. pinned taskbar that
shows desktop tasks) being shown outside desktop mode, which may be the
case on freeform displays (e.g. when
enable_desktop_taskbar_on_freeform_displays feature is enabled, or on
home). Tasks launched from this taskbar should preferably be launched
into desktop mode.

Bug: 390665752
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: manual on desktop device. verify correct taskbar is shown
      on home screen, in overview, in desktop mode, with fullscreen
      app shown. Verify opening/launching apps from taskbar works
      as expected.

Change-Id: I8f198216d84fd165c2dcbf437c82e418e5c7405e
2025-03-25 20:21:25 +00:00
Charlie Anderson 4f1452d977 Merge "Fix shaped icons not centering correctly when scaled" into main 2025-03-25 13:06:39 -07:00
Schneider Victor-Tulias 58b82620df Fix miscellaneous TAPL testing issue
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
2025-03-25 12:58:29 -07:00
Charlie Anderson e6c7c82562 Merge "Fix folder closing to different shapes" into main 2025-03-25 12:44:44 -07:00
Brian Isganitis 409ea18bf8 Merge "Perform system actions on focused display." into main 2025-03-25 12:28:30 -07:00
Schneider Victor-Tulias f1353604a9 Update fonts in gesture nav tutorial menu page
Flag: com.android.wm.shell.enable_gsf
Fixes: 405310693
Test: screenshots on bug
Change-Id: If806d4d87acf09b280bfe2efbea6256e0f936058
2025-03-25 15:21:00 -04:00
Sunny Goyal e8d901fbdb Deflaking ShortcutsChangedTaskTest by not using an active model
When using an active model, the data can change on the model thread while
the test is running on a different thread.
Instead using the model data directly without an active model running

Bug: 399155567
Flag: EXEMPT testfix
Test: Presubmit
Change-Id: I332cd7ec0f5a2fb4760ce080f016c725b2233c45
2025-03-25 12:12:20 -07:00
Charlie Anderson 347fc5e227 Merge "Make apply button for shapes ~28522% faster in picker" into main 2025-03-25 11:24:32 -07:00
Treehugger Robot fb9548ac90 Merge "Close the Recents window onNewIntent" into main 2025-03-25 11:14:23 -07:00
Treehugger Robot 982c2abef5 Merge "Also cancel TaskView collection Jobs when Overview is not on screen." into main 2025-03-25 10:37:01 -07:00
vinayjoglekar af83003826 Add logs for debugging to overview blur
Bug: 406197011
Test: Manual. Enter overview from Desktop tile / home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Iec9def155d91025e94a6ade2dc332b4c3f3ee943
2025-03-25 10:21:22 -07:00
Daniel Andersson 1735205986 Merge "desktop-exploded-view: Avoid triggering layout when starting animation" into main 2025-03-25 09:21:05 -07:00
Schneider Victor-Tulias 848b743c20 Close the Recents window onNewIntent
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Ied8a1ce6bb5b3a0c371ce857fe6df9d94fd04b40
2025-03-25 08:41:39 -07:00
Treehugger Robot d4c2dedf81 Merge "Add null backup for title." into main 2025-03-25 08:36:53 -07:00