Commit Graph

83004 Commits

Author SHA1 Message Date
Tony Wickham 7829a1ced2 Only commitRunningAppsToUI if shownTasks changed
- Add GroupTask and DesktopTask equals() (with tests)
- Add tests to verify multiple onRecentTasksChanged
  doesn't commitRunningAppsToUI if there's no change
- Add tests to verify commitRunningAppsToUI is still
  called if minimized or running apps set changes

Bug: 348802109
Bug: 348787176
Test: TaskbarRecentAppsControllerTest
Test: GroupTaskTest
Test: log TaskbarView#onMeasure() locally, ensure it is called
much less despite noisy onRecentTasksChanged callbacks
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps

Change-Id: I3efff7f4492272f88aa2bdbd7cc45bd2bf8156f6
2024-06-28 21:54:37 +00:00
Saumya Prakash 7250663fab Merge "Prevent Taskbar edu dismissal from touching outside of the window." into main 2024-06-28 21:24:46 +00:00
Saumya Prakash 443d0600d5 Prevent Taskbar edu dismissal from touching outside of the window.
In an effort to encourage users to look at Taskbar edu more thoroughly,
this change makes it so users have to press the 'Done' button explicitly
to close the taskbar edu window. This change also adds the ability for
it to be dismissed by the back gesture. It only applies to the features
edu, and not other taskbar educations.

Fix: 349612575
Test: Manually run all versions of taskbar edu and ensure that the edu only goes away with back gesture, swipe up or clicking on the DONE button
Flag: EXEMPT bugfix
Change-Id: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
Merged-In: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
2024-06-28 21:23:09 +00:00
Kevin Lim 188202f927 [E2E] Re-enable stable widget tests.
Bug: b/310242894
Flag: EXEMPT E2E test re-enabling
Test: http://android-build/test_hub/search/?filter=lowFailureRate&invfilter=unhealthyInvocations&invfilter=staleInvocations&query=branch%3Agit_main+target%3A%28cf_x86_64_phone-trunk_food-userdebug%7Ccf_x86_64_phone-trunk_staging-userdebug%29+testsub%3A%28testPendingWidget_withConfigScreen%7CtestPendingWidget_notRestored_brokenInstall%29
Change-Id: I25c48e07d6cebcc3b5bb61f1583a3859c4c0eb80
2024-06-28 21:11:59 +00:00
Kevin Lim 174e95921a Merge "[UniversalSearchInput] Create flag for multi-line search bar" into main 2024-06-28 21:03:47 +00:00
Saumya Prakash 17339843e7 Prevent Taskbar edu dismissal from touching outside of the window.
In an effort to encourage users to look at Taskbar edu more thoroughly,
this change makes it so users have to press the 'Done' button explicitly
to close the taskbar edu window. This change also adds the ability for
it to be dismissed by the back gesture. It only applies to the features
edu, and not other taskbar educations.

Fix: 349612575
Test: Manually run all versions of taskbar edu and ensure that the edu only goes away with back gesture, swipe up or clicking on the DONE button
Flag: EXEMPT bugfix
Change-Id: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
2024-06-28 19:43:24 +00:00
Brandon Dayauon d93b76b7ce Merge "Adding logs to Privateprofile animation." into main 2024-06-28 16:29:00 +00:00
Alex Chau 50293c5227 Merge "Extract TaskContainer to its own class" into main 2024-06-28 12:16:17 +00:00
Brandon Dayauon 46c542e5b7 Adding logs to Privateprofile animation.
Provide logs at the end state to see if alpha/visibility is showing or not to indicate any reasons the issue may happen
because of the animation.

bug: 341053089
Test: N/A
Flag: com.android.launcher3.enable_private_space
Change-Id: Ib94bc955e2d061d1799040ac6180d150b24118fe
2024-06-27 20:24:27 -07:00
Hongwei Wang 9fec21871c Merge "Disable gesture nav while PiP anim is running" into main 2024-06-28 02:03:10 +00:00
Federico Baron 447a4a7efb Merge "Fix folder clipping bug" into main 2024-06-27 23:42:38 +00:00
Android Build Coastguard Worker fd09776e58 Snap for 12025384 from 8c307e249c to 24Q4-release
Change-Id: I00ab3a0f99e1888957e3ecabad84f778cc9ed765
2024-06-27 23:22:12 +00:00
Brian Isganitis cc44113e57 Add context for sandboxing Taskbar window contexts.
Otherwise, the contexts leave the sandbox, which blocks testing.

Test: TaskbarWindowSandboxContextTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I4c7a60858821c8959be2c82dc61a83b7e2f4d1ed
2024-06-27 18:32:26 -04:00
Brian Isganitis c0da543553 Add tests for TaskbarUnitTestRule.
Test: TaskbarUnitTestRuleTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I1c17b7f04920676cdfbe481b9435ff5d842181d1
2024-06-27 18:32:26 -04:00
Brian Isganitis c2bb120a87 Have recreateTaskbar perform recreate on UiThread.
Test: Taskbar{AllApps,Overlay}ControllerTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I663e5ad7bb37e73381e2ef9d787c80177cfdf7a7
2024-06-27 18:32:26 -04:00
Brian Isganitis e7e98985f7 Move test rules to subpackage.
Test: Compiles
Flag: EXEMPT refactor
Bug: 230027385
Change-Id: I9199fd92450180fa10673c3072dd6e8312fd24d6
2024-06-27 18:32:26 -04:00
Vadim Tryshev 09011fcd07 Re-promote fixed test openPrivateSpaceSettings_triggersCorrectIntent to presubmit
Bug: 339109319
Test: presubmit
Flag: TEST_ONLY
Change-Id: I4873ac3eb258dba30136534e3df6a1a378a3c29a
2024-06-27 15:30:06 -07:00
fbaron c5c0974f0d Fix folder clipping bug
Fix: 341433475
Test: N/A
Flag: NONE bugfix
Change-Id: Id99eca043c4e70127cb93b0abe88aef007afc70d
2024-06-27 13:51:41 -07:00
Federico Baron 33f2e36ee4 Merge "Promote test testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty" into main 2024-06-27 20:30:45 +00:00
Hongwei Wang 3b1ebed232 Disable gesture nav while PiP anim is running
To prevent the Recents transition that may conflict with PiP

Flag: EXEMPT bug fix
Bug: 340724371
Test: Swipe to show TaskBar while expanding PiP to FS mode
Change-Id: I87bb660c37f47dd67f7593a52eda99b167a233a9
2024-06-27 12:40:19 -07:00
Vinit Nayak 8c307e249c Promote testSplitAppFromHomeWithItself to presubmit
Flag: EXEMPT test promotion
Bug: 295225524
Change-Id: Ia8615f2380fc5aa27316ecc8a4ff567ac3facb42
2024-06-27 18:37:27 +00:00
Liran Binyamin fde4fdc472 Merge "Add a new bubble at limit while expanded" into main 2024-06-27 17:26:34 +00:00
Liran Binyamin 78cf7c1745 Animate the dot with the bubble bar
The previous behavior relied on a BEHIND_STACK suppression flag to
determine whether the dot should be drawn or not. setBehindStack was
called as part of updating bubble layout properties in BubbleBarView,
which happens at each animation frame of the bubble bar collapsing
and expanding.

Instead of using the suppression flag, we now directly set the dot
scale based on the progress of the collapse and expand animation.

This change also sets the badge visibility directly from BubbleBarView
and cleans up the BEHIND_STACK suppression flag.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349822532
Test: manual
       - have some bubbles and expand bar
       - trigger a new bubble X
       - observe bubble added with notification dot
       - tap on the selected bubble to collapse
       - observe the notification dot animates for bubble X
       - expand the bar
       - observe notification dot animates for bubble X
       - tap on bubble X
       - observe notification dot animates out
       - tap on a different bubble
       - observe notification dot does not reappear
Change-Id: I6efe0dfa8b4f73064cee8b45556ff0928f6f7c08
2024-06-27 12:55:04 -04:00
Vinit Nayak d900d39412 Merge "Add set correct window corner radius on split invocation animation leashes" into main 2024-06-27 16:42:54 +00:00
fbaron f408badf13 Promote test testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Flag: TEST_ONLY
Test: TaplTwoPanelWorkspaceTest#testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Bug: 329935119
Change-Id: I4fe2967924dd9ef083ed711802eadd277d1164e5
2024-06-27 09:09:06 -07:00
Tracy Zhou adcb3d67f0 Merge "Pipe nav bar transitions logic into task bar" into main 2024-06-27 15:43:35 +00:00
Liran Binyamin 2e1dd4644b Add a new bubble at limit while expanded
Handles adding a new bubble and removing an old bubble when the bar
is expanded and at the limit.

Demo when bar is on right: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dxhFKrctdR5I2F6Pvho6u8
Demo when bar is on left: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/er4ZGQfg8OKHZ2aTi9OJ9N

Flag: com.android.wm.shell.enable_bubble_bar
Test: demos
Test: atest BubbleViewAnimatorTest
Fixes: 345795791
Change-Id: I4e75d61c8afdb81340823a1d77e55b15e3fd6bc0
2024-06-27 10:36:16 -04:00
Alex Chau 8474edcf13 Extract TaskContainer to its own class
Bug: 335606129
Test: Manual
Flag: EXEMPT refactor
Change-Id: I0ac924652079c69737cd37a9233080b432ecc16e
2024-06-27 14:26:14 +01:00
Android Build Coastguard Worker 34cee0d741 Merge cherrypicks of ['googleplex-android-review.googlesource.com/27810982', 'googleplex-android-review.googlesource.com/28017557'] into 24Q3-release.
Change-Id: I2705f435af3724834915649c216be5b9b5a9d125
2024-06-27 04:06:32 +00:00
Vinit Nayak 093978a6ba Add set correct window corner radius on split invocation animation leashes
Test: Enter split anim from overview on phone is smoother than
Michael Jackson's moonwalk
Bug: 349387413
Flag: EXEMPT bugfix

Change-Id: I01fd1eee6fe111623a22dd6aaf130837ebbdeeb1
2024-06-27 03:58:42 +00:00
Brandon Dayauon 5c20085a8c Fix NPE when locking private space in taskbar allapps.
We can just remove the check since isSearchSupported has been launched.

bug: 345648701
Test manually video -
before: https://drive.google.com/file/d/1EwwRXrASusmqVixGWuKGnOQQyiDLE6Yy/view?usp=sharing
after: https://drive.google.com/file/d/1OCvtxzbhRJrBMMM2JH_cOurQ-_BaALSA/view?usp=sharing
Flag: com.android.launcher3.enable_private_space
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e770f10d2a6a047c1ad7b1061f57c388dec4f913)
Merged-In: I0ae19d342556aac4ee0b6e26b4cef8752c0beb38
Change-Id: I0ae19d342556aac4ee0b6e26b4cef8752c0beb38
2024-06-27 03:45:27 +00:00
Schneider Victor-tulias cb2a1474a7 Fix icon flash on app launch
Flag: com.android.launcher3.enable_additional_home_animations
Fixes: 343051344
Test: temp logs, launched apps from home, quickly swiped home while quick switching
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9fb1f8043573d5bc3376f0786354fc8f7a9cf2cd)
Merged-In: I91071d53f753eb7bc99305c46241de203bcfdc98
Change-Id: I91071d53f753eb7bc99305c46241de203bcfdc98
2024-06-27 03:45:11 +00:00
Vinit Nayak 09f06c29da Merge "Promote testSplitTaskTapBothIconMenus to presubmit" into main 2024-06-27 03:35:47 +00:00
Vinit Nayak 233ab23db3 Promote testSplitTaskTapBothIconMenus to presubmit
Bug: 288939273
Flag: EXEMPT test
Change-Id: I8aec88fbba33dd94afd348ebc4ebcb9b75ab3c04
2024-06-27 03:35:34 +00:00
Willie Koomson 3cf229f7e3 Merge "Clean up code related to the old widget preview toast" into main 2024-06-27 00:47:30 +00:00
Android Build Coastguard Worker 60fdbda6ae Snap for 12019843 from 1ec2aacc05 to 24Q4-release
Change-Id: I8a8760402e7605e29b416f7d6476a6d32bbf4003
2024-06-26 23:22:28 +00:00
Treehugger Robot 9f8e1471a6 Merge "Cleanup obsolete generated preview tests" into main 2024-06-26 21:19:21 +00:00
Bill Yi ffaadb32c8 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-06-26 21:05:28 +00:00
Bill Yi f872c59428 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-06-26 21:05:28 +00:00
Bill Yi 853e5adac3 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-06-26 21:05:28 +00:00
Willie Koomson ab3f44bc19 Clean up code related to the old widget preview toast
This code is no longer used now that widget cells show an add button.

Bug: 335367158
Test: N/A
Flag: com.android.launcher3.enable_widget_tap_to_add
Change-Id: I8040c75a89394f34885c24308f4e889b7263cc54
2024-06-26 20:06:34 +00:00
Treehugger Robot a6ec45c928 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: dcec00cc4d -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28044767

Change-Id: I7231b9050241d656c52eb70c66814f4d29f732e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-26 19:49:27 +00:00
Bill Yi 5f2492b8c3 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 66bc0c0275 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28044767

Change-Id: Icc8461528af7cbe790ceeb8d2a222fac151dc534
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-26 19:49:24 +00:00
Treehugger Robot 0bf9a48115 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: 2920b04df3 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28044702

Change-Id: Ibdfa067a6d6a37b8eb956e8c0ad3832391cbb156
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-26 19:49:21 +00:00
Bill Yi 70baef0c86 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e89fa0c181 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28044702

Change-Id: If908ec8ed3d105109528c2beab8aa9b7ebe4da19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-26 19:49:18 +00:00
Bill Yi 2af7bc3aa4 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: fb9cb01e12 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28044700

Change-Id: Id22c2a3cf5ba6fc6b9e48d32bc19cc6c0dfec6a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-26 19:49:10 +00:00
Treehugger Robot dcec00cc4d Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-06-26 19:22:32 +00:00
Treehugger Robot 2920b04df3 Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-06-26 19:22:32 +00:00
Willie Koomson caf7065ef4 Cleanup obsolete generated preview tests
Remove tests that no longer run because the flag is always enabled.

Bug: 343764554
Bug: 336821272
Test: N/A
Flag: android.appwidget.flags.generated_previews
Change-Id: I106579771c2301cdac2ff1a17008c9faa1a1b0e3
2024-06-26 19:12:43 +00:00
Treehugger Robot 1ec2aacc05 [automerger skipped] Merge "Add strict_mode: false" into main am: a627a31a36 -s ours am: 74fb0eec2e -s ours
am skip reason: Merged-In I4b4f2ef9a21926eef63fcada81355b928bbe2870 with SHA-1 a75ea0b8cb is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3138597

Change-Id: I7e7b972404dc8edaa70fe09925fe424cfd2172c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-26 18:29:36 +00:00