Commit Graph

83004 Commits

Author SHA1 Message Date
Sebastian Franco 00ed8ccde7 Update back gesture zone any time the screen size changes.
Fix: 336697780
Test: Manual testing, open widget picker on folded front screen and then unfold, the widget picker should be showing and the backgesture should work.
Flag: EXEMPT bugfix
Change-Id: Ie4a7bffbd9b24ba26826f825a7c66216f565952f
2024-07-03 13:54:39 -07:00
fbaron 7672f320e8 Demote TaplThemeIconsTest#testShortcutIconWithTheme
Bug: 350557998
Test: TaplThemeIconsTest#testShortcutIconWithTheme
Flag: TEST_ONLY
Change-Id: I236fdd0bab678a385553d40f8a0dabbe78f92b5b
2024-07-03 13:51:53 -07:00
Vinit Nayak afdd0d3b31 Add divider bg placeholder to app pair icon launch
* Extract out both the top level split root leash
as well as the left and right split root leashes
* Set windowCorner radius on the left/right roots

Test: No more flicker near divider when launching app
pair (see comment for video in CL)
Flag: EXEMPT bugfix
Bug: 349387413

Change-Id: I6fce290d1e7766e55c2f11cc8c365f0c29087c0f
2024-07-03 11:27:41 -07:00
Kevin Lim aed2aa04ba [AllAppsStore] Dump class name in addition to package name for debugging
Bug: 333889822
Flag: EXEMPT Logging fix
Test: EXEMPT Logging fix
Change-Id: I9e1515c04bdc8381f96341e7211968fcc53f97cc
2024-07-03 18:03:30 +00:00
Alex Chau cd894eeae2 Merge "Make sure thumbnailViewDeprecated is only accessed when refactor flag is off" into main 2024-07-03 15:54:09 +00:00
Shamali P 96ebf67b9f Update the title and description provided by intent params.
Bug: 347288851
Flag: EXEMPT flagged in sys ui
Test: Manual (automated covered in b/339716822)
Change-Id: I71f21bc48fd03dbbe2b3804b7fcade5940606917
2024-07-03 15:49:32 +00:00
Olivier St-Onge 25eaff395e Merge "Stash taskbar when a SysUI dialog appears." into main 2024-07-03 15:20:17 +00:00
Treehugger Robot ff4f1624a9 Merge "Support TaskOverlay with new TaskThumbnailView" into main 2024-07-03 15:01:51 +00:00
Liran Binyamin 50586a37e9 Merge "Don't animate the bubble that was dismissed by drag" into main 2024-07-03 14:43:12 +00:00
Alex Chau d264071151 Make sure thumbnailViewDeprecated is only accessed when refactor flag is off
Bug: 338360089
Test: Manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I8f3bdf0308bf2dec30528ebd8ece404716578838
2024-07-03 14:52:40 +01:00
Shamali Patwa 10923a2985 Merge "Fix issue that ACTION_CLICK a11y action was removed from widget cell" into main 2024-07-03 13:45:05 +00:00
Alex Chau ac65a9979b Remove deprecated initOverlay interface used by TaskOverlayFactoryGo
Bug: 350931107
Test: presubmit
Flag: EXEMPT refactor
Change-Id: I3d03254d7c33118536e66268c1dbfebdf1130647
2024-07-03 14:17:25 +01:00
Alex Chau 58e8109d6e Support TaskOverlay with new TaskThumbnailView
- Also migrated getScaledInsets method into TaksOverlay

Bug: 335606129
Test: TaskOverlayViewModelTest
Test: TaskOverlayHelper is not tested because it should be a view-based screenshot test for TaskOverlay, which is currently impossible until we refactor TaskOverlay to MVVM
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I07a8657ff0fe925d8021875310e3ed12a712ba7a
2024-07-03 14:15:09 +01:00
Alex Chau 90808f8138 Merge "Move Overview-specific flags to a separate aconfig file" into main 2024-07-03 12:43:53 +00:00
Pat Manning fc1d2daa63 Prevent taskbar icon tooltip from showing on hotseat transition.
Fix: 350512938
Test: TaskbarHoverToolTipControllerTest
Flag: EXEMPT bugfix
Change-Id: Ifc1647834358366b2d98555138edd4ad6286c16e
2024-07-03 13:15:36 +01:00
Treehugger Robot 58f5d08d7a Merge "Show tooltip for AppPairs in taskbar on hover." into main 2024-07-03 12:09:40 +00:00
Jordan Silva 4db30dbc28 Move Overview-specific flags to a separate aconfig file
This is to keep the main launcher aconfig file more organized and easier to read and aligned with gantry namespace.

Bug: 349534860
Change-Id: Ib21fbac38ed0564fa481fce3a2da9a9b8c1a7139
Flag: EXEMPT - moving flags to another file
Test: EXEMPT - moving flags to another file
2024-07-03 10:49:51 +00:00
Pat Manning 19d5bc7a48 Scale AppPair background on hover.
Fix: 342133586
Test: manual.
Flag: EXEMPT bugfix
Change-Id: I2846b5543076688a90e8b9067f848c59e4081ea2
2024-07-03 11:31:11 +01:00
Treehugger Robot 4179538f33 Merge "WidgetPicker - allow user ids to be passed as filter arguments" into main 2024-07-03 08:51:36 +00:00
Brian Isganitis bfa3b7c80e Override DisplayController on main thread.
Bug: 230027385
Flag: TEST_ONLY
Test: TaskbarModeRuleTest
Change-Id: I6e7c349d50c8372ed0d4e1e8d5bfe7f108b2c2e2
2024-07-02 21:46:07 -04:00
Brian Isganitis 160ed1d31a Add annotations for manipulating secure settings.
By default, tests will run with user setup complete and kids mode
disabled.

Test: TaskbarUnitTestRuleTest
Flag: TEST_ONLY
Bug: 230027385
Change-Id: If6c74b3b2c07aa0eac5b6bda933b565351d65188
2024-07-02 21:46:05 -04:00
Brian Isganitis 8e5de6577b Don't use UiThreadTest for Taskbar Unit tests.
This annotation also runs the rule on the main thread, which can lead to
deadlocks with other threads (e.g. loading the model synchronously).

Change-Id: Ib276e9dc322f6f65bd32658e774d6076efb94f2e
Flag: TEST_ONLY
Test: Taskbar Unit Tests
Bug: 230027385
2024-07-02 21:45:23 -04:00
Brian Isganitis 8f1a1c4b6a Suspend Launcher taskbar while removed for tests.
This approach is less destructive than completely destroying Taskbar
while still ensuring it will not try to recreate itself.

Test: Taskbar Unit Tests
Bug: 230027385
Flag: TEST_ONLY
Change-Id: Ida0f7cc0b9c5b1d53bbadc2bb9fd81689c7f3940
2024-07-02 21:42:23 -04:00
Federico Baron 025c8a0cc0 Merge "Add test for Folder undoing behavior" into main 2024-07-02 23:57:21 +00:00
Android Build Coastguard Worker 23ce5353d2 Snap for 12042346 from 81a637089e to 24Q4-release
Change-Id: I40d740ebb48aedcf4385be405eaaae7d117d9a98
2024-07-02 23:23:43 +00:00
Brian Isganitis 3ad18b451a Merge "Revert "Completely destroy Launcher's Taskbar."" into main 2024-07-02 23:20:58 +00:00
Zak Cohen a0a810daac WidgetPicker - allow user ids to be passed as filter arguments
Bug: 330377706
Test: adb shell am start -n com.google.android.apps.nexuslauncher/com.android.launcher3.WidgetPickerActivity --eial filtered_user_ids 1
0  check that WP doesn't show up
Flag: com.android.systemui.communal_hub

Change-Id: I375545190839101681a037a4481bf4cf92128d33
2024-07-02 15:07:01 -07:00
fbaron df62b6ffd7 Add test for Folder undoing behavior
Fix: 341799410
Test: FolderTest#undoFolder
Flag: TEST_ONLY
Change-Id: I8bfb3fc9348290274b33f4b5b6531126c658037c
2024-07-02 15:02:09 -07:00
Brian Isganitis e1a2b67f2b Revert "Completely destroy Launcher's Taskbar."
Revert submission 28102205

Reason for revert: Potential test breakage.

Reverted changes: ag/28102205

Change-Id: If7fa1ff192a240e753e5c245d591d46e594e5a6f
Flag: TEST_ONLY
Bug: 230027385
Test: Presubmit
2024-07-02 17:00:11 -04:00
Shamali P 3f571468db Fix issue that ACTION_CLICK a11y action was removed from widget cell
In the past, tap didn't do anything, but now that we reveal add button
it should be kept.

Bug: 335029809
Flag: EXEMPT BUGFIX
Test: With switch access (see video)
Change-Id: I2ca9086f0dd4b0c9ac8167ab32aa278d4e2d1211
2024-07-02 20:33:43 +00:00
Hongwei Wang 81a637089e Merge "Apply cutout offset when applicable" into main 2024-07-02 18:20:46 +00:00
Vinit Nayak e04ca157e2 Merge "Make quickswitch splash reveal animation split aware" into main 2024-07-02 17:57:38 +00:00
Pat Manning 0e89070e1a Show tooltip for AppPairs in taskbar on hover.
Fix: 350744397
Test: TaskbarHoverToolTipControllerTest
Flag: EXEMPT bugfix
Change-Id: Ic2273f17d01d1068ceaddca8a5c115b551b35856
2024-07-02 18:22:44 +01:00
Federico Baron f4aa900009 Merge "Fix attempt for TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible" into main 2024-07-02 15:31:50 +00:00
Liran Binyamin 13895f1be2 Don't animate the bubble that was dismissed by drag
This change stores the bubble that was dismissed by drag temporarily
in BubbleBarView so that when we remove the bubble, we can avoid
updating it as part of the animation.

This is step 1 in this change. Next I'll look into removing the
bubble immediately after dismissing it from the menu, and lastly
update sysui to not send the removal event back to launcher.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 349826879
Test: manual
       - have bubbles in the bubble bar and expand it
       - drag a bubble to dismiss it
       - observe the bubble does not reappear in the bar during
         the animation
Change-Id: I6628ce779db4aac8d82edd4ecf2a25dedf8feef9
2024-07-02 10:48:22 -04:00
Saumya Prakash 66364f9657 [automerger skipped] Prevent Taskbar edu dismissal from touching outside of the window. am: 443d0600d5 -s ours
am skip reason: Merged-In I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3 with SHA-1 17339843e7 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28105075

Change-Id: If0e82b8b41c3b0503664bc6513aa4daf08569b4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-02 09:37:03 +00:00
Treehugger Robot 6bf444c3c9 Merge "Only commitRunningAppsToUI if shownTasks changed" into main 2024-07-02 09:07:41 +00:00
Tracy Zhou 30de75309d Merge "Fix task bar transitions applied to unfolded task bar" into main 2024-07-01 23:33:29 +00:00
Android Build Coastguard Worker ae4a496e67 Snap for 12037182 from 035a25c9a7 to 24Q4-release
Change-Id: I44056cdb73542f82d5cb3f5f34f65bac0b98f098
2024-07-01 23:27:55 +00:00
Hongwei Wang 27df26a798 Apply cutout offset when applicable
Removed the check on safeInsets#top and apply the offset.
Updated also the comment.

Flag: EXEMPT bugfix
Bug: 331128612
Test: Hold unfolded foldable in different orientation, enter PiP
Test: Hold folded foldable in different orientation, enter PiP
Change-Id: I56442ab2c4bfb1bf7ac68561aee8c0cc1fb183a8
2024-07-01 16:09:23 -07:00
Saumya Prakash 98d8094688 Merge "Add developer option to reset taskbar search edu" into main 2024-07-01 22:33:24 +00:00
Kevin Lim 9baf064a9a Merge "[E2E] Re-enable stable widget tests." into main 2024-07-01 20:30:12 +00:00
Vinit Nayak 1381196565 Make quickswitch splash reveal animation split aware
Bug: 309059057
Test: Quickswitched with split and fullscreen apps in
portrait and landscape
Flag: EXEMPT bugfix

Change-Id: If175d2d3008b71372610cf380d44bad7a07aa255
2024-07-01 13:01:42 -07:00
Tracy Zhou c97138e93d Fix task bar transitions applied to unfolded task bar
Bug: 350102824
Test: Task bar scrim doesn't happen
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ib0510d9e01b30b50bd5d295b23688547b1decef3
2024-07-01 13:00:46 -07:00
Saumya Prakash 1465e37dcb Add developer option to reset taskbar search edu
This change allows you to view taskbar search edu again by tapping the
"Taskbar Search Edu" option in launcher developer options.

Fix: 350537725
Test: Go to developer options and reset the taskbar search edu. Check
that it shows up the next time an app is launched (and if the taskbar is pinned)
Flag: EXEMPT bugfix

Change-Id: I5a0e992ef3b3d62c62998a7bbe648e4598cdde54
2024-07-01 19:13:48 +00:00
fbaron 347b408f90 Fix attempt for TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible
Bug: 344982276
Test: TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible
Flag: TEST_ONLY
Change-Id: I2f02b769aaae353d48501b8e3551a8d0939064c6
2024-07-01 10:25:27 -07:00
Brian Isganitis 035a25c9a7 Merge changes I18245c22,I4c7a6085,I1c17b7f0,I663e5ad7,I9199fd92 into main
* changes:
  Completely destroy Launcher's Taskbar.
  Add context for sandboxing Taskbar window contexts.
  Add tests for TaskbarUnitTestRule.
  Have recreateTaskbar perform recreate on UiThread.
  Move test rules to subpackage.
2024-07-01 16:41:17 +00:00
Android Build Coastguard Worker 4fb91f2221 Snap for 12032182 from b15dce1ec3 to 24Q4-release
Change-Id: Ib89bc9382067c158890d3546dcc062df318865a4
2024-06-29 03:22:09 +00:00
Brian Isganitis 326ae5e3d1 Completely destroy Launcher's Taskbar.
Just removing it temporarily from the window manager is insufficient.
Taskbar can attempt to recreate itself due to many callbacks being
invoked during tests such as the settings changing. After the tests
finish, the launcher process will restart anyways so taskbar will come
back automatically.

Flag: TEST_ONLY
Test: TaskbarUnitTestRule tests
Bug: 230027385
Change-Id: I18245c224f6d2ffc78d8bf80d30275429074f9b5
2024-06-28 18:38:23 -04:00
Liran Binyamin b15dce1ec3 Merge "Animate the dot with the bubble bar" into main 2024-06-28 22:31:27 +00:00