Commit Graph

83004 Commits

Author SHA1 Message Date
fbaron c275f53fbc Increase spring loaded hover time for tests since we switch pages too quickly leading to flakiness
Bug: 344982276
Test: TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible
Flag: TEST_ONLY
Change-Id: I2d187e37ee33f25b9b672beb3efb91300d96cab3
2024-07-09 09:48:56 -07:00
Federico Baron 501e4ab75a Merge "Revert "Fix attempt for TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible"" into main 2024-07-09 16:47:18 +00:00
Brandon Dayauon 6073fa296c Make close button to use google symbol library icon and update close color button
spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2df5f2c9773_4_0
CloseButtonColor to be scLOW
CloseIconColor to be onSurface

bug: 342246204
Test: manually photos:
beforeLT: https://drive.google.com/file/d/14O61WzHmeAhOdGirUci2u9vot3FWcSKo/view?usp=sharing
beforeDT: https://drive.google.com/file/d/1Dt75_sRIWNHMuwqnYzE1WvjRTZFHWJ8-/view?usp=sharing
afterLT: https://drive.google.com/file/d/1npg-icWcsEN5OCgMtP1oU7mB-gGuT6_n/view?usp=sharing
afterDT: https://drive.google.com/file/d/11LTC_61QTg4tX0SUO23cAbLaP7aoSnh-/view?usp=sharing
Flag: NONE Color change
Change-Id: I0c47c927c5c8094a018e6f18061e99fc4bd901de
2024-07-09 09:39:03 -07:00
Gustav Sennton f3108c59ed Taskbar running apps: show one icon per task + tap opens that task
Before this CL we would show only one Taskbar icon per app, making it
impossible (through the taskbar) to switch between several windows of
the same app.
With this CL we add one icon per task instead, making it possible to
bring each task to the front individually.

Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 351118893
Bug: 349790805
Bug: 351156858
Test: Started several Chrome windows -> taskbar has one icon per window

Change-Id: Ia692977effceb9ce339906bf6ca24d73e19d8769
2024-07-09 14:48:04 +00:00
Schneider Victor-tulias c957e68e17 Merge "Add fallback handling for gesture nav mode switch and launcher destroyed mid-gesture" into main 2024-07-09 14:37:02 +00:00
Liran Binyamin fad57132d3 Dump some bubble data to dumpsys
Flag: NONE added dump logs
Bug: 350753857
Test: manual
       - adb shell dumpsys activity service com.android.quickstep
Change-Id: I19d328f99e5ba887aa508ea9ab16e9778f13698b
2024-07-09 10:34:19 -04:00
Treehugger Robot bb2e973297 Merge "Add NaN handling to SpringAnimationRunner" into main 2024-07-09 04:42:44 +00:00
Vinit Nayak 71c9a887c9 Merge "Add divider bg placeholder to app pair icon launch" into main 2024-07-09 04:18:56 +00:00
Winson Chung 510a00958c Workaround for crash with null icon drawable
- Fallback to using a transparent drawable for the split select icon
  if one can't be resolved

Flag: EXEMPT bugfix
Bug: 342465270
Test: Instructions from the bug
Change-Id: I5e4366b08bf438df96669ad3742bc9fb998bf0b3
2024-07-09 04:14:52 +00:00
Android Build Coastguard Worker 6bcaf3df98 Merge cherrypicks of ['googleplex-android-review.googlesource.com/28173793'] into 24Q3-release.
Change-Id: I63384015f7ad54b8e7c4caae31df5915add78004
2024-07-09 03:01:34 +00:00
Vinit Nayak 1855ef15b9 Initialize SplitSelectStateController for 3P before setting content view
* RecentsView#onAttachedToWindow relies on splitSelectStateController
being initialized, so we now do it before RecentsActivity calls
setContentView()

Bug: 332643607
Test: Couldn't repro before or after :(
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4276ee4897f59cfb1a2e432adfe54196b1a0dd2d)
Merged-In: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
Change-Id: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
2024-07-09 02:41:34 +00:00
Treehugger Robot fed75d832d Merge "Adds aconfig flag for new archiving icon" into main 2024-07-09 02:17:23 +00:00
Shamali Patwa a84049f4fe Merge "Update the title and description provided by intent params." into main 2024-07-09 02:01:40 +00:00
Android Build Coastguard Worker 05533c7b28 Snap for 12058995 from 810cab2e9c to 24Q4-release
Change-Id: I2a5ae9e7abc7b832639114bf5da0306bc5aa4b8b
2024-07-08 23:27:38 +00:00
fbaron fd2fc06d69 Add screenrecord to TaplThemeIconsTest#testShortcutIconWithTheme
Flag: TEST_ONLY
Test: TaplThemeIconsTest#testShortcutIconWithTheme
Bug: 350557998
Change-Id: I38eb6558ece4cc23272a813d52ea677b8d9ad2cb
2024-07-08 15:41:06 -07:00
Federico Baron 20e7a59bff Revert "Fix attempt for TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible"
This reverts commit 347b408f90.

Reason for revert: didn't resolve the issue

Change-Id: I05563ffd3c83b4633007407953e2050ee2c87866
2024-07-08 22:32:48 +00:00
Charlie Anderson e16036f5f6 Adds aconfig flag for new archiving icon
Bug: 350758155
Test: N/A
Flag: com.android.launcher3.enable_new_archiving_icon
Change-Id: Id8bef6b127954d3a3b95c33670459a88148aa63d
2024-07-08 16:40:57 -04:00
Shamali P 012ad2fc07 Align the launch location passed to prediction session
Matches the prediction helper (the prediction service ignores added
widgets if launch location doesn't match the pattern. The size / pos
details however aren't used, so we pass defaults.

With this, prediction service may be able to predict widgets that
aren't already added, hence providing more suggestions.

Bug: N/A
Test: Unit test
Flag: EXEMPT BUGFIX
Change-Id: Ieaba4c9a8354dc96ea2bc70cafa106978037c572
2024-07-08 19:56:47 +00:00
Brandon Dayauon 4dd2907022 Adding logs to baseAllAppsAdapter to investigate private space icon alpha issue.
bug: 349766550
Test: N/A
Flag: com.android.launcher3.enable_private_space
Change-Id: I7ac8b538adc6cf8ad8ca801b703fd88d6287f18f
2024-07-08 12:28:11 -07:00
Schneider Victor-tulias 00df2a9d6a Add NaN handling to SpringAnimationRunner
Also Added some debug logs

Flag: com.android.launcher3.enable_additional_home_animations
Fixes: 340426016
Test: Forced NaN and checked logs
Change-Id: Iee3536e764752a79f97e77c2ccaa8fdaa81a6eef
2024-07-08 19:07:50 +00:00
Schneider Victor-tulias 0b15d98271 Add fallback handling for gesture nav mode switch and launcher destroyed mid-gesture
If the gesture nav mode switches to button nav mode mid gesture, specifically while a recents animation start is pending, then we never invalidate AbsSwipeUpHandler. This leaves the LauncherInitListener registered in the ActivityTracker until the AbsSwipeUpHandler is invalidated by something like a quick switch. Since the AbsSwipeUpHandler is not invalidated by pressing the home button, this leaves the home button seeming unresponsive.

Also added some clean up logic and debug logging to AbsSwipeUpHandler.onTasksAppeared since this path was confusing this investigation.

Flag: NONE code clean up, debug logs and bug fix
Fixes: 340748907
Test: adb shell cmd overlay enable-exclusive --category com.android.internal.systemui.navbar.threebutton && adb shell am start -n <component> while mid-gesture
Change-Id: I72f0656a2a2b92006d2d13ba5868062f2f0aec33
2024-07-08 18:47:01 +00:00
Tracy Zhou 810cab2e9c Merge "Get rid of multiple haptic feedbacks when long pressing on nav buttons" into main 2024-07-08 17:48:07 +00:00
Liran Binyamin a7821390e2 Fix squished hotseat due to bubbles
Hotseat supports adjusting its layout to make room for bubbles when
needed. There are 2 events that trigger this:
  1. When Hotseat's layout is reset, it checks for whether bubbles
     are showing.
  2. When Bubble Bar visibility changes it notifies hotseat so that
     it can update itself.

Folding the device is recreated triggers both hotseat layout reset
and recreation of taskbar, but the order in which these happen is not
guaranteed. Sometimes hotseat checks for the status of bubble bar
which may be visible if taskbar hasn't been recreated yet.

This change makes sure that hotseat updates itself after taskbar is
recreated and the ui controller is set, so that it cleans up any
adjustments it may have if bubbles are not visible.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349430356
Test: manual
       - unfold the device
       - create bubbles
       - observe hotseat adjusts itself for the bubble bar
       - fold the device
       - observe bubble bar is gone and hotseat shows correctly
Change-Id: I58d925c178b02c22583488ae081d478bbbbccc8c
2024-07-08 09:59:26 -04:00
Bill Yi 59d8954a6c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I48edcb7ed90f673ff5e2d7033c93082793d2e6ca
2024-07-08 05:43:45 -07:00
Bill Yi 6a67909064 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I66d9ea0f6ba47170added3139d91f9b76dd7ed0d
2024-07-08 05:43:16 -07:00
Bill Yi 16a7df47d3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I37a818837b8d38fd86120d968689f4894ec9ecf8
2024-07-08 05:42:48 -07:00
Bill Yi 93a3ec5e26 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I332f6a27769e4f9ac2d26b535cd7e825c8aaf536
2024-07-08 05:42:26 -07:00
Bill Yi b4896bfd76 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie0c78880e169d20898c63ca1e48cefc89c290cc9
2024-07-08 05:42:04 -07:00
Bill Yi 6e36413d55 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I609e3d36ba2dfad376a840746ac68c4fbd7c53ba
2024-07-08 05:41:37 -07:00
Treehugger Robot 892d358394 Merge "Make DeskopTaskView use latest TTV" into main 2024-07-08 12:05:53 +00:00
Johannes Gallmann 2e19e736bd Use default cross-activity animation in Launcher Home Settings
Bug: 347161956
Flag: EXEMPT bugfix
Test: Manual, i.e. verifying that default cross-activity animation is played
Change-Id: I27c67f727a4168bef12601955a03703becdd1698
2024-07-08 10:21:08 +00:00
Alina Zaidi f9fc3cf180 Merge "[Dev option] Move DesktopModesStatus to wm/shell/shared/desktopmode from wm/shell/shared/" into main 2024-07-08 09:49:20 +00:00
Tracy Zhou d289ca471b Get rid of multiple haptic feedbacks when long pressing on nav buttons
When returning false in a onLongClickListener, the touch event gets dispatched to onClickListener at release.

Fixes: 351457303
Test: long press and short press both result in one haptic feedback
Flag: EXEMPT bugfix
Change-Id: Id173a2d1fcf2f61c3289c653809207425b468a82
2024-07-05 23:26:45 -07:00
Alex Chau 3fde467b41 Make DeskopTaskView use latest TTV
- Made TaskThumbnailViewDeprecated nullable in TaskContainer, with non-null getter that requires feature flag to be on/off
- Removed TaskThumbnailViewDeprecated.setTaskOverlay, as it'll now be null with feature flag on
- Removed TaskThumbnailViewDeprecated from DesktopTaskView xml
- Simplifed DesktopTaskView binding logic, to always get thumbnailViews from viewPool, removeView and recycle all thumbnailViews in onRecycle
- Didn't implement view pooling of TaskThumbnailView due to difficulty with TaskContainer not being recycled togetehr with TaskThumbnailView

Bug: 338360089
Test: TaskThumbnailViewModelTest
Test: manual testing for DesktopTaskView for both enable_refactor_task_thumbnail on and off
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I38a6dfc6bc561689578d1660794f91d30bad4a68
2024-07-05 18:39:56 +01:00
Alina Zaidi 05cc31a613 [Dev option] Move DesktopModesStatus to wm/shell/shared/desktopmode from
wm/shell/shared/

Test: not needed, just refactoring. mp droid builds
Bug: 348193756
Flag: EXEMPT just refactoring
Change-Id: I6dd19f4203a2336f50bc26ac5b292057bb79ce37
2024-07-05 11:12:35 +00:00
Android Build Coastguard Worker 4479a819ef Snap for 12052458 from a00c81c173 to 24Q4-release
Change-Id: Ic1df60e993f1a962fe220a951c136c0a12b3d25c
2024-07-04 23:21:54 +00:00
Treehugger Robot a00c81c173 Merge "Change thumbnail/icon to get the image rather than updating it" into main 2024-07-04 17:13:37 +00:00
Schneider Victor-tulias acddb58539 Add CUJ instrumentation for KQS
Flag: NONE LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Bug: 339585624
Test: manually checked that CUJ calls were reached
Change-Id: Ifd2b92451c5ed2ebc35834c1d2f495275db3d49a
2024-07-04 10:44:26 -04:00
Uwais Ashraf 551927c6d3 Change thumbnail/icon to get the image rather than updating it
Flag: EXEMPT no-op refactor
Bug: 334826842
Test: existing screenshot tests
Test: Manual - checked icon loading
Change-Id: Ie1da708f911ba569d6464f338dc4efac92420268
2024-07-04 12:18:56 +00:00
Treehugger Robot 9ec1bc48d0 Merge "Remove deprecated initOverlay interface used by TaskOverlayFactoryGo" into main 2024-07-04 08:50:28 +00:00
Android Build Coastguard Worker 8683a2632b Merge cherrypicks of ['googleplex-android-review.googlesource.com/28102349'] into 24Q3-release.
Change-Id: I151b0b299990b21634a49ffc1b5a499bd30734b9
2024-07-04 03:25:21 +00:00
Saumya Prakash 62462a50ee Prevent Taskbar edu dismissal from touching outside of the window.
In an effort to encourage users to look at Taskbar edu more thoroughly,
this change makes it so users have to press the 'Done' button explicitly
to close the taskbar edu window. This change also adds the ability for
it to be dismissed by the back gesture. It only applies to the features
edu, and not other taskbar educations.

Fix: 349612575
Test: Manually run all versions of taskbar edu and ensure that the edu only goes away with back gesture, swipe up or clicking on the DONE button
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:17339843e76cb507413e1d22dcf0c7982e024379)
Merged-In: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
Change-Id: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
2024-07-04 03:14:55 +00:00
Brian Isganitis f7ca8d60be Merge changes I6e7c349d,If6c74b3b,Ib276e9dc,Ida0f7cc0 into main
* changes:
  Override DisplayController on main thread.
  Add annotations for manipulating secure settings.
  Don't use UiThreadTest for Taskbar Unit tests.
  Suspend Launcher taskbar while removed for tests.
2024-07-04 02:26:46 +00:00
Treehugger Robot f49f87decf Merge "Scale AppPair background on hover." into main 2024-07-04 01:30:10 +00:00
Treehugger Robot 12e13d89e1 Merge "Initialize SplitSelectStateController for 3P before setting content view" into main 2024-07-04 00:00:32 +00:00
Sebastián Franco 7c7794e020 Merge "Update back gesture zone any time the screen size changes." into main 2024-07-03 23:22:59 +00:00
Android Build Coastguard Worker 6b29682afa Snap for 12048319 from cd894eeae2 to 24Q4-release
Change-Id: I8cd1879fe2d204d9c7d80af3b492ea21e81d3fbd
2024-07-03 23:22:17 +00:00
Treehugger Robot 564209829d Merge "Prevent taskbar icon tooltip from showing on hotseat transition." into main 2024-07-03 23:06:44 +00:00
Federico Baron 651448cb98 Merge "Demote TaplThemeIconsTest#testShortcutIconWithTheme" into main 2024-07-03 22:43:39 +00:00
Vinit Nayak 4276ee4897 Initialize SplitSelectStateController for 3P before setting content view
* RecentsView#onAttachedToWindow relies on splitSelectStateController
being initialized, so we now do it before RecentsActivity calls
setContentView()

Bug: 332643607
Test: Couldn't repro before or after :(
Flag: EXEMPT bugfix
Change-Id: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
2024-07-03 22:18:05 +00:00