Commit Graph

83004 Commits

Author SHA1 Message Date
Jordan Silva 497729f781 Fix digital wellbeing banner position in portrait mode
The banner should be aligned to the start of the screen, not the center. This CL fixes DWB position for split tasks when device is unfolded.

Fix: 348200661
Bug: 345789862
Flag: EXEMPT bugfix
Test: Manual. Add a Digital Wellbeing (DWB) timer to 2 apps. Open these two apps in split mode. Unfold the device and go to Overview. The DWB banner should aligned correctly.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3d088e3899cfca516dfa8ae9699691ece2b914d9)
Merged-In: I0544b4a8eb85b00196373c8a4368e680abab222b
Change-Id: I0544b4a8eb85b00196373c8a4368e680abab222b
2024-06-24 09:55:17 +00:00
Treehugger Robot c1391754ff Merge "Enable currently functional multivalent tests" into main 2024-06-24 01:17:40 +00:00
Uwais Ashraf c902df4e41 Enable currently functional multivalent tests
Flag: EXEMPT test-only
Bug: 325088619
Bug: 325088638
Bug: 325088328
Test: Presubmit
Test: Gradle robolectric run
Change-Id: I20e77a401ed98c97168bf9c752eacc93c3c545dd
2024-06-22 22:14:30 +00:00
Android Build Coastguard Worker 317aaf5eec Snap for 12004070 from 9b3d882c34 to 24Q4-release
Change-Id: Iad76260d2b3ba1acdd5da7a4ee83d9841c5259ab
2024-06-22 21:22:19 +00:00
Liran Binyamin 9b3d882c34 Merge "Fix hotseat icon translation issue" into main 2024-06-22 01:35:49 +00:00
Treehugger Robot 0abbc4af14 Merge "Add scrim to TaskThumbnailView" into main 2024-06-22 01:22:31 +00:00
Android Build Coastguard Worker e4f15db9c1 Snap for 12002618 from 74fc385999 to 24Q4-release
Change-Id: I884e388b48d9984e9ce2fdecfbdbcf81b0d5b4ee
2024-06-22 01:22:07 +00:00
Treehugger Robot f53b40e1a9 Merge "[Launcher Jank] Allow list OverviewCommandHelper making IActivityTaskManager$Stub$Proxy.startActivity from main thread" into main 2024-06-21 23:36:22 +00:00
Android Build Coastguard Worker 653650bb32 Merge cherrypicks of ['googleplex-android-review.googlesource.com/27904180'] into 24Q3-release.
Change-Id: I8c3c2a6fe033e4c539522aab1e568ad27cc2e531
2024-06-21 23:34:05 +00:00
Jordan Silva 1a654c58dc Fix recents button not navigating to Overview
This CL prevents returning launcher in getVisibleLauncher method when isHomeVisible is true but Launcher is not started.

Bug: 337954957
Bug: 331947116
Flag: EXEMPT bugfix
Test: Manual. With 3-button-nav. Open a video from -1 scren (not in Youtube app), press recent button. More instructions in b/337954957#comment26.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6a4c142b5b77ccb8c439e29209b6dfd04a4690d0)
Merged-In: I40edafdab5457666474de2c0368158a9c1c05fb0
Change-Id: I40edafdab5457666474de2c0368158a9c1c05fb0
2024-06-21 23:23:01 +00:00
Jon Miranda f044d12fcc Merge "Fix taskbar bg delay for the case when user is going home." into main 2024-06-21 23:16:11 +00:00
Tracy Zhou 170092ef5d Merge "Enable taskbar on phones when the flag is turned on" into main 2024-06-21 22:47:13 +00:00
Treehugger Robot b938fa20b2 Merge "Close floating views before fake rotation" into main 2024-06-21 22:46:03 +00:00
Fengjiang Li 1f87d94e59 [Launcher Jank] Avoid SimpleBroadcastReceiver making binder calls on main thread
Fix: 348649441
Flag: NONE - jank fix
Test: manual - presubmit
Change-Id: Ie97713f3f0b1f117662d49c6d6a65651c593d424
2024-06-21 14:37:51 -07:00
Jon Miranda 09aa46b88e Fix taskbar bg delay for the case when user is going home.
The default value was not set. I decided to flip the variable to make
it more readable.

Bug: 345768019
Test: swipe up fast to go home, note no taskbar bg
      swipe up slow to reveal taskhome, note taskbar bg shows immediately
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I7fb4bbdce45a14312e42abcf71f7f0643376ddc6
2024-06-21 14:27:01 -07:00
Tony Wickham 74fc385999 Merge "Load and draw Recent/Running tasks that aren't in Hotseat" into main 2024-06-21 21:01:41 +00:00
Tony Wickham a79bc15cd0 Merge changes from topic "taskbar-running-minimized" into main
* changes:
  Maintain Running Tasks order in Desktop mode
  Change running apps section to use GroupTask instead of AppInfo
2024-06-21 21:00:01 +00:00
Tony Wickham 59e8952fc9 Merge "Handle running task launch properly in desktop mode" into main 2024-06-21 20:57:38 +00:00
Treehugger Robot f4934108bb Merge "Fix bubble bar bounce animation issue" into main 2024-06-21 20:44:10 +00:00
Liran Binyamin 891e9e3c4b Fix hotseat icon translation issue
The current behavior that adjusts hotseat icons to make room for the
bubble bar uses the index of the hotseat icon to calculate translation x.

The problem is that if icons are reordered, the index of the icon may be
different than the actual cell number it belongs to.

This change updates the logic to use the cell rather than the index.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345686425
Test: manual - on tablet in portrait
       - show bubble bar
       - observe hotseat icons adjust
       - drag an icon from the home screen into hotseat
       - observe icons are shown correctly
       - rotate the device to landscape and back to portrait
Change-Id: I8628892234d1b31205b93ba3089c6dbf2820ea04
2024-06-21 16:33:45 -04:00
Hongwei Wang 87b4060106 Offset display cutous on foldables
When entering PiP on foldables, especically in unfolded mode, offset the
display cutouts even if it's from ROTATION_0 (which is always the case
in unfolded state).

Flag: NONE bug fix
Before: http://recall/-/aaaaaabFQoRHlzixHdtY/eIR7VykaHpYeOigkuZVTp
After: http://recall/-/aaaaaabFQoRHlzixHdtY/cP7NticbA68I4eev2MyZgc
Bug: 331128612
Test: Hold unfolded foldable in different orientation, enter PiP
Test: Hold folded foldable in different orientation, enter PiP
Test: see also the videos
Change-Id: I62e8d3f361644ca0ca78ef20b3d3b5441d7f26c8
2024-06-21 12:06:52 -07:00
Fengjiang Li c5005171a6 [Launcher Jank] Allow list OverviewCommandHelper making IActivityTaskManager$Stub$Proxy.startActivity from main thread
Added comments

Fix: 348668521
Test: presubmit
Flag: NONE - add comment
Change-Id: I0b3cfb4ee7d05c3b3d2f2857542f1a76a5af7e1f
2024-06-21 12:04:04 -07:00
Brian Isganitis d3d2607a10 Merge "Extract RoboApplication object caching to Launcher3 interface." into main 2024-06-21 18:37:14 +00:00
Alex Chau bde639236f Close floating views before fake rotation
- We do the same in Launcher for real rotation

Fix: 348113790
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ibd5f42db439cd94a389f7aaf6fe2db317c11cd67
2024-06-21 18:37:21 +01:00
Uwais Ashraf 0d9b547471 Add scrim to TaskThumbnailView
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Fix: 334832108
Fix: 348195366
Test: Manual - checked scrim in un/folded
Change-Id: I758a26e9b4498dac509b75afbe059784557b3f8c
2024-06-21 16:27:01 +00:00
Mady Mellor a2146c8f10 Merge "Update bubble bar overflow to have a unique resId" into main 2024-06-21 15:55:04 +00:00
Android Build Coastguard Worker a28a9acbcf Merge cherrypicks of ['googleplex-android-review.googlesource.com/27948087'] into 24Q3-release.
Change-Id: Ic311bb2906ad81b79cfd0c9d4f5487d5dc3f01c8
2024-06-21 03:36:26 +00:00
Jordan Silva 2f2429e565 Fix digital wellbeing banner position in portrait mode
The banner should be aligned to the start of the screen, not the center. This CL fixes DWB position for split tasks when device is unfolded.

Fix: 348200661
Bug: 345789862
Flag: EXEMPT bugfix
Test: Manual. Add a Digital Wellbeing (DWB) timer to 2 apps. Open these two apps in split mode. Unfold the device and go to Overview. The DWB banner should aligned correctly.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3d088e3899cfca516dfa8ae9699691ece2b914d9)
Merged-In: I0544b4a8eb85b00196373c8a4368e680abab222b
Change-Id: I0544b4a8eb85b00196373c8a4368e680abab222b
2024-06-21 03:22:37 +00:00
Hongwei Wang a648d13ea8 Merge "Position PiP animation based on actual coordinates" into main 2024-06-21 02:51:37 +00:00
Android Build Coastguard Worker 3b0bf23ce7 Snap for 11996894 from da3f972261 to 24Q4-release
Change-Id: I369fbfe6cfe722bf687cd3d038629434de649c4e
2024-06-20 23:23:38 +00:00
Liran Binyamin cdc3e4d8b4 Fix bubble bar bounce animation issue
The bubble bar bounce animation was assuming that the initial translation
of the bubble bar is also the translation the bubble bar should have at
the end of the animation. This is normally correct except when the
bubble bar is initially hidden. What happens in that case is that the
translation is 0 so the bubble bar gets animated incorrectly.

This change gets the target animation from stash controller.

ABTD 100 runs: https://android-build.corp.google.com/abtd/run/L26900030004638356/

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 347856510
Test: atest BubbleBarTest#selectDifferentBubble
Change-Id: I661bf006c6f23ff871c221f8d9da74d79a2dff11
2024-06-20 18:03:52 -04:00
Xin Li da3f972261 [automerger skipped] Merge 24Q3 (ab/11976889) to aosp-main-future am: 020c6204dd -s ours
am skip reason: Merged-In I5059553cb9b6c02810e9638bfaf29dde9ab6140f with SHA-1 263932e729 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27907054

Change-Id: Icbb39fe46616eb1eee1c7d468f006b728cb243d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-06-20 21:46:13 +00:00
Liran Binyamin 8af78f19a3 Merge "Animate bubble removal from the bar" into main 2024-06-20 20:57:34 +00:00
Hongwei Wang cd6172911e Position PiP animation based on actual coordinates
In the previous patchset, we assumed the left/top to be 0/0 which is not
always the case. This could break, for instance, in ActivityEmbedding
setup, where the pip-ing app is on the left side.

Flag: NONE test fix
Bug: 345327260
Test: Verify with apps support auto-enter PiP such as YouTube
Change-Id: Ic2f3289cf0663d0687d5ccd7f4d0250066cb3f67
2024-06-20 13:24:18 -07:00
Shamali P e4ca191001 [part-1] Perform doMeasure only once in WidgetsFullSheet
We already know the details used to calculate the insets while in
onMeasure, so, instead of measuring everything twice, we initialize
the maxSpansPerRow in onMeasure and then call doMeasure.

Bug: 346341156
Flag: EXEMPT bugfix
Test: Manual and screenshot
Change-Id: If080f1f91c69d2d54139d876c36eac8743a224ee
2024-06-20 19:36:38 +00:00
Liran Binyamin 7b426af15f Animate bubble removal from the bar
This change creates a BubbleAnimator class that handles animating
both new bubbles in and removed bubbles out.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dMHGANplWjGC5HZT6MXyA4

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345687290
Test: atest BubbleAnimatorTest
Test: see demo

Change-Id: Ie060495f4b1421d1c8af48a861cd3e12dd0adbe8
2024-06-20 14:57:03 -04:00
Jordan Silva c9ec536f07 Merge "Fix recents button not navigating to Overview" into main 2024-06-20 16:42:16 +00:00
Luca Zuccarini 11fa93f25d Merge "Fix widget jump at the end of the new home animation." into main 2024-06-20 15:58:55 +00:00
Treehugger Robot 264a7e3336 Merge "Move testQuickSwitchFromHome to possubmit" into main 2024-06-20 14:41:18 +00:00
Luca Zuccarini 4b4e426b30 Fix widget jump at the end of the new home animation.
The window animation wasn't being updated correctly, which resulted in a
jump at the end.

Bug: 298089923
Fix: 347880952
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Test: manual
Change-Id: Idbbd2e8485ae6f2bcbc1b42aa3744c2c659d1cfc
2024-06-20 13:40:45 +00:00
Shamali P a34a264af4 Focus on the right pane when choosing an app on left
As before, user can also do 4-finger swipe down to move to right pane.

Bug: 345396938
Flag: EXEMPT bugfix
Test: Manual - see video in comments
Change-Id: If72862af2b05ae54c47e8d446a168252d3fc8194
2024-06-20 13:39:34 +00:00
Alex Chau 91602f658c Move testQuickSwitchFromHome to possubmit
Bug: 325659406
Test: presubmit
Flag: EXEMPT test
Change-Id: Iccc2c1f06da85a0df79b5f3e0881535ce226f953
2024-06-20 13:50:19 +01:00
Luca Zuccarini 52545edb41 Add return animations to Toast search results.
This only applies to targets that already use the Animation library for
launch animations.

Bug: 336719605
Bug: 298089923
Flag: com.android.launcher3.enable_container_return_animations
Flag: com.android.systemui.shared.return_animation_framework_library
Test: tested manually with flag on and off
Change-Id: Ib824e78fa8b1b226b32d23d8325f06b496ba5deb
2024-06-20 10:25:57 +00:00
Jordan Silva 3d088e3899 Fix digital wellbeing banner position in portrait mode
The banner should be aligned to the start of the screen, not the center. This CL fixes DWB position for split tasks when device is unfolded.

Change-Id: I0544b4a8eb85b00196373c8a4368e680abab222b
Fix: 348200661
Bug: 345789862
Flag: EXEMPT bugfix
Test: Manual. Add a Digital Wellbeing (DWB) timer to 2 apps. Open these two apps in split mode. Unfold the device and go to Overview. The DWB banner should aligned correctly.
2024-06-20 09:46:30 +00:00
Android Build Coastguard Worker ed367d34bb Snap for 11992154 from 622a7e37c5 to 24Q4-release
Change-Id: I765e9a3b2d6ec681c3501fd8d56222b9d12f5fbc
2024-06-19 23:22:05 +00:00
Tracy Zhou 1983e4fb13 Enable taskbar on phones when the flag is turned on
Bug: 348017501
Test: N/A
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: I8f283609b24c49e4ecd37142b0d94e449d1dc118
2024-06-19 18:45:22 +00:00
Kevin Liu 97cbdbcfd3 Add strict_mode: false
As strict mode is in place, the default strict_mode is now set to true. We are encourage teams to write tests in strict_mode to make tests Bivalent (able to run on device and devicelessly)
For more info on strict mode: go/roboStrictMode
Also fixed some missing deps.

Flag: NONE
Test: atest Launcher3RoboTests
Bug: 334089788
Change-Id: I4b4f2ef9a21926eef63fcada81355b928bbe2870
Merged-In: I4b4f2ef9a21926eef63fcada81355b928bbe2870
2024-06-19 15:53:35 +00:00
Fengjiang Li 622a7e37c5 Merge "[Launcher Jank] Avoid LauncherWidgetHolder and QuickstepWidgetHolder calling IAppWidgetService$Stub$Proxy.setAppWidgetHidden from main thread" into main 2024-06-19 15:19:22 +00:00
Jordan Silva 6a4c142b5b Fix recents button not navigating to Overview
This CL prevents returning launcher in getVisibleLauncher method when isHomeVisible is true but Launcher is not started.

Bug: 337954957
Bug: 331947116
Flag: EXEMPT bugfix
Test: Manual. With 3-button-nav. Open a video from -1 scren (not in Youtube app), press recent button. More instructions in b/337954957#comment26.
Change-Id: I40edafdab5457666474de2c0368158a9c1c05fb0
2024-06-19 15:08:43 +01:00
Ivan Tkachenko f58d227f61 Fix back gesture navigation in Launcher with DW
The windows back functionality with the
`enable_desktop_windowing_wallpaper_activity` flag enabled works as
expected and doesn't require changes in `#updateDisallowBack`.

- Added the `enable_desktop_windowing_wallpaper_activity` flag check in
  `Launcher#updateDisallowBack`
- The early return statement will get removed after flag is fully rolled
  out (b/333533253)

Bug: 330183377
Test: manual
Flag: com.android.window.flags.enable_desktop_windowing_wallpaper_activity
Change-Id: I2eaaa44da82da6cbdfe534793830d0f44c4668ba
2024-06-19 11:57:06 +00:00