Previously, we would extend the touch slop and duration when the
standard gesture slop was passed. This would actually increase
mistriggers, because it effectively doubles the trigger slop
allowance. Additionally, it seemed to usually get aborted by
gesture nav, which takes over after the first slop is passed.
With this change, we instead break down the gesture nav slop in
half (customizable by a new config parameter). In the second half,
we double (still customizable - but expressed as a percentage to
give us more flexibility than just 2x, 3x, etc) the duration to
trigger. This means omnient will be cancelled more quickly when
starting any swipe gesture, but if the user continues to dwell in
the navbar region for an extended time, omnient will still trigger.
Bug: 334860966
Test: Manual with ENABLE_LPNH_TWO_STAGES on and logging with
adb shell setprop log.tag.NavHandleLongPress VERBOSE
Flag: EXEMPT legacy DeviceConfig ENABLE_LPNH_TWO_STAGES DISABLED
Change-Id: Ida5c8e19b414a2bf0008b78b7bf0e7d41d3ff609
From the failure test videos, it looks like scrollToTop gets called https://b.corp.google.com/issues/339737008#comment15.
Bug: 339737008
Test: Manual
Flag: TEST_ONLY
Change-Id: I61a95ff45fa4409f8f1b243ac435002556a16677
The bubble's outline was hardcoded with a fixed size. This caused a
shadow to be drawn using the hardcoded outline size, regardless of the
actual bubble view size. The BubbleView logic has been updated to use
the actual bubble size for the outline. The guarding flag has been
removed.
Bug: 340445019
Flag: com.android.wm.shell.enable_bubble_bar
Test: http://recall/-/gx8ASgewUeUS3QYohfrd1J/hqFtAZJnX0tCRONoFpSK3i
Change-Id: Iaa2c2d0bfeee2af9840acbcf11daaf8be2e0b7af
The removal and update of bubbles happen in different processes, so
it's possible for race conditions to allow users to remove bubbles
without knowing that an update exists.
Passing the removal timestamp allows wm shell to determine whether
the removal happened before or after the latest update was received
for the bubble. This largely mitigates the race but does not solve
it completely. Will file a separate bug to track that.
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 351026092
Test: Manual
- Note the issue here is a race condition so requires code
changes to force repro it
- Locally I added an artificial delay between the time the
- bubble is removed and until the removal is sent to wmshell
- Create bubbles and expand the bubble bar
- Dismiss bubble by dragging it to dismiss
- Send an update to the same bubble before removal is processed
in wmshell
- Verify bubble is added back
- Verify bubble is not removed when the removal is processed
in wmshell
Change-Id: I05ddc692fe30709125e380351b223d20a0778264
This CL adds optimizations for Launcher3Quickstep builds by shrinking
unused resources.
- Enabled proguard for Launcher3QuickStep
- Launcher3Quickstep APK size reduced by -61%, 18.9Mb.
- Launcher3QuickstepGo and Launcher3Go APK size reduced by 6.5%, 872kb.
Fix: 346288630
Flag: EXEMPT Updating bp files to optimize the build
Test: Presubmit and Postsubmit builds
Change-Id: I6f8bdee7febbc125e14df3afe7bbd36ba57623f0
- Also updated AnimatedFloat to accept a Consumer<Float>, so a lambda can be used as updateCallback with refernce to udpated value
- Also updated PendingAnimation to accept Animator with TimedInterpolator without specifying SpringProperty
Fix: 352195519
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ifb78c1bcd3ca215a5d214f986a107d0988bff13b
Revert submission 28049476-kqs-cuj-instrumentation
Reason for revert: Droidmonitor created revert due to b/352144322. Will be verifying through ABTD before submission.
Reverted changes: /q/submissionid:28049476-kqs-cuj-instrumentation
Change-Id: I8bfe7bfe4ce1bd816f138dbd4d5915f837ab97a0
Don't update the dot scale if the bubble bar is not collapsing or
expanding.
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 351904597
Test: manual
- Create 2 bubbles in the bubble bar
- Select both bubbles to clear the dot
- Launch an app to stash the bar
- Send updates to both bubbles
- Observe dot appears during each animation
- Swipe up on the bubble bar
- Observe dot disappears for the selected bubble but remains
for the unselected bubble
Change-Id: I2cb6dd7ded261686ae73e497bd5d4841ebde35ef
Fix bubble update animation when the updated bubble is the only
bubble in the bar.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 352119655
Test: Manual:
- Create 1 bubble in the bubble bar
- Send an update for that bubble
- Observe bubble bar is animated correctly
Change-Id: If569810dacf0ef77147a822c53ddebd09e35fe15
UX prefers full page view over low density categorized view in tablets.
Bug: 347288847
Test: Screenshot (see the tablet screenshots vs foldable)
Flag: EXEMPT BUGFIX
Change-Id: I6c8ad36dc6169c65aea4e655af0542958e555669
Previously the translation x value for bubbles when the bar is
collapsed and on the right was 0 for the first bubble and some
fixed value for the rest of the bubbles. But if only 1 bubble
is visible when the bar is collapsed, as in the case when there
is only 1 bubble and the overflow, this ends up pushing the
overflow too far to the right.
This change updates the translation x value for bubbles when the
bar is collapsed and on the right, so that if only 1 bubble is
visible when collapsed, all bubbles have tx 0, otherwise if 2
bubbles are visible, the first has tx 0 and the rest have the same
tx value.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 350962159
Test: manual
- Add 1 bubble to the bubble bar
- Make sure bubble bar is on the right
- Expand and collapse the bar
- Observe the overflow tx value is correct during the animation
Change-Id: I8401d70fa6f374ace58d9cdbe3302e39e7aedc70
Johannes Gallmann
Andy Wickham
Android Build Coastguard Worker
Fengjiang Li
Anushree Ganjam
Mykola Podolian
Sebastián Franco
Federico Baron
Alex Chau
Liran Binyamin
Jordan Silva
Schneider Victor-tulias
Kevin Lim
Liana Kazanova
Treehugger Robot
Priyanka Advani
Brandon Dayauon
Bill Yi
Shamali P
Winson Chung