Commit Graph

20057 Commits

Author SHA1 Message Date
mpodolian 8a28b39f4d Align the adjusted hotseat drop animation with the hotseat
Adjusted the hotseat drop animation to ensure the drop target moves to
the correct position.

Fixes: 383199528
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual:
http: //recall/-/gx8ASgewUeUS3QYohfrd1J/cL46nBGrr6yCA19FD9I5vs
Change-Id: I16fa9710246ce263374d06cfa796a72a7a4d5437
2024-12-12 17:58:23 -08:00
Sebastian Franco dabf02fd86 Prevent Hotseat jank when switching Fixed Landscape setting
Fix: 380998389
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I6e7334b9f5b3d6abab57d461987db64fe3700ac4
2024-12-12 17:32:11 -08:00
Stefan Andonian b64026135f Log.wtf if DeleteDropTarget "canRemove", but doesn't remove item from the database.
Bug: 379606516
Test: Verified locally that these logs show when hard-coded to appear. Also verified that normal usage doesn't cause crashes.
Flag: EXEMPT bug logs
Change-Id: Iadc67f4a063f5924c758468c6b227b23368fc192
2024-12-13 00:41:06 +00:00
Sunny Goyal daf46a09b2 Merge "Moving WMProxy to dagger" into main 2024-12-12 15:27:19 -08:00
Brandon Dayauon d660052416 Fix swipe up to home gesture when entering scheduler page
bug: 383491628
Test video: https://drive.google.com/file/d/1brSO55cBeZZMTLq5dZ-rNO7Z-aeytghe/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: I0a8e0b64ac175ef6ccfc4f2db1b751ea6aef6995
2024-12-12 15:16:12 -08:00
Charlie Anderson 2885a6639c Add new failsafe to disable new archiving broadcast
Bug: 322314760
Test: presubmit and LoaderTaskTest
Flag: com.android.launcher3.enable_first_screen_broadcast_archiving_extras

Change-Id: I7c7b94a81dd717ed6f32de2ae986616b93dbbcc0
2024-12-11 18:59:05 -05:00
Treehugger Robot 5a5cf9e698 Merge "Fixing nullpointer error in genering error description" into main 2024-12-11 13:37:05 -08:00
Sunny Goyal 41e8057bbf Moving WMProxy to dagger
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I9a8031037f2167658b7bc212b59c9b11abbf2f03
2024-12-11 13:24:26 -08:00
Treehugger Robot 4d4eb7d685 Merge "Introduce mTaskViewCount inside the RecentsView" into main 2024-12-11 12:36:00 -08:00
Sunny Goyal 0cb0166a2c Fixing nullpointer error in genering error description
Bug: 383492095
Flag: EXEMPT bug fix
Test: Presubmit
Change-Id: I43c71bb62df45d53bd757daa3203f216229946a0
2024-12-11 11:41:39 -08:00
minch 58abc8b0a6 Introduce mTaskViewCount inside the RecentsView
Add a member property `mTaskViewCount` inside the RecentsView to track
the number of TaskView inside it. Its value will be increased
`onViewAdded` and decreased `onViewRemoved`.
- Then `getTaskViewCount()` can just return this variable directly.
- Invalidate the `PagedView.mPageScrolls` on a view addition and
  removal util they have been updated on next `onLayout`. This is done
  to guarantee that `mOnPageScrollsInitializedCallbacks` is run with
  up to date `mPageScrolls`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Tested on Tangor, ensure `mTaskViewCount` is correct in the
      following scenarios:
      1. Adding more tasks and enter overview
      2. Dismissing one and more tasks
      3. Dismissing all tasks
Change-Id: I32407e77dd2a9b3d8200efc334c1eadea1336b31
2024-12-11 10:43:31 -08:00
Mykola Podolian 29ccf8703b Merge "Remove usage of the enableBubbleBarInPersistentTaskBar flag." into main 2024-12-11 09:24:25 -08:00
ELIYAZ MOMIN (xWF) 931a86396f Merge "Revert "Making sure that test go to FixedLandscape on landscape"" into main 2024-12-11 04:05:30 -08:00
ELIYAZ MOMIN (xWF) d98bb0b979 Revert "Making sure that test go to FixedLandscape on landscape"
This reverts commit 279b77a882.

Reason for revert: <Potential culprit for b/383424365 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Change-Id: I4b1c81a8e458432c880ad68fa5bd0e2062f2680f
2024-12-11 02:38:04 -08:00
Willie Koomson 712264a855 Dismiss resize frame before adding widget with add button
This change updates LauncherAccessibilityDelegate so that any open
widget resize frame is closed before searching for space on the
workspace. While the resize frame is open, its cells are marked
unoccupied, so LauncherAccessibilityDelegate may try to place something
in that space.

Bug: 374228746
Test: follow repro steps in bug
Flag: EXEMPT bug fix
Change-Id: Ibcd0711fff53182d91e9781a73f00c979c15e189
2024-12-11 03:52:37 +00:00
Sebastián Franco 485c57044d Merge "Making sure that test go to FixedLandscape on landscape" into main 2024-12-11 00:40:31 +00:00
Treehugger Robot 4d8f0d5a8f Merge "Add Aster logging for entering and exiting desktop mode via quick switch" into main 2024-12-10 23:31:50 +00:00
mpodolian 3e419ebbf1 Remove usage of the enableBubbleBarInPersistentTaskBar flag.
Remove and merge the usage of the enableBubbleBarInPersistentTaskBar
flag to the enableBubbleBar flag.

Bug: 383181643
Flag: com.android.wm.shell.enable_bubble_bar
Test: NONE - removed and merged flag usage.
Change-Id: I4f131e1ddf8367425b91c8fb597857ee222b75d8
2024-12-10 15:10:49 -08:00
Jeremy Sim 41cdb7ffee Merge "App Groups: Allow app pairs to take more than 2 members" into main 2024-12-10 22:37:31 +00:00
Fengjiang Li b0ce150306 Merge "[PostBoot] Support post boot animation on launcher3" into main 2024-12-10 21:43:33 +00:00
Shamali Patwa 5f5b1a3f56 Merge "Fix missing IME back animation in widget picker" into main 2024-12-10 19:44:47 +00:00
Mykola Podolian 9763990e9e Merge "Align hotseat drop target with the adjusted hotseat" into main 2024-12-10 18:50:22 +00:00
Fengjiang Li c290787cf7 [PostBoot] Support post boot animation on launcher3
Add ALPHA_CHANNEL_COUNT to DragLayer

Test: manual
Flag: NONE - gated in xml
Bug: 346332241
Change-Id: Ie7cf4c11b4e606e01d54d8a87e7f1dc5906e97b0
2024-12-10 10:07:29 -08:00
Sebastian Franco 279b77a882 Making sure that test go to FixedLandscape on landscape
Fix: 379871292
Test: TaplDragTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I56027c22e4c3b1b0532ba0ac00eb0f4caea24abb
2024-12-10 17:08:54 +00:00
Shamali P aaf585aef2 Fix missing IME back animation in widget picker
Discussed with folks who worked on IME animation, and root cause seemed
to be picker unconditionally clearing the focus. Also, there is no
in-built way for clearing focus on other user interactions. So, had to
write custom logic to conditionally clear the focus.

Bug: 369933372
Test: See screencast (tested back, and other user interactions)
Flag: EXEMPT BUGFIX
Change-Id: I693bd27662563e5320159c082eb955a3bd5386f8
2024-12-10 16:28:05 +00:00
Vania Desmonda 7fd479c454 Add Aster logging for entering and exiting desktop mode via quick switch
Fixes: 360874817
Fixes: 381214742
Flag: com.android.window.flags.enable_desktop_windowing_quick_switch
Test: manual test
Change-Id: I7bae2aaff614a5590fa107d0c102c520b14b85d9
2024-12-10 13:35:15 +00:00
Jeremy Sim 0c3b2e9540 App Groups: Allow app pairs to take more than 2 members
Changes saveAppPair to take a general number of apps, rather than just 2. At the moment, this will not change anything, since GroupedTaskViews are still hard coded to contain 2 apps.

Bug: 349828130
Flag: com.android.wm.shell.enable_flexible_split
Test: No effect on behavior, just a small refactor.
Change-Id: I6f86210ab4662f0d3a8fba1f6bb6fd78391e7fa2
2024-12-09 16:41:24 -08:00
Treehugger Robot 07e6109dc6 Merge "Add logs to output intent string for NPE in DbEntry." into main 2024-12-09 23:41:08 +00:00
Stefan Andonian e2c19253b2 Add logs to output intent string for NPE in DbEntry.
Bug: 380555381
Test: No tests, just changed log string.
Flag: EXEMPT bug fix logs
Change-Id: I0b0a36ebce0db38c89afb22a89b7e969fdc16bd9
2024-12-09 13:41:57 -08:00
Stefan Andonian 3d76150128 Merge "Convert SpringLoadedDragController to Kotlin" into main 2024-12-09 21:04:16 +00:00
Treehugger Robot b172e86472 Merge "Loading generated preview on-demand instead of keeping everything in memory" into main 2024-12-09 17:26:02 +00:00
Treehugger Robot 45e274977d Merge "Some test fixes where default user is assumed to be user 0" into main 2024-12-07 08:11:56 +00:00
Brandon Dayauon 5d69c5c505 Merge "Fix workUtilityView receiving touch for pause work apps button." into main 2024-12-07 07:28:02 +00:00
Sunny Goyal 9c58954488 Some test fixes where default user is assumed to be user 0
CheckLongPressHelper: Cancelling view longpress which inturn also cancels self
This ensures that long press is properly cancelled if the default timeout for system longpress is same as ours

Bug: 379777736
Bug: 379807782
Bug: 379805363
Bug: 379805788
Bug: 379777734
Bug: 379774350
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5
2024-12-06 22:23:51 -08:00
Treehugger Robot cc0e19d298 Merge "Add more logs to investigate empty launcher restore" into main 2024-12-07 05:13:33 +00:00
Shamali Patwa 5fb8180b00 Merge "Remove the elevation on the DragView to avoid shadows underneath" into main 2024-12-06 23:40:38 +00:00
Treehugger Robot ddaf0bbd7a Merge "Modify the accessibility tree to move the searchbox to the top." into main 2024-12-06 23:37:45 +00:00
Stefan Andonian 0c057f7df9 Convert SpringLoadedDragController to Kotlin
Bug: 379798547
Test: Verified that this works well on device.
Flag: EXEMPT kotlin conversion
Change-Id: Icaf874557e86a8231614ab75e55aedc8c3718703
2024-12-06 15:11:30 -08:00
mpodolian 06fb33ceb3 Align hotseat drop target with the adjusted hotseat
Added logic to adjust the drop target to account for changes in the
hotseat position when accommodating the bubble bar.

Fixes: 382348730
Test: all tests in package src.com.android.launcher3.celllayout
Test: Manual. Ensure bubbles are present, and the hotseat width is
adjusted. Long-press any icon in the hotseat, begin dragging it over
other hotseat icons, and observe that the drop target is drawn
appropriately.
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: Ice961f40ace03077ab8c9312a93eda1a16d7da34
2024-12-06 14:57:31 -08:00
Sunny Goyal ee15f52a7c Loading generated preview on-demand instead of keeping everything in memory
Bug: 369906121
Test: atest GeneratedPreviewTest
Flag: EXEMPT bugfix
Change-Id: Idd7610e8a5c577d2c7b0a1d7d2a1f1efde40b11f
2024-12-06 22:25:40 +00:00
Charlie Anderson bad2be4944 Add more logs to investigate empty launcher restore
Flag: EXEMPT logs
Test: presubmit
Bug: 377510898
Change-Id: I1c05b90c9e1337663c4c06703ad14b6c0d00aa07
2024-12-06 22:14:19 +00:00
Brandon Dayauon 8143b69cec Fix workUtilityView receiving touch for pause work apps button.
bug: 382501851
Test manually video:
before: https://drive.google.com/file/d/1I6av4cFoYex6QhzYAdlzJWCBwd2ilgzT/view?usp=sharing
after: https://drive.google.com/file/d/1hMDELNTqUvoI7oI-lw0sLifcGyIalbS_/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: I9dfead6deac7f3dbcb66c961bea4a1828f20478d
2024-12-06 14:05:03 -08:00
Anushree Ganjam 8335b9790a Modify the accessibility tree to move the searchbox to the top.
This change fixes both quickstep and pixel launcher variants.

Before
A11y traversal order : https://paste.googleplex.com/4735370693181440
Video: http://recall/-/cYrER3oshUB9gisWlEhySV/fGSVr7vsAToApiYzywptQ6

After
A11y traversal order : https://paste.googleplex.com/6464092613902336
Video: http://recall/-/cYrER3oshUB9gisWlEhySV/cEEPIPidHGP4tg9Hng7Ra6

Bug: 378610191
Test: Manual
Flag: EXEMPT a11y Bugfix
Change-Id: I95fbdc2db02f2957db461769e0d9a0556adbb760
2024-12-06 13:13:15 -08:00
Shamali P cc21323af2 Remove the elevation on the DragView to avoid shadows underneath
In b/297952359 we are seeing that widgets with clipped outline
 elements end up showing shadows below their drag view. Which
 due to not maintaining clipping looks further bad.

It seems like, we don't really need the elevation for drag
view anymore - and presumably it was added for older android
 versions for shadow for folders. But, they don't have them
  anymore, so, removing elevation now.

 Note: The issue that during drag and drop, the dragged preview
 not showing clip to outline or shadows within widget's views is
 a separate issue related to the Picture API usage during drag
  and drop.

Bug: 297952359
Test: Screen record in comments
Flag: EXEMPT Bugfix

Change-Id: If31a0275938afe374d269a46cc950970033323f9
2024-12-06 21:10:51 +00:00
Treehugger Robot 07bf3c3085 Merge "Restore fallback Overview state when restarted by theme changes" into main 2024-12-06 19:35:07 +00:00
Treehugger Robot 3e159f5654 Merge "Generalizing monochrome icon into Theme icons" into main 2024-12-06 18:29:07 +00:00
Alex Chau c76d4a8971 Restore fallback Overview state when restarted by theme changes
- Moved RUNTIME_STATE_RECREATE_TO_UPDATE_THEME to StatefulActivity
- Handle uiMode in RecentsActivity
- When RecentsActivity is recreated due to theme changes, restore previous state

Fix: 382072029
Test: Manual: Change light/dark them from QuickSettings while in fallback Overview, Overview stay open
Flag: EXEMPT bugfix
Change-Id: Ia596150afa1436c4a25e94fd2b6930a8ded0b0d4
2024-12-06 17:10:03 +00:00
Sunny Goyal 97eb832cd3 Generalizing monochrome icon into Theme icons
Bug: 381897614
Flag: EXEMPT refactor
Test: atest MonoIconThemeControllerTest
      atest MonoThemedBitmapTest

Change-Id: Iaa0cbe3523ee26a6d4f77e002d0cca90657f89b2
2024-12-05 14:57:06 -08:00
Uwais Ashraf 4b05341d6e Merge "Use custom background dispatcher to stop excess thread creation." into main 2024-12-05 21:37:38 +00:00
Pinyao Ting 0cb19af97c Merge "Hide "Shortcut Menu" from a11y actions when shortcut menu is already opened" into main 2024-12-05 21:05:31 +00:00