Commit Graph

20057 Commits

Author SHA1 Message Date
Sunny Goyal 5bf0742fc5 Fixing prediction ring color not getting updated if the icon changes
while the slot animation is running

Slot animation is only trigerred through prediction update and it sets
final ring color at that point as part of the animation. If the icon
and the color change due to some other reason (like high-res icon or
a package-update), that color is overriden by the ongoing slot animation.

Bug: 381897614
Test: Verified manually by slowing down animation
Flag: EXEMPT bugfix
Change-Id: Ia3b86330afdb91ba6ff3366e3c8057bd7ec34e5d
2024-12-27 02:54:21 -08:00
Sunny Goyal c2639e464f Replacing some fixed lookup flags with specific constant flag
This would make it easier to customize flags used on desktop icons

Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: I0f3f04ddbe73abea207a5b58a65714ff172b2726
2024-12-26 20:19:02 -08:00
Sunny Goyal a39a09ba6a Replacing custom parcelables with platform types for test APIs
Bug: 377772352
Flag: EXEMPT test only
Test: Presubmit
Change-Id: Ie464c67adf6502aee1fe65ef643e1a67260b820f
2024-12-26 17:19:15 -08:00
Holly Sun ae654ddaff Remove remaining "Item added to home screen" annoucement from talkback.
Based on https://b.corp.google.com/issues/383457529#comment5, we should remove all app annouced confirmation.

Bug: 386247991
Test: build
Flag: EXEMPT a11y bug fix
Change-Id: I0ba2e282a42c0785c8bdad1be23adf2bf90a44b3
2024-12-26 15:02:39 -08:00
Sihua Ma 8c141ef524 Merge "Remove disruptive home screen announcement when scrolling" into main 2024-12-26 10:21:57 -08:00
Treehugger Robot 1aea1ea8e0 Merge "Converting BaseIconCache to kotlin" into main 2024-12-26 09:29:00 -08:00
Sunny Goyal d5ad770d2c Converting BaseIconCache to kotlin
Bug: 366237794
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ia191ed468eda24f910bba87221cf1f1714408a55
2024-12-24 21:27:33 -08:00
Sihua Ma 67d2f4b591 Merge "Remove disruptive announcement when exiting folder" into main 2024-12-23 15:17:13 -08:00
Sihua Ma 765df11c2e Merge "Remove disruptive announcement after widget resize" into main 2024-12-23 15:16:29 -08:00
Sihua Ma 32f5d08555 Merge "Remove disruptive confirmation announcement when dropping icon" into main 2024-12-23 15:10:59 -08:00
Shamali P ed5b8ea05f Remove page number announcement on carousel and set it on description
Others e.g. folder etc. will need to handle it separately, so, didn't
update pagedView.

Bug: 383252838
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I43f3818afcdaa4d4805df2af0890b970d71db9a7
2024-12-23 07:58:56 -08:00
Shamali P 9753481abb Remove disruptive announcement when widget is added
Bug: 383423227
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I59aa0c226f197c3e25c50738230ce8c070f7f483
2024-12-23 07:58:46 -08:00
Holly Jiuyu Sun 3bfeb56eca Merge "[a11y] Do not announce "item added to homescreen" after adding web shortcut." into main 2024-12-20 15:05:35 -08:00
Sihua Ma 4cc729ebca Remove disruptive announcement when exiting folder
Accessibility announcement needs to be disabled when folder is closing

Test: Manual
Flag: EXEMPT bug fix
Fix: 383248901
Change-Id: Ie6077a1214c234946bc9fb59ce54dfa7107188bd
2024-12-20 22:06:38 +00:00
Sihua Ma 4ccf8e2957 Remove disruptive home screen announcement when scrolling
Test: Manual
Flag: EXEMPT bug fix
Fix: 383247157
Change-Id: I8470740af2720b328a358a21507270a4735a53a4
2024-12-20 19:07:56 +00:00
Sihua Ma eddeb21b60 Remove disruptive announcement after widget resize
Fix: 383450007
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I9f48970d24fdb425c8e3da40d4a66195bd13dd30
2024-12-20 18:25:33 +00:00
Charlie Anderson 7db906a5ec Merge "Put shape options for picker behind it's own flag" into main 2024-12-20 06:16:24 -08:00
Treehugger Robot 89c4752aa3 Merge "Add Debug Logs to AllAppsStore's dump for Bitmap flags" into main 2024-12-19 17:31:51 -08:00
Willie Koomson b2cd3659b6 Merge "Dismiss resize frame before adding widget with add button" into main 2024-12-19 17:27:22 -08:00
Sihua Ma 41963ef6b2 Remove disruptive confirmation announcement when dropping icon
Bug: 383643519
Flag: EXEMPT bug fix
Test: Manual
Change-Id: I995a4a68f55f3de77cadf3eee20f72c0edb824f2
2024-12-20 00:08:31 +00:00
Charlie Anderson be6f04b11a Put shape options for picker behind it's own flag
Test: presubmit && locally verified switching flags
Flag: com.android.launcher3.enable_launcher_icon_shapes
Bug: 376293447

Change-Id: If2fb8b6dcdcfcaf6ba0f6f1acef45d5bf2b327cb
2024-12-19 17:34:08 -05:00
Stefan Andonian a87a57277d Add Debug Logs to AllAppsStore's dump for Bitmap flags
Bitmap flag state determines whether or not the work badge is shown.
Sometimes, it is not present when it should be. This state is necessary
for determining why the badges are not showing.

Bug: 377618519
Test: Verified that the logs don't crash the app when they are printed. Used command: adb shell dumpsys activity com.google.android.apps.nexuslauncher.NexusLauncherActivity | grep -A 68 "AllAppsStore"
Flag: EXEMPT bug logs
Change-Id: Ia52ae49cdf9dcfda7ffbef1e7c71f2a17782fbae
2024-12-19 12:09:08 -08:00
Holly Sun 52b5d3b4f0 [a11y] Do not announce "item added to homescreen" after adding web shortcut.
Bug: 383457529
Test: manual
Flag: EXEMPT talkback bug fix
Change-Id: I3fe331b17e51e208e2b5ce74be88e35c2b802077
2024-12-19 11:22:58 -08:00
Charlie Anderson 4c89531f9d Merge "cleanup misleading logs around restore and grid migration" into main 2024-12-19 11:03:37 -08:00
Charlie Anderson 9654c08d9d cleanup misleading logs around restore and grid migration
Bug: 378684472
Test: N/A just logs
Flag: EXEMPT just logs
Change-Id: I756ef1926810852453bbc00e6dcf02eec4f8955b
2024-12-19 11:06:42 -05:00
mpodolian 226ed8143d Shift transient taskbar to ensure 12dp distance with the bubble bar.
Shift the taskbar to fulfill the 12dp distance if the distance between
the taskbar and the bubble bar is below this threshold.

Fixes: 376929094
Test: TaskbarViewControllerTest
Test: Manual. Test that the transient taskbar shifts properly.
Increased the minimum distance to 120 dp and verified that the taskbar
shifts correctly. Moved bubbles side to side, confirming the taskbar
follows. The return-to-home-screen animation to the hotseat plays as
expected from either side.
Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/bJZ8PclmltZu7IupvBFrLn
Test: Manual. Test that the transient taskbar stashes properly.
Increased the minimum distance to 120 dp and verified that the taskbar
shifts correctly. Go to any application. Stash and un-stash the taskbar.
Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/hCGRhUgIqvcehOrTQ2Ulvj
Test: Manual. Test that the transient taskbar pin/unpin properly.
Increased the minimum distance to 120 dp and verified that the taskbar
shifts correctly. Pin/unpin the taskbar.
Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/f3fy5JKVZAk4wLCpVra4DK
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: Id4bd713da93053f90d9c2be8503dc93531a03b29
2024-12-18 15:51:37 -08:00
Ana Salazar Maldonado bc2b3ae3b0 Merge "Fix Title padding for the contrast tile" into main 2024-12-18 15:24:04 -08:00
Sebastián Franco f07079d0ff Merge "Revert^2 "Making sure that test go to FixedLandscape on landscape"" into main 2024-12-18 14:16:08 -08:00
Treehugger Robot a429476ec6 Merge "If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name" into main 2024-12-17 15:38:17 -08:00
Ana Salazar Maldonado e3f421211e Fix Title padding for the contrast tile
When drawing the pill, after the pill surrounds the text, add
horizontal_padding on each side instead of round_rect_padding. This is
the correct value since it is the space between the tile and the text.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I48521dc05c04b561b271aa589712ed493af63189
2024-12-17 14:45:42 -08:00
Sebastián Franco 12c346fbab Revert^2 "Making sure that test go to FixedLandscape on landscape"
This reverts commit d98bb0b979.

Reason for revert: b/383917141

Change-Id: I503fd7136b927064a54e428e422335c06e221e2e
2024-12-17 11:19:29 -08:00
Stefan Andonian fa1b2ba983 If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name
Bug: 356096502
Test: Verified locally that if you hard-code the PINNED shortcut query to not return data, the backup query still allows the deep shortcuts to show up on the home screen.
Flag: EXEMPT bug fix
Change-Id: I7a9b2d2c3be2ecce38a5af71951f1a12bc1c20ee
2024-12-17 18:06:48 +00:00
Treehugger Robot d3f591f614 Merge "Prevent bad grid configuration by making sure RestoreDbTask updates IDP correctly." into main 2024-12-16 22:06:32 -08:00
Treehugger Robot 254ba3092e Merge "Handle cancelled All Apps transitions." into main 2024-12-16 19:33:00 -08:00
Charlie Anderson 3eec1895ed Prevent bad grid configuration by making sure RestoreDbTask updates IDP correctly.
IPD#reset() was resetting the internal IDP dbFile to the factory default instead of current grid/db

This lead to LoaderTask and grid migration creating an empty DB for the wrong grid size, while the restored DB remained unused. Leading to an empty home screen because an empty DB file was used.

Bug: 377510898
Flag: EXEMPT bugfix
Test: manually testing backup & restore with various grid sizes
Change-Id: I709201e484afb8f12a4fde21198d2c5793d89ca1
2024-12-16 14:39:41 -08:00
Brandon Dayauon 9f481bb2ea Merge "Fix swipe up to home gesture when entering scheduler page" into main 2024-12-16 13:07:04 -08:00
Treehugger Robot eeebf0111b Merge "Don't allow drag n drops to auto-switch pages during accessibility item moves." into main 2024-12-16 09:36:34 -08:00
Andy Wickham f6850bd4f2 Handle cancelled All Apps transitions.
Previously if this was cancelled mid-animation, the background
panel could get stuck on the screen.

To reproduce this consistently, I automatically cancelled the
animation 50ms after it started. Here's how that looked:
 - Before: https://drive.google.com/file/d/1tiW7mFehk3of-qYe1_HBZSmJLjU4VVmv/view?usp=drive_link&resourcekey=0-tH7YccjcNuXe8qKaL_8H2w
 - After: https://drive.google.com/file/d/1XpRy8FusaSZkJTGa7FHhUuqMUHkeI_UA/view?usp=drive_link&resourcekey=0-gvoyXE3puv7lW78kgKLEng

Fix: 383731295
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I9423b75800a002419a56a3fe3f93b2e7350aeaa0
2024-12-13 17:59:32 -08:00
Mykola Podolian 19e6afa1f6 Merge "Align the adjusted hotseat drop animation with the hotseat" into main 2024-12-13 17:13:30 -08:00
Wen-chien Wang ad0b62daad Merge "pin-shortcut: Add pin shortcut to the context menu" into main 2024-12-13 17:00:42 -08:00
Stefan Andonian 0f4e5e974d Don't allow drag n drops to auto-switch pages during accessibility item moves.
Bug: 379798547
Test: Manually tested this on device.
Flag: EXEMPT bug fix
Change-Id: Ic19a0d167525d5500ed1dacd3dcaaa4550b11261
2024-12-13 16:11:08 -08:00
Wen-Chien Wang 2badfc7ebc pin-shortcut: Add pin shortcut to the context menu
This cl adds the pin shortcut option to the context menu, where
it works on Home launcher, hotseat, and pinned apps on the
taskbar.
Currently the option is a no-op.

Bug: 375648361
Test: Manual. Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I5d1284a6e909fd75f14e81c3ae713da3cdc01ce3
2024-12-13 22:49:52 +00:00
Treehugger Robot 5849df4002 Merge "[-1] Fix flicker of -1 when swipe up to exit -1 isn't fast enough" into main 2024-12-13 14:02:46 -08:00
Fengjiang Li b8b16bd288 [-1] Fix flicker of -1 when swipe up to exit -1 isn't fast enough
Fix: 381017761
Flag: NONE - released code
Test: manual - record a video
Change-Id: I5bda4a234cdcc8227d4feb9a92a174d07e46f7a2
2024-12-13 12:11:41 -08:00
Sebastián Franco 6f3213b260 Merge "Prevent Hotseat jank when switching Fixed Landscape setting" into main 2024-12-13 11:51:46 -08:00
Stefan Andonian 4e3d6a5d6e Merge "Log.wtf if DeleteDropTarget "canRemove", but doesn't remove item from the database." into main 2024-12-13 11:33:34 -08:00
Sebastian Franco f2b9190c64 Adding logs to see what is triggering rotation changes
Bug: 380940677
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I393232b410a4b961d3cbdd39766a403f994610e7
2024-12-13 11:08:43 -08:00
Sebastián Franco 24e9e55bca Merge "Setting mIsFixedLandscape as the first if condition while fixing 380940677" into main 2024-12-13 11:08:09 -08:00
Charlie Anderson 9a2e3a715b Merge "Add new failsafe to disable new archiving broadcast" into main 2024-12-13 07:33:49 -08:00
Sunny Goyal 18e480838a Replacing all int lookup flags and boolean overrides with an object to make it easier to extend options
Bug: 381897614
Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: Ic89d48dd1c5dc8b0a89b1898cd7b00d9c61d6513
2024-12-12 18:32:55 -08:00