Commit Graph

20057 Commits

Author SHA1 Message Date
Ana Salazar Maldonado f9884f20f3 Avoid drawing the launcher pill outside the view bounds
When drawing the launcher pill, the round rect corners may extend a little
beyond the view bounds.  Add a small padding for the round rect corners around
the text view to avoid drawing out of bounds for the view.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I41cd2ad9909081cb66751d7f03e52f03f8ae928b
2024-11-22 11:06:14 -08:00
Juan Sebastian Martinez a91fbb2efd Adding MSDL haptics for dragging app icons in Workspace and Hotseat.
The feedback occurs when an icon hovers over an empty available space in
Workspace and Hotseat, as well as over other icons to create folders.
This is now compliant with the Multi-sensory Design Language spec.

Test: manual. Verified haptics while dragging icons over Workspace and
  Hotseat.
Test: manual. Verified haptics with adb shell dumpsys of Launcher and
  checking the MSDL token history.
Flag: com.android.launcher3.msdl_feedback
Bug: 371314631

Change-Id: I7d039ddf9d05faa39a6e6e3f9a84217d8916adc0
2024-11-22 10:31:18 -08:00
Juan Sebastian Martinez 12c5b06add Merge "Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest." into main 2024-11-22 18:21:05 +00:00
Treehugger Robot 05e02fae43 Merge "Add logs for grid migration" into main 2024-11-22 15:52:00 +00:00
Treehugger Robot f2f8cd7536 Merge "Remove redundant a11y announcement upon removal of workspace item." into main 2024-11-22 15:49:35 +00:00
Pinyao Ting 604ae3283c Remove redundant a11y announcement upon removal of workspace item.
When a workspace item is removed, launcher currently shows a Snackbar which contains a message saying "item removed". This renders the a11y announcement in DeleteDropTarget#onAccessibilityDrop redundant since it's saying exactly the same string.


Bug: 378032433
Change-Id: Iaf3b42404ecd382b1ee15f670cc4ebe0124218d2
Test: manual
Flag: EXEMPT bugfix
2024-11-22 00:34:03 +00:00
Brandon Dayauon 90ff53775a Merge "Fix keyboard staying up in AOSP launcher." into main 2024-11-21 22:06:11 +00:00
fbaron 4f1e64c8e6 Add logs for grid migration
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: n/a it's just logs
Change-Id: Icce21f507e07adfd954fd88634bdd7f0becf4a4c
2024-11-21 13:59:39 -08:00
Juan Sebastian Martinez 86f3d35839 Adding a mock for MSDLPlayerWrapper to DeleteDropTargetTest.
The mock makes sure we don't rely on a device hardware for tests.

Test: DeleteDropTargetTest
Flag: com.android.launcher3.msdl_feedback
Bug: 379958544
Change-Id: I202b81f3dd16af1c0985980d0b962be0000bf31f
2024-11-21 13:32:43 -08:00
Marcelo Arteiro bc02103a6a Migrate materialColor* attributes into colors
TLDR:
* This change should not break anything or change any color.
* Simplifies theming and styling while improving developer experience.
* With this  developers can often skip styling for color entirely, while ensuring consistency and preventing accidental overrides.

Bug: 374273611
Test: presubmit
Flag: EXEMPT bugfix
Change-Id: Id19038078e83c73847b1a7c686c3a3df1ecccac2
2024-11-21 13:08:11 +00:00
Sebastian Franco cb8f82a9fd Remove Allow Rotation in foldables
Fix: 380128987
Flag: com.android.launcher3.one_grid_specs
Test: NA
Change-Id: I4bdb495b57fa7d638dde3fe47e853f3505f63628
2024-11-20 15:42:43 -08:00
Brandon Dayauon c2f4537495 Fix keyboard staying up in AOSP launcher.
The keyboard doesn't close when swiping down from A-Z list. So in Launcher when going to any state from A-Z getAPpsView().reset() gets called which eventually
calls resetSearch() where we can hideKeyboard.

bug: 379052503
Test: before in bug
after: https://drive.google.com/file/d/11oVTvkBtj9rECEtz4IVH1tURaJz6pFTO/view?usp=sharing
Flag: NONE bug fix
Change-Id: I707bf5dc2f81d5e83e869e34de674ef7fc065486
2024-11-20 14:30:41 -08:00
Schneider Victor-tulias 602dc74c5b Merge "Fix broken first gestures when using recents window" into main 2024-11-20 21:13:34 +00:00
Schneider Victor-Tulias c14e143338 Fix broken first gestures when using recents window
The first gestures fail to finish the recents animation controller when using the recents window tracker. This change fixes several test failures and makes gesture nav more stable on launcher restart.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 377679001
Test: TAPL tests
Change-Id: I617a27238a834dc734c9ae036045f159b06fd004
2024-11-20 11:44:19 -05:00
Juan Sebastian Martinez 9241d291aa Merge "Adding MSDL history to Launcher's dump information." into main 2024-11-20 16:11:03 +00:00
Treehugger Robot 5b1796daeb Merge "Fix inaccurate ItemInfo.id from DatabaseHelper with AtomicInteger" into main 2024-11-20 07:05:50 +00:00
Fengjiang Li be930c838f Fix inaccurate ItemInfo.id from DatabaseHelper with AtomicInteger
We can have both bg and UI threads accessing DatabaseHelper to read/write mMaxItemId, thus we should use AtomicInteger to avoid producing duplicated id, which will fail ModelWrite#checkItemInfoLocked

Fix: 379490918
Test: presubmit
Flag: NONE - crash fix
Change-Id: I6cebbb7e854a9eb48ff59b61f5ebba42ea449ec7
2024-11-19 21:18:26 -08:00
Juan Sebastian Martinez 4c35e50dd4 Adding MSDL history to Launcher's dump information.
The history displays the latest tokens played. Useful for testing and
debugging.

Test: presubmit
Flag: NONE MSDL playback is flagged case by case.
Bug: 377496684
Change-Id: I163889ade9fe4dee7f02459d2d9d81b94197bea1
2024-11-19 15:44:39 -08:00
Juan Sebastian Martinez 3f0d356619 Merge "Adding MSDL feedback to dragging apps and widgest over drop targets." into main 2024-11-19 15:58:35 +00:00
Sebastián Franco 3448777679 Merge "Changing name of RowCount to GridDimension to be more general" into main 2024-11-19 05:36:43 +00:00
Shamali Patwa d2cc1f0577 Update the enforce_system_radius_for_app_widgets flag's type
Renamed to use_system_radius_for_app_widgets since metadata cannot be updated after submitting definition.

Bug: 373351337
Test: N/A flag metadata update
Change-Id: I25283b05341517f5984b0f2fc0d27efe8027a3de
Flag: com.android.launcher3.use_system_radius_for_app_widgets
2024-11-18 21:58:48 +00:00
Jeremy Sim ec788cb24d Merge "Migrate away from listening for main/side specific stage types" into main 2024-11-18 18:41:38 +00:00
Sebastián Franco fefe9bbd12 Merge "Making the QSB align in Fixed Landscape" into main 2024-11-18 18:34:00 +00:00
Ana Salazar Maldonado 933baa72cf Merge "Draw contrast tile around the text" into main 2024-11-18 18:20:56 +00:00
Liana Kazanova (xWF) bd5afcfdda Merge "Revert "Remove redundant a11y announcement upon removal of workspace item."" into main 2024-11-18 17:24:25 +00:00
Charlie Anderson 6edad19ce2 Merge "Clean up usage of FileLog, and some logging related to B&R" into main 2024-11-18 14:23:09 +00:00
Johannes Gallmann cd46d978bd Merge "Never scale navbar scrim in all apps and widget picker" into main 2024-11-18 08:20:46 +00:00
Brandon Dayauon 519be86c57 Merge "Add perfetto traces to privateProfile CUJs" into main 2024-11-18 06:41:43 +00:00
ESWAR MAGATAPALLI (xWF) 9707b2cd0d Revert "Remove redundant a11y announcement upon removal of workspace item."
This reverts commit 556db6df04.

Reason for revert: Droidmonitor created revert due to b/379322118. Will be verifying through ABTD before submission.

Change-Id: Iece717248c63b3b8dabcdf1c413309d24f51c37f
2024-11-18 02:40:15 +00:00
Himanshu Gupta dad333da84 Merge "Handle Quiet Mode for Work Profile gracefully when Pixel Launcher is not default." into main 2024-11-17 16:57:15 +00:00
Treehugger Robot ebe64c7cc2 Merge "Add new heuristic for deciding whether we should add extra rows on grid migration to the bottom or top of the grid" into main 2024-11-16 00:55:02 +00:00
Sebastian Franco 5353cd8626 Making the QSB align in Fixed Landscape
Fix: 378959186
Fix: 378959255
Bug: 364711735
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I36612949006f12929cdc5b21f27f20ebc9751201
2024-11-16 00:39:44 +00:00
Fengjiang Li f6f4c18ff9 Merge "Revert "Revert AllAppsRecyclerViewPoolTest.kt"" into main 2024-11-16 00:09:23 +00:00
Vinit Nayak 49282f8ecc Migrate away from listening for main/side specific stage types
Bug: 349828130
Flag: com.android.wm.shell.enable_flexible_split
Test: Manual, incremental change, not stable yet.
Works fine with flag off

Change-Id: Ief1a41fb9f32cd99266f0ac73b17d5676ead042a
2024-11-15 23:57:46 +00:00
fbaron cdde399a00 Add new heuristic for deciding whether we should add extra rows on grid migration to the bottom or top of the grid
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: GridSizeMigrationTest
Change-Id: I070ed1eddc2c7ab475267268ebdbb2e559ab6dda
2024-11-15 13:44:01 -08:00
Charlie Anderson 859c793b6b Clean up usage of FileLog, and some logging related to B&R
Bug: 378684472
Test: N/A just logs
Flag: EXEMPT just logs
Change-Id: Ie2de7b700862b1439adc0c44d684b3864469014a
2024-11-15 16:38:27 -05:00
Ana Salazar Maldonado 3c44a029be Draw contrast tile around the text
If the BubbletTextView should have an app contrast tile, account for
some padding between the tile and the text when measuring the view, so
that the text is guaranteed to be inside of the bubble.  In a similar
way, recalculate the bounds of the tile to only surround the app title
as needed.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I9e8b149ade3fa4522e62b89c2332195f648b190f
2024-11-15 10:14:13 -08:00
Johannes Gallmann c87d41f369 Never scale navbar scrim in all apps and widget picker
The navbar scrim is scaled during the predictive back animation. This should be prevented since the navbar itself does not change it's position or scale.

Bug: 373544911
Test: Manual, i.e. verifying that the navbar scrim remains in its original position during the predictive back animation (with 3-button-nav) on phones and tablets
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: Iaffd31de5493dea8c856ad3d5b441cca066bbad8
2024-11-15 11:00:30 +00:00
Sebastian Franco 394a7e64f8 Changing name of RowCount to GridDimension to be more general
Bug: 364711064
Flag: com.android.launcher3.one_grid_specs
Test: HomeScreenImageTest
Change-Id: I7ca46babf0c4ce647a4c98a7dd0326b35450479f
2024-11-14 18:58:16 -08:00
Sebastián Franco 3b62b22651 Merge "Dissable allow rotation when oneGridSpecs flag is on" into main 2024-11-15 00:47:12 +00:00
Brandon Dayauon fc61ab973b Add perfetto traces to privateProfile CUJs
These traces cover onBind() and animation calls.

bug: 356777068
Test: screenshot of perfetto trace https://screenshot.googleplex.com/43tbo8fJrvTMUft
Flag: NONE adding traces
Change-Id: I06c322266ccb7ee9d940969f952aaaeb1b53c78b
2024-11-14 15:34:09 -08:00
Treehugger Robot 7bf8675679 Merge "Fixing LauncherAppCompoent not available for isolated context" into main 2024-11-14 22:24:00 +00:00
Treehugger Robot 90c4e9e62b Merge "Fix hotseat layout on device rotation." into main 2024-11-14 22:10:32 +00:00
Sebastian Franco 52ae78d11b Dissable allow rotation when oneGridSpecs flag is on
Flag: com.android.launcher3.one_grid_specs
Test: IntegrationReorderWidgetsTest
Bug: 378956572
Change-Id: I41e591b6d8fa1f93e2034a784516d5a38e83cbd9
2024-11-14 21:53:38 +00:00
Treehugger Robot b9cd487c86 Merge "Remove redundant a11y announcement upon removal of workspace item." into main 2024-11-14 21:04:04 +00:00
Sunny Goyal 5861ee437a Fixing LauncherAppCompoent not available for isolated context
In those cases, creating a new LauncherAppCompoent and storing it in
the application context

Bug: 372180905
Test: atest LauncherComponentProviderTest
Flag: EXEMPT bugfix
Change-Id: Ibf517a23801138b1fa18e8e4a7adbdedb994365b
2024-11-14 12:34:26 -08:00
Pinyao Ting 556db6df04 Remove redundant a11y announcement upon removal of workspace item.
When a workspace item is removed, launcher currently shows a Snackbar which contains a message saying "item removed". This renders the a11y announcement in DeleteDropTarget#onAccessibilityDrop redundant since it's saying exactly the same string.


Bug: 378032433
Change-Id: I6eda4bb449f1d1fd4441a68b3129b0ab2d2c19a3
Test: manual
Flag: EXEMPT bugfix
2024-11-14 17:29:26 +00:00
Liana Kazanova (xWF) 94f4f1bcf3 Merge "Revert "Listen to LauncherUserInfo config changes and hide/unhid..."" into main 2024-11-14 17:27:31 +00:00
Sebastián Franco 60f2aa328a Merge "Dissable fixed landscape on foldables until fixed b/378972567" into main 2024-11-14 16:25:51 +00:00
Fengjiang Li 8fa1dcdc03 Revert "Revert AllAppsRecyclerViewPoolTest.kt"
This reverts commit 6554ab99e3.

Reason for revert: Since ag/28600866 was the real fix of b/354560500, we should restore the AllAppsRecyclerViewPoolTest.kt

Fix: 359247985
Test: Presubmit
Flag: NONE - released

Change-Id: I54c3a4d15ec5a9e96cd03c465d10898ef6ac2078
2024-11-14 16:21:07 +08:00