Commit Graph

20057 Commits

Author SHA1 Message Date
Adnan Begovic 8d3eaf1a36 Merge "launcher3: Introduce onGridMigrationComplete callback." into main 2025-01-13 15:22:18 -08:00
Mykola Podolian fc8db9afc3 Merge "Shift transient taskbar to ensure 12dp distance with the bubble bar." into main 2025-01-13 12:52:21 -08:00
Adnan Begovic 4b9b9d7e40 launcher3: Introduce onGridMigrationComplete callback.
onGridMigrationComplete is invoked when grid migration
  successfully completes.

  ModelDelegate's can choose to observe this by overriding
  the callback.

Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Bug: 386802204

Change-Id: Iaca2e61a95c3d3decc12b2cc54461dba441202a0
2025-01-13 09:52:16 -08:00
Adam Cohen 8d4669a620 Merge "Add LauncherProvider interface to get and set current workspace layout via xml" into main 2025-01-10 16:36:25 -08:00
Sunny Goyal 0b01527d9a Removing shape detection in icon loader lib
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Iedec7bbcb8388e292050bbc0a94b21e74109def6
2025-01-10 14:02:00 -08:00
Treehugger Robot ce9ea2caef Merge "Simplifying IconShape" into main 2025-01-09 18:14:30 -08:00
Sunny Goyal 1138f5fe59 Simplifying IconShape
Removing various custom shapes and replacing it with a generic shape implementation. This works with any valid svg path.

Bug: 366237794
Flag: EXEMPT refactor
Test: atest IconShapeTest
Change-Id: I4665bc657b8bffc4d4efa30cebe00341b3140c55
2025-01-09 15:04:46 -08:00
Adam Cohen 295c520bcb Add LauncherProvider interface to get and set current workspace layout via xml
=> For prototyping purposes only. The method is protected by system|signature permission.
=> Uses the AutoInstall layout xml specification to allow for getting and setting the current launcher layout.

Test: manual via prototype apk
Flag: EXEMPT prototyping interface

Change-Id: I04dd29ee69db642095dfb5f6c4965cdb8509b05e
2025-01-09 12:28:42 -08:00
Sihua Ma e9f1c33f04 Merge "Add debug logs to folder open anim" into main 2025-01-09 09:27:08 -08:00
Alex Chau cb50273ad0 Merge changes Ic571a506,I0877cff7 into main
* changes:
  Reland "Introduce `mTaskViewCount` inside the RecentsView"
  Run the given callback only inside `runOnPageScrollsInitialized`
2025-01-09 02:49:23 -08:00
Treehugger Robot b49023dc3b Merge "Move all db calls for grid migration inside a SQLiteTransaction" into main 2025-01-08 16:56:24 -08:00
Sihua Ma a5d096b922 Add debug logs to folder open anim
Bug: 383526431
Flag: EXEMPT logs only
Test: None
Change-Id: Ib18d63e7f8ab194f8fda74aa99d99c9aa27f5f19
2025-01-08 22:53:53 +00:00
fbaron a94ecdfac0 Move all db calls for grid migration inside a SQLiteTransaction
Bug: 388564911
Flag: com.android.launcher3.one_grid_specs
Test: GridSizeMigrationTest
Change-Id: I22a373ea5b71a0713eeba37e8d09e09130eae525
2025-01-08 13:44:34 -08:00
minch a69673de08 Run the given callback only inside runOnPageScrollsInitialized
Let `PagedView.runOnPageScrollsInitialized` run the given callback only
instead of running all the current existing callbacks inside
`mOnPageScrollsInitializedCallbacks` once `mPageScrolls` has been
initialized.
All the existing callbacks will be run by
`PagedView.onPageScrollsInitialized` instead.
By doing this, we can avoid some unexpected crash while running
the pending callbacks in some scenarios. E.g., removeAllViews.

Flag: EXEMPT fix a regression
Bug: 385612978
Test: Manual
Change-Id: I0877cff752aabd1569dd54a9d04001687f90a5f6
2025-01-08 18:44:40 +00:00
Holly Jiuyu Sun 9d0cbfd689 Merge "Remove remaining "Item added to home screen" annoucement from talkback." into main 2025-01-08 10:15:49 -08:00
George Lin a1037f63a7 Merge "Return list of one default option when shape not enabled (1/2)" into main 2025-01-08 09:13:47 -08:00
Alex Chau 679d6a5240 Merge "Revert "Introduce mTaskViewCount inside the RecentsView"" into main 2025-01-08 02:28:37 -08:00
Treehugger Robot 2dbb255975 Merge "Maintain Talkback / Voice Access / etc. focus after moving item in Workspace." into main 2025-01-07 17:32:54 -08:00
Stefan Andonian 8a0f9b7f15 Merge "Fix ConcurrentModificationException in Folder by not sorting. Already done elsewhere." into main 2025-01-07 16:22:10 -08:00
minch 59440da093 Revert "Introduce mTaskViewCount inside the RecentsView"
Manually revert ag/30692743 because of a performance
regression tracking at b/385612978 .

Flag: EXEMPT as reverting
Bug: 385612978
Test: Manual
Change-Id: Iadcdc07588755ee47b6d6d37db08291aa707ecfe
2025-01-07 22:12:01 +00:00
Stefan Andonian 3593b6a9e2 Fix ConcurrentModificationException in Folder by not sorting. Already done elsewhere.
Bug: 385682296
Test: Verified locally that folder behavior remained identical to before.
Flag: EXEMPT bug fix
Change-Id: I9c3ca9aa456f0ac724f4f002a8ec0385f019ee0d
2025-01-07 13:43:41 -08:00
George Lin c6bdd4b181 Return list of one default option when shape not enabled (1/2)
This is to return a list of one default option (circle) if the shape
cutstomization flag is not turned on.

It resolves the issue that the selected shape option never emits.

Test: Manually tested
Fixes: 388299893
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I328efa370c1a741e8461dd9b37e37c138eb7e09f
2025-01-07 20:21:25 +00:00
Sebastian Franco f59d3de3c6 Using pixels instead of DPI for selecting the grid size
Fix: 383132640
Bug: 386479043
Test: Screenshot test
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ic3eda69324e03cc6f049cd7d21dac7ab6a22271e
2025-01-07 10:32:07 -08:00
Stefan Andonian 6284b233bf Maintain Talkback / Voice Access / etc. focus after moving item in Workspace.
Bug: 383456105
Test: Verified this works well manually.
Flag: EXEMPT bug fix
Change-Id: I35377443c4800a53cfa539c7061d5ef1b8b27837
2025-01-07 09:57:43 -08:00
Schneider Victor-tulias a4c8c7fafb Merge changes Iceb7c9cf,I1e802e67 into main
* changes:
  Fix NPE in LauncherSwipeHandlerV2Test.setup
  Update recents states sent to tests by RecentsWindowManager
2025-01-07 07:46:03 -08:00
Schneider Victor-Tulias 878b2af8ea Update recents states sent to tests by RecentsWindowManager
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 382527932
Test: Tapl tests
Change-Id: I1e802e6787570e781d59e61cf03ce62c8a1edb47
2025-01-07 10:41:17 -05:00
Sunny Goyal c369d1e4af Adding ThemeManager as a centralized place for controlling icon theming
Bug: 381897614
Flag: EXEMPT refactor
Test: atest ThemeManagerTest

Change-Id: Ib1dafdcc303f05f78cf586741c3d35243ab06e69
2025-01-06 21:53:22 -08:00
Charlie Anderson 239745aae9 Merge "Convert IconShape to Kotlin" into main 2025-01-06 14:59:26 -08:00
Treehugger Robot eb453571d9 Merge "Converting DesktopVisibilityController to a singleton" into main 2025-01-06 12:05:48 -08:00
Charlie Anderson 825bac83fa Convert IconShape to Kotlin
Bug: 387546047
Test: Just presubmit
Flag: EXEMPT no functionality change
Change-Id: I68029ec02690eaf7cb30a16f87fca71df7c2fd51
2025-01-06 13:39:46 -05:00
Sihua Ma 67db76e847 Merge "Change home screen state description to manifest page change" into main 2025-01-06 10:37:20 -08:00
Treehugger Robot 9817348151 Merge "Call AccessibilityDragListener immediately after Workspace's OnDragListener." into main 2025-01-06 10:09:53 -08:00
Uwais Ashraf b1f28aa75e Use Dispatchers.Main.immediate to run code quickly that runs on main.
immediate dispatcher schedules code on main (post{...}) if the current coroutine context is not main. However, if the coroutine context is main it will run synchronously without scheduling the work.

This removes all the continuations that come from initialisation of flow collectors.

Bug: 387511656
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Checking perfetto traces shows that this reduces the number of continuations on main by ~120 for 30 apps
Change-Id: I6c5ffba893e470c25d81f044f83cf43cb80588b8
2025-01-06 16:06:26 +00:00
Stefan Andonian fa8e3f9292 Call AccessibilityDragListener immediately after Workspace's OnDragListener.
This ensures that the dragInfo has not been set to null before the AccessibilityDragListener's
onDragEnd is called. Previously, this was breaking long accessibility moves.

Bug: 387563703
Test: Verified locally that this fixes the issue.
Flag: EXEMPT bug fix.
Change-Id: I8d25c3865a0a025a9dad341ea39062cb3658a763
2025-01-03 16:19:34 -08:00
Sunny Goyal 6d6529cff9 Merge "Converting LauncherPrefs to dagger" into main 2025-01-03 14:18:19 -08:00
Sunny Goyal e79d453bc8 Converting LauncherPrefs to dagger
Fixing ENABLE_TWOLINE_ALLAPPS_TOGGLE not properly tied to IDP:
http://recall/-/ep7WJ8pKwCEklUN5J1mAkM

Bug: 361850561
Flag: EXEMPT dagger-migration
Test: atest LauncherPrefsTest FakeLauncherPrefsTest
Change-Id: Iba63d060f4a8c2e31033fca2a4638c559c161338
2025-01-03 13:49:53 -08:00
Treehugger Robot c7ce8d588a Merge "Remove Widget Resize Border on Accessibility delete" into main 2025-01-02 18:25:19 -08:00
Stefan Andonian d3d62de59a Remove Widget Resize Border on Accessibility delete
Bug: 384446998
Test: Verified locally that this works as designed.
Flag: EXEMPT bug fix
Change-Id: Ib93e4d574ee5584b955b973005008708ca986ac6
2025-01-02 16:33:50 -08:00
Treehugger Robot fca7701858 Merge "WidgetResizeFrame doesn't disappear during Accessibility Widget Resize" into main 2025-01-02 16:31:18 -08:00
Sihua Ma 2bad402275 Change home screen state description to manifest page change
Bug: 383247157
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I1c2d3aa90d2b4ee9a1beaa4fbe7db57e79ae49dc
2025-01-03 00:00:48 +00:00
Stefan Andonian f1791fe5f0 WidgetResizeFrame doesn't disappear during Accessibility Widget Resize
Bug: 384446925
Test: Verified this works locally after reproducing it.
Flag: EXEMPT bug fix
Change-Id: If5db895358f05b24cb67f7b23d78aada6c79a80a
2025-01-02 14:33:21 -08:00
Treehugger Robot d4bfadf263 Merge "Fixing low res folder icon when preview changes" into main 2025-01-02 10:11:27 -08:00
Sebastián Franco ef414988cc Merge "Fix Widgets in portrait being restricted by landscape grid and vice-versa" into main 2025-01-02 09:50:02 -08:00
Treehugger Robot c3b0330292 Merge "Fix for bug where Talkback announce Folder:null" into main 2024-12-30 16:09:01 -08:00
Sunny Goyal 04b50a08f6 Fixing low res folder icon when preview changes
Also removing legacy for drawable sharing between folder-content and folder-icon, since preview now always creates new drawables

Flag: EXEMPT bugfix
Bug: 386842651
Test: atest PreviewItemManagerTest
Change-Id: Ib8e4b4d5be4fb0c9601b9d8e3cef8a29d6c77651
2024-12-30 15:47:17 -08:00
Treehugger Robot 7482e5cbe2 Merge "Fixing prediction ring color not getting updated if the icon changes while the slot animation is running" into main 2024-12-30 14:27:50 -08:00
Stefan Andonian 25283f0f45 Fix for bug where Talkback announce Folder:null
Bug: 385046797
Test: Verified this works locally.
Flag: EXEMPT bug fix
Change-Id: I9ad23f351df078b6bd40ff861e13b9109bfa8993
2024-12-30 14:01:28 -08:00
Sunny Goyal ad61173ca2 Converting DesktopVisibilityController to a singleton
This avoids a persistant connection to TouchInteractionService from WMProxy,
which keeps the service alive all the time

Bug: 384896306
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Id6fe59471c8c3f9874514f71126631f217ab610c
2024-12-30 12:54:19 -08:00
Sebastian Franco 5a9280203b Fix Widgets in portrait being restricted by landscape grid and vice-versa
Fix: 380049023
Test: Verified locally
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ie06a7eaa059d5b8e675a16da80dc03803d28ea2f
2024-12-30 14:42:37 -06:00
Treehugger Robot cdfec1a942 Merge "Replacing custom parcelables with platform types for test APIs" into main 2024-12-27 10:39:19 -08:00