Commit Graph

20057 Commits

Author SHA1 Message Date
Shamali Patwa 51a340a3c4 Merge "Fix issue that recommendations were visible in landscape mode." into main 2025-01-24 10:35:40 -08:00
Stefan Andonian 8a41c7c99b Merge "Add Logging for NotificationService Events in Launcher" into main 2025-01-23 17:02:04 -08:00
Adnan Begovic 2ac0f140b2 Merge "launcher3: Only translate on positive values." into main 2025-01-23 14:13:22 -08:00
Sunny Goyal 777324ed15 Removing redudntant objects from BgDataModel
Bug: 390572144
Flag: EXEMPT refactor
Test: Updated model tests
Change-Id: Ied8a0bfdbfd324b9fb05724f1fcf67238aa37d16
2025-01-23 12:55:37 -08:00
Treehugger Robot 0fc6cb470c Merge "launcher3: Add support for custom layouts in ArrowTipView." into main 2025-01-23 12:17:39 -08:00
Treehugger Robot ed5910ad52 Merge "Revert "Revert "Migrating RecentsAnimationDeviceState and depend..."" into main 2025-01-23 11:02:36 -08:00
Stefan Andonian a2db1356ba Focus on newly added app for all Accessibility use cases when adding an app to the home screen.
Bug: 377555526
Test: Verified that this works well for both this use case and for b/383456105's use case.
Flag: EXEMPT bug fix
Change-Id: I91426487f435d6c0b796cafe58b526c73dfaa398
2025-01-23 10:42:09 -08:00
Stefan Andonian 3ef8ffeaa8 Add Logging for NotificationService Events in Launcher
Bug: 362473999
Test: Verified that these logs show up on device
Flag: EXEMPT bug logs
Change-Id: Ib85fa5d57d0ff6fef456bfd816d21e41269eadbc
2025-01-23 10:02:18 -08:00
Treehugger Robot 11e4b589f6 Merge "Remove heuristic that determines whether to shift cells down or not" into main 2025-01-22 23:55:00 -08:00
Adnan Begovic 27772e9780 launcher3: Only translate on positive values.
Don't translate canvas on non positive values
  when utilizing delegate cell drawing.

Bug: 391731169
Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Change-Id: I44f51d40e5a6352e6d4eed2b9e475b2a37b6ea9d
2025-01-22 18:55:57 -08:00
Sunny Goyal a5fef475a5 Revert "Revert "Migrating RecentsAnimationDeviceState and depend..."
Revert submission 31416515-revert-31332401-recents-device-state-LXBUANUQFL

Reason for revert: Fixing build breakage and resubmitting

Reverted changes: /q/submissionid:31416515-revert-31332401-recents-device-state-LXBUANUQFL

Change-Id: I3b89356df57f1e7ff1a9e364c0d766578e23798c
2025-01-22 18:31:06 -08:00
Shamali P 7d64195793 Fix issue that recommendations were visible in landscape mode.
ag/30344959 showed the recommendations if available, to avoid the issue
of widgets list flashing when exiting search mode. However, we usually
hide recommendations in phone landscape due to the sticky header layout
not having enough space. In this fix, instead, we rebind recommendations
as before (to let the logic there decide whether to show or hide them),
and in order to fix the flashing problem that the earlier change was handling, we reset the recycler view.

Bug: 391231345
Flag: EXEMPT bugfix
Test: Manual, we don't have tests for interactions between screens
Change-Id: I535aa43cc553c9287c5d38ef7cde30f01e84d347
2025-01-22 16:19:35 -08:00
Federico Baron 8d3883def3 Remove heuristic that determines whether to shift cells down or not
We decided to always shift the cells down, so that the new row always
shows up at the top

Bug: 391697719
Test: GridMigrationTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id093e0d64e437bf218f942bfdf6d2f14ee875776
2025-01-22 23:19:43 +00:00
Adnan Begovic 3cabbe8f1d launcher3: Add support for custom layouts in ArrowTipView.
Allow overriding of various interfaces that allow a subclass
  of ArrowTipView to stipulate its own layout.

Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Bug: 388311172
Change-Id: Id42e2a18faf5ca6a4259c0e707f09584a6804cb0
2025-01-22 14:51:21 -08:00
Liana Kazanova (xWF) 9b0a007ae3 Merge "Revert "Migrating RecentsAnimationDeviceState and dependent obje..."" into main 2025-01-22 14:05:04 -08:00
Liana Kazanova (xWF) fa30e3fc0e Revert "Migrating RecentsAnimationDeviceState and dependent obje..."
Revert submission 31332401-recents-device-state

Reason for revert: DroidMonitor: Potential culprit for http://b/391684419 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:31332401-recents-device-state

Change-Id: I3986328ee3aa8ebb822f7ef05b9f80ef68872aef
2025-01-22 13:50:08 -08:00
Treehugger Robot 906aa39c47 Merge "Cleanup leftRightSplitInPortrait flag" into main 2025-01-22 12:29:12 -08:00
Vinit Nayak 56234dbfe1 Cleanup leftRightSplitInPortrait flag
Bug: 291018646
Change-Id: I2c801378c33ee62b5f6eabf2e9122dd7ae1a5ee0
Flag: EXEMPT removing flag
2025-01-22 08:28:40 -08:00
Sunny Goyal d7bfa76bcc Migrating RecentsAnimationDeviceState and dependent objects to Dagger
Bug: 361850561
Flag: EXEMPT dagger
Test: Presubmit

Change-Id: I2c45ec49a913abb0532e83b09e797012e06eb8c4
2025-01-21 23:53:02 -08:00
Charlie Anderson ad8b2ec13b Update usages of icon shapes in Launcher
Bug: 387546051
Test: manual
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I33725259b3480f6e3a2976c227ccdffcfd7d6f83
2025-01-22 02:37:08 +00:00
Vinit Nayak e7753eb796 Merge "Remove and cleanup AppPairs flag" into main 2025-01-21 12:20:55 -08:00
Treehugger Robot 399ca5a6f4 Merge "Add kill switch for ViewPool.initPool." into main 2025-01-21 02:22:21 -08:00
Treehugger Robot fd726c7ce8 Merge "Add logging for RDeps lifecycle and ViewPool.initPool to help debugging." into main 2025-01-21 02:20:38 -08:00
Uwais Ashraf 6322c00b70 Add kill switch for ViewPool.initPool.
This fixes an issue where, in fast E2E tests, the test can complete before initPool is completed. This results in the ViewPool continuing to create TaskViews and therefore TaskThumbnailViews after RecentsDeps is destroyed. Doing this causes a crash.

Stopping the ViewPool.initPool thread before destroying RecentsDeps fixes this.

Bug: 390156722
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: fast E2E tests in presubmit e.g. AllAppsImageTest
Change-Id: I0f8801ca75cda383df8ed96077cf1b7178771cb6
2025-01-21 08:06:23 +00:00
Uwais Ashraf e545182223 Add logging for RDeps lifecycle and ViewPool.initPool to help debugging.
Bug: 390156722
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: none - logging only change
Change-Id: I657194e79023598c17ca8b1885f98457f3d773a9
2025-01-21 08:03:54 +00:00
Schneider Victor-Tulias f8fa42be84 Fix test Dagger initialization deadlock in RecentsDisplayModel
WallpaperColorHints is a MainThreadInitializedObject that was causing a deadlock in RecentsDisplayModel initialization. Converting WallpaperColorHints to a dagger singleton.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit
Change-Id: Ib5b4eab27b4e28baf1208915fa7cf6dbd36bc1f5
2025-01-20 08:08:40 -08:00
Adam Cohen ea1c34bdcb Merge "Fix issue with AutoInstallsLayout Parser and user profile" into main 2025-01-18 11:56:09 -08:00
Adam Cohen dcc2e5d21f Fix issue with AutoInstallsLayout Parser and user profile
=> the profileId was only being added from the root workspace parser
=> instead, the profileId should be added at the individual item parser level

Flag: NONE small bug fix
Issue: 390674545
Test: manually verified using import / export

Change-Id: I76187b1210f282d1a0f8f4652a499d2472461d87
2025-01-17 13:27:00 -08:00
Jagrut Desai 6971afcd0b Merge "Fix Taskbar icon Accessibilty Focus on hovering" into main 2025-01-17 13:17:41 -08:00
Liran Binyamin e96bd71f50 Merge "Pass the user id for intent app bubbles" into main 2025-01-17 12:29:50 -08:00
Jagrut Desai 625b78ae13 Fix Taskbar icon Accessibilty Focus on hovering
The problem: ArrowTipView was TypeAccessible hence taking a focus away from taksbar icon. The hover event was getting consumer by onHover of the listener and not getting passed to view. Upon passing the hover event we see icon scale up. We don't want both icon to scale up and show
tootip when hovering.

The Solution: pass motion event to onHoverEvent for icon view and mark ArrowTipView to be not included as Accessible View. For disabling hove
ring for taskbar icon we introduced new field to track if hovering is enabled for display type for that icon.

Test: Manual, Presubmit
Bug: 284081291
Flag: EXEMPT bugfix
Change-Id: Ie02d17856b26f82887fd178ccf0a7351416cc43e
2025-01-17 09:57:38 -08:00
Sihua Ma 0413cfc05c Merge "Fix work badge theme issue" into main 2025-01-16 19:16:59 -08:00
Treehugger Robot 47b4339df5 Merge "Fix Talkback Announcement for Workspace Pages" into main 2025-01-16 17:21:33 -08:00
Sihua Ma 4a3aa354b8 Fix work badge theme issue
The work badges are being themed even though themed icon is disabled

Test: Manual
Bug: 390031380
Flag: EXEMPT bug fix
Change-Id: Ia25a58631d416face0bd1ca2e5f086324b579834
2025-01-16 16:39:56 -08:00
Adnan Begovic 3c4c268b4c Merge "launcher3: Add one grid edu to floating view." into main 2025-01-16 15:27:01 -08:00
Stefan Andonian e73541c30c Fix Talkback Announcement for Workspace Pages
Bug: 379649357
Test: Verified manually that the fixes work for announcements.
Flag: EXEMPT bug fix
Change-Id: I0a2e989eb34adbd975a7211d8334d264d64b3933
2025-01-16 15:19:04 -08:00
Mady Mellor f7f4c3c7ac Merge "Update code guarded by bubble anything flag to use the helper method" into main 2025-01-16 13:36:38 -08:00
Vinit Nayak 3456fcbe03 Remove and cleanup AppPairs flag
Test: Launcher compiles and runs
Bug: 274835596
Flag: EXEMPT cleanup
Change-Id: Iab8f17d444753df303ed1a09d6547917545e66f5
2025-01-16 14:02:55 -05:00
Treehugger Robot 22df0f9d20 Merge "Adding some source hints when generating theme icons" into main 2025-01-16 00:11:10 -08:00
Liran Binyamin 96dc022401 Pass the user id for intent app bubbles
When creating a new app bubble by long pressing on launcher icons,
pass the user id to wm shell so the bubble is created for the correct
user context.

Bug: 361173339
Flag: com.android.wm.shell.enable_bubble_anything
Test: atest BubbleAnythingTest
Test: manual
       - create work profile
       - long press on a work profile app icon -> Bubble
       - observe new bubble opens in the work profile context
Change-Id: Idb980bc6f74e85e85a9777f0d39e772b84feeb9c
2025-01-15 21:35:54 -05:00
Mady Mellor 7d97e96550 Update code guarded by bubble anything flag to use the helper method
Also adds a dependency on shared shell lib so launcher can use this.

Flag: com.android.wm.shell.enable_create_any_bubble
Test: manual - enable the create flag and check that bubble anything still
               works; same with bubble anything flag
Bug: 389737359
Change-Id: I18322512c9d9883ee5cf473b72df565adea85879
2025-01-15 17:04:10 -08:00
Adnan Begovic aacbfce7d1 launcher3: Add one grid edu to floating view.
Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Bug: 388311172

Change-Id: I0ea819d266af443d71ed22f5394b41a51202fa0b
2025-01-15 15:23:17 -08:00
Pat Manning 75769b7696 Start collecting task dismiss CUJ on dismiss animation start.
Bug: 385698952
Bug: 389653070
Test: OverviewTaskDismiss#dismissTask (Functional & microbenchmark test)
Flag: EXEMPT adding CUJ for existing recents
Change-Id: I8f68d05d2b701291e17ece5b38d2267adcbabae4
2025-01-15 13:30:53 +00:00
Sunny Goyal 01a976f210 Adding some source hints when generating theme icons
Bug: 381897614
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ief779bb04cd69372ec3acd4501e283f09de41b4d
2025-01-14 16:00:46 -08:00
Treehugger Robot bc3995222b Merge "Moving DisplayController to dagger" into main 2025-01-14 13:39:19 -08:00
Sunny Goyal 55dc2d1c31 Moving DisplayController to dagger
Separating various overrides to individual modules so that they can be reused in tests

Removing ContextualEduStatsManager and directly using SysUiProxy as all the usescases
are only in quickstep/
This avoids additional Module definition and delegation

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I096459d638553991ed01766002b874589c6b976e
2025-01-14 11:40:35 -08:00
Vinit Nayak 75d7e07844 Merge "Remove and cleanup splitContextual flag" into main 2025-01-14 09:39:59 -08:00
Charlie Anderson 3799932a38 Add ability to preview and apply shapes from Picker
Bug: 372887760
Bug: 372887555
Bug: 388579538
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Manually change icon shapes

Change-Id: Ie423306e3ae5ae8176898ff5ffc59b4b576c20f4
2025-01-14 07:24:52 -08:00
Vinit Nayak 3815a095f1 Remove and cleanup splitContextual flag
Bug: 276361926
Flag: EXEMPT removing flag
Change-Id: I6f567a8aae5b962f36ec2bc96b7fb05906b4ff2f
2025-01-14 10:23:59 -05:00
Treehugger Robot 3196197f41 Merge "Removing shape detection in icon loader lib" into main 2025-01-13 23:55:12 -08:00