Commit Graph

20057 Commits

Author SHA1 Message Date
Sunny Goyal 5bca45a739 Moving InvariantDeviceProfile to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Ia99ee031e96c5e6069a56fe90a262a533dd8665a
2025-02-11 15:22:18 -08:00
Treehugger Robot 0d9c54fc51 Merge "Make sure only old grids show up when the flag is off" into main 2025-02-11 13:52:38 -08:00
Sunny Goyal a48e22319e Converting LauncherIcons to kotlin
This will simplify migration to dagger

Bug: 361850561
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I1d806c51a49cea4a5c44788d2fc3b825c2da8bbd
2025-02-11 13:22:06 -08:00
Sebastian Franco e34f561224 Rotate Wallpaper Picker if in FixedLandscape
Bug: 382906719
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id4f29567899e4fec5585247077456eec5f343b98
2025-02-11 12:32:52 -06:00
ELIYAZ MOMIN (xWF) 31d6be8891 Revert "Moving TisBinder to its own class"
This reverts commit ce9ad064d6.

Reason for revert: <Potential culprit for  b/395855288  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted>

Change-Id: I12d1eb66ae03e2638a503c103d0b1fa8a863b6b5
2025-02-11 08:18:42 -08:00
Sunny Goyal ce9ad064d6 Moving TisBinder to its own class
> Using callback patter for various change events instead of routing it
  via  TIS

Bug: 386288280
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I95577d6a1c17103cb947ef1200c1c22b68fd1d9c
2025-02-11 00:21:51 -08:00
Treehugger Robot 7456651ed7 Merge "Updating ThemeManager to be extendible" into main 2025-02-10 17:20:26 -08:00
Brandon Dayauon 573fe8c72b Add logs to components in AllApps to verify click.
Adding logs for investigation to verify related bugs where work profile
may seem inactive but is supposed to be active. This also helps verify
if touch is being received.

Bug: 383301695
Test: manually- screenshot in bug
Flag: EXEMPT adding logs
Change-Id: I9f42d7013c8a127767b5cbcfbe5c416cebb2adbd
2025-02-11 00:58:31 +00:00
Federico Baron 72dc958b9f Make sure only old grids show up when the flag is off
XL and large grid icons were showing up with the flag off

Bug: 395139926
Test: ValidGridOptionsTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: If6b077ce854341563d8c2fbefd741b598b77a7a8
2025-02-11 00:13:21 +00:00
Brandon Dayauon 4498f095fe Merge "Fix shadow clipping in work FAB." into main 2025-02-10 13:21:59 -08:00
Cole Faust 04bff7b50c Merge "Replace .toList() with .collect()" into main 2025-02-10 11:59:47 -08:00
Sunny Goyal 835461a148 Updating ThemeManager to be extendible
Moving the themeController inside the iconState object

Bug: 381897614
Test: atest ThemeManagerTest
Flag: EXEMPT refactor
Change-Id: I190be0af3202e97808f5dbda30ad0ca811581881
2025-02-10 11:49:32 -08:00
Charlie Anderson 9a791b8f1a Merge "Revert^2 "Restore Archived Pinned Shortcuts instead of removing them."" into main 2025-02-10 08:57:11 -08:00
Treehugger Robot 628b37af3d Merge "Sort grid options in onegrid" into main 2025-02-07 14:48:16 -08:00
Treehugger Robot ff1fbcf177 Merge "Reorder shape options, making sure that the default Circle is first." into main 2025-02-07 13:31:17 -08:00
Treehugger Robot d633c4774b Merge "Fix issue where turning off fixed landscape goes to default grid" into main 2025-02-07 13:16:16 -08:00
Treehugger Robot 2d906e472c Merge "launcher3: Gate strict mode enablement behind flag." into main 2025-02-07 12:32:39 -08:00
Charlie Anderson ceb401c3e7 Revert^2 "Restore Archived Pinned Shortcuts instead of removing them."
This reverts commit f5cb1b664b.

Reason for revert: adding test fix and reverting

Change-Id: I2fc8dc83259b2ee7992ac2291df6ee4246a2e9d5
2025-02-07 12:14:55 -08:00
Federico Baron 8d9d81e4b2 Sort grid options in onegrid
We need to make sure that the new grid options are sorted by column
count from greatest to least

Bug: 395086953
Flag: com.android.launcher3.one_grid_specs
Test: manually verified
Change-Id: I94fbf0fe74fa7dfc92afc64be92cdf511b79e763
2025-02-07 20:13:41 +00:00
Brandon Dayauon b995cbe857 Fix shadow clipping in work FAB.
The reason is because the parent container having set clipped children
to true. It is already turned off for the fast letter scroll prototype
so we can probably just set to false all together.

Bug: 383299303
Test: manually-
before: https://drive.google.com/file/d/1GfJtmdX6RPi0QWlpjd1uBNGcDm_ePJko/view?usp=sharing
after: https://drive.google.com/file/d/1Lf6boBSeZ1ZcJ9M24S_JP6jzdUfov8kh/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile
Change-Id: I5060081f51a11dd34fd55afb75a5302759e16670
2025-02-07 19:24:59 +00:00
Charlie Anderson 4f23162f77 Reorder shape options, making sure that the default Circle is first.
Bug: 394885877
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: manually verifying options
Change-Id: I85e9b56f6ede3b5a367e6833fa51ce5962f42883
2025-02-07 18:57:31 +00:00
Federico Baron 54b09dc41f Fix issue where turning off fixed landscape goes to default grid
Bug: 390091751
Test: manually verified on device
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id9de8cadc6fc1ee0ac0124638b2c487b8f8357bb
2025-02-07 09:22:42 +00:00
Treehugger Robot 026930cd14 Merge "Use pinned taskbar with desktop tasks on freeform displays" into main 2025-02-06 19:37:47 -08:00
Brandon Dayauon b30bb197d1 Fix focusability of web suggest via talkback
The reasson is due to shortcut flow not having sent an accessibility
event. Shortcuts adding to home can use the same flow of how apps are
added to home by using bindInflatedItems() with an animation
endCallback(). This change should be fine since addInScreen() is called
in bindInflatedItems() too.

Bug:383461209
Test:Manually video- https://drive.google.com/file/d/1y3CslaIvRQMsODlQCYnGtG0Im4t7p4rR/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I3b88b5ee40b4bcd43a83d362b6cbb0925120b700
2025-02-07 02:34:16 +00:00
Charlie Anderson 2ffea06040 Merge "Resizes shaped icons based on selected shape" into main 2025-02-06 16:26:37 -08:00
Daniel Andersson 4899bc2c80 Merge "desktop-exploded-view: Initial implementation" into main 2025-02-06 14:51:31 -08:00
Charlie Anderson c902340594 Resizes shaped icons based on selected shape
Bug: 372905360

Test: Manual verify specs
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ia73fde0f493235004ed577738696c8be98a290f7
2025-02-06 12:32:47 -08:00
Winson Chung acca04d897 Merge "Move multi-instance suppport checking to ApiWrapper" into main 2025-02-06 08:17:55 -08:00
Treehugger Robot d026b7be7e Merge "Fixing ProxyPrefs not removing values correctly" into main 2025-02-05 20:49:02 -08:00
Sunny Goyal c9d9e335a4 Fixing ProxyPrefs not removing values correctly
Bug: 394600803
Flag: EXEMPT bugfix
Test: atest ProxyPrefsTest
Change-Id: Icb116df1826e9538c929a08f4e8afc32d1b1f183
2025-02-05 18:49:54 -08:00
Daniel Andersson 66288ed6fa desktop-exploded-view: Initial implementation
This is an initial implementation of the desktop exploded view. The
layout algorithm (implemented in OrganizeDesktopTasksUseCase) is
currently a basic placeholder.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 367353392

Change-Id: I6826a2583a3e0027c809d4fd3b9bab716f2f3b72
2025-02-05 15:56:27 -08:00
Adnan Begovic 2eb151771c launcher3: Gate strict mode enablement behind flag.
Bug: 394651876
Flag: com.android.launcher3.enable_strict_mode
Test: Manual
Change-Id: I973dacbfac1fbcd889c503623df948c8fde379dd
2025-02-05 15:32:40 -08:00
Sebastian Franco 2164771130 Fix null ptr exception on createUpdateRunnable lambda
Fix: 394043832
Test: NA
Flag: EXEMPT bugfix
Change-Id: I60b85c520e7553318ea741da8768951c974dcc7e
2025-02-05 13:38:31 -08:00
Charlie Anderson 8107a6ea07 Merge "Remove spammy log in LoaderTask" into main 2025-02-05 12:44:21 -08:00
Charlie Anderson 53dcfdf963 Merge "Fix folder morphing animation" into main 2025-02-05 11:42:59 -08:00
Adnan Begovic beeaaa2185 Merge "launcher3: Amend strict mode policy to account for activity leaks." into main 2025-02-05 11:03:19 -08:00
Charlie Anderson ade47d530b Remove spammy log in LoaderTask
Bug: N/A
Test: presubmit
Flag: EXEMPT just logging
Change-Id: I82f87ce2ed1e27bb72c6d4c9f3b426374f3fc777
2025-02-05 18:06:36 +00:00
Charlie Anderson 5c7ef0b01e Fix folder morphing animation
- Also splits interpolator between open / closing anim to setup future folder motion work
  - Also fixed bug if no shape selected in picker

Bug: 393979768
Bug: 387543793
Test: Manual verify animation and picker bug
Flag: com.android.launcher3.enable_launcher_icon_shapes

Change-Id: Ieb7355b9128cd1ded46af6787f5c14baf9be6774
2025-02-05 09:44:22 -08:00
Winson Chung 4443ff10f6 Move multi-instance suppport checking to ApiWrapper
- It's only used for App Pairs & Taskbar (both limited to quickstep
  launcher, and we need to use hidden api to query the multi-instance
  support per-activity.  This is necessary as there can be apps
  installed for a profile, but not the primary user.

Bug: 391611065
Flag: EXEMPT bugfix
Test: atest WMShellUnitTests
Test: Install a multi-instance app only for the non-primary user,
      ensure that we can see the multi-instance UI for these apps

Change-Id: I9d38f32aa38b27b2bffaa744c3f578423f7c7d86
2025-02-05 07:56:36 +00:00
Liana Kazanova (xWF) 43032a5a61 Merge "Revert "Restore Archived Pinned Shortcuts instead of removing them."" into main 2025-02-04 16:26:27 -08:00
Liana Kazanova (xWF) f5cb1b664b Revert "Restore Archived Pinned Shortcuts instead of removing them."
This reverts commit abbb991d8f.

Reason for revert: DroidMonitor: Potential culprit for Bug X - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ifa241a631a1a4361623cfe0e81e31ca6b44e9d73
2025-02-04 15:37:46 -08:00
Adnan Begovic 3d29c0a062 launcher3: Amend strict mode policy to account for activity leaks.
detectActivityLeaks() will identify any cases where subclasses
  of Activity are leaking.

Bug: 392635961
Test: EXEMPT debug code
Flag: EXEMPT debug code
Change-Id: I28057738a7bb8951a39152f4a4e6954bd2b97706
2025-02-04 14:08:37 -08:00
Charlie Anderson 9eb29e78b5 Merge "Restore Archived Pinned Shortcuts instead of removing them." into main 2025-02-04 13:35:30 -08:00
Toni Barzic 860c4ee680 Use pinned taskbar with desktop tasks on freeform displays
Bug: 390665752
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: manual on desktop device. verify correct taskbar is shown
      on home screen, in overview, in desktop mode, with fullscreen
      app shown. Verify opening/launching apps from taskbar works
      as expected.

Change-Id: I5c1e21799609c28ec44cc190bfc681934907199f
2025-02-04 13:00:37 -08:00
Treehugger Robot 3b11538381 Merge "Simplifying some ActivityContext and StateManager methods" into main 2025-02-04 12:16:44 -08:00
Charlie Anderson abbb991d8f Restore Archived Pinned Shortcuts instead of removing them.
Bug: 375414891
Test: ShortcutsChangedTaskTest, WorkspaceItemProcessor test and manually backing up + restoring.
Flag: com.android.launcher3.restore_archived_shortcuts

Change-Id: I798d56bc1ffef9a454e3899e4155d63f7edf39f2
2025-02-04 11:29:29 -08:00
Brandon Dayauon a0f2b0eeb0 Merge "Log work scheduler animation jank" into main 2025-02-04 10:52:19 -08:00
Sunny Goyal 1ada394e00 Simplifying some ActivityContext and StateManager methods
> Merging asContext and getContext meethod
> Simplifying some generic declaration in StateManager

Bug: 393703968
Flag: EXEMPT refactor
Test: Compilation
Change-Id: I679ac83e39b2a17f510698db15335aae8f735aad
2025-02-04 10:11:34 -08:00
Treehugger Robot d3b31eb20d Merge "Removing BaseDraggingActivity > Merging come methods to BaseActivtiy > Separating wallpaper theme implementation to an independent class" into main 2025-02-04 09:29:46 -08:00
Sunny Goyal edc1453cf1 Removing BaseDraggingActivity
> Merging come methods to BaseActivtiy
> Separating wallpaper theme implementation to an independent class

Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I8cdb6d1520beff3f8226b62c5b7eafd48b2c674f
2025-02-03 17:23:10 -08:00