Commit Graph

78507 Commits

Author SHA1 Message Date
Tracy Zhou bcdde0d1a6 Merge "Use KeyButtonRipple for button nav" into main 2024-01-09 02:42:08 +00:00
Android Build Coastguard Worker 4f89f66ac6 Snap for 11286711 from 10ac692f9d to 24Q2-release
Change-Id: I21a8fe91d36c9e40d10388740df96e71d2a0ecd2
2024-01-09 00:21:31 +00:00
Sunny Goyal fdeb19e02c Simplifying pending widget inflation path
Instead of adding a PendingView in appWidgetHost, attaching a
listener in PendingView for widget-updates.

This moves the view inflation as the last stage of widget
binding. Eventually we can separate the model update and view
inflation to different threads

Bug: 318539160
Test: atest TaplBinderTests
Flag: None
Change-Id: I124edaa9622fa367302b80969036d128a978396e
2024-01-08 15:52:50 -08:00
Sunny Goyal 3c52d93131 Merge "Fixing broken build" into main 2024-01-08 23:48:52 +00:00
Jordan Silva 2de6a277b7 Update responsive grid spec cell size remainderSpace logic
Refactoring the cellSize spec of responsive grid to divide the remainder space in code instead of dividing by cols/rows in the spec definition. For example, instead of using 0.2 in the spec for 5x5 grid (1 / number of rows), it is going to use 1 (100% of the remainder space) and divide the percentage by the number of cols or rows in code.

Fix: 313621277
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: NexusLauncherImageTests
Test: CalculatedWorkspaceSpecTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: Ifaec838ac9751562ecedc1fe39b966ee3d092de3
2024-01-08 19:40:01 -03:00
Vadim Tryshev 10ac692f9d Merge "Waiting for AllApps state when clicking Qsb" into main 2024-01-08 21:29:46 +00:00
Schneider Victor-tulias 5bc6a0aa1f Update KQS task launch animation
Updated the KQS app launch animation to match the spec: translate the launching app from the left (right in RTL) and translate the closing app to the right (left in RTL)

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313606549
Fixes: 313607264
Test: launched tasks from KQS from home and launched app
Change-Id: I0e903c741e4f930b377607b7eaf42a87177c3eb6
2024-01-08 16:19:17 -05:00
Vadim Tryshev 0896b68cb5 Merge "Removing dependency of All Apps test from 1P apps" into main 2024-01-08 20:39:45 +00:00
Vadim Tryshev f912287c8a Merge "Waiting for Recents activity to stop after starting apps" into main 2024-01-08 20:13:39 +00:00
Tracy Zhou f46729fd23 Use KeyButtonRipple for button nav
- Matched ripple style
- Matched ripple bounds

Bug: 230395757
Test: Ripple looks the same as the one using navigation bar
Change-Id: I58c773b1f767fb8b0f2570bc4603ea953d589560
2024-01-08 11:54:48 -08:00
Tony Wickham a3daee40f3 Merge "Update kotlin formatting for TaskbarInsetsController" into main 2024-01-08 19:10:24 +00:00
Brandon Dayauon 4f673d2517 Merge "Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW" into main 2024-01-08 18:00:05 +00:00
Jordan Silva dd612687cc Step down icon size when isVerticalBarLayout for responsive grids
Fix the icon step down logic to resize the icons to fit when isVerticalBarLayout and the iconSize does not fit inside the cellHeight.

Bug: 316087877
Bug: 314285621
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I3a1fd28b729435eaf2dbbff650e4d13d33d77ff8
2024-01-08 14:09:23 -03:00
Sunny Goyal 87ad18b667 Fixing broken build
Bug: 319078785
Test: atest TaplPromiseIconUiTest
Flag: N/A
Change-Id: Ie8a11c4928f4b33a631de951e7cc62b5511e2e98
2024-01-08 09:04:10 -08:00
Uwais Ashraf aa9e98b5d7 Hardcode ActionBar height to avoid changes while emulating
Test: Presubmits passing
Bug: 284210693
Flag: NA
Change-Id: If3fdb74703f57bfc5c7afbb38caa2acd5b7bd189
2024-01-08 14:53:23 +00:00
Sam Cackett ad51bc1df2 Merge "Reset AppChip chevron when closed" into main 2024-01-08 14:40:05 +00:00
samcackett 191b13e8d0 Reset AppChip chevron when closed
This CL fixes two issues:
1. It resets the chevron AnimatedVectorDrawable back to the start when
the TaskMenuView has finished closing. This stops it being re-opened in
any previously animated state and starts fresh each time.
2. The original position of the TaskMenuView is put back in its original
position when finished closing. If animations are disabled, the
TaskMenuView is never put back in its original position.

Video after this commit is applied: http://shortn/_gfy0pN6sKX

Fixes: 316998167
Fixes: 316996167
Test: Manual
  Open several apps. Open Overview. Expand a TaskMenuView. Swipe up to
  home. Open Overview again. TaskMenuView chevron should be facing down.
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD

Change-Id: I7d9e60b5c0a56cf809e9870573c3b51af5ded8c3
2024-01-08 13:44:51 +00:00
Riddle Hsu d4d4eaaf31 Merge "Perform TaskView animation when reopening the current task" into main 2024-01-08 13:25:13 +00:00
Johannes Gallmann 48a425df95 Fix TaplTestsQuickstep.testPressback failure
In the predictive back to home case, no WALLPAPER_OPEN_ANIMATION_FINISHED_MESSAGE event was sent to AccessibilityManagerCompat, which caused TaplTestsQuickstep.testPressback to fail.

Bug: 318675970
Flag: ACONFIG com.android.systemui.predictive_back_qs_dialog_anim DEVELOPMENT
Test: TaplTestsQuickstep
Change-Id: I326577575d9e51e0f9ae879bca76e9c254f4ea34
2024-01-08 13:31:51 +01:00
Android Build Coastguard Worker e63a5f4aef Snap for 11282454 from 7a9686b49d to 24Q2-release
Change-Id: Ic71a3622de684b8f583fbf2e240ee190558d7583
2024-01-06 22:20:48 +00:00
Jagrut Desai 7a9686b49d Merge "Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-01-06 19:11:01 +00:00
Vadim Tryshev 38d395be3e Removing dependency of All Apps test from 1P apps
Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: I8b3894a383416cea08c56c8874e6974323ffdc3a
2024-01-05 19:02:30 -08:00
Android Build Coastguard Worker 14fc234f24 Snap for 11281094 from ec88372892 to 24Q2-release
Change-Id: I3f06304bb9ad6669f3b2914a13e2f7f9c3334e49
2024-01-06 02:20:53 +00:00
Brandon Dayauon 8b35defbaf Merge "Fix right-bottom corner edge to curve in PS container." into main 2024-01-06 01:20:04 +00:00
Brandon Dayauon 3dd0f12cad Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW
Verified that there should be no jumping going on in the top app row between A-Z list and Toast.

bug: 312781931
Test: manual -video:
https://drive.google.com/file/d/11GX-5mVr5BoZY29IyX5FvrIA_yT57MOJ/view?usp=sharing
Flag: None

Change-Id: I5c35c04eb500f52780b0b77c542e0a861346a3fd
2024-01-05 17:09:23 -08:00
Jagrut Desai 4f56608aec Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Test: Presubmit
Bug: 317798731
Flag: NONE
Change-Id: I05d430a4d8a306b672e89bb3033dfb41bbb9d000
2024-01-05 17:00:53 -08:00
Tony Wickham 762f8151f6 Improve Taskbar touchableRegion debuggability
- Add DebugTouchableRegion which includes the last region that we
  set as well as the reason (code path) for it, which we dump.
- If persist.debug.draw_taskbar_debug_ui is enabled, we will also
  outline the touchable region on the screen.

Flag: None
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Bug: 315393203

Change-Id: I70b37e8b8804c4a48ffe3956d2a24aa5eab452fd
2024-01-06 00:42:08 +00:00
Tony Wickham 79f5536524 Update kotlin formatting for TaskbarInsetsController
Flag: none
Test: none
Bug: none
Change-Id: I2f83ce8bbbe89ac3fcee6f6b3c1100f387ddf76e
2024-01-06 00:42:08 +00:00
Vadim Tryshev edd7c4cc98 Waiting for Recents activity to stop after starting apps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ifbc23289d040ad31d40434e9d81529c7800532e9
2024-01-05 16:19:56 -08:00
fbaron 0f2ca91b8b Add PreviewItemManager unit test to check if icons are themed when they shoudl be in folder previews
Fix: 317417863
Test: PreviewItemManagerTest
Flag: NONE
Change-Id: I067a8d9d2ef4890e816d44ee62f7f5c1119cdd83
2024-01-05 16:01:58 -08:00
Jagrut Desai ec88372892 Merge "Fixing com.android.launcher3.ui.widget.TaplAddWidgetTest#testDragIcon" into main 2024-01-05 23:34:27 +00:00
Jagrut Desai 21f3d770a0 Merge "Taskbar Pinning Animation Improvements" into main 2024-01-05 23:21:57 +00:00
Vadim Tryshev 6f16b338ad Waiting for Normal state when swiping from a popup to home
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I3bcb7717e0b8e7b9ac94aac157297c4cf675f72e
2024-01-05 14:55:32 -08:00
Tony Wickham 8424eed91a Merge "Fix onIsStashedChanged() not called in 3 button mode" into main 2024-01-05 22:18:18 +00:00
Brandon Dayauon 17477dbf42 Fix right-bottom corner edge to curve in PS container.
This happens when there isn't enough apps to fill in the private space container.

* Added test to check the correct regions are being set depending on the apps in the list.
* Need to set ROUND_BOTTOM_RIGHT to the last app item and the decorator would take care of it.
* Changed to use mNumAppsPerRowAllApps that is already set in ctor.

bug: 316116551
Test: manual/presubmit/photos:
before: https://screenshot.googleplex.com/4Uo5Vtu3a6MDuGa
after: https://screenshot.googleplex.com/878g8yv5LgPsHaL
Flag: None
Change-Id: Ic481628b824c75e5578f3129e3a48f575c6a3655
2024-01-05 13:54:46 -08:00
Tracy Zhou 899c28193c Merge "Delete enable_split_from_fullscreen_with_keyboard_shortcuts from aconfig" into main 2024-01-05 21:20:33 +00:00
Liran Binyamin fdc5c72aa1 Merge "Add a test for stashed bubble bar" into main 2024-01-05 21:19:19 +00:00
Jagrut Desai a3d3c06967 Taskbar Pinning Animation Improvements
Test: Manual
Bug: 312178646
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I708127be8301a61994168f780474c75be726815d
2024-01-05 12:12:12 -08:00
Tony Wickham 438e6c90af Fix onIsStashedChanged() not called in 3 button mode
Calling this ensures we update touchableRegion accordingly.

Since this will also start the stashed handle region sampling,
which we don't need for 3 button mode, also adjust logic to
check that the StashedHandleView is actually visible.

Flag: None
Test: Lock screen, run `adb shell cmd uimode night yes`, unlock
Test: Lock screen, rotate, unlock
  In both cases, verify touchableRegion is accurate
Fixes: 315393203
Change-Id: I951af6b97cad0ee0f362dc22f3996cfd9286a21e
2024-01-05 19:19:57 +00:00
Vadim Tryshev 8d42081b23 Merge "Waiting for Normal state after dismissing Home AllApps by touching outside" into main 2024-01-05 18:59:51 +00:00
Vadim Tryshev c8e6763fbb Merge "Waiting for AllApps state when opening all apps with keyboard" into main 2024-01-05 18:59:45 +00:00
Jagrut Desai ad88561612 Merge "Migrating Tapl Overview test to platform scenario project" into main 2024-01-05 18:53:24 +00:00
Tracy Zhou ef8e4e2e77 Delete enable_split_from_fullscreen_with_keyboard_shortcuts from aconfig
It's merged with split_contextual in ag/25511408

Bug: 270394122
Test: N/A
Change-Id: Idabddee7c566ec426be744261ff50d7b360e2afa
2024-01-05 10:45:22 -08:00
Jordan Silva 49374a905d Merge "Reduce the iconSize to fit inside the cellSize when display size largest" into main 2024-01-05 18:33:40 +00:00
Vadim Tryshev 819a55f6c8 Waiting for AllApps state when clicking Qsb
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Idf0639a1d91ad3fba40ab5589595b6376d49fd6d
2024-01-05 10:32:19 -08:00
Jagrut Desai a7cf2ac11b Fixing com.android.launcher3.ui.widget.TaplAddWidgetTest#testDragIcon
Test: Presubmit
Bug: 316910614
Flag: NONE
Change-Id: I7728664ddae5538dabaa8a78de6c4c3b84e3c2d6
2024-01-05 10:00:22 -08:00
Jordan Silva 10ce3f5fe2 Reduce the iconSize to fit inside the cellSize when display size largest
For some cases, even after reducing the iconSize and iconTextSize the content of the cell does not fit inside the cell height. This issue leads the icons or labels of the folders and workspace to crop. To prevent the icons of cropping when the display size or font size is largest (for acessibility) we allow the icons and labels shrink until it fits inside the defined cell height.

Bug: 314285621
Bug: 316087877
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: NexusLauncherImageTests
Change-Id: Id8da3ee89658b9fc53a36d8605b9bd56ce168834
2024-01-05 13:24:32 -03:00
Charlie Anderson 67636269dd add metrics for when db grid migration fails
Flag: ACONFIG enable_launcher_br_metrics TEAMFOOD
Test: locally verified
Bug: 307527314

Change-Id: Iab84a337d76d63bb3bc2ed81fdf4b6fd50dc5661
2024-01-05 10:48:40 -05:00
Liran Binyamin 40c1b93aee Add a test for stashed bubble bar
This change introduces a new test protocol event for unstashing the bubble bar.

It's not possible to do this via a UI event because the stashed handle is only visible when an app is in the foreground, but in that state none of the elements in TaskbarDragLayer are visible to accessbility.

Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Bug: 273994695
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.BubbleBarTest
Change-Id: I4581bf95b07691429966ecbd573232047f820b69
2024-01-05 08:49:27 -05:00
Sergey Pinkevich 0f8d28024e Merge "Java crash on RecentsView.isTaskViewVisible method" into main 2024-01-05 11:34:55 +00:00