Commit Graph

78507 Commits

Author SHA1 Message Date
Johannes Gallmann d0aa5b82db Fix stuck wallpaper with predictive back
Bug: 315149515
Flag: NONE
Test: Manual, i.e. visually verifying that wallpaper never jumps to a new zoom level with predictive back enabled
Change-Id: I17b12bdfd3ef5c9cffbc64df3d26ae140e506dc6
2024-01-05 11:30:58 +01:00
Jakob Schneider b88ba19233 Merge "Add support for progress bar during unarchival of app." into main 2024-01-05 10:21:58 +00:00
Vadim Tryshev 6a8a4ba0b8 Merge "Waiting for Split Select state after tapping split menu item" into main 2024-01-05 03:09:54 +00:00
Charlie Anderson 6c4dde2c4d Merge "Adds a legacy flag to enable Launcher BR metrics." into main 2024-01-05 01:32:11 +00:00
Jagrut Desai 71e8dcca46 Migrating Tapl Overview test to platform scenario project
- Removes tapl overview test form platinum test suite
 - adds individual overview test to platform scenario test.

Test: Presubmit, Manual
Bug: 303256981
Flag: NONE
Change-Id: I7d04dc5dc63ba3a5e63ad03d98760dbd24c974f8
2024-01-04 16:25:17 -08:00
Android Build Coastguard Worker 29c637b277 Snap for 11275524 from 852a70f994 to 24Q2-release
Change-Id: I94c1f3c4dc5c27b9cfddb13e867ec5e2c29b7487
2024-01-05 00:20:54 +00:00
Sunny Goyal 1a8f804195 Merge "Removing ENABLE_CACHED_WIDGET since we now have always listenign widget" into main 2024-01-05 00:02:54 +00:00
Vadim Tryshev 710634b192 Merge "Explicitly waiting for Launcher to restart after enabling test content provider" into main 2024-01-04 23:11:24 +00:00
Vadim Tryshev 25c1b792d8 Waiting for AllApps state when opening all apps with keyboard
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Idc17322fc8c22cd3fdcfe459e012bd04bc98b071
2024-01-04 15:06:00 -08:00
Vadim Tryshev 5675734d97 Waiting for Split Select state after tapping split menu item
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I54edb4e2b79c5dae0acedecae0f0b858a2ed0ddb
2024-01-04 14:58:05 -08:00
Charlie Anderson a4240c72c0 Adds a legacy flag to enable Launcher BR metrics.
This is necessary because the aconfig flag requires reboot to enable, however backup/restore happens on the first load so the flag will not be ready.

Flag: LEGACY ENABLE_LAUNCHER_BR_METRICS TEAMFOOD
Test: compilation / presubmit
Bug: 305984208
Change-Id: Ida90b1bd485fb037ebf3dde7ad17bf4e462661e6
2024-01-04 17:40:51 -05:00
Charlie Anderson f0b1ddc038 Merge "Adds restore metrics to RestoreDbTask.java" into main 2024-01-04 22:25:09 +00:00
Vadim Tryshev b2d111d90c Waiting for Normal state after dismissing Home AllApps by touching outside
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I4fc90a791d0264aee3b81306fdb1b15814dccfd8
2024-01-04 14:14:13 -08:00
Andy Wickham 93504b4225 Merge "Ensure header view expected height accounts for tabs." into main 2024-01-04 21:32:13 +00:00
Vadim Tryshev d151784801 Explicitly waiting for Launcher to restart after enabling test content provider
I hope that this will prevent diagnostics that the Launcher has restated during the test.

This CL is a partial revert of ag/25428448

Bug: 314809015
Test: presubmit
Flag: N/A
Change-Id: I52f9641a5efcb67465794abca4f8ead621fad434
2024-01-04 21:09:59 +00:00
Johannes Gallmann 852a70f994 Merge "Hide app icon during predictive back to home" into main 2024-01-04 19:39:05 +00:00
Sergey Pinkevich f78644b4eb Merge "Revert "Wrong app icon position in seascape mode for RTL layout"" into main 2024-01-04 17:54:32 +00:00
Tony Wickham 97e6c9c214 Merge "Fix KI in test and re-enable for postsubmit." into main 2024-01-04 17:50:35 +00:00
Sunny Goyal 4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Sergey Pinkevich 387e99f4bc Revert "Wrong app icon position in seascape mode for RTL layout"
This reverts commit 9b6587d80f.

Reason for revert: Show app icons in wrong order

Change-Id: I0fcc6b6f6431a8e596a504f5f7eb2c2d533be887
2024-01-04 14:54:30 +00:00
Jordan Silva 873d49937c Merge "Add ESCAPE key to dismiss Overview" into main 2024-01-04 14:12:28 +00:00
Riddle Hsu 51ceb99715 Perform TaskView animation when reopening the current task
When using gesture navigation to switch task, if the next started
task moves the previous task in live tile to top, the appeared
task will be the previous animating task rather than the task
started by recents.

Previously, none of condition handles the case, which causes a
splash screen task view to stay on screen and the transition keeps
in running state.

By running the side task launch animation, it can indicate that
there is an additional task switch visually, and the recents
transition can be finished when the animation is finished.

Bug: 317160303
Test: Activity A's onResume always starts activity B (declares
      different taskAffinity) with FLAG_ACTIVITY_NEW_TASK.
      Use gesture to swipe from B to A. B should be visible
      instead of staying at recents with a splash screen view.

Change-Id: Id1a441561ac9958f71efe2440e4fb467bedc6947
2024-01-04 21:28:05 +08:00
Jordan Silva 9878a7206e Add ESCAPE key to dismiss Overview
This CL adds the functionality of escape key to Overview. It dismisses Overview when the esc key is pressed.
When Overview is showing a Modal Task, it will return to Overview state instead of the Normal state.

Fix: 315283507
Flag: N/A
Test: TaplTestsQuickstep
Change-Id: I02e02f623d9a4aad1c2d6188fdea4e3fc4f96d64
2024-01-04 09:08:44 -03:00
Sergey Pinkevich e8f4fbf012 Merge "Wrong app icon position in seascape mode for RTL layout" into main 2024-01-04 12:07:40 +00:00
Vinit Nayak e4b5ab6523 Merge "Null out launcher reference to prevent leak" into main 2024-01-04 00:59:28 +00:00
Andy Wickham f495102326 Ensure header view expected height accounts for tabs.
This was already handled except for the case where there were no
predicted apps and no all apps divider, i.e. suggested apps are
disabled and a work profile is added (so tabs show instead of the
divider).

Why did the other cases work? Predicted apps and the divider are
FloatingHeaderRows which call FloatingHeaderView#onHeightUpdated
whenever they are updated (triggering updateExpectedHeight()).

And why did this sometimes "fix itself" until a reboot? When the
search bar is tapped, the search transition causes the expected
height to be updated. So that is my guess.

The key to this change is to wait to update the expected height
until after we have defined mTabsHidden during setup(). It is
normal for the header to be initialized without tabs and then
updated to show the tabs when the work apps are available. So
this was previously incorrectly using mTabsHidden=true for the
calculations.

Fix: 245516031
Test: Manual (force stop launcher and verify tabs scroll correctly)
Flag: NA
Change-Id: Ifcc2f39649c5494b5f3ebefc1cdddfbefbe5d9a0
2024-01-03 18:54:24 -06:00
Android Build Coastguard Worker 8a1b1ad341 Snap for 11270238 from e1c3332532 to 24Q2-release
Change-Id: I70819384943a9d2e2ee6bf1264bcc1e65a2fe87d
2024-01-04 00:21:15 +00:00
Vadim Tryshev 1339847866 Waiting for Normal state after pressing Esc in AllApps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Iace454f28067492623929c8160ee9b30aaa53e1f
2024-01-03 15:38:00 -08:00
Tony Wickham c5d4e4dcf5 Fix KI in test and re-enable for postsubmit.
- The taskbar stashing logic with hardware keyboards was different
  between tests and user experience; aligned the test to be the
  same.
- There is still a previous test failure that only occurred in
  post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.

Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
2024-01-03 23:27:18 +00:00
Vinit Nayak e363a611d2 Null out launcher reference to prevent leak
Bug: 314806687
Flag: None
Test: Enabled flag and played with taskbar/home transitions,
seemed fine

Change-Id: I86ab417eccf1fd6255195025890a1b93bf5d3bb4
2024-01-03 15:08:47 -08:00
Andy Wickham 60dcb19a48 Merge "Better handling of insets for All Apps." into main 2024-01-03 22:34:36 +00:00
Federico Baron 8d23a6762d Merge "Fix IllegalArguemntException for ClipIconView#update" into main 2024-01-03 22:28:00 +00:00
Charlie Anderson 1fcf8da4e5 Adds restore metrics to RestoreDbTask.java
Bug: 307527314
Flag: ACONFIG enable_launcher_br_metrics TEAMFOOD
Test: locally verified
Change-Id: I105b17276cf7e2c270c819854a8fbc269b7c81b4
2024-01-03 22:06:44 +00:00
Tracy Zhou e1c3332532 Merge "Correct contextual button width, height and touch area" into main 2024-01-03 21:11:24 +00:00
Vadim Tryshev 6741d1affc Ignoring testQuickSwitchToPreviousAppForTablet
It fails on some targets

Test: presubmit
Flag: N/A
Bug: 318544733
Change-Id: Ia6e34f81942b3e911b637cd66eae4362e633eee5
2024-01-03 12:58:57 -08:00
fbaron 3b894e1f70 Fix IllegalArguemntException for ClipIconView#update
The scale was infinity sometimes which means that the view minSize is probably getting set to 0 due to lp height and width being 0, so we do not update the views as they are no longer laid out

Flag: NONE
Test: Opening apps should work fine, but i wasn't able to repro this exception before or after this fix
Fix: 318099222
Change-Id: I1c08346c7ee1d4e89d9c3ba23ee2aa51a451cb31
2024-01-03 12:44:10 -08:00
Sergey Pinkevich 9b6587d80f Wrong app icon position in seascape mode for RTL layout
Bug: 317072320
Test: manual
Flag: NONE

Change-Id: If998033d6008626941eb766dcc96803c25b8bf02
2024-01-03 19:28:52 +00:00
Andy Wickham 99d7d4f2cb Better handling of insets for All Apps.
Changes:
 - For tablet, always center All Apps without applying additional
   insets for things like cutouts.
 - For tablet, allow the panel to span the full height of the
   screen (minus system bars), rather than 5.5 app rows. This also
   ensures the panel fully closes even if there are cutouts.
 - Remove additional padding for vertical bar mode (landscape on
   phones). This was double counting the cutout insets, but only
   for some views, so things were not aligned. Now the apps line
   up with the search bar, and the scroll bar still makes room for
   any side insets.

Before and after examples:
https://drive.google.com/drive/folders/1k0vSzisf4ZuGyp-qR-IF0QwM-IcHBFrZ?resourcekey=0-uxjzuVQ1KA3WwOQ4v6Dh2w&usp=drive_link

Bug: 299923399
Bug: 259617884
Fix: 300761324
Test: Manual
Flag: NA
Change-Id: I136d516260a1343b1198693c73fa389fe0e11cc9
2024-01-03 19:21:01 +00:00
Sergey Pinkevich c7dcb95b4c Java crash on RecentsView.isTaskViewVisible method
Bug: 316567614
Flag: NONE
Test: manual

Change-Id: I8e7a47a06a94ce0d9eb5921020cb19097873e8c4
2024-01-03 19:20:46 +00:00
Helen Cheuk df20ea0ed4 Merge "Update BubbleTextView height to match parent so focus outline drawn could be fully displayed" into main 2024-01-03 18:38:29 +00:00
Vinit Nayak 05d5424049 Merge changes I21801b63,I017f1d55 into main
* changes:
  App pairs: themed icons
  Fix bug where app pair icons were appearing empty
2024-01-03 18:26:04 +00:00
Vadim Tryshev 943843a239 Merge "Re-promoting some tests to postsubmit" into main 2024-01-03 18:25:59 +00:00
Rohit Goyal 2e6010c421 Add support for progress bar during unarchival of app.
* With this change, progress bar should appear whenever app update for archived app reaches non-zero progress.
* Once the update is cancelled, the progress bar should also disappear.

Test: PromiseIconUiTest and manually tested the progress bar using Play Store
Bug: 302115555
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iacf7a0fd865dba34915fa09f59c63a1da6e47315
2024-01-03 23:44:52 +05:30
Sunny Goyal 05dc6db762 Merge "Fix launcher holds a surfaceController" into main am: 4b48398352 am: 507cccdb17 am: cb1fc471bb
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: Ib1b0eae5c1664f202312109da2391a250607108b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 17:59:03 +00:00
Sunny Goyal cb1fc471bb Merge "Fix launcher holds a surfaceController" into main am: 4b48398352 am: 507cccdb17
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: I5a9c74659439b1dd04e124f9191796bc348d97f6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 17:25:19 +00:00
Jagrut Desai 39e4b611b5 Merge "Refactor TaskbarDividerPopup Open/close animation" into main 2024-01-03 17:00:52 +00:00
Sunny Goyal 507cccdb17 Merge "Fix launcher holds a surfaceController" into main am: 4b48398352
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: I1b9beba5e4ff06b338bc10ed618f60338e6e8d3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 16:54:23 +00:00
Sunny Goyal 4b48398352 Merge "Fix launcher holds a surfaceController" into main 2024-01-03 16:21:06 +00:00
Sergey Pinkevich efc5d81209 Merge "Select task is broken on display large size" into main 2024-01-03 16:19:15 +00:00
Johannes Gallmann 436b9939e3 Hide app icon during predictive back to home
Bug: 311337169
Flag: ACONFIG com.android.systemui.predictive_back_qs_dialog_anim DEVELOPMENT
Test: Manual, i.e. testing predictive back to home on device and verifying visually that app icon behaves correctly
Change-Id: I91491d91d004d81f4abc67c361c8824eba8dfdcd
2024-01-03 16:45:16 +01:00