Commit Graph

78507 Commits

Author SHA1 Message Date
Schneider Victor-tulias 97eee72e6e Merge "Use ACTION_SCROLL to scroll TAPL workspace objects" into main 2024-01-03 15:24:14 +00:00
Jeremy Sim 14424e9e1f App pairs: themed icons
App pairs now use themed icons when theming is enabled.

Fixes: 312452183
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I21801b63bc3b52da9b2dfff02cc9ec70e679b300
2024-01-03 15:14:31 +00:00
Jeremy Sim d36d4f3f94 Fix bug where app pair icons were appearing empty
Using similar logic as other BubbleTextViews, checks for PlaceholderIconDrawables and redraws the icons if needed.

Fixes: 316041983
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I017f1d5597fd28d37ca9a8a5758f33468e46f384
2024-01-03 15:13:48 +00:00
Vinit Nayak a85fa48883 Merge "Improve null safety for app pairs" into main 2024-01-03 15:11:27 +00:00
Sergey Pinkevich 638ee17821 Select task is broken on display large size
The update of the focus task overlay should be at last, cause otherwise the first time the "Select" button doesn't work - the text is not highlighted.

Also, we need to update pivot of the selected task only if there is a grid overview enabled. Otherwise the bug is still reproducible on Felix.

Bug: 305125147
Flag: NONE
Test: Manual (both on Tangor and Felix in Portrait/Landscape mode with small/medium/large Display size)
Change-Id: Id928cee0949b9124aeb27cc8210a53993e72ba19
2024-01-03 14:44:12 +00:00
helencheuk 2174b0ad2e Update BubbleTextView height to match parent so focus outline drawn could be fully displayed
Design doc: go/launcher-focus-outline
Before: BubbleTextView height is larger than its parent, outline is cropped
https://screenshot.googleplex.com/dYXjWAHS4VzPQdJ
After: BubbleTextView has the same height as its parent Prediction Row, outline is fully shown
https://screenshot.googleplex.com/3eMxPwxiHs9JTTq

Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I7bfa4da3b67b4a4abc4dfe9df560dda8d7e9b1bd
2024-01-03 12:14:25 +00:00
Tracy Zhou 650000f68f Correct contextual button width, height and touch area
Side note: this is unrelated to NearestTouchFrame

Bug: 313371759
Bug: 230395757
Test: https://screenshot.googleplex.com/6mF4ZPSob6z55Nh
Change-Id: I7e5217bef4b2cfb6d14d62d107e75b1267ffd2f4
2024-01-02 23:05:53 -08:00
Riddle Hsu 78611ea4ca Merge "Reduce redundant IPC when switching app by navigation bar" into main 2024-01-03 06:30:44 +00:00
Vinit Nayak d6493f4558 Improve null safety for app pairs
- Improves crash safety in AppPairIcon.java. An app pair should never have more or fewer than 2 app members, but if it happens somehow and there is an app pair on the home screen, the device will enter a crash loop that is hard to recover from. Added some safety checks so that it doesn't happen.

Fixes: 317283244
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I2cbd90f028f7c31af6e832b5515502ba992f0b54
2024-01-02 22:22:02 -08:00
Andy Wickham 6ab98924f3 Merge "Update Launcher3 TAPL "find app icon" logic to allow whitespace." into main 2024-01-03 06:05:50 +00:00
Fengjiang Li 772675ed11 Merge "Revert "Fix small gap between widget resize frame and widget background."" into main 2024-01-03 00:51:44 +00:00
Ikram Gabiyev 221457f00b Send app bounds to Shell via stopSwipePipToHome
Send app bounds used for content overlay by launcher
to Shell's PiP component. This is used by Shell to
reset overlay scale and offset properly after the enter animation
but before the overlay fades out to avoid icon shifts.

We observed that app bounds can be different depending on
whether we are at 90 deg or 270 deg before fixed rotation.
Moreover, the presence of the taskbar can also alter the app bounds.
So supplying the app bounds we take from task view simulator to Shell
should solve the issue in general.

Flag: NONE
Bug: 316993346
Test: manually enter PiP w/ fixed rotation in 90 or 270 deg
Change-Id: I0a26b0c69020dae399d6794d36a9f3bc8425f40b
2024-01-02 16:50:48 -08:00
Android Build Coastguard Worker 9e67d0b523 Snap for 11265615 from 756da982fc to 24Q2-release
Change-Id: I2a5e2cbb86b0bd309058a6aba46ed89ce0a9ee66
2024-01-03 00:22:00 +00:00
Tracy Zhou 9742e603b5 Merge "Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification" into main 2024-01-03 00:12:56 +00:00
Charlie Anderson 81b6b21faf Merge "Adding extensions for backup restore test" into main 2024-01-02 23:30:55 +00:00
Jagrut Desai 25cb918a37 Refactor TaskbarDividerPopup Open/close animation
Test: Manual
Bug: 315848479
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I3c43bd718cef24ec334f7f4884167ecb2ce0cfd5
2024-01-02 15:25:42 -08:00
Fengjiang Li e81f4b8dc5 Revert "Fix small gap between widget resize frame and widget background."
This reverts commit 1e6bbf368b.

Reason for revert: b/317375712 TAPL is failing

Change-Id: Ib6b200f99c9feb7986ffca50015c02f3e558fc84
2024-01-02 23:00:03 +00:00
Tracy Zhou 5ad10ff6f6 Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification
In nav bar, we assign layout weight 0.25:0.5:1(for home but the content width of home is set to 80dp):0.5:0.25 with a LinearLayout. Since we use a FrameLayout for taskbar (to support both folded and unfolded task bar), in this change we are matching the layout by manually calculating the width of each section (since we are already manipulating like so in different layoutters)

Bug: 230395757
Test: https://screenshot.googleplex.com/3P6vDrgb6geqTUm
Change-Id: I6ba201477621f173e42c5211fcc68b24e3022122
2024-01-02 14:34:51 -08:00
Vadim Tryshev 365adb289d Making testAllAppsFromHome platinum
This test has a search for Youtube, which makes it possible for this test to replace android.platform.test.scenario.launcher.integration_tests.ScrollDownToSearchYoutubeFromAllApps#scrollDownToYouTube

Removing ScrollDownToSearchYoutubeFromAllApps#scrollDownToYouTube would move close to a state where the only Platinum tests outside of Launcher projects are ones that use 1P apps. This will make it easier to divide responsibilities between the IW and the Launcher teams.

Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: I889b1b23e5fe0a543eba24a922dc6908ac887305
2024-01-02 14:27:11 -08:00
Vadim Tryshev 756da982fc Merge "Always waiting for launcher stop from launchIntoSplitScreen()" into main 2024-01-02 21:49:09 +00:00
Charlie Anderson d6fc23f230 Adding extensions for backup restore test
Bug: 294386159
Test: presubmit
Flag: N/A
Change-Id: I4acc48c0bdd967d3c5463c85acd275a57d4a28ba
2024-01-02 16:19:32 -05:00
Fengjiang Li afbf61a150 Merge "Add assertion error message so test failure is more descriptive" into main 2024-01-02 21:18:40 +00:00
Vadim Tryshev 5cc6b2ba52 Re-promoting some tests to postsubmit
Excluding TaplDragTest#testDragToFolder, which is failing on some devices

Will watch their stability; may further promote to presubmit

Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: I6fd9a6fb315dc9ab7bcac788edfac95cc3e9b93f
2024-01-02 13:14:08 -08:00
Jagrut Desai 2107717252 Merge "Change Tracking Bug for Taskbar pinning feature flag" into main 2024-01-02 20:52:50 +00:00
Vadim Tryshev b36f70a8e3 Always waiting for launcher stop from launchIntoSplitScreen()
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I7f3c818355d43def7a29fbc1f087f2bdd150da0d
2024-01-02 12:40:04 -08:00
Vadim Tryshev fdf79d917d Merge "Waiting for NORMAL state after removing work profile" into main 2024-01-02 20:33:32 +00:00
Fengjiang Li abd3d6ddcc Merge "Revert " ALLAPPS PREINFLATION to TEAMFOOD"" into main 2024-01-02 20:00:35 +00:00
Hyunyoung Song 0c2204dcbe Merge "Fixing UserHandle for AppTarget Event from Launcher." into main 2024-01-02 18:22:18 +00:00
Fengjiang Li 937f163a4e Add assertion error message so test failure is more descriptive
Flag: NONE
Bug: 316588649
Test: unit test
Change-Id: I8be89ac00da0ffff367aad15177d50d254645195
2024-01-02 09:52:34 -08:00
Vadim Tryshev b4ff22754a Waiting for the state to settle after clear-all-tasks action
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Idbbf48d5814fa457b3542ff972bfb86d31f04377
2023-12-31 18:36:20 -08:00
Vadim Tryshev 9838b73ced Waiting for NORMAL state after removing work profile
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Iddeb41dcf702855790e847417566636613f327b4
2023-12-29 19:08:56 -08:00
Android Build Coastguard Worker 7e8f320e2f Snap for 11260009 from ff03dd19c7 to 24Q2-release
Change-Id: I73b072df5ba10b3411cd7550eb6e1d013ce064b9
2023-12-29 00:21:01 +00:00
Vadim Tryshev 670294e935 Waiting Launcher to stop after swiping to unstash taskbar
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I4087c89ca66cb125adb34cf94e340690741d6313
2023-12-28 14:25:05 -08:00
Vadim Tryshev ff03dd19c7 Merge "Waiting for Launcher activity to stop when starting a Launchable into split screen" into main 2023-12-28 19:26:43 +00:00
Yunfan Chen 2c385bec7b Merge "Do not recreate taskbar due to unestimated bounds" into main 2023-12-28 11:09:16 +00:00
Android Build Coastguard Worker f95a00cd53 Snap for 11257657 from 664375d43a to 24Q2-release
Change-Id: I098944cc9f589347985e352d668a78bd9a3b51b2
2023-12-28 00:20:48 +00:00
Bill Yi 767da4889e [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 663c446926 -s ours am: 41f4b05347 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25755413

Change-Id: I1bfb0a4c8551adec19976288e44e1fa4706b61aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-27 23:43:24 +00:00
Bill Yi 41f4b05347 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 663c446926 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25755413

Change-Id: I70e667d459dc457b8009027c8a98d6ce18b3451d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-27 23:02:06 +00:00
Bill Yi f68aedbd86 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-12-27 22:16:51 +00:00
Saumya Prakash 664375d43a Merge "Ensure the back gesture tutorial icon renders correctly for RTL" into main 2023-12-27 21:35:13 +00:00
Bill Yi 663c446926 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I500c8f6d2dd74ab7ba3c3fde85d59eb54c75bc79
2023-12-26 17:27:58 -08:00
Bill Yi 78941bd1a9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iee5a6456177dc64115c3de5d651b7a9aca0ff36d
2023-12-26 17:27:33 -08:00
Brandon Dayauon f4d2c13752 Merge "Change all apps handle color to outLineVariant." into main 2023-12-27 01:03:56 +00:00
Android Build Coastguard Worker 6c59404e8b Snap for 11251507 from 8a037e3b2e to 24Q2-release
Change-Id: I3217eef6dbde215a85bf1617e13bc14e68b9f94b
2023-12-23 02:20:37 +00:00
Uwais Ashraf 8a037e3b2e Merge "Create Launcher3RoboTests and enable Robolectric on small set of tests" into main 2023-12-22 17:27:58 +00:00
Riddle Hsu 894c17c87b Reduce redundant IPC when switching app by navigation bar
In SplitScreenController#onStartingSplitLegacy, it also ignores:
if (ENABLE_SHELL_TRANSITIONS) return null;

This avoids a latency from the 2-way IPC in
RecentsAnimationListener#onTasksAppeared.

Bug: 275508603
Test: Capture trace when switching app by quickstep.

Change-Id: Ia11cbca0d38cdc2bfd676dfa3d59a5c8931a2d6e
2023-12-22 20:14:31 +08:00
chuanghua.zhao 5a6161d928 Fix launcher holds a surfaceController
When the dark night mode switch is triggered,systemui calls binder
to the onNavigationBarSurface method in the launcher and applies the
surfaceController.
Keep switching,you will keep applying,resulting in more surface
objects. The behaviour would cause that SurfaceFlinger couldn't
remove the unnecessary navigationbar layers timely and the
navigationbar layer would leak in SF.

Actively release the SC after using the SC in the launcher.

Bug: 317336417
Test: 1.Launch the settings app
      2.Click Display menu
      3.click the dark theme menu multiple times
      4.Check whether the surfaceController is released
      adb shell "ls -l/proc/904/fd|wc -l"

Change-Id: Ic449de9dbe0c52e0053be91e67ee9081a574581b
2023-12-22 13:04:41 +08:00
Android Build Coastguard Worker 97e1436033 Snap for 11248037 from 5221d39bda to 24Q2-release
Change-Id: I30c69530e42ce45aa0d32720801400cd589f2bc1
2023-12-22 00:22:55 +00:00
Tony Wickham 2ad9d442a4 Merge "Update live tile during dismiss anim even if disabled at start" into main 2023-12-21 22:58:02 +00:00
Brandon Dayauon 46884202f5 Merge "Fix padding between text and (x) icon in work profile card." into main 2023-12-21 22:25:41 +00:00