Commit Graph

78507 Commits

Author SHA1 Message Date
Anushree Ganjam 32b5ac61e0 Add null check since LauncherUserInfo can be null.
Bug: 319142187
Test: Manual
Flag: N/A. Crash in tests.
Change-Id: Iaa9fc1b8e7c2c09621d984bfdeb9012bcc479ef8
2024-01-12 18:05:29 -08:00
Tony Wickham dc566559d0 Merge "Improve Taskbar touchableRegion debuggability" into main 2024-01-13 01:38:18 +00:00
Jagrut Desai a15b88f484 Merge "Adding Taskbar Pinning Analytics again." into main 2024-01-13 00:54:14 +00:00
Stefan Andonian 22c4399105 Merge "Split LoaderTask.processWorkspaceItem into separate methods." into main 2024-01-13 00:25:13 +00:00
Andy Wickham bfb7c269b0 Ensure "AppIconSelector" does not match folders.
Not sure if this is considered brittle, but at this moment, the
BubbleTextView used for folder labels is not focusable, while the
one used for app labels is focusable.

Also add package name to the context logs to help debug similar
test failures in the future.

Fix: 319194153
Test: atest android.platform.test.scenario.google.OpenAppMicrobenchmark$1#testOpen
Flag: NA
Change-Id: Ibf88afdd6d3ef03b75ea44910b485e7e74e348b0
2024-01-12 23:56:05 +00:00
Sunny Goyal 39f235154e Merge "Fixing some launcher model tests" into main 2024-01-12 23:04:39 +00:00
Federico Baron e29666681b Merge "Don't reset search in two pane sheet" into main 2024-01-12 22:35:00 +00:00
Jagrut Desai fff93577e8 Merge "Update enableTaskbarNoRecreate logic" into main 2024-01-12 22:31:15 +00:00
Stefan Andonian 808e4f32f0 Split LoaderTask.processWorkspaceItem into separate methods.
Right now, processWorkspaceItem is almost impossible to fully
understand. It is a behemoth of a method that handles everything
possibily related to processing a workspace item.

In order to make life easier for developers, it is being split into
smaller methods that deal with limited functionality each, and are
commented / named well. These can also be individually unit tested, so
developers don't have to use mock data anymore to test even the smallest
bit of functionality.

Bug: 318398886
Test: Manually verified that the workspace loading behavior still works
on device.
Flag: None, this is just a copy/paste refactor.

Change-Id: I040bce708cada5b29cf3488ddf37ccc8d7af8282
2024-01-12 22:22:01 +00:00
Charlie Anderson 9fc2fa34b3 Merge "Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag." into main 2024-01-12 21:37:17 +00:00
Bill Yi 7a0c6fc84a [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 2a7d9f3927 -s ours am: cc2aa5bad2 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25868376

Change-Id: I23cdf0fe9abaf129c849221abe3ff7ce58952b95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-12 21:25:49 +00:00
Sebastian Franco c6cb35d97e Send pointer up input even if there is an exception
Fix: 315525621
Test: atest TaplTestsQuickstep
Flag: NA
Change-Id: Ie0310ee8d4cf25435d752ed2b838ae79e7ce4a45
2024-01-12 13:23:50 -08:00
Jagrut Desai 777f3a4b9d Merge "Fix TaskbarDividerPopupView vertrical Arrow offset" into main 2024-01-12 21:18:27 +00:00
Sunny Goyal 6449a21062 Fixing some launcher model tests
> Removing static mocks and using Sandbox context instead
> Removing inheritence in LauncherModel and converting LauncherApps.Callbacks
  to a separate class. decMaker sometimes fails because of API changes in
  LauncherApps.Callbacks

Bug: 319877828
Test: atest LoaderTaskTest
Flag: N/A
Change-Id: If78b5d83595627a355b284f52d887d75fef53014
2024-01-12 12:30:52 -08:00
Johannes Gallmann 4743cb3b87 Merge "Disable back gesture in Launcher after reboot" into main 2024-01-12 20:24:54 +00:00
Bill Yi cc2aa5bad2 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 2a7d9f3927 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25868376

Change-Id: I6c6da415e207346666ac86974ad3b554b38e4c69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-12 20:12:54 +00:00
Bill Yi f35f5f3917 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-01-12 20:09:43 +00:00
Bill Yi 9f46172927 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-01-12 20:09:43 +00:00
Charlie Anderson da3138cd91 Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag.
This is necessary because the value of the read-write flag will not be updated in time for backup/restore.

Bug: 307527314
Test: compiles
Flag: ACONFIG ENABLE_LAUNCHER_BR_METRICS_FIXED TEAMFOOD
Change-Id: I67a1a820734d8881b3ed5be4a1f2f1556e6e4704
2024-01-12 14:33:29 -05:00
Shan Huang 7fc7c44fc6 Attach launcher protection scrim to the opening target instead of
Launcher's surface.

Bug: 317183323
Flag: NONE
Test: m -j
Test: Swipe back to home, make sure there's no flicker. Try both quick
swipes and slow swipes. Try staying in apps for different durations and
then swipe back.

Change-Id: I59df680d889489291b28610ff76693a63e55e49a
2024-01-12 11:03:35 -08:00
Jagrut Desai 057144e0f6 Update enableTaskbarNoRecreate logic
Test: Presubmit
Bug: 318567569
Flag: NONE
Change-Id: I6927f0bab0317219a00a7c09c08640825d54e91b
2024-01-12 10:59:10 -08:00
Vadim Tryshev 8ed18ab5bc Merge "Using a standard way to go to Overview in DWB Toast test" into main 2024-01-12 18:41:20 +00:00
Anushree Ganjam 5e9b71e055 Add "Don't suggest app" shortcut to suggested apps.
This works for suggested apps in both Home and AA+. When enable_shortcut_dont_suggest_app is true, the secondary drop target "Don't Suggest app" is removed instead "Don't suggest app" is added to shortcuts.

Video: https://b.corp.google.com/issues/319250810#comment5

Home: https://screenshot.googleplex.com/d7Wts48X6EmFAYg.png
Private space app suggested: https://screenshot.googleplex.com/BukzCRTvkzbpwQ3.png

AA+: https://screenshot.googleplex.com/ADMCHnQ378jvJEE.png
Private space app suggested : https://screenshot.googleplex.com/AYga8Km3646AqMt.png

Bug: 319250810
Flag: aconfig com.android.launcher.enable_shortcut_dont_suggest_app DEVELOPMENT
Test: Manual.

Change-Id: Ia7df749a1c7d806bd9d74124be138384c3050119
2024-01-12 10:33:24 -08:00
Anna Zhuravleva eb1966c278 Merge "Add shortcut to install an app to Private space" into main 2024-01-12 15:51:05 +00:00
Brandon Dayauon 6ea6ffa94a Merge "Revert "Revert "Fix the badge in badge (triple badging), by simp..."" into main 2024-01-12 15:47:38 +00:00
Johannes Gallmann 9532717757 Merge changes I05d517a7,Ided0a095 into main
* changes:
  Minor clenaup in LauncherBackAnimationController
  Fix window corner radius for predictive back to home on Felix
2024-01-12 10:33:56 +00:00
Johannes Gallmann 09f29f7492 Merge "Align window clipping logic of back-to-home to cross-task-back" into main 2024-01-12 09:15:41 +00:00
Tracy Zhou 7a30de2fc3 Merge "Remove taskbar window from WindowManager in TaskbarManager.destroy()" into main 2024-01-12 06:05:44 +00:00
Cole Faust 47e6c241e6 Merge "Baseline NewApi issues" into main 2024-01-12 04:49:23 +00:00
Android Build Coastguard Worker e21a821c3d Snap for 11303174 from 6cdb1de48d to 24Q2-release
Change-Id: Ic2f8f0dfc48ab422364852b49979d138ab675cdb
2024-01-12 02:50:44 +00:00
Android Build Coastguard Worker 73fe6ac6f4 Snap for 11302939 from 480448b059 to 24Q2-release
Change-Id: I42e39aaeba0927967ef15ba709c1c9c0f46ab324
2024-01-12 01:28:57 +00:00
Bill Yi 11766a67bb Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4e130d40326ad2b4580d7449c5c9229dc83cefc9
2024-01-11 17:26:25 -08:00
Vadim Tryshev 6cdb1de48d Merge "Making testAllAppsFromHome platinum" into main 2024-01-12 01:25:48 +00:00
Bill Yi 2a7d9f3927 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2f4edf2f617b9c7c5fc2fe36b84144b7e620f5cb
2024-01-11 17:25:27 -08:00
Bill Yi 2f863664af Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iecc8364731c1fd3bd540875601599642a36a1e96
2024-01-11 17:25:02 -08:00
Tracy Zhou 78c548a829 Remove taskbar window from WindowManager in TaskbarManager.destroy()
When task bar crashes (from anything), task bar window is not cleaned up properly. This is because destroyExistingTaskbar() only removes the root layout from the window when we are no longer rendering task bar (one use case of that is folding the device). We need to clean it up in onDestroy() also.

Fixes: 319105323
Test: adb shell am crash com.android.systemui and make sure there is only one task bar window
Change-Id: Ia9c808e903422707bf4c270b2631fc913dde65d9
2024-01-11 16:13:06 -08:00
Tony Wickham 480448b059 Merge "Temporary workaround for taskbar hiding in Desktop" into main 2024-01-11 23:21:42 +00:00
Holly Jiuyu Sun de4ac178b9 Merge "Implement Install Apps button in Private Space." into main 2024-01-11 23:18:46 +00:00
Jagrut Desai 3fc1e3a45d Fix TaskbarDividerPopupView vertrical Arrow offset
Test: Manual
Bug: 310673489
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I6c6af315cb058c8da599af8120a6a903ab247006
2024-01-11 14:00:37 -08:00
Vadim Tryshev bfbc121e5d Merge "Waiting for Normal state when closing search result by touching outside" into main 2024-01-11 21:43:19 +00:00
Vadim Tryshev d586d054a2 Merge "Waiting for Normal state after pressing meta key in AllApps" into main 2024-01-11 21:43:06 +00:00
fbaron ae39c0f9de Don't reset search in two pane sheet
Fix: 319150904
Test: Verify on device that search doesn't reset
Flag: NONE
Change-Id: I7ecb20ef67416e5393d600821ac96b2f7e80c4d2
2024-01-11 13:37:45 -08:00
Charlie Anderson 3e53925c88 Merge "Change FIRST_LOAD_AFTER_RESTORE_KEY to be nonRestorableItem" into main 2024-01-11 21:08:18 +00:00
Vadim Tryshev 5674552a5d Using a standard way to go to Overview in DWB Toast test
Standardizing reduces maintenance.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I0f59262a9f34c29a97c496f0f61c44ab1af56d04
2024-01-11 12:46:47 -08:00
Vadim Tryshev 65b735beeb Merge "Waiting for Normal state when closing Overview by touching outside of first task" into main 2024-01-11 19:40:57 +00:00
Jagrut Desai 80cc62173e Adding Taskbar Pinning Analytics again.
Test: Presubmit
Bug: 265436916
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I742dccccc7648bb7ec8bf94d5f5f55430a5543ab
2024-01-11 11:33:02 -08:00
Vadim Tryshev 04947de324 Merge "Re-promoting testDragToFolder to postsubmit" into main 2024-01-11 19:21:43 +00:00
Sergey Pinkevich 19265a47bd Merge "Place app icons in correct place in RTL for Seascape mode" into main 2024-01-11 13:31:04 +00:00
Anna Zhuravleva 29a3139815 Add shortcut to install an app to Private space
Introduce long-press shortcut to install a copy
of the main user app to private space.

Test: manual, installed apps in different stores
and tried shortcut
https://screenshot.googleplex.com/6oAVamTytiYmvPC.png
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT

Change-Id: I702cd2a27388e3cc6e9e126308d5479836ba6655
2024-01-11 12:40:28 +00:00
Johannes Gallmann 9e91335473 Disable back gesture in Launcher after reboot
It needs to be ensured that `updateDisallowBack` is called at startup after views are created.

Bug: 318786031
Flag: NONE
Test: Manual, i.e. verifying that back gesture is disabled after rebooting the device
Change-Id: I32812101c0e159f5cba41ab419f86de760449906
2024-01-11 12:23:22 +00:00