Commit Graph

78507 Commits

Author SHA1 Message Date
Zak Cohen 02f0c92ea8 Merge "Widget Picker - center text description vertically to align with add button" into main 2024-04-05 16:46:44 +00:00
Sebastian Franco df7d2b0861 Set default grid when doing a backup and restore
When restoring from a tablet because phones don't have
the same table some issues can ocure because we setup a
non valid grid, the correct thing is to setup a default.

Bug: 325285743
Fix: 332964986
Flag: ACONFIG narrow_grid_restore enabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I28bf02e83dddf5ae84818d879a5e21600eddf67e
2024-04-05 08:53:32 -07:00
Tony Wickham fa696568e5 Unstash taskbar due to IME immediately when system gesture starts
This is reversing a previous change from a few years ago
(ag/16325264) because we now clip the recent apps on the bottom
during gesture nav, whereas before we left them unclipped until
you swiped up.

Flag: none
Fixes: 305977350
Test: verified visuals manually in persistent, transient, and 3
button nav; also tested interactions with All Apps

Change-Id: Ib3823a9bd9aebf923ad481c010c7e8544bcb6a4d
(cherry picked from commit a6b29968a4)
2024-04-05 15:50:15 +00:00
Tony Wickham fefe8a441b Merge "Unstash taskbar due to IME immediately when system gesture starts" into main 2024-04-05 15:49:36 +00:00
Schneider Victor-tulias 148cbffdbf Add debug logs to TaskView
Investigating b/332386996

Flag: N/A
Bug: 332386996
Test: TaplTestsQuickstep#testQuickSwitchFromApp
Change-Id: I633a1a67cadc8f1f85fbdeb3a0913623ae817bf1
2024-04-05 10:31:21 -04:00
Jakob Schneider 221117bcfd Merge "Fix issue where progress around icons is not shown" into main 2024-04-05 09:39:04 +00:00
Andreas Agvard c43b7163a2 Removes recovery
Flag: NONE
Bug: 326143814
Test: Unit
Change-Id: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
Merged-In: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
2024-04-05 06:10:04 +00:00
Brandon Dayauon c752dd032c Merge "Ripple to header and button when click happens" into main 2024-04-05 04:20:49 +00:00
Brandon Dayauon bcb6a62297 Merge "Apply icon alpha animation to expand/collapse private space." into main 2024-04-05 04:18:48 +00:00
Treehugger Robot 6539e29882 Merge "Launch AppPair live tile when not visible" into main 2024-04-05 02:08:17 +00:00
Holly Sun b4954547ac [PS] Disable long press for install app button.
For Install button - Disable long press would also disable drag logic altogether.
For apps in PS - Long press is not disabled as it. Drag is disabled in ag/25898351.

Video: https://drive.google.com/file/d/1g5jJ2vebZdiKUwjDMfkUnLwQ1oK1fWXB/view?usp=sharing

Bug: 332572841
Test: manual
Flag: aconfig com.android.launcher3.private_space_app_installer_button trunkfood
Change-Id: I418a31785b25c4f19dde2136747a74811628e92f
2024-04-04 18:14:25 -07:00
Liran Binyamin 98bbc2b46d Merge "Animate the stash handle for new bubbles" into main 2024-04-05 00:49:39 +00:00
Vinit Nayak 74a3314172 Explicitly set animation and timings for split cancel button
* Mismatched animation durations were causing recents task
thumbnails to flash in at the end.
* Following a similar pattern started at ag/26378432, except
here we manually call all the steps to create launcherState
animation

Fixes: 321863575
Test: Repro steps from bug no longer occur.
Tested on phone and large screen, workspace, overview and all apps

Change-Id: I02696c0470bf4cfe6a278f0a2bc0786367a9fe37
(cherry picked from commit aeb9595b37)
2024-04-05 00:07:26 +00:00
Vinit Nayak 8c14bef1f2 Merge "Explicitly set animation and timings for split cancel button" into main 2024-04-05 00:07:13 +00:00
Jeremy Sim 324c2478d8 Merge "Update app pair icon colors when switching containers" into main 2024-04-05 00:00:56 +00:00
Jagrut Desai d2508e5178 Merge "Adjusting Taskbar Icons for larger display size" into main 2024-04-04 23:39:51 +00:00
Android Build Coastguard Worker 083a01fa48 Snap for 11672362 from c9d07b0639 to 24Q3-release
Change-Id: I8409e07a2f4fd796e20e128ce0c40ac47140a33e
2024-04-04 23:21:01 +00:00
Zak Cohen 106cd240de Widget Picker - center text description vertically to align with add button
Bug: 332287648
Test: Widget picker tests
Flag: NA bug fix
Change-Id: I4d600633c3cfdc40973134903f4ba7a04090ccfe
2024-04-04 15:59:00 -07:00
Vinit Nayak 637274ebc9 Launch AppPair live tile when not visible
* End the recents animation and then relaunch as if
from scratch
* We explicitly ignore the anim for end of recents animation
since that will cause the taskbar to quickly show and stash
again, and we know in this case that we'll quickly be launching
right back into an app

Test: Tested w/ live tile + non live,
fullscreen + app pairs
Bug: 316485863

Change-Id: I6ae8cccc01401935bf96fba8a154216e6b1ad701
2024-04-04 15:58:17 -07:00
Fengjiang Li a197a4f3ae Merge "[1/2] Fix resize frame showing at left top corner of workspace." into main 2024-04-04 22:45:39 +00:00
Zak Cohen 86397baf6d Update OWNERS for Widget Picker team.
Bug: NA
Test: NA
Flag: NA
Change-Id: Ie8c79da48ef150e1323b512ff198bb68303f06d7
2024-04-04 15:28:47 -07:00
Zak Cohen ea3fe15fa8 Merge "Widget Picker - Always center add widget button text vertically" into main 2024-04-04 22:19:21 +00:00
Tony Wickham a6b29968a4 Unstash taskbar due to IME immediately when system gesture starts
This is reversing a previous change from a few years ago
(ag/16325264) because we now clip the recent apps on the bottom
during gesture nav, whereas before we left them unclipped until
you swiped up.

Flag: none
Fixes: 305977350
Test: verified visuals manually in persistent, transient, and 3
button nav; also tested interactions with All Apps

Change-Id: Ib3823a9bd9aebf923ad481c010c7e8544bcb6a4d
2024-04-04 22:07:43 +00:00
Jeremy Sim 05617cb11f Update app pair icon colors when switching containers
This CL updates the color for the app pair background, and adds a way for an app pair icon to redraw as a different color when switching containers.

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I615cb95d51f7c4c120ad306246d9491bf4452229
2024-04-04 15:07:30 -07:00
Jeremy Sim e261ecbbd1 Merge "Update to correct Material SurfaceContainer values" into main 2024-04-04 21:59:32 +00:00
Brandon Dayauon 5cbe7605f6 Apply icon alpha animation to expand/collapse private space.
This change is more so to the Alt 3 motion spec:
https://docs.google.com/presentation/d/1zRwJ8cZbwMleXHfC2hX4CJJMGSI954FK0V3ksXl7fyE/edit#slide=id.g2baced0bfd0_1_25

bug: 299294792
bug: 325455879
Test: locally: https://screenshot.googleplex.com/BYCwSH3yRvkkZ3v and https://screenshot.googleplex.com/44byrRx5GUQkncw
manual video:
expand and collapse from header: https://drive.google.com/file/d/1-qRdcbo6lNvUPOx4QWL6wVhTRzl2TVtE/view?usp=sharing
from toast and close container after locking: https://drive.google.com/file/d/1-ix4CcOIzMhsJH3uZdJA1vcV8BvY91T9/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD

Change-Id: I4cde4b8626cf3271880fee697f2fb6bc780eab60
2024-04-04 14:54:28 -07:00
Vinit Nayak aeb9595b37 Explicitly set animation and timings for split cancel button
* Mismatched animation durations were causing recents task
thumbnails to flash in at the end.
* Following a similar pattern started at ag/26378432, except
here we manually call all the steps to create launcherState
animation

Fixes: 321863575
Test: Repro steps from bug no longer occur.
Tested on phone and large screen, workspace, overview and all apps

Change-Id: I02696c0470bf4cfe6a278f0a2bc0786367a9fe37
2024-04-04 14:20:18 -07:00
Brandon Dayauon c3281ee18a Ripple to header and button when click happens
bug:320701510
Test: manual video: https://drive.google.com/file/d/11X7vUetuMN1J34Now4zlQZ0WaOnryLpA/view?usp=sharing
Flag: None

Change-Id: Ibe22d02b59da5b1133f02ebd936520b97a63e44a
2024-04-04 14:08:41 -07:00
Jagrut Desai e6f349b3dd Adjusting Taskbar Icons for larger display size
Bug: 323948193
Test: Manual
Flag: NONE

Change-Id: I0bdfcaebf3de050ac850fe42c061c82ffebdb7c2
2024-04-04 14:01:57 -07:00
Fengjiang Li 9b46c463ad [1/2] Fix resize frame showing at left top corner of workspace.
Some widget will show config activity and immediately dismiss it after user dropping widget onto workspace. This lead to 2 code paths triggered around same time:

1. Drop widget to workspace and show resize frame, after state is transitiion to NORMAL, show workspace
2. Close config activity and Launcher#onActivityResult, which triggers removing dropped widget and extract bitmap, then re-inflate another pending widget and show resize frame

Due to race condition between #1 and #2, we might remove the dropped widget first in #2, then show resize frame in #1 after workspace is transitione to NORMAL, leading showing resize frame at incorrect location

Next CL will fix the slight misalignment of resize frame with widget.

Bug: 331433240
Flag: NONE
Test: manual
Change-Id: Ie02f59b370271d517ed2e91b42d665f44a86095b
2024-04-04 12:41:47 -07:00
Ats Jenk 9f0042b2c8 Merge "Update spring stiffness for bubble bar drag animation" into main 2024-04-04 18:56:27 +00:00
Ats Jenk d961c3d31d Merge "Update bubble bar bounds in shell" into main 2024-04-04 18:55:36 +00:00
Hyunyoung Song d0eb878d90 Merge "Add 16dp between nav bar and container by setting extra padding to the recyclerView." into main 2024-04-04 18:33:52 +00:00
Liran Binyamin 597ced3033 Animate the stash handle for new bubbles
The stash handle now animates out before the new bubble animates in, and animates back in after the new bubble is hidden.
There's still some additional polish needed :)

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/z30Ob1rcDUkNEphLAQsgV

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: I03449286b01ec96de9834e24a707652ddbe49fb0
2024-04-04 14:26:08 -04:00
Treehugger Robot c9d07b0639 Merge "Align widget picker bottom swipe transition with predictive back." into main 2024-04-04 18:07:32 +00:00
Vinit Nayak 247c6ac8ec Merge "Allow app pairs in folders" into main 2024-04-04 17:55:34 +00:00
Zak Cohen d00650bec3 Widget Picker - Always center add widget button text vertically
https://screenshot.googleplex.com/6aLoQSeADh2Ds6V

Bug: 331493703
Test: screenshot tests
Flag: NA layout bug fix
Change-Id: I6399474c42d3cd8ee172bbbbc0789044aac8cbe0
2024-04-04 10:01:18 -07:00
Holly Jiuyu Sun 568b84ffcc Merge "[omni] Read long press duration from AppSearch and override server configured value." into main 2024-04-04 16:09:44 +00:00
Shamali Patwa ffb90d859c Merge "Remove unused badge logic on WidgetCell now that we don't show badges." into main 2024-04-04 15:01:42 +00:00
Treehugger Robot 5c8241b421 Merge "Update the WidgetPickerActivity to display recommendations for hub host" into main 2024-04-04 14:36:56 +00:00
Treehugger Robot fd40addeb6 [automerger skipped] Merge "Reland "Update Split button visibility based on DeviceProfile change"" into 24D1-dev am: df537d249b -s ours
am skip reason: Merged-In I9ecf872279f6f07d2d9bc33fb09031568023cb77 with SHA-1 7d0edb46ac is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26833439

Change-Id: Ied74c569148fabb2d3fdcc01664a86c7814dfe0f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-04 14:32:52 +00:00
Alex Chau 208aa18c37 [automerger skipped] Reland "Update Split button visibility based on DeviceProfile change" am: ddb12d7a0c -s ours
am skip reason: Merged-In I9ecf872279f6f07d2d9bc33fb09031568023cb77 with SHA-1 7d0edb46ac is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26833439

Change-Id: Ib3610a1750ee50885c1f6101b1587922bdaea3a9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-04 14:32:48 +00:00
Treehugger Robot df537d249b Merge "Reland "Update Split button visibility based on DeviceProfile change"" into 24D1-dev 2024-04-04 14:18:38 +00:00
Alex Chau 2bf1143079 Merge "Clean-up unnecessary desktop windowing flag usage" into main 2024-04-04 14:04:49 +00:00
Pat Manning ce01b91f41 Merge "Set next page immediately on subsequent arrow/tab presses when navigating overivew." into 24D1-dev am: 05bb8f39e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26588650

Change-Id: I10ec720696b3240c39c558bef6ae40501384e228
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-04 13:52:18 +00:00
Pat Manning 05bb8f39e9 Merge "Set next page immediately on subsequent arrow/tab presses when navigating overivew." into 24D1-dev 2024-04-04 13:38:53 +00:00
Johannes Gallmann ed184acb3a Merge "Use custom interpolator for predictive back system animations" into main 2024-04-04 13:19:31 +00:00
Shamali P 8f44617191 Remove unused badge logic on WidgetCell now that we don't show badges.
See ag/26786552 that removed the usage.

Bug: 331838199
Test: Manual validation
Flag: N/A
Change-Id: I4393df1f8c6c7568925428bb3489081df17aa623
2024-04-04 13:10:00 +00:00
Alex Chau ddb12d7a0c Reland "Update Split button visibility based on DeviceProfile change"
This reverts commit 38bc885de9.

- Always request layout of action_buttons after changing visibility of its children
- Update Split button visibility based on DeviceProfile change in updateDimension() only
- Update Split button visibility based on 3P launcher in initialization only
- Also simplified action_buttons to wrap_content and layout in middle of parent
- Also removed the space between buttons and use marginStart
- Fixed TAPL to not expect save app pair button on phone. Before this CL actions_buttons are still on view hierarchy despite they're not visible on screen.

Fix: 321291049
Fix: 329255757
Test: Clear all tasks, fold, launch app, swipe up to Overivew; repeat in RTL
Test: OverviewImageTest
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7d0edb46ac0a09aa0c801598b46cd338d04886a9)
Merged-In: I9ecf872279f6f07d2d9bc33fb09031568023cb77
Change-Id: I9ecf872279f6f07d2d9bc33fb09031568023cb77
2024-04-04 12:19:44 +00:00
Alex Chau 312dd2f5bb Merge "Reland "Update Split button visibility based on DeviceProfile change"" into main 2024-04-04 12:17:38 +00:00