Commit Graph

78507 Commits

Author SHA1 Message Date
Bill Yi ba4161b68b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6b4ec662a766b9c95f01299f82b2c8d7b0fa213c
2024-04-02 00:27:42 -07:00
Bill Yi 4988629481 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1215dc2f61a3d6278658212749aec75edf4eff1a
2024-04-02 00:27:10 -07:00
Bill Yi 4046bc668b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib38aca104a8bd610756af4e0016a9efd9d8ad09e
2024-04-02 00:26:10 -07:00
Bill Yi b1ef45cf1f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ida67111c12717453e5f1a68f5ef868bcc4758a9e
2024-04-02 00:25:40 -07:00
Sebastian Franco 3d04c1f3fc Fix widget dissapearing because of change of appWidgetId
When migrating the widgets might dissapear because the appWidgetId
can change and when migrating it's no longer valid.

Bug: 324931424
Bug: 330583877
Test: ValidGridMigrationUnitTest
Test: GridMigrationTest
Flag: NA
Change-Id: Ie41a01470814b252f6bb7e4409d3382951a1d70d
2024-04-01 20:19:20 -07:00
Vadim Tryshev c22a62a1a4 Honoring @PortraitLandscape annotation in presubmit
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Icf0d06fc244e894ab8d5c9e8c5cddeb78b847a26
2024-04-01 18:06:25 -07:00
Vadim Tryshev 785da8d60a Restoring the full set of combinations in testDragShortcutToMultipleWorkspaceCells in presubmit
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib345c94c79c7dda72283eb03515cd254e31e7c0b
2024-04-01 18:01:54 -07:00
Vadim Tryshev 1c8354543a Re-enabling stress tests in presubmit
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I466ffb58fbd3bf5e7b3e0fc186aed12f75019e23
2024-04-01 17:52:50 -07:00
Android Build Coastguard Worker e4a58b0f00 Snap for 11654651 from 1bc33421de to 24Q3-release
Change-Id: I182405b7193aa209728cc0e581e8275da7c0b84a
2024-04-01 23:20:46 +00:00
Shamali P 809e1a8efb Fix issue that old search results list show up momentarily
After exiting the search, we clear the search results and hide the
results lists (because that recycler view shouldn't be accessible after it). However, it often doesn't get chance to layout the empty data.
So, the next time we show the search results list again with new data,
it first animates to clear the old results and then animates in the new
ones. In this fix,
[demo](http://screencast/cast/NDg5OTg2NzIyMTU1NzI0OHxhMTk0NzEzZS1hYw), we swap the adapter to remove any old views, because old search results aren't valid anymore. Spoke with yigit who worked on RV in past and they suggested swapAdapter
was fine for this.

Other options explored:
1. set item animator = null; so, it doesn't animate flushing out old
results -> but we want animations
2. delay the visibility update to let layout happen -> but, if we are
 hiding the section,  why wait making the other UI updates until
layout?

Bug: 274051332
Flag: N/A
Test: Manual
Change-Id: I9f9c5a67b47b5415b2d9e4caa23fd4b6daf7cdea
2024-04-01 23:07:03 +00:00
Shamali Patwa 1270b0810b Merge "Don't show badge for widgets in recommendations" into main 2024-04-01 22:44:05 +00:00
fbaron c0c0bdbc38 Fix null pointer in FloatingWidgetView
Flag: NONE
Test: NONE
Bug: 331868669
Change-Id: I350e6660ea1936bb9ee799c3d2c840c57876fef4
2024-04-01 13:17:49 -07:00
Shamali P 7ae51788da Update the WidgetPickerActivity to display recommendations for hub host
- Accepts a ui_surface param of format "widgets{_hub}" and existing
widgets on the surface to be excluded from predictions
- Refactored the widgets prediction update task to extract reusable
logic that maps the predictions to widget items and reused it.

http://screencast/cast/NjE1MTA5MDI0NzU2NTMxMnwzMGE3NTMwNi1hZg

Bug: 326092660
Test: WidgetsPredictionHelperTest and see screencast above.
Flag: N/A
Change-Id: I6ceeb752c167893bab4ed496cedc5e8081e1b950
2024-04-01 20:16:37 +00:00
Fengjiang Li 01cc273537 Add LAUNCHER_ALL_APPS_SEARCH_BACK jank instrumentation
Bug: 330405993
Test: prefetto trace TBD
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I1fb2876fb29bc360cbb8dc8c1605215f28383c3c
2024-04-01 11:12:50 -07:00
Liran Binyamin 1bc33421de Merge "Initial animation of new bubble bar bubble" into main 2024-04-01 17:54:59 +00:00
Ats Jenk 599ed3ba06 Merge "Create drop target for bubble bar" into main 2024-04-01 17:14:55 +00:00
Shamali P 48c2f8a0dc Don't show badge for widgets in recommendations
- Now that we display app logo, it will already be badged. So, another
badge on widget itself is not necessary. Moreover, when widget previews
don't fill bounds, its position feels inconsistent.

Bug: 331838199
Test: Manual (see screenshot in bug comment)
Flag: N/A
Change-Id: Id411d054de634d7735b70fff9540e580b078b741
2024-04-01 14:39:58 +00:00
Android Build Coastguard Worker cba512e395 Snap for 11650815 from 6c585ca7d7 to 24Q3-release
Change-Id: I1da7e753c6418d3d18d780512d9be77f9fd2b472
2024-03-30 21:21:17 +00:00
Jeremy Sim 6c585ca7d7 Merge "Update save app pair icon" into 24D1-dev am: 370d05a276
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26743078

Change-Id: I35ba86a1e032467a3bbc1775bf3a4271533060f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-30 03:49:36 +00:00
Jeremy Sim 370d05a276 Merge "Update save app pair icon" into 24D1-dev 2024-03-30 03:36:21 +00:00
Jeremy Sim da4ba9336e Merge "Reparent folders and app pairs" into main 2024-03-30 03:06:44 +00:00
Android Build Coastguard Worker 15e8b5ef34 Snap for 11648291 from 520d91f93b to 24Q3-release
Change-Id: Ic7149c8d3447856998a9dc42c56ade4b5e41a56d
2024-03-30 01:20:52 +00:00
Mateusz Cicheński bc77683210 Merge "Support going home from immersive fullscreen in 3 button nav" into main 2024-03-29 23:21:23 +00:00
Sukesh Ram 5c34cf2d06 Fix Taskbar Background Visibility After Entering IME then Overview.
Fixed issue whereby taskbar background disappears as expected when the IME switcher is present, but does not appear again if the overview button is pressed after this state.

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 297472865
Change-Id: If1074b28870c794db8a87dd6cd59f9656dc7c15d
2024-03-29 16:08:43 -07:00
Jeremy Sim 742630c2f8 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-03-29 15:39:28 -07:00
Automerger Merge Worker adf1df2e7e Merge changes from topic "am-d6f679a9148840b4beaadf3677246075" into main
* changes:
  [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: ff0d5f0b6a -s ours
  [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 2e779a3301 -s ours
  [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a8c1f8aca3 -s ours
2024-03-29 22:37:12 +00:00
Treehugger Robot 2bdd3bddef [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: ff0d5f0b6a -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26750325

Change-Id: I6be449ed42a512f84f96ec8150521a240c842b87
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-29 22:36:31 +00:00
Bill Yi 825bc026f9 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 2e779a3301 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26750325

Change-Id: I97f2a509a2c58174b3a4fba493c71cc157c44736
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-29 22:36:24 +00:00
Treehugger Robot 124a9596b6 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-29 22:36:18 +00:00
Treehugger Robot 9f599f0636 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-29 22:36:18 +00:00
Bill Yi 1de3231787 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: a8c1f8aca3 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26745380

Change-Id: I44a63130f477d2528710a41fc120c712ad919689
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-29 22:36:13 +00:00
Treehugger Robot ff0d5f0b6a Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-03-29 22:17:51 +00:00
Anushree Ganjam f1b8e4e155 Enable the CUSTOM_LPNH_THRESHOLDS flag.
Decision by PM: Set the default LPNH_TIMEOUT_MS to 450ms.

Bug: 311355495
Test: Manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS ENABLED
Change-Id: I07f075a7c73e8038a83b19cdc1091c0c8735f869
2024-03-29 12:33:10 -07:00
Android Build Coastguard Worker bd563d8c22 Merge cherrypicks of ['googleplex-android-review.googlesource.com/26720644'] into 24Q2-release.
Change-Id: I5d45280b4fe4b5b4a929c663055847f61e2fdcb1
2024-03-29 18:58:40 +00:00
Bill Yi c53d86ba94 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import

Bug: 328603775
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b06d115b1fb261636dbe99e69fbf9d846ce77413)
Merged-In: Ic2989766561a25c68064303d71578201910bcf72
Change-Id: Ic2989766561a25c68064303d71578201910bcf72
2024-03-29 18:49:48 +00:00
Mateusz Cicheński 5f8124ad05 Support going home from immersive fullscreen in 3 button nav
In gesture nav the swipe happens at the bottom of the screen,
which brings the navbar handle into the view.

In 3 button nav the swipe needs to happen from the right edge of
the screen, because the 3 button nav is always staying fixed in
the "bottom portrait" position, unless it is large screen, in
which case it should happen on the bottom landscape edge.

This can be detected via config_navBarCanMove resource value.

Bug: 313928629
Test: atest NetflixEnterPipTest
Test: above command on foldable in folded and unfolded state
Flag: n/a

Change-Id: I0a94757687fd9eb491b2a5cf0086ae51589ae0aa
2024-03-29 17:31:29 +00:00
Treehugger Robot 520d91f93b Merge "Don't toggle scrollbar during predicitve back swipe to avoid flicker" into main 2024-03-29 09:56:10 +00:00
Brandon Dayauon 4958ecfadb Merge "Move adding views logic to privateProfileManager" into main 2024-03-29 04:03:42 +00:00
Brandon Dayauon 391e53d2fc Merge "Fix private space settings cog margin" into main 2024-03-29 01:08:43 +00:00
Brandon Dayauon 136f9d6f8a Move adding views logic to privateProfileManager
- Have the animation happen according to the state of private space.
- Have the transition happen only once by setting the current transition to null at the end of transition and by ensuring
where the transitions are allowed.
- Removing controller class.

- The onClick controls the enablement of the profile. On reset (when getting the transition) is what controls the animation
during expand.

tldr- In the collapse case:  execute() is called -> animation happens  -> addPsHeader
tldr- Expand case: post() is called -> addPsHeader -> animation happens.

Collapse:
onClick() -> AACV.onAppsUpdated() that resets & apply/RUNS runnable because EXECUTE
-> AAList.onAppsUpdated() (which is called at the same time animating happens which we should cancel and do at end callback)
-> AAList.onAppsUpdated() gets called again

Expand:
onCLick() -> AACV.onAppsUpdated() that resets & apply runnable
-> AAList.onAppsUpdated() (no animation running)
-> AAList.onAppsUpdated() (no animation running)
-> addPrivateSpaceHeader
-> then unlockAction() runnable because its posted at this point

bug: 326206132
bug: 330444548
bug: 299294792
Test: manually locally and presubmit: https://screenshot.googleplex.com/9wavvwKQ8hY6oUw & https://screenshot.googleplex.com/BiqmidLFjPwS28j
video: https://drive.google.com/file/d/1XGhmTncdUFtJj188_l7alGyyNz_fhXNw/view?usp=sharing

Scrolling fix before: https://drive.google.com/file/d/1XykDm4UELoCvcwZdj8ZlJ6TszptB8W0W/view?usp=sharing
scrolling fix after when not a lot of apps: https://drive.google.com/file/d/1Y4VY1eX7WE8ShSLXRrT56ieBdAuJo_zn/view?usp=sharing
scrolling fix after with a lot of apps: https://drive.google.com/file/d/1Y58c-Z9xnU1GILp0Ih-oLORXYkMB-jWn/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation

Change-Id: I8d03ae60e2c9fe0ec145c4b0a2e9604b9e6e9017
2024-03-28 17:39:42 -07:00
Android Build Coastguard Worker d664b659c2 Snap for 11641371 from 0ec7c1e4a8 to 24Q3-release
Change-Id: I468a7f5f952a2fd425003766731720cdb40953b8
2024-03-28 23:20:53 +00:00
Brandon Dayauon 7e50fa9624 Fix private space settings cog margin
Inset on the lock button already exists, so in reality there are 4dp +
8dp margin from the settings button. To fix this, we can just reduce
8dp -> 4dp on the settings button.

bug: 331742915
Test: before: https://drive.google.com/file/d/1z6-U5eO5oM6h6uULNdmJciMCP_F33rDn/view?usp=sharing
after: https://drive.google.com/file/d/1yzCysJRaRKDp0kivhi6GWE83qsloh39U/view?usp=sharing
Flag: none
Change-Id: Iafb1101b8029398c139ba02f31a027db272132f3
2024-03-28 22:01:55 +00:00
Ats Jenk f221b8a7de Create drop target for bubble bar
When dragging bubble bar in launcher, show drop target when drag passes
middle of the screen.

Bug: 330585397
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual
Change-Id: I52c3e9ac0b7c36e2207640baf75dc44300b522ef
2024-03-28 14:21:33 -07:00
Alex Chau 170306d54a Update Split button visibility based on DeviceProfile change
- Updating Split button visibility in notifyPageSwitchListener() is sometimes too late and causes OverviewActions failed to re-center after removing Split button
- Instead, update Split button visibility based on DeviceProfile change in updateDimension(), which is the ultimate source of information impacting button visibility

Fix: 321291049
Test: Clear all tasks, fold, launch app, swipe up to Overivew
Flag: None
Change-Id: If518cb02429011fedfb8df3dd05dd7ab180d849a
2024-03-28 21:10:12 +00:00
Stefan Andonian f6867d48d9 Merge "Make "Undo" button not be long-clickable explicitly." into main 2024-03-28 20:00:11 +00:00
Stefan Andonian 462c80831c Merge "Explicitly set the Hotseat to not long or short clickable." into main 2024-03-28 19:59:27 +00:00
Bill Yi a8c1f8aca3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I05ace27fef4679f480b62d861c341b57d554a9b9
2024-03-28 12:08:33 -07:00
Bill Yi c18cafda4a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I725d6479c36e7ee0e9978eef413a76dd431aa67d
2024-03-28 12:08:06 -07:00
Bill Yi 2e779a3301 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I76dd0d716268b03eddb9f4fadee7b7f186505d7b
2024-03-28 12:07:12 -07:00
Bill Yi fb288950d3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I29eec7ffbf29c7498b9ece028ae2584d09677420
2024-03-28 12:06:48 -07:00