Commit Graph

78507 Commits

Author SHA1 Message Date
Liran Binyamin 4d257139ad Fix NPE when setting bubble bar bounds
The bubble bar bounds change listener is sometimes invoked before the IBubbles service has been initialized.
This change adds a null check before calling the service.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Fixes: 332423960
Test: manual
Change-Id: Iaa048c62a60c90c5e416da05ba53467a5034d86c
2024-04-08 21:05:00 +00:00
Uwais Ashraf 7a0150d02e Use script to auto-enable all tests that are currently working
Fix: 325088906
Test: presubmits passing, gradle robo run passing locally
Flag: NA
Change-Id: I481bfe9caeb8cc18b3e01ec8b7a58fb0eb36fdaa
2024-04-08 20:59:23 +00:00
Jordan Silva a3eff1fe96 Update save app pair test to validate when icon chip menu is disabled
This CL adds a validation in the test to check if save app pair action is available in the overview actions. Kept the validation to check if save app pair is available in the menu only for overview icon menu flag enabled.

Bug: 330515672
Flag: N/A
Test: TaplTestsSplitscreen
Change-Id: I3097180a24b430f2310d11ddec36e6d6cf4982fb
2024-04-08 12:30:51 -07:00
Federico Baron 9462c3b604 Merge "Fix null pointer in FloatingWidgetView" into main 2024-04-08 18:52:43 +00:00
Shamali P 11aa56e48f Add maxlines bounds to the category title.
- So far, none of the translations exceeded 1-line, but setting maxlines
to avoid it to happen in future.

* http://screen/35PYFHV5SCeBhqC (at max font size)

Bug: N/A
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_suggestions TEAMFOOD
Test: Manual - see videos.
Change-Id: I263706a5d85dd4a37a4150abd58222283d5e039a
2024-04-08 18:23:25 +00:00
Treehugger Robot 8687018b09 Merge "Disable app chip menu height limit for bottom row" into main 2024-04-08 18:22:08 +00:00
Treehugger Robot 18694cc977 Merge "Add max height logic and avoidance of taskbar into task menu" into main 2024-04-08 18:22:08 +00:00
Treehugger Robot adbdfe2ac7 Merge "Fix failing LauncherIntentTest." into main 2024-04-08 16:43:28 +00:00
Liran Binyamin 9a9ef494ae Merge changes I74b09220,Id7e2db5f into main
* changes:
  Don't animate bubbles in the initial state update
  Suppress animation for bubbles that auto expand
2024-04-08 16:30:30 +00:00
Uwais Ashraf d9de4b0558 Add max height logic and avoidance of taskbar into task menu
Fix: 329842207
Test: Manually tested, see video in bug
Flag: NA
Change-Id: I08079f14cee63fe7973ba751529109ca66423bb6
2024-04-08 16:23:59 +00:00
Shamali P 168d420440 Maintain the recommendations that were initially displayed
- The component names of the widgets shown on first opening the picker
are saved across orientation change - and only those shown initially are
displayed.

* http://screencast/cast/NDkyMDQ0OTg3OTI0NDgwMHw4ZGU1ZjRmNy0zNQ
* https://screencast/cast/NTc1NjQ1NDI5MTExMTkzNnxiZGJlMjQ2Yi01Ng

Bug: 331776686
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_suggestions TEAMFOOD
Test: Manual - see videos.
Change-Id: I6af7421c2757fde321d06406514ab2576a48fb47
2024-04-08 16:02:05 +00:00
Alex Chau 293d2cb867 Disable app chip menu height limit for bottom row
Bug: 326952853
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: manual
Change-Id: I104296979803eb8967b07793f4f2590e592f9df7
2024-04-08 16:24:45 +01:00
Alex Chau 7714b2cd32 Add more logs tracking gesture and recents animation in RecentsView
Bug: 332635097
Test: manual
Flag: None
Change-Id: I6f83806f783344c07f7f59fe87c37b7cc377fff2
2024-04-08 13:12:06 +01:00
Android Build Coastguard Worker a28f66e675 Snap for 11681105 from 962b3d43ea to 24Q3-release
Change-Id: I1a0562fe955b21462a54aacdda7eae9f5ddf0089
2024-04-06 21:20:57 +00:00
Treehugger Robot 962b3d43ea Merge "Explicitly set animation and timings for split cancel button" into 24D1-dev am: dcb860a22a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26842505

Change-Id: Ib72008aa452836829f865970e51986b52555210a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-06 07:59:40 +00:00
Treehugger Robot dcb860a22a Merge "Explicitly set animation and timings for split cancel button" into 24D1-dev 2024-04-06 07:30:28 +00:00
Saumya Prakash 83646f9b82 Merge "Add Taskbar education for Circle to Search for pinned taskbar" into main 2024-04-06 05:39:28 +00:00
Saumya Prakash 5453c053b9 Add Taskbar education for Circle to Search for pinned taskbar
This change adds a new education tooltip for pinned taskbar that teaches
users how to use Circle to Search invoked through the action key. It won't run on
transient taskbar or if the user is in 3 button mode. The disclosures at
the bottom of the tooltip link to localized legal agreements for the feature.

Fix: 330401405
Test: Pin the taskbar and observe that the next time an app is launched
the edu shows up. After dismissal it shouldn't show up again.
Additionally, click on the disclosures and ensure they launch.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I64aea3004aca77c3ec81b81dea0cfab7a9c1e272
2024-04-06 01:52:49 +00:00
Android Build Coastguard Worker d914dc739a Snap for 11679388 from a7ce667e3a to 24Q3-release
Change-Id: I60ef1979f07471daaecc1469a2de2cf9609d9a61
2024-04-06 01:20:45 +00:00
Andy Wickham 29671bdf1f Adds AssistStateManager#supportsShowWhenLocked.
This indicates whether search can show over the lock screen.

Bug: 320444706
Test: Manual with supported and unsupported AGA APKs
Flag: NA
Change-Id: I06612af6731b991b38614e47f207e190db109c24
2024-04-05 17:48:03 -07:00
Willie Koomson 2041fd04a4 Merge "Fix resize frame for widgets added with tap-to-add button" into main 2024-04-06 00:45:37 +00:00
Tony Wickham b3754c7cee Merge "Apply insets to top-level providers, not just paramsForRotation" into 24D1-dev am: c189a54ca3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26856995

Change-Id: Id766dd34cc7f8e1e882f7a3157d75ac373a0be04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-06 00:19:42 +00:00
Liran Binyamin 0701ab166d Don't animate bubbles in the initial state update
When launcher receives the initial bubble state update from sysui, don't animate the bubbles. The initial update is sent when bubble bar is created and not when new bubbles are created.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
Change-Id: I74b09220be22d7382fa6d7c1351d5e60a799a054
2024-04-05 20:15:52 -04:00
Tony Wickham c189a54ca3 Merge "Apply insets to top-level providers, not just paramsForRotation" into 24D1-dev 2024-04-06 00:01:19 +00:00
Sunny Goyal 8e1f37181d Merge "Allowing base class for ResourceBasedOverride to have Context based constructors" into main 2024-04-05 23:20:38 +00:00
Winson Chung 731739470b [automerger skipped] Fix regression in checking disabled state am: 95179cffab -s ours
am skip reason: Merged-In I7242e0c525ef578a54a06fb9137fcfc42c6f0e86 with SHA-1 fcbef122e6 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26857590

Change-Id: I05f4123c8c5c271e114bdfe60af1c4a90b6b7480
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-05 22:13:54 +00:00
Willie Koomson 7d2d6ced25 Fix resize frame for widgets added with tap-to-add button
This change updates the tap-to-add code to wait for the animations
between each step (close widget sheet, snap to Workspace page)
to finish before continuing with the next step of the flow.

Bug: 331425905
Bug: 331699050
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add TEAMFOOD
Change-Id: I774b86b429cd2e8a397e5605243056e6cea666b3
2024-04-05 22:03:37 +00:00
Tony Wickham a6dcb11094 Merge "Apply insets to top-level providers, not just paramsForRotation" into main 2024-04-05 22:01:29 +00:00
Winson Chung 95179cffab Fix regression in checking disabled state
- It should only check the disabled state after the icon graphic
  has been set

Fixes: 333017803
Test: Load with an app pair icon on the workspace
Change-Id: Ic313f98e1e31d673d774f050bb418d359b4bd653
Merged-In: I7242e0c525ef578a54a06fb9137fcfc42c6f0e86
2024-04-05 21:54:22 +00:00
Jeremy Sim 24284467b5 Fix bug where app pair title was not updating with language
This CL adds the ability for an app pair icon to update its title string when package changes are detected. It also reorganizes some code in the app pairs classes for readability.

Fixes: 316051810
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I833e4f9766b7da8c0a3a5fb4b9fc050d8897437e
2024-04-05 21:35:58 +00:00
Jeremy Sim a7ce667e3a Merge "Fix launch flow when one app in an app pair is paused" into main 2024-04-05 21:30:09 +00:00
Jeremy Sim 08fc2d434f Delete app pairs on model load if flag is turned off
This CL adds a case to processFolderOrAppPair() -- if the ENABLE_APP_PAIRS flag is turned off, we do not load app pairs into launcher.

This prevents a case where a user uses backup+restore to migrate an app pair onto an environment where app pairs is disabled.

Fixes: 330412376
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I4a97e4aadc620f8b727439fcdd70ab0e7a3005a8
2024-04-05 13:07:20 -07:00
Sunny Goyal 21f498c5f3 Merge "Moving all configs from overrides.xml to config.xml" into main 2024-04-05 20:04:15 +00:00
Sunny Goyal 9d28eee769 Allowing base class for ResourceBasedOverride to have Context based constructors
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Ib4d1ef80133596a114a4fb32ea8ae918852a77f5
2024-04-05 12:56:36 -07:00
Tony Wickham 3205876bf5 Apply insets to top-level providers, not just paramsForRotation
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode

Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
2024-04-05 19:46:11 +00:00
Anushree Ganjam 16a0f61078 Merge "Add dump for PredictionRowView." into main 2024-04-05 19:41:31 +00:00
Tony Wickham f95a6b73e5 Apply insets to top-level providers, not just paramsForRotation
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode

Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
2024-04-05 19:40:06 +00:00
Treehugger Robot 09cee48a84 Merge "Fix homescreen rotation delay during fold" into main 2024-04-05 18:39:26 +00:00
Sebastián Franco 5ccac93d0a Merge "Adding even more tracing for the tests" into main 2024-04-05 18:26:54 +00:00
Jeremy Sim 17db14b107 Fix launch flow when one app in an app pair is paused
This CL changes the error handling logic in ItemClickHandler to continue with app pair launch when only one app in an app pair is paused. It also changes AppPairIconGraphic so that the disabled state of the app pair is drawn modularly (if only one app is paused, only one app will appear visually paused).

Bug: 330795643
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ieaf0120cced07b6ac0f3eb07c75b66666a8dcc85
2024-04-05 11:24:33 -07:00
Sunny Goyal bd07c05446 Moving all configs from overrides.xml to config.xml
> Removing some used configs
> Moving ids to id.xml

Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: I86bd22db49a3980c55f5d42350a7c6368fa86d21
2024-04-05 11:20:17 -07:00
Liran Binyamin c21852a186 Suppress animation for bubbles that auto expand
Check whether the state update indicates that the bubble bar is expanding, and pass that to the bubblebarviewcontroller so that we can suppress the new bubble animation if we're expanding from stashed.
Note that in some cases the notification service may not include the auto expand flag on the message it sends to sysui, so launcher will end up getting 2 separate messages. We may need to handle that separately.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
       - create bubble that auto expands
       - observe that the bubble does not animate
       - note that in some cases the notification service may not include the auto expand flag, will look into that separately.
Change-Id: Id7e2db5fd32d391413c57d83effb4b23b1085125
2024-04-05 14:09:32 -04:00
Anushree Ganjam 1115b416bb Add dump for PredictionRowView.
adb shell dumpsys activity NexusLauncherActivity : https://paste.googleplex.com/4907497231482880

When AllApps prediction is off : https://paste.googleplex.com/5930628737925120

Bug: 332171918
Test: Manual
Flag: NA
Change-Id: I753ff876aab162026d99fd1b35f63edf2e712f70
2024-04-05 10:57:44 -07:00
Tony Wickham 7149e036f1 Unstash taskbar due to IME immediately when system gesture starts am: fa696568e5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26852022

Change-Id: I09b82105630add2755057d665619e32d6e3a8154
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-05 17:36:29 +00:00
Sebastián Franco 6739770ea0 Merge "Set default grid when doing a backup and restore" into main 2024-04-05 17:23:25 +00:00
Zak Cohen 60e0bca4c3 Merge "Update OWNERS for Widget Picker team." into main 2024-04-05 17:19:01 +00:00
yyalan 12bd37ddd8 Fix homescreen rotation delay during fold
The issue is caused by the delay that Launcher handles the rotation; onDisplayInfoChanged that RotationHelper listens to is triggered later than the screen turning on. onDeviceProfileChanged is triggered earlier, but it only receives callback when in foreground. Using both listeners means that if in the background, we can still rely on onDisplayInfoChanged to update, assuming by the delay is tolerable given it takes time to changes to foreground.

Bug: 300929233
Flag: NA
Test: Manual and Perfetto trace in the bug
Change-Id: I5c6983649a38c3e4fe2b8c4a950435ceb07afa5a
2024-04-05 18:15:20 +01:00
Himanshu Gupta b04262784d Fix failing LauncherIntentTest.
Bug: 332894108
Test: atest Launcher3Tests
Flag: NA
Change-Id: I654a45d5a9371aa9da74ae89a0513bf203e27981
2024-04-05 18:11:06 +01:00
Holly Jiuyu Sun a65c0b97c3 Merge "[PS] Disable long press for install app button." into main 2024-04-05 16:59:22 +00:00
Schneider Victor-tulias 09268637b4 Merge "Add debug logs to TaskView" into main 2024-04-05 16:46:55 +00:00