Commit Graph

78507 Commits

Author SHA1 Message Date
Treehugger Robot 4fc8a9f965 Merge "[2/2] Fix widget resize frame show up at skewed location." into main 2024-04-09 22:26:55 +00:00
Sunny Goyal 8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Song Chun Fan ca79c70816 [Launcher/Archive] remove all checks for the archiving system property
No longer needed

Change-Id: I62c8843aa04a245d1dcc30f7787c71d17993f5d1
Merged-In: I62c8843aa04a245d1dcc30f7787c71d17993f5d1
BUG: 331165939
Test: builds
2024-04-09 22:05:26 +00:00
Song Chun Fan ab21ddb2da Merge "[Launcher/Archive] remove all checks for the archiving system property" into main 2024-04-09 22:05:08 +00:00
Treehugger Robot b155421ada Merge "Add debug log for RecentsView touch down" into main 2024-04-09 21:32:52 +00:00
Himanshu Gupta 6c089d7ac1 Merge "Adding TAPL tests for Private Space in Quickstep." into main 2024-04-09 21:12:09 +00:00
Fengjiang Li 59091e4612 [2/2] Fix widget resize frame show up at skewed location.
Wait until launcher is not animating to show resize frame

Fix: 331433240
Test: manual - took a photo
Flag: NONE
Change-Id: I3aec7f8bf2b6081134004b30de3d389e5b1ab253
2024-04-09 13:43:36 -07:00
Sunny Goyal 3b00e7909a Merge "Using resource override instead of code-swap for ApiWrapper" into main 2024-04-09 20:33:20 +00:00
Alex Chau 8ddacf2185 Merge "Add more logs tracking gesture and recents animation in RecentsView" into main 2024-04-09 20:32:19 +00:00
Alex Chau 55ef24c229 Merge "Add task menu item to move task to Desktop" into main 2024-04-09 20:31:47 +00:00
Holly Sun 6d8b85e83a [omni] Log LP duration & slop's data source and value.
For duration, the data source and value should be the same for LPNH and LPH. E.g., if AGSA overrides duration, it applies for both LPNH and LPH. When there is no AGSA override, there are cases that one of our feature flag is enabled and the other one is disabled. We just simply rely on LPNH's feature flag in this case. This should be fine because the purpose is to cross check the data source and its value.

Bug: 332722082
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS enabled
Change-Id: I3f10b944257e7021ae7c930b782f1d963c0e505b
2024-04-09 13:27:41 -07:00
Holly Jiuyu Sun 887a88f149 Merge "[omni] Read and use touch slop multiplier for LPNH." into main 2024-04-09 20:17:51 +00:00
Treehugger Robot cb8ad6edde Merge "Add debug log for TaskView.onClick" into main 2024-04-09 19:54:11 +00:00
Treehugger Robot 58d913d996 Merge "Fix BinderTests#testSwitchToOverview" into main 2024-04-09 19:41:29 +00:00
Himanshu Gupta 0d400993a9 Adding TAPL tests for Private Space in Quickstep.
This CL adds an initial test, that creates
private profile and verifies the elements
present in unlocked state.

More tests will be followed in next CL.

Doc: go/private-space-tapl

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I6032f4531818031991a5d51e23cfad22518250e6
2024-04-09 20:30:31 +01:00
Anushree Ganjam 59ab86218b Fill CellX , CellY and Rank for predictionRowView iteminfo.
HotseatPreditionController already does this: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/launcher3/hybridhotseat/HotseatPredictionController.java;l=239;drc=fe3f542e614df52cdcfa761074dd52957788a670;bpv=0;bpt=0

PreparePredictionInfo: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/launcher3/hybridhotseat/HotseatPredictionController.java;l=413-419;drc=6cdf7ce91a2643e02156d5ab8fb0f1c416f80c29;bpv=0;bpt=0

adb shell dumpsys activity NexusLauncherActivity

Before: https://paste.googleplex.com/4907497231482880

After: https://paste.googleplex.com/5157313861648384

Test: Manual
Flag: NA
Bug: 332171918

Change-Id: Ic9522238b2df06eb7c96b7f8961bc174fae17c9c
2024-04-09 11:57:13 -07:00
Sunny Goyal 11117d9b2a Using resource override instead of code-swap for ApiWrapper
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Iac19f32e64d2c76ed5b4f8592943ee4ae7af51b5
2024-04-09 11:14:44 -07:00
Schneider Victor-tulias 2dee591601 Fix BinderTests#testSwitchToOverview
This test has been failing because the "unexpected" Binder call is actually expected. Updated the test to account for this.

Flag: N/A
Fixes: 315075477
Test: BinderTests#testSwitchToOverview
Change-Id: I2f5d3d07f6ec373f394e7a6f3887000af5f63c7e
2024-04-09 14:04:34 -04:00
Holly Sun 9b11c40b01 [omni] Read and use touch slop multiplier for LPNH.
1) This part is missing from the previous set of CLs. `getLPNHCustomSlopMultiplier` is defined but unused. Similar as reading LPNHDuration, we should also read the touch slot multiplier in Launcher for LPNH.
2) Also, change type to float, which is consistent with our existing implementation and the definition in OverviewProxyService.
3) Slop value is in percentage and Launcher divide it by 100. We haven't got AGSA implementation yet so we can predefine this part.

Bug: 330444720
Bug: 330446188
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS disabled
Change-Id: Id606a4bc765fe01464ef36a2806c280ee42d30cd
2024-04-09 10:10:10 -07:00
Alex Chau 45162f9cf0 Add debug log for RecentsView touch down
Bug: 318590728
Test: manual
Flag: None
Change-Id: I591ed74af748f0fe424e1b58b4f610a21a106124
2024-04-09 17:46:38 +01:00
Alex Chau 34bfc7a80b Add debug log for TaskView.onClick
Bug: 310064698
Test: manual
Flag: None
Change-Id: Ib772dd8995442d3b1af84aec0668b11828ab62e6
2024-04-09 17:45:30 +01:00
Helen Cheuk a0dc66c206 Merge "Add focus outline to overview clear all button" into main 2024-04-09 16:27:27 +00:00
Vadim Tryshev 6ae89d13ff Merge "Re-enabling stress tests in presubmit" into main 2024-04-09 16:26:17 +00:00
Vadim Tryshev 5940c59a2c Merge "Honoring @PortraitLandscape annotation in presubmit" into main 2024-04-09 16:26:14 +00:00
Brian Isganitis 093b432985 Merge "Reset allAppsVisible if folding to phone upon recreateTaskbar." into main 2024-04-09 16:22:16 +00:00
Brian Isganitis 4ba8346a34 Merge "Use translation shift setter when showing AllApps without animation." into main 2024-04-09 16:21:54 +00:00
Alex Chau 3c0729c462 Add task menu item to move task to Desktop
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing

Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
2024-04-09 16:35:55 +01:00
Johannes Gallmann 75dd62fd22 Update predictive back progress interpolator
Bug: 332512902
Flag: ACONFIG com.android.systemui.predictive_back_sysui TRUNKFOOD
Test: Manual, i.e. analysing screenrecordings and verify that there are no more animation jumps at the start/end of the back animations
Change-Id: I99b13199032f7098fedb1cbd02cfe478d6fbb1f7
2024-04-09 14:11:40 +00:00
Liran Binyamin 60d4e8d3b8 Merge "Fix NPE when setting bubble bar bounds" into main 2024-04-09 14:04:19 +00:00
Vinit Nayak 0e920d2ca2 [automerger skipped] Merge "On disabled app pairs, set color tint instead of changing alpha" into 24D1-dev am: fc7f52967d -s ours
am skip reason: Merged-In Ifc8ac694f321a6b28996ba9a42860dfc419d5901 with SHA-1 09fe96b95a is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26860296

Change-Id: I5a38b585280b693fcf52d1f15c6dda4d9a6ee55d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-09 05:50:40 +00:00
Jeremy Sim 43a6065d80 [automerger skipped] On disabled app pairs, set color tint instead of changing alpha am: 00dc98c9e4 -s ours
am skip reason: Merged-In Ifc8ac694f321a6b28996ba9a42860dfc419d5901 with SHA-1 09fe96b95a is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26860296

Change-Id: I74810685ff051698f2156b2c59fd374d1cc84f09
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-09 05:50:37 +00:00
Vinit Nayak 7eeaf283c1 [automerger skipped] Add CUJ Jank interactions for App Pair saving and launching am: 674aa03862 -s ours
am skip reason: Merged-In Ia4944f8d23634bb92296938ea2d07a6babf6f77c with SHA-1 422a634a24 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26879812

Change-Id: I935f2444b8f7b9571f073dad9a0ffaa386516165
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-09 05:49:19 +00:00
Sunny Goyal 8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Vinit Nayak fc7f52967d Merge "On disabled app pairs, set color tint instead of changing alpha" into 24D1-dev 2024-04-09 05:40:02 +00:00
Vinit Nayak 26c11f2c49 Launch split tasks at beginning of animation instead of the end
* Ideally we animate the live leashes from the placeholder tasks,
that's a lot more changes at this moment so we don't do that
* Instead we just hold off fading in the leashes until the very
end of the animation
* This way taskbar can scale down correctly in both contextual and
app pair launch cases since now launcher visibility will be changed
at the same time

Bug: 308851855
Test: Launches are a bit snappier from workspace/all apps compared
to overview, but in a good way!(?)

Change-Id: I73a9284a2b1a993c5a020396e2aca8499fc5eb09
2024-04-08 22:28:01 -07:00
Jeremy Sim 6a60c3b113 Prevent menu items from showing on split tasks
This CL changes the TaskShortcutFactory for SCREENSHOT and MODAL so that the associated menu options ("Screenshot" and "Select") don't show up on split tasks. These actions are not fully supported on splitscreen tiles (they will only work on one of the two apps), so we disable them.

Bug: 327434215
Flag: N/A
Test: Manual
Change-Id: I121a9c28fa7570f10e13be2de6489182e3362cfc
2024-04-08 17:56:29 -07:00
Jeremy Sim be2a18d3fc Merge "Delete app pairs on model load if flag is turned off" into main 2024-04-09 00:38:42 +00:00
Jeremy Sim fa3eae99a5 Merge "Fix bug where app pair title was not updating with language" into main 2024-04-09 00:22:19 +00:00
Vinit Nayak 674aa03862 Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
Merged-In: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
2024-04-09 00:17:21 +00:00
Uwais Ashraf fe1a9c36b7 Merge "Use script to auto-enable all tests that are currently working" into main 2024-04-09 00:01:05 +00:00
Sunny Goyal 89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Jeremy Sim 00dc98c9e4 On disabled app pairs, set color tint instead of changing alpha
This CL changes the way disabled app pair icons are drawn: instead of setting alpha, it sets a color filter to indicate disabled status. This brings it in line with other apps icons and V's design specs.

Fixes: 326665140
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: Ifc8ac694f321a6b28996ba9a42860dfc419d5901
Merged-In: Ifc8ac694f321a6b28996ba9a42860dfc419d5901
(cherry picked from commit 09fe96b95a)
2024-04-08 23:37:50 +00:00
Android Build Coastguard Worker 6baf610701 Snap for 11685790 from 9462c3b604 to 24Q3-release
Change-Id: I075b43b714a1fa53602b56cd2601d37a820ff909
2024-04-08 23:21:13 +00:00
Song Chun Fan e5ad96ce10 [Launcher/Archive] remove all checks for the archiving system property
No longer needed

Change-Id: I62c8843aa04a245d1dcc30f7787c71d17993f5d1
BUG: 331165939
Test: builds
2024-04-08 23:14:07 +00:00
Vadim Tryshev 47f192f3be Merge "Restoring the full set of combinations in testDragShortcutToMultipleWorkspaceCells in presubmit" into main 2024-04-08 23:02:42 +00:00
Shamali Patwa b8714e1f7f Merge "Maintain the recommendations that were initially displayed" into main 2024-04-08 22:52:12 +00:00
Shamali Patwa 4c5472e6a1 Merge "Add maxlines bounds to the category title." into main 2024-04-08 22:51:56 +00:00
Brian Isganitis 6d63e7796d Reset allAppsVisible if folding to phone upon recreateTaskbar.
For taskbar unification, we should reset this bit to false when folding
into phone orientation. Otherwise, we will reinit Taskbar AllApps over
the phone UI which is unexpected behavior.

Test: Manual
Flag: N/A
Fix: 293379641
Change-Id: I53c38c8b4df477191be3c21b7750c55a71c7336f
2024-04-08 15:36:31 -07:00
Brian Isganitis 514f866f5c Use translation shift setter when showing AllApps without animation.
The no-animation case used to be handled immediately upon inflating the
view, so we got away with reassigning the field to
TRANSLATION_SHIFT_OPENED directly. Since this happens in post of a
handler, we need to instead use the setter so that a relayout happens.

Test: Manual
Fix: 324268840
Flag: N/A
Change-Id: I089f15a8d64e0d22885ae387679214a540790ad0
2024-04-08 15:15:41 -07:00
Jordan Silva 65972d5ba4 Merge "Update save app pair test to validate when icon chip menu is disabled" into main 2024-04-08 22:08:49 +00:00