Commit Graph

78507 Commits

Author SHA1 Message Date
Treehugger Robot c16efda876 Merge "Re-promote fixed test openPrivateSpaceSettings_triggersCorrectIntent to presubmit" into main 2024-07-09 21:53:16 +00:00
Liran Binyamin e1d5ce2fda Merge "Dump some bubble data to dumpsys" into main 2024-07-09 21:41:46 +00:00
Liran Binyamin fef9d249bd Fix bubble update animation
Fix bubble update animation when the updated bubble is the only
bubble in the bar.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 352119655
Test: Manual:
       - Create 1 bubble in the bubble bar
       - Send an update for that bubble
       - Observe bubble bar is animated correctly
Change-Id: If569810dacf0ef77147a822c53ddebd09e35fe15
2024-07-09 16:47:36 -04:00
Fengjiang Li 6944c9e63f [Launcher Jank] Add TODO for LauncherPreviewRenderer to set bg handler on smartspace BaseTemplateCard
Fix: 347775522
Flag: NONE - performance change
Test: manual
Change-Id: I19ba67e1eabfe02c45909d85d723bc28a78ae6df
2024-07-09 13:38:32 -07:00
Treehugger Robot 25d19bdb85 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: 34d12a2d6d -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28215172

Change-Id: If7768daa9d9728534774d8b25bcb70e612ee1be7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-09 20:09:09 +00:00
Bill Yi c639d8398e [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 59d8954a6c -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28215172

Change-Id: I873dd57cb5a6fa535794db5960325bdcbf136263
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-09 20:09:06 +00:00
Treehugger Robot 582dc5e96e [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: 995791cde7 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28215170

Change-Id: Id4f4548c12e8ecf39c9b18e5b32ea02cc166601c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-09 20:09:02 +00:00
Bill Yi c4055d2f26 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 16a7df47d3 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28215170

Change-Id: I9d6468b1f4f8b603eaa1e8673e832b8167aeb282
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-09 20:08:58 +00:00
Bill Yi 701bf344b6 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: b4896bfd76 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28214598

Change-Id: I93a5d6e4707ec43cfa3ba71bc9cbffbf084a9f7f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-09 20:08:47 +00:00
Treehugger Robot 580fc6d747 Merge "Show full page view if categorized view is low density in large screen" into main 2024-07-09 20:05:04 +00:00
Liran Binyamin a7a5617466 Merge "Fix bubble translation x when bar is collapsed" into main 2024-07-09 19:54:05 +00:00
Brandon Dayauon 1a18fb83b3 Merge "Adding logs to baseAllAppsAdapter to investigate private space icon alpha issue." into main 2024-07-09 19:52:44 +00:00
Treehugger Robot 34d12a2d6d Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-07-09 19:50:29 +00:00
Treehugger Robot 995791cde7 Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-07-09 19:50:29 +00:00
Federico Baron 07acdf105c Merge "Increase spring loaded hover time for tests since we switch pages too quickly leading to flakiness" into main 2024-07-09 19:39:57 +00:00
Treehugger Robot 6f7be465c0 Merge "Taskbar running apps: show one icon per task + tap opens that task" into main 2024-07-09 19:01:02 +00:00
Shamali P 81fc278760 Show full page view if categorized view is low density in large screen
UX prefers full page view over low density categorized view in tablets.

Bug: 347288847
Test: Screenshot (see the tablet screenshots vs foldable)
Flag: EXEMPT BUGFIX
Change-Id: I6c8ad36dc6169c65aea4e655af0542958e555669
2024-07-09 18:27:21 +00:00
Winson Chung b5522f0564 Merge "Workaround for crash with null icon drawable" into main 2024-07-09 17:42:28 +00:00
Liran Binyamin 0f08377436 Fix bubble translation x when bar is collapsed
Previously the translation x value for bubbles when the bar is
collapsed and on the right was 0 for the first bubble and some
fixed value for the rest of the bubbles. But if only 1 bubble
is visible when the bar is collapsed, as in the case when there
is only 1 bubble and the overflow, this ends up pushing the
overflow too far to the right.

This change updates the translation x value for bubbles when the
bar is collapsed and on the right, so that if only 1 bubble is
visible when collapsed, all bubbles have tx 0, otherwise if 2
bubbles are visible, the first has tx 0 and the rest have the same
tx value.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 350962159
Test: manual
       - Add 1 bubble to the bubble bar
       - Make sure bubble bar is on the right
       - Expand and collapse the bar
       - Observe the overflow tx value is correct during the animation
Change-Id: I8401d70fa6f374ace58d9cdbe3302e39e7aedc70
2024-07-09 13:10:12 -04:00
Federico Baron 44faf4cc9e Merge "Add screenrecord to TaplThemeIconsTest#testShortcutIconWithTheme" into main 2024-07-09 17:09:46 +00:00
Schneider Victor-tulias d0811445d4 Merge "Add CUJ instrumentation for KQS" into main 2024-07-09 17:07:42 +00:00
fbaron c275f53fbc Increase spring loaded hover time for tests since we switch pages too quickly leading to flakiness
Bug: 344982276
Test: TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible
Flag: TEST_ONLY
Change-Id: I2d187e37ee33f25b9b672beb3efb91300d96cab3
2024-07-09 09:48:56 -07:00
Federico Baron 501e4ab75a Merge "Revert "Fix attempt for TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible"" into main 2024-07-09 16:47:18 +00:00
Brandon Dayauon 6073fa296c Make close button to use google symbol library icon and update close color button
spec: https://docs.google.com/presentation/d/1tTODboxGqJ3ypEyYnr0-bUpSXcvX1cl6Sj8y0Nut5hU/edit?resourcekey=0-9GT8EJG43kTT4aKPWVWRig#slide=id.g2df5f2c9773_4_0
CloseButtonColor to be scLOW
CloseIconColor to be onSurface

bug: 342246204
Test: manually photos:
beforeLT: https://drive.google.com/file/d/14O61WzHmeAhOdGirUci2u9vot3FWcSKo/view?usp=sharing
beforeDT: https://drive.google.com/file/d/1Dt75_sRIWNHMuwqnYzE1WvjRTZFHWJ8-/view?usp=sharing
afterLT: https://drive.google.com/file/d/1npg-icWcsEN5OCgMtP1oU7mB-gGuT6_n/view?usp=sharing
afterDT: https://drive.google.com/file/d/11LTC_61QTg4tX0SUO23cAbLaP7aoSnh-/view?usp=sharing
Flag: NONE Color change
Change-Id: I0c47c927c5c8094a018e6f18061e99fc4bd901de
2024-07-09 09:39:03 -07:00
Gustav Sennton f3108c59ed Taskbar running apps: show one icon per task + tap opens that task
Before this CL we would show only one Taskbar icon per app, making it
impossible (through the taskbar) to switch between several windows of
the same app.
With this CL we add one icon per task instead, making it possible to
bring each task to the front individually.

Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 351118893
Bug: 349790805
Bug: 351156858
Test: Started several Chrome windows -> taskbar has one icon per window

Change-Id: Ia692977effceb9ce339906bf6ca24d73e19d8769
2024-07-09 14:48:04 +00:00
Schneider Victor-tulias c957e68e17 Merge "Add fallback handling for gesture nav mode switch and launcher destroyed mid-gesture" into main 2024-07-09 14:37:02 +00:00
Liran Binyamin fad57132d3 Dump some bubble data to dumpsys
Flag: NONE added dump logs
Bug: 350753857
Test: manual
       - adb shell dumpsys activity service com.android.quickstep
Change-Id: I19d328f99e5ba887aa508ea9ab16e9778f13698b
2024-07-09 10:34:19 -04:00
Treehugger Robot bb2e973297 Merge "Add NaN handling to SpringAnimationRunner" into main 2024-07-09 04:42:44 +00:00
Vinit Nayak 71c9a887c9 Merge "Add divider bg placeholder to app pair icon launch" into main 2024-07-09 04:18:56 +00:00
Winson Chung 510a00958c Workaround for crash with null icon drawable
- Fallback to using a transparent drawable for the split select icon
  if one can't be resolved

Flag: EXEMPT bugfix
Bug: 342465270
Test: Instructions from the bug
Change-Id: I5e4366b08bf438df96669ad3742bc9fb998bf0b3
2024-07-09 04:14:52 +00:00
Android Build Coastguard Worker 6bcaf3df98 Merge cherrypicks of ['googleplex-android-review.googlesource.com/28173793'] into 24Q3-release.
Change-Id: I63384015f7ad54b8e7c4caae31df5915add78004
2024-07-09 03:01:34 +00:00
Vinit Nayak 1855ef15b9 Initialize SplitSelectStateController for 3P before setting content view
* RecentsView#onAttachedToWindow relies on splitSelectStateController
being initialized, so we now do it before RecentsActivity calls
setContentView()

Bug: 332643607
Test: Couldn't repro before or after :(
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4276ee4897f59cfb1a2e432adfe54196b1a0dd2d)
Merged-In: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
Change-Id: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
2024-07-09 02:41:34 +00:00
Treehugger Robot fed75d832d Merge "Adds aconfig flag for new archiving icon" into main 2024-07-09 02:17:23 +00:00
Shamali Patwa a84049f4fe Merge "Update the title and description provided by intent params." into main 2024-07-09 02:01:40 +00:00
fbaron fd2fc06d69 Add screenrecord to TaplThemeIconsTest#testShortcutIconWithTheme
Flag: TEST_ONLY
Test: TaplThemeIconsTest#testShortcutIconWithTheme
Bug: 350557998
Change-Id: I38eb6558ece4cc23272a813d52ea677b8d9ad2cb
2024-07-08 15:41:06 -07:00
Federico Baron 20e7a59bff Revert "Fix attempt for TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible"
This reverts commit 347b408f90.

Reason for revert: didn't resolve the issue

Change-Id: I05563ffd3c83b4633007407953e2050ee2c87866
2024-07-08 22:32:48 +00:00
Charlie Anderson e16036f5f6 Adds aconfig flag for new archiving icon
Bug: 350758155
Test: N/A
Flag: com.android.launcher3.enable_new_archiving_icon
Change-Id: Id8bef6b127954d3a3b95c33670459a88148aa63d
2024-07-08 16:40:57 -04:00
Shamali P 012ad2fc07 Align the launch location passed to prediction session
Matches the prediction helper (the prediction service ignores added
widgets if launch location doesn't match the pattern. The size / pos
details however aren't used, so we pass defaults.

With this, prediction service may be able to predict widgets that
aren't already added, hence providing more suggestions.

Bug: N/A
Test: Unit test
Flag: EXEMPT BUGFIX
Change-Id: Ieaba4c9a8354dc96ea2bc70cafa106978037c572
2024-07-08 19:56:47 +00:00
Brandon Dayauon 4dd2907022 Adding logs to baseAllAppsAdapter to investigate private space icon alpha issue.
bug: 349766550
Test: N/A
Flag: com.android.launcher3.enable_private_space
Change-Id: I7ac8b538adc6cf8ad8ca801b703fd88d6287f18f
2024-07-08 12:28:11 -07:00
Schneider Victor-tulias 00df2a9d6a Add NaN handling to SpringAnimationRunner
Also Added some debug logs

Flag: com.android.launcher3.enable_additional_home_animations
Fixes: 340426016
Test: Forced NaN and checked logs
Change-Id: Iee3536e764752a79f97e77c2ccaa8fdaa81a6eef
2024-07-08 19:07:50 +00:00
Schneider Victor-tulias 0b15d98271 Add fallback handling for gesture nav mode switch and launcher destroyed mid-gesture
If the gesture nav mode switches to button nav mode mid gesture, specifically while a recents animation start is pending, then we never invalidate AbsSwipeUpHandler. This leaves the LauncherInitListener registered in the ActivityTracker until the AbsSwipeUpHandler is invalidated by something like a quick switch. Since the AbsSwipeUpHandler is not invalidated by pressing the home button, this leaves the home button seeming unresponsive.

Also added some clean up logic and debug logging to AbsSwipeUpHandler.onTasksAppeared since this path was confusing this investigation.

Flag: NONE code clean up, debug logs and bug fix
Fixes: 340748907
Test: adb shell cmd overlay enable-exclusive --category com.android.internal.systemui.navbar.threebutton && adb shell am start -n <component> while mid-gesture
Change-Id: I72f0656a2a2b92006d2d13ba5868062f2f0aec33
2024-07-08 18:47:01 +00:00
Tracy Zhou 810cab2e9c Merge "Get rid of multiple haptic feedbacks when long pressing on nav buttons" into main 2024-07-08 17:48:07 +00:00
Liran Binyamin a7821390e2 Fix squished hotseat due to bubbles
Hotseat supports adjusting its layout to make room for bubbles when
needed. There are 2 events that trigger this:
  1. When Hotseat's layout is reset, it checks for whether bubbles
     are showing.
  2. When Bubble Bar visibility changes it notifies hotseat so that
     it can update itself.

Folding the device is recreated triggers both hotseat layout reset
and recreation of taskbar, but the order in which these happen is not
guaranteed. Sometimes hotseat checks for the status of bubble bar
which may be visible if taskbar hasn't been recreated yet.

This change makes sure that hotseat updates itself after taskbar is
recreated and the ui controller is set, so that it cleans up any
adjustments it may have if bubbles are not visible.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349430356
Test: manual
       - unfold the device
       - create bubbles
       - observe hotseat adjusts itself for the bubble bar
       - fold the device
       - observe bubble bar is gone and hotseat shows correctly
Change-Id: I58d925c178b02c22583488ae081d478bbbbccc8c
2024-07-08 09:59:26 -04:00
Bill Yi 59d8954a6c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I48edcb7ed90f673ff5e2d7033c93082793d2e6ca
2024-07-08 05:43:45 -07:00
Bill Yi 6a67909064 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I66d9ea0f6ba47170added3139d91f9b76dd7ed0d
2024-07-08 05:43:16 -07:00
Bill Yi 16a7df47d3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I37a818837b8d38fd86120d968689f4894ec9ecf8
2024-07-08 05:42:48 -07:00
Bill Yi 93a3ec5e26 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I332f6a27769e4f9ac2d26b535cd7e825c8aaf536
2024-07-08 05:42:26 -07:00
Bill Yi b4896bfd76 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie0c78880e169d20898c63ca1e48cefc89c290cc9
2024-07-08 05:42:04 -07:00
Bill Yi 6e36413d55 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I609e3d36ba2dfad376a840746ac68c4fbd7c53ba
2024-07-08 05:41:37 -07:00
Treehugger Robot 892d358394 Merge "Make DeskopTaskView use latest TTV" into main 2024-07-08 12:05:53 +00:00