Commit Graph

78507 Commits

Author SHA1 Message Date
Johannes Gallmann 2e19e736bd Use default cross-activity animation in Launcher Home Settings
Bug: 347161956
Flag: EXEMPT bugfix
Test: Manual, i.e. verifying that default cross-activity animation is played
Change-Id: I27c67f727a4168bef12601955a03703becdd1698
2024-07-08 10:21:08 +00:00
Alina Zaidi f9fc3cf180 Merge "[Dev option] Move DesktopModesStatus to wm/shell/shared/desktopmode from wm/shell/shared/" into main 2024-07-08 09:49:20 +00:00
Tracy Zhou d289ca471b Get rid of multiple haptic feedbacks when long pressing on nav buttons
When returning false in a onLongClickListener, the touch event gets dispatched to onClickListener at release.

Fixes: 351457303
Test: long press and short press both result in one haptic feedback
Flag: EXEMPT bugfix
Change-Id: Id173a2d1fcf2f61c3289c653809207425b468a82
2024-07-05 23:26:45 -07:00
Alex Chau 3fde467b41 Make DeskopTaskView use latest TTV
- Made TaskThumbnailViewDeprecated nullable in TaskContainer, with non-null getter that requires feature flag to be on/off
- Removed TaskThumbnailViewDeprecated.setTaskOverlay, as it'll now be null with feature flag on
- Removed TaskThumbnailViewDeprecated from DesktopTaskView xml
- Simplifed DesktopTaskView binding logic, to always get thumbnailViews from viewPool, removeView and recycle all thumbnailViews in onRecycle
- Didn't implement view pooling of TaskThumbnailView due to difficulty with TaskContainer not being recycled togetehr with TaskThumbnailView

Bug: 338360089
Test: TaskThumbnailViewModelTest
Test: manual testing for DesktopTaskView for both enable_refactor_task_thumbnail on and off
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I38a6dfc6bc561689578d1660794f91d30bad4a68
2024-07-05 18:39:56 +01:00
Alina Zaidi 05cc31a613 [Dev option] Move DesktopModesStatus to wm/shell/shared/desktopmode from
wm/shell/shared/

Test: not needed, just refactoring. mp droid builds
Bug: 348193756
Flag: EXEMPT just refactoring
Change-Id: I6dd19f4203a2336f50bc26ac5b292057bb79ce37
2024-07-05 11:12:35 +00:00
Treehugger Robot a00c81c173 Merge "Change thumbnail/icon to get the image rather than updating it" into main 2024-07-04 17:13:37 +00:00
Schneider Victor-tulias acddb58539 Add CUJ instrumentation for KQS
Flag: NONE LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Bug: 339585624
Test: manually checked that CUJ calls were reached
Change-Id: Ifd2b92451c5ed2ebc35834c1d2f495275db3d49a
2024-07-04 10:44:26 -04:00
Uwais Ashraf 551927c6d3 Change thumbnail/icon to get the image rather than updating it
Flag: EXEMPT no-op refactor
Bug: 334826842
Test: existing screenshot tests
Test: Manual - checked icon loading
Change-Id: Ie1da708f911ba569d6464f338dc4efac92420268
2024-07-04 12:18:56 +00:00
Treehugger Robot 9ec1bc48d0 Merge "Remove deprecated initOverlay interface used by TaskOverlayFactoryGo" into main 2024-07-04 08:50:28 +00:00
Android Build Coastguard Worker 8683a2632b Merge cherrypicks of ['googleplex-android-review.googlesource.com/28102349'] into 24Q3-release.
Change-Id: I151b0b299990b21634a49ffc1b5a499bd30734b9
2024-07-04 03:25:21 +00:00
Saumya Prakash 62462a50ee Prevent Taskbar edu dismissal from touching outside of the window.
In an effort to encourage users to look at Taskbar edu more thoroughly,
this change makes it so users have to press the 'Done' button explicitly
to close the taskbar edu window. This change also adds the ability for
it to be dismissed by the back gesture. It only applies to the features
edu, and not other taskbar educations.

Fix: 349612575
Test: Manually run all versions of taskbar edu and ensure that the edu only goes away with back gesture, swipe up or clicking on the DONE button
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:17339843e76cb507413e1d22dcf0c7982e024379)
Merged-In: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
Change-Id: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
2024-07-04 03:14:55 +00:00
Brian Isganitis f7ca8d60be Merge changes I6e7c349d,If6c74b3b,Ib276e9dc,Ida0f7cc0 into main
* changes:
  Override DisplayController on main thread.
  Add annotations for manipulating secure settings.
  Don't use UiThreadTest for Taskbar Unit tests.
  Suspend Launcher taskbar while removed for tests.
2024-07-04 02:26:46 +00:00
Treehugger Robot f49f87decf Merge "Scale AppPair background on hover." into main 2024-07-04 01:30:10 +00:00
Treehugger Robot 12e13d89e1 Merge "Initialize SplitSelectStateController for 3P before setting content view" into main 2024-07-04 00:00:32 +00:00
Sebastián Franco 7c7794e020 Merge "Update back gesture zone any time the screen size changes." into main 2024-07-03 23:22:59 +00:00
Treehugger Robot 564209829d Merge "Prevent taskbar icon tooltip from showing on hotseat transition." into main 2024-07-03 23:06:44 +00:00
Federico Baron 651448cb98 Merge "Demote TaplThemeIconsTest#testShortcutIconWithTheme" into main 2024-07-03 22:43:39 +00:00
Vinit Nayak 4276ee4897 Initialize SplitSelectStateController for 3P before setting content view
* RecentsView#onAttachedToWindow relies on splitSelectStateController
being initialized, so we now do it before RecentsActivity calls
setContentView()

Bug: 332643607
Test: Couldn't repro before or after :(
Flag: EXEMPT bugfix
Change-Id: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
2024-07-03 22:18:05 +00:00
Sebastian Franco 00ed8ccde7 Update back gesture zone any time the screen size changes.
Fix: 336697780
Test: Manual testing, open widget picker on folded front screen and then unfold, the widget picker should be showing and the backgesture should work.
Flag: EXEMPT bugfix
Change-Id: Ie4a7bffbd9b24ba26826f825a7c66216f565952f
2024-07-03 13:54:39 -07:00
fbaron 7672f320e8 Demote TaplThemeIconsTest#testShortcutIconWithTheme
Bug: 350557998
Test: TaplThemeIconsTest#testShortcutIconWithTheme
Flag: TEST_ONLY
Change-Id: I236fdd0bab678a385553d40f8a0dabbe78f92b5b
2024-07-03 13:51:53 -07:00
Vinit Nayak afdd0d3b31 Add divider bg placeholder to app pair icon launch
* Extract out both the top level split root leash
as well as the left and right split root leashes
* Set windowCorner radius on the left/right roots

Test: No more flicker near divider when launching app
pair (see comment for video in CL)
Flag: EXEMPT bugfix
Bug: 349387413

Change-Id: I6fce290d1e7766e55c2f11cc8c365f0c29087c0f
2024-07-03 11:27:41 -07:00
Kevin Lim aed2aa04ba [AllAppsStore] Dump class name in addition to package name for debugging
Bug: 333889822
Flag: EXEMPT Logging fix
Test: EXEMPT Logging fix
Change-Id: I9e1515c04bdc8381f96341e7211968fcc53f97cc
2024-07-03 18:03:30 +00:00
Alex Chau cd894eeae2 Merge "Make sure thumbnailViewDeprecated is only accessed when refactor flag is off" into main 2024-07-03 15:54:09 +00:00
Shamali P 96ebf67b9f Update the title and description provided by intent params.
Bug: 347288851
Flag: EXEMPT flagged in sys ui
Test: Manual (automated covered in b/339716822)
Change-Id: I71f21bc48fd03dbbe2b3804b7fcade5940606917
2024-07-03 15:49:32 +00:00
Olivier St-Onge 25eaff395e Merge "Stash taskbar when a SysUI dialog appears." into main 2024-07-03 15:20:17 +00:00
Treehugger Robot ff4f1624a9 Merge "Support TaskOverlay with new TaskThumbnailView" into main 2024-07-03 15:01:51 +00:00
Liran Binyamin 50586a37e9 Merge "Don't animate the bubble that was dismissed by drag" into main 2024-07-03 14:43:12 +00:00
Alex Chau d264071151 Make sure thumbnailViewDeprecated is only accessed when refactor flag is off
Bug: 338360089
Test: Manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I8f3bdf0308bf2dec30528ebd8ece404716578838
2024-07-03 14:52:40 +01:00
Shamali Patwa 10923a2985 Merge "Fix issue that ACTION_CLICK a11y action was removed from widget cell" into main 2024-07-03 13:45:05 +00:00
Alex Chau ac65a9979b Remove deprecated initOverlay interface used by TaskOverlayFactoryGo
Bug: 350931107
Test: presubmit
Flag: EXEMPT refactor
Change-Id: I3d03254d7c33118536e66268c1dbfebdf1130647
2024-07-03 14:17:25 +01:00
Alex Chau 58e8109d6e Support TaskOverlay with new TaskThumbnailView
- Also migrated getScaledInsets method into TaksOverlay

Bug: 335606129
Test: TaskOverlayViewModelTest
Test: TaskOverlayHelper is not tested because it should be a view-based screenshot test for TaskOverlay, which is currently impossible until we refactor TaskOverlay to MVVM
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I07a8657ff0fe925d8021875310e3ed12a712ba7a
2024-07-03 14:15:09 +01:00
Alex Chau 90808f8138 Merge "Move Overview-specific flags to a separate aconfig file" into main 2024-07-03 12:43:53 +00:00
Pat Manning fc1d2daa63 Prevent taskbar icon tooltip from showing on hotseat transition.
Fix: 350512938
Test: TaskbarHoverToolTipControllerTest
Flag: EXEMPT bugfix
Change-Id: Ifc1647834358366b2d98555138edd4ad6286c16e
2024-07-03 13:15:36 +01:00
Treehugger Robot 58f5d08d7a Merge "Show tooltip for AppPairs in taskbar on hover." into main 2024-07-03 12:09:40 +00:00
Jordan Silva 4db30dbc28 Move Overview-specific flags to a separate aconfig file
This is to keep the main launcher aconfig file more organized and easier to read and aligned with gantry namespace.

Bug: 349534860
Change-Id: Ib21fbac38ed0564fa481fce3a2da9a9b8c1a7139
Flag: EXEMPT - moving flags to another file
Test: EXEMPT - moving flags to another file
2024-07-03 10:49:51 +00:00
Pat Manning 19d5bc7a48 Scale AppPair background on hover.
Fix: 342133586
Test: manual.
Flag: EXEMPT bugfix
Change-Id: I2846b5543076688a90e8b9067f848c59e4081ea2
2024-07-03 11:31:11 +01:00
Treehugger Robot 4179538f33 Merge "WidgetPicker - allow user ids to be passed as filter arguments" into main 2024-07-03 08:51:36 +00:00
Brian Isganitis bfa3b7c80e Override DisplayController on main thread.
Bug: 230027385
Flag: TEST_ONLY
Test: TaskbarModeRuleTest
Change-Id: I6e7c349d50c8372ed0d4e1e8d5bfe7f108b2c2e2
2024-07-02 21:46:07 -04:00
Brian Isganitis 160ed1d31a Add annotations for manipulating secure settings.
By default, tests will run with user setup complete and kids mode
disabled.

Test: TaskbarUnitTestRuleTest
Flag: TEST_ONLY
Bug: 230027385
Change-Id: If6c74b3b2c07aa0eac5b6bda933b565351d65188
2024-07-02 21:46:05 -04:00
Brian Isganitis 8e5de6577b Don't use UiThreadTest for Taskbar Unit tests.
This annotation also runs the rule on the main thread, which can lead to
deadlocks with other threads (e.g. loading the model synchronously).

Change-Id: Ib276e9dc322f6f65bd32658e774d6076efb94f2e
Flag: TEST_ONLY
Test: Taskbar Unit Tests
Bug: 230027385
2024-07-02 21:45:23 -04:00
Brian Isganitis 8f1a1c4b6a Suspend Launcher taskbar while removed for tests.
This approach is less destructive than completely destroying Taskbar
while still ensuring it will not try to recreate itself.

Test: Taskbar Unit Tests
Bug: 230027385
Flag: TEST_ONLY
Change-Id: Ida0f7cc0b9c5b1d53bbadc2bb9fd81689c7f3940
2024-07-02 21:42:23 -04:00
Federico Baron 025c8a0cc0 Merge "Add test for Folder undoing behavior" into main 2024-07-02 23:57:21 +00:00
Brian Isganitis 3ad18b451a Merge "Revert "Completely destroy Launcher's Taskbar."" into main 2024-07-02 23:20:58 +00:00
Zak Cohen a0a810daac WidgetPicker - allow user ids to be passed as filter arguments
Bug: 330377706
Test: adb shell am start -n com.google.android.apps.nexuslauncher/com.android.launcher3.WidgetPickerActivity --eial filtered_user_ids 1
0  check that WP doesn't show up
Flag: com.android.systemui.communal_hub

Change-Id: I375545190839101681a037a4481bf4cf92128d33
2024-07-02 15:07:01 -07:00
fbaron df62b6ffd7 Add test for Folder undoing behavior
Fix: 341799410
Test: FolderTest#undoFolder
Flag: TEST_ONLY
Change-Id: I8bfb3fc9348290274b33f4b5b6531126c658037c
2024-07-02 15:02:09 -07:00
Brian Isganitis e1a2b67f2b Revert "Completely destroy Launcher's Taskbar."
Revert submission 28102205

Reason for revert: Potential test breakage.

Reverted changes: ag/28102205

Change-Id: If7fa1ff192a240e753e5c245d591d46e594e5a6f
Flag: TEST_ONLY
Bug: 230027385
Test: Presubmit
2024-07-02 17:00:11 -04:00
Shamali P 3f571468db Fix issue that ACTION_CLICK a11y action was removed from widget cell
In the past, tap didn't do anything, but now that we reveal add button
it should be kept.

Bug: 335029809
Flag: EXEMPT BUGFIX
Test: With switch access (see video)
Change-Id: I2ca9086f0dd4b0c9ac8167ab32aa278d4e2d1211
2024-07-02 20:33:43 +00:00
Hongwei Wang 81a637089e Merge "Apply cutout offset when applicable" into main 2024-07-02 18:20:46 +00:00
Vinit Nayak e04ca157e2 Merge "Make quickswitch splash reveal animation split aware" into main 2024-07-02 17:57:38 +00:00
Pat Manning 0e89070e1a Show tooltip for AppPairs in taskbar on hover.
Fix: 350744397
Test: TaskbarHoverToolTipControllerTest
Flag: EXEMPT bugfix
Change-Id: Ic2273f17d01d1068ceaddca8a5c115b551b35856
2024-07-02 18:22:44 +01:00