Commit Graph

78507 Commits

Author SHA1 Message Date
Bill Yi 833672b657 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 4f8678642b -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28324364

Change-Id: I3857d8704f5359b0a3c80246df9ad107cc8d9306
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-16 17:53:14 +00:00
Bill Yi 6af940b058 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 25da1d83d1 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28323489

Change-Id: I1af0b6aafbb0663559c619e73b7cc12135f9f89c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-16 17:53:06 +00:00
Jagrut Desai 84151055b7 Add support for different container and space calculation logic.
This CL includes
	- Taskbar container enum class and interface for container to calculate their space needed.
        - Inits and getter of util classes in taksbar activity context.
        - Taskbar Icons specs not have default margins and minimum touch target specs
	- Updates to the test
        - Logic for calculating the space needed for taskbar container

Test: Presubmit
Bug: 341146605
Flag: com.android.launcher3.enable_taskbar_customization
Change-Id: I89e9d521476902a9027f6fd0cebdc2690b2e5f31
2024-07-16 10:48:51 -07:00
Treehugger Robot 666fec0c77 Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-07-16 17:36:04 +00:00
Treehugger Robot cd4d7f56cb Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-16 17:27:16 +00:00
Treehugger Robot d87c8cb2b2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-16 17:27:16 +00:00
Stefan Andonian 487a21726d [Test Week] Move ListenableHostView into it's own class for ease of unit testing.
Bug: 353303621
Test: Verified with follow-up unit test CL.
Flag: EXEMPT unit test
Change-Id: Idfdaca0bee7f162f6e6ac60b1ddb53458603c227
2024-07-16 16:50:43 +00:00
Fengjiang Li f04eeb5eee Merge "[Test Week] Add ViewCacheTest" into main 2024-07-16 16:36:28 +00:00
Sihua Ma 5132315aee Merge "Add test for LauncherWidgetHolder" into main 2024-07-16 15:49:44 +00:00
Johannes Gallmann 93af1db6a3 Fix CUJ_LAUNCHER_APP_CLOSE_TO_HOME Cuj for predictive back to home
CUJ_LAUNCHER_APP_CLOSE_TO_HOME was broken because in the non-fallback case, the anim on which addCujInstrumentation was called on was empty.

Bug: 300078127
Flag: com.android.window.flags.predictive_back_system_anims
Test: Manual, i.e. verifying that CUJ_LAUNCHER_APP_CLOSE_TO_HOME shows up properly in perfetto trace with the fix applied in the predictive back case
Change-Id: I4a1130bd7c4622c057db054d829f662a16443799
2024-07-16 13:42:03 +02:00
Cosmin Băieș eccda9419d Update IME switcher icon in taskbar
This updates the icon of the IME switcher button used in taskbar.

Test: show taskbar and verify icon manually
Bug: 311791923
Flag: android.view.inputmethod.ime_switcher_revamp
Change-Id: I0288601717ab9d0f6842766df62599c51c5a2b4f
2024-07-16 10:26:35 +02:00
Riddle Hsu ebc6bf5014 Merge "Avoid changing transform when touching in progress" into main 2024-07-16 04:50:11 +00:00
Brian Isganitis d52e15b35a Add subrule for controlling an individual Taskbar preference.
Test: TaskbarPreferenceRuleTest, TaskbarPinningPreferenceRuleTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I382c7e17a5739823c25fc8d64c981405af56e3e4
2024-07-15 22:39:27 -04:00
Brian Isganitis e3d3d653d1 Taskbar Pinning Preference Rule fixes.
- Actually evaluate statement in tests.
- Enable aconfig flag for taskbar pinning.
- Allow DisplayController Taskbar mode to change in test harness.
- Make DisplayController think it's in desktop mode when needed.

Flag: TEST_ONLY
Bug: 230027385
Test: TaskbarPinningPreferenceRuleTest

Change-Id: I1c55f73cb5a4bb903cd2d628fa47fbd5e8b1bb86
2024-07-15 22:34:01 -04:00
Fengjiang Li 7c8f90f04a [Test Week] Add ViewCacheTest
Number of new tested methods: 3

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I235ba375db12b9f3fac6f204018b32e692835eab
2024-07-15 16:51:10 -07:00
Android Build Coastguard Worker bf4a7385c1 Merge cherrypicks of ['googleplex-android-review.googlesource.com/28255751'] into 24Q3-release.
Change-Id: I25c866ebe559df2c3a4eab38ff22d456f89471c0
2024-07-15 23:20:06 +00:00
Alex Chau 5fbc9a5d5d Perform state switch to Overview from -1 screen
- This fixed a regression caused by ag/27904180, where -1 is no longer considered `visibleLauncher`. -1 still have Launcher being top activity, and recents animation will always fail
- Added isInMinusOne in LauncherActivityInterface, and return Launcher in getVisibleLauncher for -1 case
- -1 should be the only case where Launcher is top activity, but is not started

Fix: 352254279
Test: Recents button from the following scenarios: Home, -1, apps, transparent apps, video from -1
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1cd3fe27f229da4f7bb80a2e04d1416cc050fc94)
Merged-In: I0898d202b9dd4742c0c7d2c0d6b340c748e8acf7
Change-Id: I0898d202b9dd4742c0c7d2c0d6b340c748e8acf7
2024-07-15 23:15:28 +00:00
Sihua Ma 7098ba260f Add test for LauncherWidgetHolder
Number of new tested methods: 8

Test: atest NexusLauncherRoboTests:LauncherWidgetHolderTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I8751c8de8d719e567775368d988794b2d7abc37e
2024-07-15 22:51:04 +00:00
Bill Yi 25da1d83d1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I57ee8549d4e1adfa45d23bdf0721055cf17fb619
2024-07-15 14:42:37 -07:00
Bill Yi e21b81fdeb Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If667a4fdadf307506c44c894f4c52a849fc3f94a
2024-07-15 14:42:07 -07:00
Bill Yi 4f8678642b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If32af03d3162501f90d9a829ecf4429df1a8f4dd
2024-07-15 14:41:11 -07:00
Bill Yi ed6b942cb8 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I52341b9a96ac15c3e27e6649b0b2fe47f1067e9b
2024-07-15 14:40:46 -07:00
Jagrut Desai dafd7f55ed Adding Skeleton Code for Customizable Taksbar
This cl includes
        - new skeleton xml view customizable taskbar view
        - new skeleton xml view for customizable taksbar container and a view class.
        - new taskbar all apps button view container class
        - pxFromDp util method introduction to launcher utilities

Test: Presubmit
Bug: 349885828
Bug: 349886203
Flag: com.android.launcher3.enable_taskbar_customization
Change-Id: Id83906ed0717da495c33275e52261153a1598074
2024-07-15 13:06:12 -07:00
Andrew Cole d798e6d1f9 Test Week - Deleting NexusTestInformationHandler
NexusTestInformationHandler only relied on one boolean switch that is not currently used so I am deleting it.

Bug: 353303621
Test: TAPL
Flag: TEST_ONLY
Change-Id: I6181d47561b318d1eb1bd632d4ae042e126cfdb9
2024-07-15 11:57:47 -07:00
Cosmin Băieș 1a0406e1be Merge "Add IME switch button long click support" into main 2024-07-15 18:06:02 +00:00
Treehugger Robot 72c4ebed6c Merge "Create scope for TTV attached to run collections that modify UI within." into main 2024-07-15 12:01:04 +00:00
Sam Cackett a94365b5af Merge "Maintain if any task has been dismissed in RecentsView state" into main 2024-07-15 10:46:10 +00:00
Uwais Ashraf f7093d445e Create scope for TTV attached to run collections that modify UI within.
Bug: 335396935
Test: Manual checking shows clear improvement of preformance problems
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I92aa4ce3edfe297cc5a177a2d93837d33cdfb548
2024-07-15 10:09:26 +00:00
Riddle Hsu cbc84d96ef Avoid changing transform when touching in progress
After swiping from a landscape app to portrait home, the touch
orientation may be changed if there the touch event comes in a
short time (e.g. click app icon immediately):
 DOWN
 MOVE...
 SimpleOrientationTouchTransformer#onDisplayInfoChanged
 MOVE... (start to transform with inconsistent orientation)
 UP

That could disturb the gesture detection:
OverviewInputConsumer#onMotionEvent
 > BaseDragLayer#proxyTouchEvent
  onInterceptTouchEvent, findControllerToHandleTouch
  > PortraitStatesTouchController#onControllerInterceptTouchEvent
   > BaseSwipeDetector#onTouchEvent
which may show the app drawer unexpectedly.

http://recall/-/b2qm27pJZxFIWQccA9qE9Q/ggLXlE5kf7AWMOjUc0FCUU

Bug: 351755391
Flag: EXEMPT bugfix
Test: atest NexusLauncherTests: \
            com.android.quickstep.OrientationTouchTransformerTest# \
            testSimpleOrientationTouchTransformer
Change-Id: Ic0e9d8292606837feb4775663abb60229c90e9c5
2024-07-15 16:41:42 +08:00
Brian Isganitis fd1cc12054 Merge changes I2b87ab88,I939d8202,Ibedd8cae into main
* changes:
  Introduce rule for changing taskbar pinning preferences.
  Reinject controllers when Taskbar recreates itself.
  Inline showTaskbarFromBroadcast.
2024-07-13 19:01:33 +00:00
Hongwei Wang a531da0b85 Merge "Revert "Disable gesture nav while PiP anim is running"" into main 2024-07-13 08:16:44 +00:00
Treehugger Robot 41d50792f4 Merge "Clamp scrim progress for slow taskbar animation duration to max 1f" into main 2024-07-12 23:29:56 +00:00
Brian Isganitis 803c85ac21 Introduce rule for changing taskbar pinning preferences.
Test: TaskbarPinningPreferenceRuleTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I2b87ab8823b17c364b3797a325c8b0d569a1d39a
2024-07-12 18:04:17 -04:00
Brian Isganitis c79c2fd28d Reinject controllers when Taskbar recreates itself.
Test: TaskbarUnitTestRuleTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I939d820271ba7e5426303ac4662d1d621d86c08b
2024-07-12 18:04:17 -04:00
Ikram Gabiyev fa096a77f6 Merge "Allow extra pixel for app bounds containment PiP" into main 2024-07-12 21:29:16 +00:00
Treehugger Robot 11a4756728 Merge "Resolve aconfig flag deps for Launcher" into main 2024-07-12 20:53:05 +00:00
Brian Isganitis 1a03740ebd Inline showTaskbarFromBroadcast.
Feels like it should be the activities' responsibility to coordinate the EDU with stashing. All of these methods are also public to TaskbarActivityContext.

Test: Compiles
Bug: 346394503
Flag: EXEMPT refactor
Change-Id: Ibedd8caec59da3b3a14c15d0c948bf1069ca3c6c
2024-07-12 16:00:50 -04:00
Ikram Gabiyev 402a96f588 Allow extra pixel for app bounds containment PiP
Allow an extra one pixel delta on each side of the
app bounds for source-rect-hint containment checks
when swiping to enter PiP.

Bug: 349821386
Flag: EXEMPT bugfix
Test: swipe PiP to home with 21:9 video from landscape to portrait
Change-Id: Ibc53e426b49cfcd58e977433358b9980732ac289
2024-07-12 10:46:16 -07:00
Liran Binyamin b67d4cc134 Merge "Fix regression in bubble animation" into main 2024-07-12 17:01:30 +00:00
Schneider Victor-tulias 25ff85efdc Merge "Add temporary debug logs to OtherActivityInputConsumer" into main 2024-07-12 16:57:31 +00:00
samcackett 0337520c7f Maintain if any task has been dismissed in RecentsView state
Fixes an issue in large screen layouts where the task order was
incorrectly being recalculated and the user would see their previous
tasks swap places.

Fix: 352308373
Test: Manual. In tablet view, open several apps, go to Overview, dismiss
 a task so the top row order changes, then swipe down the current
 focused task to resume. Observe order stays the same.
Flag: EXEMPT bugfix
Change-Id: Ic59e3125f69d36ba32d13436dba872f4d3a3d0df
2024-07-12 17:45:37 +01:00
Sebastián Franco 535267a00d Merge "Promote test testAddDeleteShortcutOnHotseat" into main 2024-07-12 16:03:17 +00:00
Liran Binyamin ef08582d36 Fix regression in bubble animation
This was a bug introduced in ag/28230638. Accidentally passed the
wrong boolean value. The bug is that the initial state animation
does not play, and the bubble bar remains invisible.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 352119655
Fixes: 352412093
Test: manual
       - Clear all bubbles
       - Send initial bubble
       - Observe that the initial state animation plays correctly
Change-Id: Ie1435539e348c0a92a11db0b58a0b3bce6525cc0
2024-07-12 15:55:36 +00:00
Schneider Victor-tulias f67d384f86 Merge "Revert^2 "Add CUJ instrumentation for KQS"" into main 2024-07-12 14:59:45 +00:00
Alex Chau e74d34673b Merge "Perform state switch to Overview from -1 screen" into main 2024-07-12 10:08:41 +00:00
Android Build Coastguard Worker 9898ac4b5f Merge cherrypicks of ['googleplex-android-review.googlesource.com/28231687', 'googleplex-android-review.googlesource.com/28240994'] into 24Q3-release.
Change-Id: I01869591a2667594683184770641529b09bcd80c
2024-07-12 04:04:10 +00:00
Bill Yi f061e8b26d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import

Bug: 347053373
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4bafcb8b1dd8d982eaa39c50ad0008539866ba5e)
Merged-In: Ia4bc42b575811c5371e2a6a84c5b83e65f36b01c
Change-Id: Ia4bc42b575811c5371e2a6a84c5b83e65f36b01c
2024-07-12 03:52:41 +00:00
Alex Chau 912edc94a1 focusTransitionScaleAndDimOut should always go from 1f to 0f
- Also updated AnimatedFloat to accept a Consumer<Float>, so a lambda can be used as updateCallback with refernce to udpated value
- Also updated PendingAnimation to accept Animator with TimedInterpolator without specifying SpringProperty

Fix: 352195519
Test: manual
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c378e64b757dbb83b6024be462a6752bc6a2c5f2)
Merged-In: Ifb78c1bcd3ca215a5d214f986a107d0988bff13b
Change-Id: Ifb78c1bcd3ca215a5d214f986a107d0988bff13b
2024-07-12 03:52:35 +00:00
Sebastian Franco e84cdcc468 Promote test testAddDeleteShortcutOnHotseat
Flag: TEST_ONLY
Test: testAddDeleteShortcutOnHotseat
Bug: 338869019
Change-Id: Ib3dd4fec0e8e6b4ac9e4233172197b557890ab15
2024-07-11 17:56:44 -07:00
Jared Duke 1222dd753c Resolve aconfig flag deps for Launcher
Only link in framework-declarared aconfig flags for targets that *don't*
reference platform APIs. Targets that do reference platform APIs will
inherit the framework-defined implementation, avoiding runtime classpath
collisions.

Bug: 352519114
Test: m + presubmit
Flag: EXEMPT refactor
Change-Id: I297a3c7929f41b065cc8b9c00d39dfd6ab831c96
2024-07-12 00:05:47 +00:00