Commit Graph

78507 Commits

Author SHA1 Message Date
Federico Baron f4aa900009 Merge "Fix attempt for TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible" into main 2024-07-02 15:31:50 +00:00
Liran Binyamin 13895f1be2 Don't animate the bubble that was dismissed by drag
This change stores the bubble that was dismissed by drag temporarily
in BubbleBarView so that when we remove the bubble, we can avoid
updating it as part of the animation.

This is step 1 in this change. Next I'll look into removing the
bubble immediately after dismissing it from the menu, and lastly
update sysui to not send the removal event back to launcher.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 349826879
Test: manual
       - have bubbles in the bubble bar and expand it
       - drag a bubble to dismiss it
       - observe the bubble does not reappear in the bar during
         the animation
Change-Id: I6628ce779db4aac8d82edd4ecf2a25dedf8feef9
2024-07-02 10:48:22 -04:00
Saumya Prakash 66364f9657 [automerger skipped] Prevent Taskbar edu dismissal from touching outside of the window. am: 443d0600d5 -s ours
am skip reason: Merged-In I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3 with SHA-1 17339843e7 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28105075

Change-Id: If0e82b8b41c3b0503664bc6513aa4daf08569b4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-02 09:37:03 +00:00
Treehugger Robot 6bf444c3c9 Merge "Only commitRunningAppsToUI if shownTasks changed" into main 2024-07-02 09:07:41 +00:00
Tracy Zhou 30de75309d Merge "Fix task bar transitions applied to unfolded task bar" into main 2024-07-01 23:33:29 +00:00
Hongwei Wang 27df26a798 Apply cutout offset when applicable
Removed the check on safeInsets#top and apply the offset.
Updated also the comment.

Flag: EXEMPT bugfix
Bug: 331128612
Test: Hold unfolded foldable in different orientation, enter PiP
Test: Hold folded foldable in different orientation, enter PiP
Change-Id: I56442ab2c4bfb1bf7ac68561aee8c0cc1fb183a8
2024-07-01 16:09:23 -07:00
Saumya Prakash 98d8094688 Merge "Add developer option to reset taskbar search edu" into main 2024-07-01 22:33:24 +00:00
Kevin Lim 9baf064a9a Merge "[E2E] Re-enable stable widget tests." into main 2024-07-01 20:30:12 +00:00
Vinit Nayak 1381196565 Make quickswitch splash reveal animation split aware
Bug: 309059057
Test: Quickswitched with split and fullscreen apps in
portrait and landscape
Flag: EXEMPT bugfix

Change-Id: If175d2d3008b71372610cf380d44bad7a07aa255
2024-07-01 13:01:42 -07:00
Tracy Zhou c97138e93d Fix task bar transitions applied to unfolded task bar
Bug: 350102824
Test: Task bar scrim doesn't happen
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ib0510d9e01b30b50bd5d295b23688547b1decef3
2024-07-01 13:00:46 -07:00
Saumya Prakash 1465e37dcb Add developer option to reset taskbar search edu
This change allows you to view taskbar search edu again by tapping the
"Taskbar Search Edu" option in launcher developer options.

Fix: 350537725
Test: Go to developer options and reset the taskbar search edu. Check
that it shows up the next time an app is launched (and if the taskbar is pinned)
Flag: EXEMPT bugfix

Change-Id: I5a0e992ef3b3d62c62998a7bbe648e4598cdde54
2024-07-01 19:13:48 +00:00
fbaron 347b408f90 Fix attempt for TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible
Bug: 344982276
Test: TaplTwoPanelWorkspaceTest#testSinglePageDragIconWhenMultiplePageScrollingIsPossible
Flag: TEST_ONLY
Change-Id: I2f02b769aaae353d48501b8e3551a8d0939064c6
2024-07-01 10:25:27 -07:00
Brian Isganitis 035a25c9a7 Merge changes I18245c22,I4c7a6085,I1c17b7f0,I663e5ad7,I9199fd92 into main
* changes:
  Completely destroy Launcher's Taskbar.
  Add context for sandboxing Taskbar window contexts.
  Add tests for TaskbarUnitTestRule.
  Have recreateTaskbar perform recreate on UiThread.
  Move test rules to subpackage.
2024-07-01 16:41:17 +00:00
Brian Isganitis 326ae5e3d1 Completely destroy Launcher's Taskbar.
Just removing it temporarily from the window manager is insufficient.
Taskbar can attempt to recreate itself due to many callbacks being
invoked during tests such as the settings changing. After the tests
finish, the launcher process will restart anyways so taskbar will come
back automatically.

Flag: TEST_ONLY
Test: TaskbarUnitTestRule tests
Bug: 230027385
Change-Id: I18245c224f6d2ffc78d8bf80d30275429074f9b5
2024-06-28 18:38:23 -04:00
Liran Binyamin b15dce1ec3 Merge "Animate the dot with the bubble bar" into main 2024-06-28 22:31:27 +00:00
Tony Wickham 7829a1ced2 Only commitRunningAppsToUI if shownTasks changed
- Add GroupTask and DesktopTask equals() (with tests)
- Add tests to verify multiple onRecentTasksChanged
  doesn't commitRunningAppsToUI if there's no change
- Add tests to verify commitRunningAppsToUI is still
  called if minimized or running apps set changes

Bug: 348802109
Bug: 348787176
Test: TaskbarRecentAppsControllerTest
Test: GroupTaskTest
Test: log TaskbarView#onMeasure() locally, ensure it is called
much less despite noisy onRecentTasksChanged callbacks
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps

Change-Id: I3efff7f4492272f88aa2bdbd7cc45bd2bf8156f6
2024-06-28 21:54:37 +00:00
Saumya Prakash 7250663fab Merge "Prevent Taskbar edu dismissal from touching outside of the window." into main 2024-06-28 21:24:46 +00:00
Saumya Prakash 443d0600d5 Prevent Taskbar edu dismissal from touching outside of the window.
In an effort to encourage users to look at Taskbar edu more thoroughly,
this change makes it so users have to press the 'Done' button explicitly
to close the taskbar edu window. This change also adds the ability for
it to be dismissed by the back gesture. It only applies to the features
edu, and not other taskbar educations.

Fix: 349612575
Test: Manually run all versions of taskbar edu and ensure that the edu only goes away with back gesture, swipe up or clicking on the DONE button
Flag: EXEMPT bugfix
Change-Id: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
Merged-In: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
2024-06-28 21:23:09 +00:00
Kevin Lim 188202f927 [E2E] Re-enable stable widget tests.
Bug: b/310242894
Flag: EXEMPT E2E test re-enabling
Test: http://android-build/test_hub/search/?filter=lowFailureRate&invfilter=unhealthyInvocations&invfilter=staleInvocations&query=branch%3Agit_main+target%3A%28cf_x86_64_phone-trunk_food-userdebug%7Ccf_x86_64_phone-trunk_staging-userdebug%29+testsub%3A%28testPendingWidget_withConfigScreen%7CtestPendingWidget_notRestored_brokenInstall%29
Change-Id: I25c48e07d6cebcc3b5bb61f1583a3859c4c0eb80
2024-06-28 21:11:59 +00:00
Kevin Lim 174e95921a Merge "[UniversalSearchInput] Create flag for multi-line search bar" into main 2024-06-28 21:03:47 +00:00
Saumya Prakash 17339843e7 Prevent Taskbar edu dismissal from touching outside of the window.
In an effort to encourage users to look at Taskbar edu more thoroughly,
this change makes it so users have to press the 'Done' button explicitly
to close the taskbar edu window. This change also adds the ability for
it to be dismissed by the back gesture. It only applies to the features
edu, and not other taskbar educations.

Fix: 349612575
Test: Manually run all versions of taskbar edu and ensure that the edu only goes away with back gesture, swipe up or clicking on the DONE button
Flag: EXEMPT bugfix
Change-Id: I9c456b9efddc6de5f292d6a14b1ce9daee7efaa3
2024-06-28 19:43:24 +00:00
Brandon Dayauon d93b76b7ce Merge "Adding logs to Privateprofile animation." into main 2024-06-28 16:29:00 +00:00
Alex Chau 50293c5227 Merge "Extract TaskContainer to its own class" into main 2024-06-28 12:16:17 +00:00
Brandon Dayauon 46c542e5b7 Adding logs to Privateprofile animation.
Provide logs at the end state to see if alpha/visibility is showing or not to indicate any reasons the issue may happen
because of the animation.

bug: 341053089
Test: N/A
Flag: com.android.launcher3.enable_private_space
Change-Id: Ib94bc955e2d061d1799040ac6180d150b24118fe
2024-06-27 20:24:27 -07:00
Hongwei Wang 9fec21871c Merge "Disable gesture nav while PiP anim is running" into main 2024-06-28 02:03:10 +00:00
Federico Baron 447a4a7efb Merge "Fix folder clipping bug" into main 2024-06-27 23:42:38 +00:00
Brian Isganitis cc44113e57 Add context for sandboxing Taskbar window contexts.
Otherwise, the contexts leave the sandbox, which blocks testing.

Test: TaskbarWindowSandboxContextTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I4c7a60858821c8959be2c82dc61a83b7e2f4d1ed
2024-06-27 18:32:26 -04:00
Brian Isganitis c0da543553 Add tests for TaskbarUnitTestRule.
Test: TaskbarUnitTestRuleTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I1c17b7f04920676cdfbe481b9435ff5d842181d1
2024-06-27 18:32:26 -04:00
Brian Isganitis c2bb120a87 Have recreateTaskbar perform recreate on UiThread.
Test: Taskbar{AllApps,Overlay}ControllerTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I663e5ad7bb37e73381e2ef9d787c80177cfdf7a7
2024-06-27 18:32:26 -04:00
Brian Isganitis e7e98985f7 Move test rules to subpackage.
Test: Compiles
Flag: EXEMPT refactor
Bug: 230027385
Change-Id: I9199fd92450180fa10673c3072dd6e8312fd24d6
2024-06-27 18:32:26 -04:00
Vadim Tryshev 09011fcd07 Re-promote fixed test openPrivateSpaceSettings_triggersCorrectIntent to presubmit
Bug: 339109319
Test: presubmit
Flag: TEST_ONLY
Change-Id: I4873ac3eb258dba30136534e3df6a1a378a3c29a
2024-06-27 15:30:06 -07:00
fbaron c5c0974f0d Fix folder clipping bug
Fix: 341433475
Test: N/A
Flag: NONE bugfix
Change-Id: Id99eca043c4e70127cb93b0abe88aef007afc70d
2024-06-27 13:51:41 -07:00
Federico Baron 33f2e36ee4 Merge "Promote test testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty" into main 2024-06-27 20:30:45 +00:00
Hongwei Wang 3b1ebed232 Disable gesture nav while PiP anim is running
To prevent the Recents transition that may conflict with PiP

Flag: EXEMPT bug fix
Bug: 340724371
Test: Swipe to show TaskBar while expanding PiP to FS mode
Change-Id: I87bb660c37f47dd67f7593a52eda99b167a233a9
2024-06-27 12:40:19 -07:00
Vinit Nayak 8c307e249c Promote testSplitAppFromHomeWithItself to presubmit
Flag: EXEMPT test promotion
Bug: 295225524
Change-Id: Ia8615f2380fc5aa27316ecc8a4ff567ac3facb42
2024-06-27 18:37:27 +00:00
Liran Binyamin fde4fdc472 Merge "Add a new bubble at limit while expanded" into main 2024-06-27 17:26:34 +00:00
Liran Binyamin 78cf7c1745 Animate the dot with the bubble bar
The previous behavior relied on a BEHIND_STACK suppression flag to
determine whether the dot should be drawn or not. setBehindStack was
called as part of updating bubble layout properties in BubbleBarView,
which happens at each animation frame of the bubble bar collapsing
and expanding.

Instead of using the suppression flag, we now directly set the dot
scale based on the progress of the collapse and expand animation.

This change also sets the badge visibility directly from BubbleBarView
and cleans up the BEHIND_STACK suppression flag.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349822532
Test: manual
       - have some bubbles and expand bar
       - trigger a new bubble X
       - observe bubble added with notification dot
       - tap on the selected bubble to collapse
       - observe the notification dot animates for bubble X
       - expand the bar
       - observe notification dot animates for bubble X
       - tap on bubble X
       - observe notification dot animates out
       - tap on a different bubble
       - observe notification dot does not reappear
Change-Id: I6efe0dfa8b4f73064cee8b45556ff0928f6f7c08
2024-06-27 12:55:04 -04:00
Vinit Nayak d900d39412 Merge "Add set correct window corner radius on split invocation animation leashes" into main 2024-06-27 16:42:54 +00:00
fbaron f408badf13 Promote test testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Flag: TEST_ONLY
Test: TaplTwoPanelWorkspaceTest#testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Bug: 329935119
Change-Id: I4fe2967924dd9ef083ed711802eadd277d1164e5
2024-06-27 09:09:06 -07:00
Tracy Zhou adcb3d67f0 Merge "Pipe nav bar transitions logic into task bar" into main 2024-06-27 15:43:35 +00:00
Liran Binyamin 2e1dd4644b Add a new bubble at limit while expanded
Handles adding a new bubble and removing an old bubble when the bar
is expanded and at the limit.

Demo when bar is on right: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dxhFKrctdR5I2F6Pvho6u8
Demo when bar is on left: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/er4ZGQfg8OKHZ2aTi9OJ9N

Flag: com.android.wm.shell.enable_bubble_bar
Test: demos
Test: atest BubbleViewAnimatorTest
Fixes: 345795791
Change-Id: I4e75d61c8afdb81340823a1d77e55b15e3fd6bc0
2024-06-27 10:36:16 -04:00
Alex Chau 8474edcf13 Extract TaskContainer to its own class
Bug: 335606129
Test: Manual
Flag: EXEMPT refactor
Change-Id: I0ac924652079c69737cd37a9233080b432ecc16e
2024-06-27 14:26:14 +01:00
Android Build Coastguard Worker 34cee0d741 Merge cherrypicks of ['googleplex-android-review.googlesource.com/27810982', 'googleplex-android-review.googlesource.com/28017557'] into 24Q3-release.
Change-Id: I2705f435af3724834915649c216be5b9b5a9d125
2024-06-27 04:06:32 +00:00
Vinit Nayak 093978a6ba Add set correct window corner radius on split invocation animation leashes
Test: Enter split anim from overview on phone is smoother than
Michael Jackson's moonwalk
Bug: 349387413
Flag: EXEMPT bugfix

Change-Id: I01fd1eee6fe111623a22dd6aaf130837ebbdeeb1
2024-06-27 03:58:42 +00:00
Brandon Dayauon 5c20085a8c Fix NPE when locking private space in taskbar allapps.
We can just remove the check since isSearchSupported has been launched.

bug: 345648701
Test manually video -
before: https://drive.google.com/file/d/1EwwRXrASusmqVixGWuKGnOQQyiDLE6Yy/view?usp=sharing
after: https://drive.google.com/file/d/1OCvtxzbhRJrBMMM2JH_cOurQ-_BaALSA/view?usp=sharing
Flag: com.android.launcher3.enable_private_space
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e770f10d2a6a047c1ad7b1061f57c388dec4f913)
Merged-In: I0ae19d342556aac4ee0b6e26b4cef8752c0beb38
Change-Id: I0ae19d342556aac4ee0b6e26b4cef8752c0beb38
2024-06-27 03:45:27 +00:00
Schneider Victor-tulias cb2a1474a7 Fix icon flash on app launch
Flag: com.android.launcher3.enable_additional_home_animations
Fixes: 343051344
Test: temp logs, launched apps from home, quickly swiped home while quick switching
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9fb1f8043573d5bc3376f0786354fc8f7a9cf2cd)
Merged-In: I91071d53f753eb7bc99305c46241de203bcfdc98
Change-Id: I91071d53f753eb7bc99305c46241de203bcfdc98
2024-06-27 03:45:11 +00:00
Vinit Nayak 09f06c29da Merge "Promote testSplitTaskTapBothIconMenus to presubmit" into main 2024-06-27 03:35:47 +00:00
Vinit Nayak 233ab23db3 Promote testSplitTaskTapBothIconMenus to presubmit
Bug: 288939273
Flag: EXEMPT test
Change-Id: I8aec88fbba33dd94afd348ebc4ebcb9b75ab3c04
2024-06-27 03:35:34 +00:00
Willie Koomson 3cf229f7e3 Merge "Clean up code related to the old widget preview toast" into main 2024-06-27 00:47:30 +00:00
Treehugger Robot 9f8e1471a6 Merge "Cleanup obsolete generated preview tests" into main 2024-06-26 21:19:21 +00:00