Launcher should pass an empty srcRectHint to Shell
via stopSwipePipToHome if overlay is present, so
that Shell know that srcRectHint is being "simulated"
for the enter PiP animation with an app icon overlay.
Shell will recalculate the simulated src-rect based on
appBounds and aspect ratio of the destination bounds.
Bug: 352773027
Flag: EXEMPT bugfix
Test: swipe PiP to home from Maps with fixed rotation (90 and 270)
Change-Id: I5f89c5af9d6b8a66725e346d09e7b3d84044bb4c
The freeform shortcut was previously changed to only show if the desktop
windowing flag was disabled, which is incorrect since it's not a
reliable indicator about whether desktop windowing is supported or not.
When the flag is enabled as the feature progresses, it causes the button
to be hidden on devices that support freeform windows but don't support
desktop windowing, such as phones or tablets when freeform is enabled in
developer options.
To properly check that DW is not enabled, this CL changes the flag check
to DesktopModeStatus#canEnterDesktopMode.
Bug: 353740331
Test: enable freeform in dev options, disable desktop windowing - check
"freeform" button is available through long-press of the app icon in
overview/recents.
Flag: EXEMPT bugfix
Change-Id: I0ea5073e5570838acf49a27f54546fd97e6739cd
Unit test added as part of the testing week.
Bug: 353588686
Test: CellLayoutMethodsTest
Flag: TEST_ONLY
Change-Id: Ibd796b4b6c354846c7e5ba432f4dca80d9aed4f2
Adding unit tests for FolderAccessibilityHelper. In order to write these tests we have also included a refactor of DragAndDropAccessibilityDelegate to get mDragLayer and the accessibility delegate from ActivityContext instead of Launcher. This allows us to pull that from test context in ActivityContextWrapper during testing.
* Tests 1 class previously untested
* Tests 3 methods
* Includes 1 class refactor
Bug: 353303621
Test: FolderAccessibilityHelperTest
Flag: TEST_ONLY
Change-Id: I8d13113fc09d3ee902faecc426deb80bcbae0b0d
1. Removes unused method `getAllWidgetComponentsWithoutShortcuts`
2. Exposes widgets either as component map or package item map - to
eliminate the duplicate logic around widget sections.
3. Add tests that validate that each package is unique - to help
cover the redirect issue seen in past.
4. In follow up cls, other methods that deal with picker specific data
types like WidgetsListBaseEntry will also be moved out - leaving the
model to only be responsible for providing all widgets map or widgets
by package.
Bug: 341611976
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Ife70874d312b51c66025a6ec678480f2b5c41793
- DeviceProfile have java fields that cannot be mocked, nor can be freely instantiated, so I've to use FakeInvariantDeviceProfileTest to give me some predefined DeviceProfile for testing
Bug: 343101424
Test: RecentsOrientedStateRepositoryTest
Test: RecentsDeviceProfileRepositoryTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Iaa34ef60a418eb336859d260f5808b263de6b4f7
I was too excited when I finally got the repro on my device. After some debugging, I found it (ag/27947503)
Fixes: 350790048
Test: with the change, double task bar is gone.
Flag: EXEMPT bugfix
Change-Id: I969dbf5e9d2c5cc277dfb366858023e6eeff14e2
- Can now set start drawable for BubbleTextView title with setTextWithStartIcon()
- App Archiving cloud overlay icon will be disabled when flag on
Bug: 350758155
Test: locally tested B&R with pre-archiving
Flag: com.android.launcher3.enable_new_archiving_icon
Change-Id: I4d395a7ea7dc5ee11259f897d45b83eabdabb766
We do not need this for now and it is making development more difficult on macs.
Test: Taskbar unit tests
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I2e74e91e21aa650544d8264fab7b336b97b52547
This cl addresses
- removing of getWorkspaceIconsPositions()
- addition of getWorkspaceIconPosition()
getWorkspaceIconsPositions() was not reliable as it was getting any icon selector and not actually waiting for the icon of intereset.
now we wait for specific icon of interest and tests are change accordingly.
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: Ia65b9d51520763a7fbbb8d5cd3bc129496e443cc
This is a re-land of ag/28058564
To prevent the Recents transition that may conflict with PiP
Flag: EXEMPT bug fix
Bug: 340724371
Test: Swipe to show TaskBar while expanding PiP to FS mode
Change-Id: I8395f40bf64bc69af0e3c39789f3a727b03fae0d
Apparently, on slow devices the operation may time out.
Bug: 353541583
Test: presubmit
Flag: TEST_ONLY
Change-Id: I6a569810d47452012f597e412311066c33aec7bb