Commit Graph

78507 Commits

Author SHA1 Message Date
Tracy Zhou ae637b60e0 Merge "Fix double task bar" into main 2024-07-17 20:14:51 +00:00
Ikram Gabiyev a393f2b678 Pass empty srcRectHint if overlay is present
Launcher should pass an empty srcRectHint to Shell
via stopSwipePipToHome if overlay is present, so
that Shell know that srcRectHint is being "simulated"
for the enter PiP animation with an app icon overlay.

Shell will recalculate the simulated src-rect based on
appBounds and aspect ratio of the destination bounds.

Bug: 352773027
Flag: EXEMPT bugfix
Test: swipe PiP to home from Maps with fixed rotation (90 and 270)
Change-Id: I5f89c5af9d6b8a66725e346d09e7b3d84044bb4c
2024-07-17 12:38:23 -07:00
Winson Chung abdbc75801 Update comment to remove todo
Fixes: 197326121
Flag: EXEMPT bugfix
Test: N/a
Change-Id: I66c07a29dda128e14a0e6ff1755546bbda48ba55
2024-07-17 18:50:44 +00:00
Jorge Gil b9a0766dde Re-enable FREEFORM task shortcut when DW is unsupported
The freeform shortcut was previously changed to only show if the desktop
windowing flag was disabled, which is incorrect since it's not a
reliable indicator about whether desktop windowing is supported or not.
When the flag is enabled as the feature progresses, it causes the button
to be hidden on devices that support freeform windows but don't support
desktop windowing, such as phones or tablets when freeform is enabled in
developer options.

To properly check that DW is not enabled, this CL changes the flag check
to DesktopModeStatus#canEnterDesktopMode.

Bug: 353740331
Test: enable freeform in dev options, disable desktop windowing - check
"freeform" button is available through long-press of the app icon in
overview/recents.
Flag: EXEMPT bugfix

Change-Id: I0ea5073e5570838acf49a27f54546fd97e6739cd
2024-07-17 18:37:39 +00:00
Sebastian Franco 3780e096d6 Adding testin for Utilities.java
Happy testing week.

Bug: 353588686
Test: LauncherUtilitiesUnitTest
Flag: TEST_ONLY
Change-Id: I321aa9197a53801282591198aef0229d44da60d3
2024-07-17 11:28:24 -07:00
Sebastian Franco 9a3dd3de64 Adding unit test for pointToCellExact
Unit test added as part of the testing week.

Bug: 353588686
Test: CellLayoutMethodsTest
Flag: TEST_ONLY
Change-Id: Ibd796b4b6c354846c7e5ba432f4dca80d9aed4f2
2024-07-17 11:23:09 -07:00
Charlie Anderson 7dc0ce4019 Merge "[Test Week] Add tests for each operation in PackageUpdatedTask" into main 2024-07-17 17:55:45 +00:00
Brandon Dayauon 0e5640376e Remove enableLayoutTransitions for private space.
Get rid of layoutTransitions as they are not reliable, see here: https://docs.google.com/document/d/1ExSemBvzzVv-I9tUCVzdLeN-lDb2hTSOM886UYSH-Qk/edit?usp=sharing&resourcekey=0-aBCCLnrB7KtkhIeyUOkKyw
Instead use actual animatorSet to do the animating.
- This also fixes the timings so that the pill transition happens at the same time of the icon alpha animation.
Made member variable for lockText and settingButton.

bug:346298256
Test:
before: See bug
after manually- video: https://drive.google.com/file/d/1B7PIgrGWMJTphc1b5CvCkyg-QYx3TTN3/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I049b84dbe1279a0becb090db8660975dc5c5961e
2024-07-17 10:35:53 -07:00
Vadim Tryshev 300ca3422f Merge "Adding screen record for the bug where we can't find a folder after dragging" into main 2024-07-17 17:00:25 +00:00
Fengjiang Li a92b80f357 Merge "[Test Week] Move ViewCacheTest.kt to multivalentTests folder" into main 2024-07-17 16:55:38 +00:00
Andrew Cole 6ce5c66356 Test Week - FolderAccessibilityHelperTest
Adding unit tests for FolderAccessibilityHelper. In order to write these tests we have also included a refactor of DragAndDropAccessibilityDelegate to get mDragLayer and the accessibility delegate from ActivityContext instead of Launcher. This allows us to pull that from test context in ActivityContextWrapper during testing.

* Tests 1 class previously untested
* Tests 3 methods
* Includes 1 class refactor

Bug: 353303621
Test: FolderAccessibilityHelperTest
Flag: TEST_ONLY

Change-Id: I8d13113fc09d3ee902faecc426deb80bcbae0b0d
2024-07-17 09:48:30 -07:00
Treehugger Robot fd7499bb82 Merge "Update IME switcher icon in taskbar" into main 2024-07-17 15:37:50 +00:00
Charlie Anderson 98c3cafcaf [Test Week] Add tests for each operation in PackageUpdatedTask
Bug:353303621
Test: unit test
Flag: TEST_ONLY

Change-Id: Ic2194fd1506c4ff5a542eac62a492f395d12886e
2024-07-17 11:06:38 -04:00
Shamali P 3ae39c72de Cleanup widgetsModel and add tests
1. Removes unused method `getAllWidgetComponentsWithoutShortcuts`
2. Exposes widgets either as component map or package item map - to
eliminate the duplicate logic around widget sections.
3. Add tests that validate that each package is unique - to help
cover the redirect issue seen in past.
4. In follow up cls, other methods that deal with picker specific data
types like WidgetsListBaseEntry will also be moved out - leaving the
model to only be responsible for providing all widgets map or widgets
by package.

Bug: 341611976
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Ife70874d312b51c66025a6ec678480f2b5c41793
2024-07-17 14:29:31 +00:00
Treehugger Robot 4997c14218 Merge "Adding screen record for the bug where com.google.android.apps.nexuslauncher:id/popup_container is not present" into main 2024-07-17 14:10:16 +00:00
Charlie Anderson db7b6a0104 Merge "Add new Cloud archived app icon and support for inline icons for BubbleTextView" into main 2024-07-17 13:57:38 +00:00
Treehugger Robot c2a36a6fcd Merge "Add Repository for RecentOrientedState and DeviceProfile" into main 2024-07-17 12:25:09 +00:00
Treehugger Robot f834c2c881 Merge "Adjust scope for TaskOverlayHelper" into main 2024-07-17 11:10:17 +00:00
Alex Chau 5837a4628c Add Repository for RecentOrientedState and DeviceProfile
- DeviceProfile have java fields that cannot be mocked, nor can be freely instantiated, so I've to use FakeInvariantDeviceProfileTest to give me some predefined DeviceProfile for testing

Bug: 343101424
Test: RecentsOrientedStateRepositoryTest
Test: RecentsDeviceProfileRepositoryTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Iaa34ef60a418eb336859d260f5808b263de6b4f7
2024-07-17 11:29:20 +01:00
Uwais Ashraf 7fb7ac21a2 Adjust scope for TaskOverlayHelper
Fix: 335396935
Test: Manual - start stop overlay multiple times
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I615e43eddc896f52f9718ccef3a09f39b1ed7569
2024-07-17 09:09:33 +00:00
Fengjiang Li 7f81733666 Merge "[Test Week] Add RunnableListTest" into main 2024-07-17 07:10:24 +00:00
Tracy Zhou 100d8b3ec0 Fix double task bar
I was too excited when I finally got the repro on my device. After some debugging, I found it (ag/27947503)

Fixes: 350790048
Test: with the change, double task bar is gone.
Flag: EXEMPT bugfix
Change-Id: I969dbf5e9d2c5cc277dfb366858023e6eeff14e2
2024-07-16 23:43:38 -07:00
Treehugger Robot 984ea0b9d8 Merge "Adding screen record for the bug where Play Store is not present on the workspace" into main 2024-07-17 03:33:12 +00:00
Sebastian Franco c275326e40 Remove unused methods
Bug: 353303621
Test: compiles
Flag: NONE Removing code
Change-Id: Ibfdc983c5d29d8e928e4277dac285d4e62bdc1fd
2024-07-16 19:10:32 -07:00
Vadim Tryshev 1b540e7a99 Adding screen record for the bug where Play Store is not present on the workspace
Bug: 330232490
Test: presubmit
Flag: TEST_ONLY
Change-Id: I147cd0b45298a9b34c3dfb331af80e1253c013c4
2024-07-16 18:45:05 -07:00
Treehugger Robot 52f7fc5ef6 Merge "Unit tests for ListenableHostView" into main 2024-07-17 01:17:57 +00:00
Vadim Tryshev 243650e2cb Adding screen record for the bug where we can't find a folder after dragging
Bug: 353600888
Test: presubmit
Flag: TEST_ONLY
Change-Id: Idc26dc294aa05a88ce590f9466e60adf2d2f4898
2024-07-16 17:40:17 -07:00
Charlie Anderson d5acd6a016 Add new Cloud archived app icon and support for inline icons for BubbleTextView
- Can now set start drawable for BubbleTextView title with setTextWithStartIcon()
 - App Archiving cloud overlay icon will be disabled when flag on

Bug: 350758155
Test: locally tested B&R with pre-archiving
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I4d395a7ea7dc5ee11259f897d45b83eabdabb766
2024-07-16 19:39:03 -04:00
Stefan Andonian 3e28e9c829 Merge "[Test Week] Unit test for WidgetAddFlowHandlerTest." into main 2024-07-16 23:25:57 +00:00
Stefan Andonian f50dca1138 Merge "[Test Week] Unit test for WidgetManagerHelperTest." into main 2024-07-16 23:07:40 +00:00
Jagrut Desai c6c95c8381 Merge "Remove getWorkspaceIconsPositions()" into main 2024-07-16 22:37:29 +00:00
Brian Isganitis 2477f89fd2 Disable model loading in Taskbar unit tests.
We do not need this for now and it is making development more difficult on macs.

Test: Taskbar unit tests
Bug: 230027385
Flag: TEST_ONLY
Change-Id: I2e74e91e21aa650544d8264fab7b336b97b52547
2024-07-16 18:37:28 -04:00
Fengjiang Li 9569f54008 [Test Week] Add RunnableListTest
Number of new tested methods: 5

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I546a775530cdf61424f1047e81e79c28fa7c63e4
2024-07-16 15:26:36 -07:00
Vadim Tryshev 78e9ef2b12 Merge "Increase clearPackageData timeout" into main 2024-07-16 21:52:28 +00:00
Stefan Andonian 2e1bb929ba Unit tests for ListenableHostView
3 public methods.

Bug: 353303621
Test: unit test CL.
Flag: EXEMPT unit test
Change-Id: If5e3b4f8e6f2fa2c2e44907a1a8080215f231ca2
2024-07-16 21:03:56 +00:00
Stefan Andonian 35b584d0ef [Test Week] Unit test for WidgetAddFlowHandlerTest.
8 public methods covered.

Bug: 353303621
Test: Unit Test
Flag: EXEMPT unit test
Change-Id: I5dd20de33b64de561ee8845beaa513b4e08c3a31
2024-07-16 20:58:39 +00:00
Stefan Andonian 19c5f7ae71 [Test Week] Unit test for WidgetManagerHelperTest.
6 public methods covered.

Bug: 353303621
Test: Unit Test
Flag: EXEMPT unit test
Change-Id: I549d97f5b57f0e6e9af44bd1695d94ebfa0538f2
2024-07-16 20:58:11 +00:00
Jagrut Desai 6276f1797b Remove getWorkspaceIconsPositions()
This cl addresses
	- removing of getWorkspaceIconsPositions()
	- addition of getWorkspaceIconPosition()

getWorkspaceIconsPositions() was not reliable as it was getting any icon selector and not actually waiting for the icon of intereset.
now we wait for specific icon of interest and tests are change accordingly.

Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY

Change-Id: Ia65b9d51520763a7fbbb8d5cd3bc129496e443cc
2024-07-16 13:48:27 -07:00
Treehugger Robot 2d36c4635c Merge "[Test Week] Add ViewOnDrawExecutorTest" into main 2024-07-16 20:42:32 +00:00
Vadim Tryshev be508f4aa1 Adding screen record for the bug where com.google.android.apps.nexuslauncher:id/popup_container is not present
Bug: 349439239
Test: presubmit
Flag: TEST_ONLY
Change-Id: I177080040244462c8d1ca36ec433d36a7fbd7897
2024-07-16 13:24:33 -07:00
Hongwei Wang 5c44a7a19c Disable gesture nav while PiP anim is running
This is a re-land of ag/28058564

To prevent the Recents transition that may conflict with PiP

Flag: EXEMPT bug fix
Bug: 340724371
Test: Swipe to show TaskBar while expanding PiP to FS mode
Change-Id: I8395f40bf64bc69af0e3c39789f3a727b03fae0d
2024-07-16 13:20:30 -07:00
Jagrut Desai b0e0e00660 Merge "Adding Skeleton Code for Customizable Taksbar" into main 2024-07-16 20:16:10 +00:00
Jagrut Desai c9174e17a2 Merge "Add support for different container and space calculation logic." into main 2024-07-16 20:16:10 +00:00
Vadim Tryshev eeeaa6da56 Increase clearPackageData timeout
Apparently, on slow devices the operation may time out.

Bug: 353541583
Test: presubmit
Flag: TEST_ONLY
Change-Id: I6a569810d47452012f597e412311066c33aec7bb
2024-07-16 12:31:52 -07:00
Stefan Andonian 9fb11f4d95 Merge "[Test Week] Move ListenableHostView into it's own class for ease of unit testing." into main 2024-07-16 18:51:55 +00:00
Fengjiang Li 6cd7630504 [Test Week] Move ViewCacheTest.kt to multivalentTests folder
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ie969e9bffecf61bbcfd7b2132ef7a5df1d97cbed
2024-07-16 11:36:31 -07:00
Fengjiang Li 3f5e44e0cc [Test Week] Add ViewOnDrawExecutorTest
Number of new tested methods: 7

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ic89984fac515924cf9a16ebc6fc7028325bed386
2024-07-16 11:32:54 -07:00
Brian Isganitis 984d782024 Merge changes from topic "taskbar-pinning-preference-rule-fixes" into main
* changes:
  Add subrule for controlling an individual Taskbar preference.
  Taskbar Pinning Preference Rule fixes.
2024-07-16 18:05:33 +00:00
Liran Binyamin 0e1ae64920 Merge "Send the bubble removal timestamp to wm shell" into main 2024-07-16 18:04:43 +00:00
Treehugger Robot a255f15a9b [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: 666fec0c77 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/28324364

Change-Id: I1f2c9042a10f538e5da39a75ea29bfde7783a86e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-07-16 17:53:18 +00:00