Commit Graph

78507 Commits

Author SHA1 Message Date
Brandon Dayauon 3188bd08ae Merge "Don't add floatingMaskView if it will not fit." into main 2024-07-18 20:53:14 +00:00
Andrew Cole 6ace1c0d3a Test Week - AccessibleDragLstenerAdapterTest
Refactored AccessibleDragListnerAdapter to kotlin for null safety and removed a explicit call to Launcher. Added tests for all public methods
* Refactored 1 class
* Tested 1 class previously untested
* Tested 4 public methods

Bug: 353303621
Test: AccessibleDragListnerAdapterTest
Flag: TEST_ONLY

Change-Id: I7db70330f5e76b8f7298304314584e88e067c139
2024-07-18 12:34:17 -07:00
Charlie Anderson c22b0ea47b Merge "[Test Week] unit tests for LauncherRestoreEventLoggerImpl" into main 2024-07-18 18:44:15 +00:00
Charlie Anderson ba9705c4ab Merge "[Test week] unit tests for ItemInfoMatcher" into main 2024-07-18 18:44:05 +00:00
Liran Binyamin a2aa555faf Merge "Update bubble notification dot drawing" into main 2024-07-18 18:42:01 +00:00
Shamali P 54bd36ef81 Move out picker related methods from widgets model
* The WidgetsBaseEntry and related types are specific to picker UI.
So, moved them to a entry builder class.

Bug: 353347512
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: I42b3083b42ee03dc8d548e7464689ea270a36f22
2024-07-18 18:35:19 +00:00
Liam, Lee Pong Lam c56711c669 Add unit tests for SettingsChangeLogger
Bug: 353584526
Flag: EXEMPT bugfix
Test: Unit tests
Change-Id: Ib1bac2471d9cc467b8b6697ae4d79f561eea75e4
2024-07-18 18:32:36 +00:00
mpodolian f667c3bc3b Prepare BubbleBarViewController to support persistent task bar.
Added required resources for the transient taskbar. Unified
BubbleBarViewController logic for the persistent taskbar.

Bug: 350065038
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest
Change-Id: I24e6d2d43bf8145cdcc71c75da0cb6f6e84373da
2024-07-18 19:17:12 +01:00
Sebastián Franco 45bad7252e Merge "Refactoring FolderPagedView to make it more testable" into main 2024-07-18 17:02:54 +00:00
Alex Chau 1c1547f5f9 Merge "Enable RecentsModel cache preloading for TTV refactoring" into main 2024-07-18 16:45:43 +00:00
Alex Chau 7e26ff8063 Enable RecentsModel cache preloading for TTV refactoring
- Enabled preloading so thumbnails are loaded faster after Launcher restarts

Fix: 353927953
Test: Manual
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I8710495dee672eb0449c01522451578f30ad84aa
2024-07-18 16:44:35 +00:00
Jorge Gil e2c2302aef Merge "Re-enable FREEFORM task shortcut when DW is unsupported" into main 2024-07-18 16:30:20 +00:00
Alex Chau 33d0b14384 Merge "Update bug id of a TODO" into main 2024-07-18 16:21:31 +00:00
Fengjiang Li 5c4c3bcbf3 [Test Week] Move SimpleBroadcastReceiver to multivalentTests folder
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I82a59b6d090df7a246ba283bbfa286c99417c876
2024-07-18 09:20:49 -07:00
Charlie Anderson 48ff57d7d1 [Test week] unit tests for ItemInfoMatcher
7 public methods tested
no previous test class

Flag: TEST_ONLY
Bug: 353303621
Test: unit tests
Change-Id: Ie327ab790b46326ee97165706c126c8ad0de7776
2024-07-18 11:59:01 -04:00
Sihua Ma e2dde4e468 Merge "Add unit test for CustomAppWidgetProviderInfo" into main 2024-07-18 15:47:32 +00:00
Sihua Ma b648a0f386 Merge "Add unit test for CustomWidgetManager" into main 2024-07-18 15:47:15 +00:00
Charlie Anderson ee3cc97fd3 [Test Week] unit tests for LauncherRestoreEventLoggerImpl
5 public methods tested
No previous testing class

Flag: TEST_ONLY
Test: unit test
Bug: 353303621
Change-Id: I97273e7eebebfa4aac1e7c3db8bf089f3e49f150
2024-07-18 15:38:08 +00:00
Liran Binyamin 5013028596 Update bubble notification dot drawing
The notification dot drawing state depends on changes in the bubble
bar, so the bubble bar now directly requests updates to the dot at
specific states.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 351904597
Fixes: 350782375
Test: atest BubbleViewTest
Test: manual basically just hammering on it trying to break it
       1. Dot appears for new bubble in all states of the bar
       2. Expand bubble bar
          - Dot is removed for selected and shows for others
            that have a dot
       3. After removing bubble while expanded
          - Dot is removed from newly selected bubble
       4. Collapse bubble bar
          - Dot is hidden for all bubbles
       5. Dot removed after tapping on a bubble when expanded

Change-Id: I4a940d38a8c77bddaf058b7ef882bab06886bcf4
2024-07-18 10:38:29 -04:00
Shamali Patwa 1407aeca8d Merge changes from topic "ls-picker-filter" into main
* changes:
  Consider the widget option menu choice in search results
  Show only filtered / default widgets in standalone activity by default
  Add a 3 dot vertical menu and styles (child cl makes it functional)
  Set default widgets and all widgets separately from standalone activity
  Update the widget picker activity theme for popup menus styling
2024-07-18 14:14:42 +00:00
Alex Chau 1d75081a5f Merge "Apply PreviewPositionHelper matrix to TTV and Overlay" into main 2024-07-18 13:56:42 +00:00
Alex Chau e62ceb9043 Update bug id of a TODO
Change-Id: I0c122f70b2a954ab88b1696c2c3ece48670774ca
Fix: 340437778
Bug: 342635213
Test: None
Flag: EXEMPT refactor
2024-07-18 13:34:23 +00:00
Alex Chau 893f4c6a45 Apply PreviewPositionHelper matrix to TTV and Overlay
- Added GetThumbnailMatrixUseCase to retrieve task using taskId and calcualte Matrix using provided canvas size and isRTL
- TTVM and OverlayVM will uses GetThumbnailMatrixUseCaseTest with runBlocking to obtain the matrix from the loaded thumbnail
- TTV and Overlay listen for size change, and call VM to get the latest Matrix and apply to the view

Fix: 343101424
Test: GetThumbnailMatrixUseCaseTest
Test: TaskThumbnailViewModelTest
Test: TaskOverlayViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: If3f37824bed84d5cbaa54d7a4b12f5f1ef4e2c09
2024-07-18 13:07:14 +01:00
Johannes Gallmann 8c983e8d48 Merge "Fix CUJ_LAUNCHER_APP_CLOSE_TO_HOME Cuj for predictive back to home" into main 2024-07-18 08:29:38 +00:00
Treehugger Robot ada4e16644 Merge "Replace get/setPendingIntentBackgroundActivityLaunchAllowedByPermission" into main 2024-07-18 06:52:30 +00:00
Sebastián Franco 0eafdad0f5 Merge "Adding testin for Utilities.java" into main 2024-07-18 03:05:44 +00:00
Sebastián Franco 51c8ae668d Merge "Remove unused methods" into main 2024-07-18 03:05:15 +00:00
Sebastián Franco 61600168fd Merge "Adding unit test for pointToCellExact" into main 2024-07-18 03:04:32 +00:00
Anushree Ganjam 696d3f48f7 Add SEARCH_TARGET_UTIL_LOG for debugging searchtargetutil logs
Bug: 352067203
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I27b7c29ae0400f2ff3fb8336cee0eec0d962ac1b
2024-07-17 18:34:40 -07:00
Tracy Zhou 749ea3115c Merge "Fix missing taskbar scrim in folded state when swiping up from immersive mode" into main 2024-07-18 00:47:41 +00:00
Achim Thesmann 79300ffae0 Replace get/setPendingIntentBackgroundActivityLaunchAllowedByPermission
Replace usages of the old get/setPendingIntentBackgroundActivityLaunchAllowedByPermission
API with the new replacement (passing in mode = ALWAYS).

Test: atest DragAndDropPolicyTest StageCoordinatorTests AlarmManagerServiceTest BackgroundActivityStartControllerExemptionTests BackgroundActivityStartControllerTests ActivityOptionsTest ActivityStarterTests BackgroundActivityLaunchTest
Flag: EXEMPT refactor
Bug: 352182359
Change-Id: I692dbb2122995d5cc3fa87bf5061704987ebddbb
2024-07-18 00:44:04 +00:00
Brandon Dayauon 1710cbeb6e Don't add floatingMaskView if it will not fit.
See this screenshot for math explanation: https://screenshot.googleplex.com/9x256x5uk7qNZDg
We use the Y values of the views to determine if the header will be clipped by the
floating mask view.

Also added logs for private space.

bug:343478928
Test manually before: see bug.
after: https://drive.google.com/file/d/1FZXDQG-hV-V3wErVR0-nVCMgjUDk910Z/view?usp=sharing
Flag: com.android.launcher3.enable_private_space

Change-Id: I025e4e62f9ba60e8493d2aceb139d2c4ed6a84dd
2024-07-17 17:12:34 -07:00
Brandon Dayauon ef81b5c630 Merge "Remove enableLayoutTransitions for private space." into main 2024-07-17 23:54:59 +00:00
Sihua Ma 1f3f951b70 Add unit test for CustomAppWidgetProviderInfo
Number of methods covered: 2

Test: atest NexusLauncherRoboTests:CustomAppWidgetProviderInfoTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I4235569878a9f1c1b2ec040b26190f97d9734679
2024-07-17 23:38:33 +00:00
Sebastian Franco c794aca69f Refactoring FolderPagedView to make it more testable
Bug: 353588686
Test: Compiles
Flag: NONE refactor
Change-Id: I612523282a57beac90b14a890a333a1670ab0d48
2024-07-17 23:32:17 +00:00
Andy Wickham e6b43c86ba Merge "Invert the 2 stage LPNH logic to lower false positive triggers." into main 2024-07-17 23:11:51 +00:00
Kevin Lim 0c7079ece0 [UniversalSearchInput] Support search box dynamic height adjustment in
ActivityAllAppsContainerView

Previously, ActivityAllAppsContainerView assumed a static height for the
search box and relied only on FloatingHeaderView's height calculation.
With multi-line search bar, we need to add to the FloatingHeaderView's
mMaxTranslation to update the clipping position for the recycler views
belowe

Bug: b/341795751
Flag: com.android.launcher3.multiline_search_bar
Test: http://recall/clips/32f64e77-3522-4873-bc7b-86d844912724
Change-Id: I67aab186e96d7bdecbba454f660d73f0f4408a98
2024-07-17 23:07:58 +00:00
Shamali P 6211e86009 Consider the widget option menu choice in search results
Makes the search related code separate from popup provider.

Bug: 347288851
Flag: EXEMPT flag in sysui
Test: Unit tests
Change-Id: I4534d5f70876ec0cf4e2d78030864f78a8bfabb9
2024-07-17 22:56:58 +00:00
Shamali P 9aabb9a9cb Show only filtered / default widgets in standalone activity by default
Bug: 347288851
Flag: EXEMPT flag in sysui
Test: b/339716822 to set it up
Change-Id: I71baac8897ce600f3c588eb3d48b9677e507145b
2024-07-17 22:56:49 +00:00
Shamali P 2e2d4ff603 Add a 3 dot vertical menu and styles (child cl makes it functional)
Bug: 347288851
Flag: EXEMPT standalone picker
Test: Manual
Change-Id: I99985098034f6336f683b1ff3a47dce2aa8e596a
2024-07-17 22:56:41 +00:00
Shamali P 8654ff0116 Set default widgets and all widgets separately from standalone activity
Bug: 347288851
Flag: EXEMPT standalone picker
Test: Manual
Change-Id: I4eaeb7cb44b8b9c4187f7cf8fdc1b80143bb322e
2024-07-17 22:56:30 +00:00
Shamali P 2d7a6b0fee Update the widget picker activity theme for popup menus styling
The earlier version didn't inherit in-built popup styles and launcher
inherits from these too.

Bug: 347288851
Flag: EXEMPT standalone picker
Test: standalone picker will be covered in b/339716822
Change-Id: Ic33afbcea3838a608385e3f94cb864f66cef9e8a
2024-07-17 22:56:22 +00:00
Shamali Patwa 45b5acef28 Merge "Cleanup widgetsModel and add tests" into main 2024-07-17 22:55:01 +00:00
Andrew Cole 940917b92e Merge "Test Week - Deleting NexusTestInformationHandler" into main 2024-07-17 22:33:47 +00:00
Sihua Ma 71a48d9ac5 Add unit test for CustomWidgetManager
Number of methods covered: 5

Test: atest NexusLauncherRoboTests:CustomWidgetManagerTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I69c9567391d3a874c7b2abcd473887194ec2dcfc
2024-07-17 22:21:40 +00:00
mpodolian baf0307494 Added scrim visibility check.
Scrim view was not shown because the TaskbarScrimViewController did not
check taskbar visibility on initialization. Added the check to fix the
issue.

Fixes: 353583417
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
Switch task bar to transient mode on overview screen or inside an
application. Expand bubble bar.

Change-Id: Ia8a05802a779a4bac70906e7e52ac6650308c85c
2024-07-17 22:32:54 +01:00
Treehugger Robot 2397ffd437 Merge "Disable model loading in Taskbar unit tests." into main 2024-07-17 21:14:10 +00:00
Tracy Zhou fe5c3fb5eb Fix missing taskbar scrim in folded state when swiping up from immersive mode
TaskbarTransitions is needed for gesture nav too

Also updated the TaskbarTransitions check so that foldables are included (instead of just phones with the unification for phones flag on

Fixes: 353620747
Test: Scrim shows in Youtube immerisve mode
Flag: EXEMPT bugfix
Change-Id: I9990ef8f793e28b3af2f42b0a5a117fdfbdd4081
2024-07-17 14:04:13 -07:00
Treehugger Robot 5d4587f04d Merge "Update comment to remove todo" into main 2024-07-17 20:28:05 +00:00
Andrew Cole f0bdb71e38 Merge "Test Week - FolderAccessibilityHelperTest" into main 2024-07-17 20:16:39 +00:00