Commit Graph

78507 Commits

Author SHA1 Message Date
Treehugger Robot d603151ae7 Merge "Remove TODO for animating bubble bar view" into main 2024-07-22 13:50:59 +00:00
Andrew Cole 6beb1964a4 Merge "Test Week - ShortcutUtilTest" into main 2024-07-22 13:42:14 +00:00
Sam Cackett 78524ae618 Merge "Convert IconView class to Kotlin" into main 2024-07-22 13:20:18 +00:00
vinayjoglekar 82bb770738 Support sysUiStatusNavFlags for refactored TTV
Bug: 350743460
Test: SysUiStatusNavFlagsUseCaseTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Id7576cb2eda14e6c72f34fe3fea3323a104a5164
2024-07-22 12:44:52 +01:00
samcackett d256c912b1 Convert IconView class to Kotlin
Fix: 342594235
Test: Manual. Check IconView in Overview works
Flag: EXEMPT converting java class to Kotlin
Change-Id: Icef4c5ebe7c4ce05fb844448679d032b171ad1bb
2024-07-22 08:51:19 +01:00
Ats Jenk 496e56e4f5 Remove TODO for animating bubble bar view
The animation is added and the linked bug is fixed.
Removing obsolete TODO.

Bug: 280605790
Change-Id: I54ab56f93794afb7f7c23de4df1a348d30cbbf42
Test: NA
Flag: DOCS_ONLY
2024-07-20 00:06:34 +00:00
Charlie Anderson 5cb2e93e7b [Test Week] Add unit tests for UserCache
6 new methods tested.
added 1 method to help with testing.
no previous test class.

Bug: 353303621
Test: unit test
Flag: TEST_ONLY
Change-Id: I27e607df91bacc1a5dc5adc3b76a2f1758404e6a
2024-07-19 20:02:40 -04:00
fbaron aa1a462d0e Test Week - Add test for PageIndicatorDots.java
* 2  methods covered
* Adding tests for PageIndicatorDots.java

Bug: 353303621
Test: Not Applicable
Flag: TEST_ONLY
Change-Id: Ie30c0fb0e5efb041eb805e474d6d824d61238a3d
2024-07-19 16:59:21 -07:00
Sebastian Franco 85392b745f Add unit test for FolderNameInfosTest
Bug: 353588686
Flag: TEST_ONLY
Test: FolderNameInfosTest
Change-Id: I77b703548be5d45669800946874c5245e96e9b37
2024-07-19 16:57:36 -07:00
Ats Jenk f2eb1152a2 Merge "Create accessibility menu for bubble bar" into main 2024-07-19 23:40:47 +00:00
Fengjiang Li 2b5deb2fb9 Merge "[Test Week] Add VibratorWrapperTest" into main 2024-07-19 23:28:13 +00:00
Andrew Cole 9b3b54eb40 Test Week - ShortcutUtilTest
Adding simple tests for ShortcutUtils
* 1 New Class Covered
* 4 Methods Covered

Bug: 353303621
Test: ShortcutUtilTest
Flag: TEST_ONLY
Change-Id: I3f2fbb592cc5abe18524c3883fb0a0e96912fdfb
2024-07-19 23:04:03 +00:00
fbaron f8962a5406 Test Week - Add more coverage for Folder.java
* Refactored Folder class
* 30  methods covered
* Adding more coverage for Folder.java

Bug: 353303621
Test: Not Applicable
Flag: TEST_ONLY
Change-Id: Ibd7ca8c2121ddc71c33f91262b46e593670eadfe
2024-07-19 14:35:29 -07:00
Marcelo Arteiro 0d6190eb52 Updates many launcher color to new dynamic tokens
Bug: 335442983
Test: Manual
Flag: EXEMPT bugfix
Change-Id: Ic453ae6a717bb274682242f7af5b0551313672a4
2024-07-19 21:31:31 +00:00
Fengjiang Li 979adecc7b [Test Week] Add VibratorWrapperTest
Number of new tested methods: 9

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Id6dde920d6365823cf859e97c7c0cfbb25e7270d
2024-07-19 14:10:32 -07:00
Ats Jenk 7f3b6c030b Create accessibility menu for bubble bar
Bug: 344670180
Test: open accessibility action menu on bubble bar. use menu to
  - expand bubble bar
  - dismiss bubble bar
Test: when bubble bar is on the right, the action menu has an option to
  move bubble bar to the left only, use menu to move bar to the left
Test: when bubble bar is on the left, the action menu has an option to
  move bubble bar to the right only, use menu to move bar to the right
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id875a43927bc3410a83d1342b9456330c9521085
2024-07-19 13:59:35 -07:00
Hongwei Wang 7c0fe2d17f Merge "Disable gesture nav while PiP anim is running" into main 2024-07-19 19:38:52 +00:00
Treehugger Robot f3fde3f58c Merge "[Test week] add tests for InstallSessionHelper" into main 2024-07-19 18:00:20 +00:00
Sihua Ma f2abd671d1 Merge "Add unit test for RoundedCornerEnforcement" into main 2024-07-19 17:13:08 +00:00
Fengjiang Li 1749bf0308 Merge "[Test Week] Add missing @RunWith(AndroidJUnit4.class) annotation" into main 2024-07-19 17:07:39 +00:00
Fengjiang Li 74861537f6 Merge "[Test Week] Add ScreenOnTrackerTest" into main 2024-07-19 17:07:26 +00:00
Sebastián Franco 5217ae7fa3 Merge "Refactoring FolderPagedView to make it more testable" into main 2024-07-19 16:59:35 +00:00
Treehugger Robot 8bba516ca4 Merge "Align color resources in launcher projects." into main 2024-07-19 16:15:25 +00:00
Shamali Patwa 6babde40e3 Merge "Move out picker related methods from widgets model" into main 2024-07-19 15:46:00 +00:00
Ikram Gabiyev d890a9e3e2 Merge "Pass empty srcRectHint if overlay is present" into main 2024-07-19 15:04:02 +00:00
Marcelo Arteiro f38d98d1a6 Align color resources in launcher projects.
This is an effort to align/unify color usage across all launcher projects and the system itself.
This fix recreates all dynamic color attributes present in the OS since many launcher areas cannot access private attributes.
It is recomemnded to use these new local attributes in all launcher areas and avoid creating new color resources when these can be used directly.

Bug: 352690172
Test: Presubmits
Flag: EXEMPT bugfix
Change-Id: Ic36b8bf70ee37f2fdd32e459e66f0e2d001d6ba2
2024-07-19 14:22:21 +00:00
Charlie Anderson b6e8ab0d21 [Test week] add tests for InstallSessionHelper
9 public methods tested
no previous test class

Bug: 353303621
Test: unit tests
Flag: TEST_ONLY
Change-Id: Ib113c00c10ed0aca8c996db493a84077026bf6c8
2024-07-19 09:46:40 -04:00
Jordan Silva 426f74369a Introducing Manual DI for Overview
This CL adds the RecentsDependencyContainer to maintain singletons and dependencies related to RecentsView. RecentsDependencies is a singleton that requires the application context to be initialized. Unlike regular singletons, this class has an initialize function where it gets initialized and can be retrieved with getInstance without providing the appContext each time.

- We've updated the refactored classes behind the -enable_refactor_task_thumbnail flag to use this DI solution rather than relying on .parent or recreating dependencies.

- To inject dependencies, you can use RecentsDependencies.inject for lazy initialization or RecentsDependencies.get for eager initialization.

- At the moment, we don't have a singleton or factory definition. All dependencies created by RecentsDependencies will be stored in a specific scope, making the instance a singleton within that scope.

- You can create or retrieve a dependency in a particular scope by calling RecentsDependencies.inject(scopeId).

- If you don't need the dependency to be stored in RecentsDependencies, you can create it manually in your code and inject the necessary parameters from RecentsDependencies (see the viewModel in TaskOverlayHelper).

- Handling the cleaning/resetting of dependencies will be addressed in b/353917593. RecentsView lifecycle is more complex and doesn't get recreated every time. We need to determine which dependencies or scopes can be destroyed and recreated.

Fix: 349055024
Test: NONE
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I27b92e3038f1cce0fd53b637dba5054c05b40283
2024-07-19 11:54:20 +00:00
Treehugger Robot 2495e980ed Merge "Throw exception from SystemUiProxy.getRecentTasks for invalid result" into main 2024-07-19 11:01:40 +00:00
Johannes Gallmann 35f77be929 Merge "Fix onUserInteraction not called with 3-button-nav and enableOnBackInvokedCallback=true" into main 2024-07-19 09:46:51 +00:00
Alex Chau 3210f73125 Throw exception from SystemUiProxy.getRecentTasks for invalid result
- The reason Recents is empty after a force-stop is when RecentsTasksList.getTasks is called first time after restart, the result is always invalid but we cached the invalid result with a chagneId(=1). The next time we call getTasks again, we think the cached result is valid, and returend an empty list.
- The fix is to mark such result as invalid to avoid caching the wrong result

Fix: 353926204
Test: RecentTasksListTest
Flag: EXEMPT bugfix
Change-Id: If15ab8fd7454db8a08c22b17eaac73f0c78aa75f
2024-07-19 09:21:40 +00:00
Fengjiang Li b7b3137261 [Test Week] Add ScreenOnTrackerTest
Number of new tested methods: 5

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ieae1ed9bb215a52a12fef919c8dd407291c2b0f9
2024-07-19 00:49:58 -07:00
Fengjiang Li cda1c12ebe [Test Week] Add missing @RunWith(AndroidJUnit4.class) annotation
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ieb8f8ac3a8a94defe5f9ed2b8ca9812fd2ac1ba6
2024-07-18 22:29:18 -07:00
Fengjiang Li 3a33017797 Merge "[Test Week] Add SystemUiControllerTest" into main 2024-07-19 03:00:19 +00:00
Liam Lee Pong Lam 0002e9cfc9 Merge "Add unit tests for SettingsChangeLogger" into main 2024-07-19 01:53:21 +00:00
Andrew Cole 4a680b1374 Merge "Test Week - AccessibleDragLstenerAdapterTest" into main 2024-07-19 00:53:21 +00:00
Sihua Ma 045165a4ba Add unit test for LauncherAppWidgetHost
Number of methods covered: 3

Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I8fa9ed7b496baa18dac1a721c72a32814d89dd6f
2024-07-19 00:38:32 +00:00
Fengjiang Li abc4a9589a Merge "[Test Week] Add AllAppsRecyclerViewPoolTest" into main 2024-07-19 00:33:51 +00:00
Fengjiang Li a74d9d74c9 Merge "[Test Week] Add ViewPoolTest" into main 2024-07-19 00:33:38 +00:00
Fengjiang Li 5337a1ba31 Merge "[Test Week] Replace verifyZeroInteractions with verifyNoMoreInteractions in RunnableListTest" into main 2024-07-19 00:31:51 +00:00
Jon Miranda 6d5ab854d1 Merge "Synchronize the app launch and taskbar stash animations." into main 2024-07-19 00:26:33 +00:00
Jon Miranda cde962dcb7 Synchronize the app launch and taskbar stash animations.
Introduce FLAG_IGNORE_IN_APP to prevent taskbar from stashing prematurely
due to HomeTransitionListener signal.

Bug: 345768019
Fixes: 319162553
Test: Launch an app, note the two animations are synced
      Verified by locally introducing a startDelay (since otherwise it is hard to tell)
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: Ibb64e0321f33cf81e337fc7c1b2c3edfb23e6ba4
2024-07-19 00:26:13 +00:00
Sihua Ma cda4805e62 Add unit test for RoundedCornerEnforcement
Number of methods covered: 4

Test: atest NexusLauncherRoboTests:RoundedCornerEnforcementTest
Test: SysUI studio
Flag: TEST_ONLY
Bug: 353303621
Change-Id: I488ce4a6617b96d4937a7030cd25831bcefadca1
2024-07-18 23:57:09 +00:00
Sebastian Franco cda3427fea Refactoring FolderPagedView to make it more testable
Bug: 353588686
Test: FolderPagedViewTest.kt
Flag: TEST_ONLY
Change-Id: I2a2efd9f9b2a6ac32153f8102613a3af5afc1ecf
2024-07-18 23:33:21 +00:00
Mykola Podolian e80618db64 Merge "Prepare BubbleBarViewController to support persistent task bar." into main 2024-07-18 23:16:47 +00:00
Fengjiang Li f257aef6d7 [Test Week] Add SystemUiControllerTest
Number of new tested methods: 4

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I2c2b8101853b4b5a6562fe26dfa6b7358f0be17e
2024-07-18 15:47:26 -07:00
Fengjiang Li 5ad7a20e90 [Test Week] Add ViewPoolTest
Number of new tested methods: 3

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I13f1a7bad41c07368cff3d544120d1f41c92b603
2024-07-18 15:25:07 -07:00
Fengjiang Li 30d02c20bf [Test Week] Add AllAppsRecyclerViewPoolTest
Number of new tested methods: 2

Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: Ic210b5ad7988c9e8d060c959fb2a425068c82511
2024-07-18 15:19:42 -07:00
Fengjiang Li 2eeb08f216 [Test Week] Replace verifyZeroInteractions with verifyNoMoreInteractions in RunnableListTest
Fix: 354021767
Bug: 353303621
Test: This is the unit test
Flag: NONE - unit test
Change-Id: I85945c0a0f64ca0a65d28d66f3c47d83d0943c3b
2024-07-18 15:05:10 -07:00
Fengjiang Li f28a059e5b Merge "[Test Week] Move SimpleBroadcastReceiver to multivalentTests folder" into main 2024-07-18 21:06:30 +00:00