Commit Graph

78507 Commits

Author SHA1 Message Date
Satish Yalla de82f8f44f Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 25532044-tapl-transient-taskbar-default

Reason for revert: <test revert (b/314873201)>

Reverted changes: /q/submissionid:25532044-tapl-transient-taskbar-default

Change-Id: I51e78699f588a8fe8506c96398de921448e0ab6a
2023-12-05 06:48:25 +00:00
Federico Baron c22bc0dbf8 Merge "Add ACONFIG flag enable_unfolded_two_pane_picker" into main 2023-12-05 06:25:58 +00:00
Tracy Zhou ec26a138d5 Do not apply rounded corner background to task bar when it's in phone mode
Fixes: 311428370
Test: Make sure nav bar in landscape phone mode doesn't have weird clips
Change-Id: I0c402dd10a3bd39afd5692d21ef8adaad04646db
2023-12-04 22:07:04 -08:00
Schneider Victor-tulias dc4b61be59 Merge "Fix Keyboard quick switch screenshots and spliscreen launch" into main 2023-12-05 04:10:13 +00:00
Tony Wickham 2f334e9ca7 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-12-05 02:40:02 +00:00
Vadim Tryshev 01444246cd Waiting for Launcher activity to stop in OverviewTaskMenu.tapAppInfoMenuItem
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I1100ec8e015a67ebef8b7e834b55b1ed5fcabae8
2023-12-04 18:22:33 -08:00
Sukesh Ram ea6f544f7d Merge "Fix 3-Button Color w/ Widget Sheet post-Rotation" into main 2023-12-04 23:39:13 +00:00
Vadim Tryshev dc7de0d9fb Merge "Waiting for Launcher activity to stop when starting an overview task" into main 2023-12-04 21:47:09 +00:00
Schneider Victor-tulias a74612611d Merge "Update isLauncherInitialized check to wait until Launcher has stopped binding items" into main 2023-12-04 20:02:10 +00:00
Sunny Goyal 21eeda4cc3 Merge "Revert^2 "Changing SystemUiProxy to kotlin"" into main 2023-12-04 19:30:37 +00:00
Vadim Tryshev 7b78d4093b Merge "Not diagnosing taskbar as <Launcher in invalid state>" into main 2023-12-04 19:21:17 +00:00
Holly Sun b226257c17 [cleanup] Clean up LayoutType.PEOPLE_TILE.
Bug: 313696037
Test: manual
Flag: LEGACY ENABLE_PEOPLE_TILE_PREVIEW DISABLED
Change-Id: Iae66c86357ef50a97083c79d6a94d038ad83dcf1
2023-12-04 11:14:00 -08:00
Sunny Goyal 3de59f24a0 Revert "Revert "Removing unnecessary iconFactory class when gene..."
Revert submission 25518508-revert-25483550-themed-badge-GJNKEECDMN

Reason for revert: Fixed badging bug

Reverted changes: /q/submissionid:25518508-revert-25483550-themed-badge-GJNKEECDMN

Change-Id: I0f378eaabcb7bdea855b80a33bdec007c9b11436
2023-12-04 18:53:50 +00:00
Sunny Goyal b1e430bcb9 Revert^2 "Changing SystemUiProxy to kotlin"
49997a7cf9

Change-Id: Ieed3f7ad7c9d36ee1c2fc53e0c03df34698c256d
2023-12-04 17:21:22 +00:00
Pat Manning f9e64bc0ce Merge "Revert^2 "Update cell drop visualizer radius"" into main 2023-12-04 11:06:00 +00:00
Pat Manning 5004d4dd3b Merge "Update focus indicator radius to match workspace drag indicator radius." into main 2023-12-04 11:06:00 +00:00
Sebastian Franco 25f8e406a7 Adding ReorderParameters to ReorderAlgorithm
No logic change made.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: Iababd2fba688a482cffe6d2243c987b0c022c6a5
2023-12-03 22:39:50 -06:00
Himanshu Gupta b6ebbb019c Fixing dangling PS container on profile addition.
When Work profile state is changed, the all apps container is redrawn
Eventually `PrivateProfileManager.reset()` is also called but PS decorator
is not added as there is no change in PS state.
https://photos.app.goo.gl/V2bmZWfzBzcRP97C8
To fix this, we allow decorator addition on reset, but only
apply the same when its not already present in the recycler view.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 313498792
Test: PrivateProfileManagerTest
Change-Id: I4c9a89d84e670ed45bf53a2d2e2c4922b165463e
2023-12-03 23:34:19 +00:00
Himanshu Gupta f63c645d8c Merge "Fixing work widgets tab in WidgetsFullSheet." into main 2023-12-03 23:33:42 +00:00
Himanshu Gupta c2a2b86e76 Fixing work widgets tab in WidgetsFullSheet.
Currently the work widget matcher matches against all
non-foreground user profiles, due to which the work
tab is incorrectly shown in widgets full screen, when
PS is present.
This was missed in ag/25129268 where a bunch of work
matcher fixes were done.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 312900122
Test: Launcher3 tests
Change-Id: I80d33e851ea3366dc3897bb1f5cc17fcd6b34520
2023-12-03 21:23:44 +00:00
Andreas Agvard 973c049fe0 Adds supportsCommitHaptic
Test: Manual
Bug: 314408519
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Change-Id: Ia8f90489c2b8d82f6c63b4b363f9be5de6b2598b
2023-12-02 11:04:51 +01:00
Andreas Agvard 4b9a14cd8b Merge changes I9c92d3cb,I98e2dea9 into main
* changes:
  Increase slider for haptic hint iterations
  Enables ENABLE_SEARCH_HAPTIC_COMMIT
2023-12-02 08:55:57 +00:00
Vadim Tryshev caf5958e57 Waiting for Launcher activity to stop when starting an overview task
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ie72853a9d289b2688fdfbdf5220ce86808ac2da1
2023-12-01 16:15:45 -08:00
Sukesh Ram b8ddc944ff Fix 3-Button Color w/ Widget Sheet post-Rotation
Fixed issue where upon opening the widgets menu in the home screen in landscape, then rotating screen to portrait, then back to landscape (whilst keeping widget sheet open), the buttons are dim colored rather than white.

Flag: NONE
Test: Manually tested in pixel 7 in light mode and dark mode (with home screen rotation enabled).
Bug: 284801356
Change-Id: I0ed59373eb3af5f1b5ab695b43b850777042d2eb
2023-12-01 22:53:09 +00:00
Sebastián Franco b70b7fde7a Merge "Moving the remainder of reorder logic to ReorderAlgorithm" into main 2023-12-01 21:32:50 +00:00
Federico Baron 5f46067417 Merge "Fix flicker for widget picker" into main 2023-12-01 21:01:38 +00:00
Andreas Agvard 23de925836 Increase slider for haptic hint iterations
The haptic hint can now be made up to 200 itertions long (2.4 seconds)

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT DISABLED
Change-Id: I9c92d3cb24fabfa3b0d318a77d312423501737a6
2023-12-01 21:16:14 +01:00
Andreas Agvard fd7f192a0a Enables ENABLE_SEARCH_HAPTIC_COMMIT
ENABLE_SEARCH_HAPTIC_COMMIT should be enabled for now to keep consistency in
behavior.

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Bug: 314005577
Change-Id: I98e2dea91fe58b6abaeeb63f6c92a5ee130b5204
2023-12-01 21:16:14 +01:00
Andreas Agvard ffa44902d4 Merge "Adds support for shrinking nav handle on press" into main 2023-12-01 20:14:03 +00:00
Vinit Nayak 717c4f51ff Merge "Remove unused animation of splitInstructionsView text" into main 2023-12-01 20:00:27 +00:00
fbaron eca18c0bd1 Fix flicker for widget picker
Fix: 312159033
Flag: NONE
Test: verified on device
Change-Id: I69e39c9041ff2d0a2ac3a6459a4c85c131a1b785
2023-12-01 10:52:39 -08:00
Sebastian Franco dcf6bf2311 Moving the remainder of reorder logic to ReorderAlgorithm
This is a no-op thoroughly tested by ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I7203444df289cd3b67794fc570a2cd46e64549a2
2023-12-01 12:50:13 -06:00
Vadim Tryshev 6edb70f749 Merge "Waiting for Launcher to stop after quick-starting test apps" into main 2023-12-01 18:47:33 +00:00
Vadim Tryshev 0ad6d9bcee Waiting for Launcher to stop after quick-starting test apps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I795571ec191b01929bb871fd021d8653449bb608
2023-12-01 18:22:04 +00:00
Sebastián Franco f601447877 Merge "Moving bindAppsAdded and setIsFirstPagePinnedItemEnabled to ModelCallbacks" into main 2023-12-01 17:58:11 +00:00
Andreas Agvard 1ea0746e1c Adds support for shrinking nav handle on press
Fix: 314158312
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Test: Manual

Change-Id: Icd46467939ae9a38592ee67ee0d2a521eb8e0b6c
2023-12-01 17:54:41 +01:00
randypfohl 1338dc41df Fixing regression where icon view became focusable
Description: in ag/24721149 we stopped inflating IconView
from Task.xml and instead used a viewstub. When creating
files to fill the viewstub, we forgot to place the correct
attributes on Icon_view.xml. We did place them correctly
elsewhere. Anyways this is why we were seeing focusable
icons.

Flag: None

Test: Built locally, will follow up with automation

Bug: 307461880

Change-Id: I45f895c8545a80f80c79709180f2878476d10221
2023-12-01 14:35:48 +00:00
Pat Manning e06a23ed29 Update focus indicator radius to match workspace drag indicator radius.
Also decouple focus indicator radius from ENABLE_DEVICE_SEARCH feature flag, as it is used on home screen as well as all apps.

Bug: 313665319
Test: Manual.
Flag: N/A.
Change-Id: I629c1180b1b1b6797e2c3ba6ca13da04e8fa392b
2023-12-01 14:24:05 +00:00
Pat Manning 27efab01f3 Revert^2 "Update cell drop visualizer radius"
This reverts commit 311afc6987.

Reason for revert: Resubmitting with updated screenshots

Change-Id: Ieb114c06376cf46b90b140490a54cbae592c8f5a
2023-12-01 13:56:26 +00:00
Pat Manning bf6905c069 Merge "Navigate grid overview via arrows and tab properly." into main 2023-12-01 12:23:21 +00:00
Serdar Kocdemir 063858b510 Merge "Revert "Changing SystemUiProxy to kotlin"" into main 2023-12-01 12:04:59 +00:00
Pat Manning e683c4c549 Navigate grid overview via arrows and tab properly.
Fix: 311646336
Fix: 281021558
Test: TaskGridNavHelperTest
Flag: N/A
Change-Id: Iad5a2eec22f8fa4519a6a1f7bcde097e00d6b142
2023-12-01 11:06:41 +00:00
Uwais Ashraf 205d707579 Merge "Revert "Update cell drop visualizer radius"" into main 2023-12-01 10:16:29 +00:00
Uwais Ashraf 311afc6987 Revert "Update cell drop visualizer radius"
This reverts commit 77e0faa670.

Reason for revert: Causes a 100% failing test see b/314206230

Change-Id: Icfc5bb4bace17b630bfd74a1460f6d1748d8d9d3
2023-12-01 10:14:54 +00:00
Surajit Chandra 49997a7cf9 Revert "Changing SystemUiProxy to kotlin"
Revert submission 25509210-proxy-kotlin

Reason for revert: test revert b/314219394
Reverted changes: /q/submissionid:25509210-proxy-kotlin

Change-Id: I3ada33461886ba2428b6b768cacc0d5454d543a3
2023-12-01 08:27:16 +00:00
Vadim Tryshev 1ccdc411e5 Not diagnosing taskbar as <Launcher in invalid state>
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib73785d7421ebc0fb899cb02ae8c29b6bbad968e
2023-11-30 17:20:32 -08:00
Treehugger Robot 0cfbca60ab Merge "Move logic only used on the reorder from the cellLayout to ReorderAlgorithm" into main 2023-12-01 00:57:37 +00:00
Vinit Nayak 440cdc4a4a Merge "Revert "Add logs for move pointer"" into main 2023-12-01 00:49:23 +00:00
Sunny Goyal 6f04a32b21 Merge "Revert "Removing unnecessary iconFactory class when generating b..."" into main 2023-11-30 23:55:59 +00:00
Sunny Goyal 01f8bc59c6 Merge "Changing SystemUiProxy to kotlin" into main 2023-11-30 23:55:15 +00:00