Commit Graph

78507 Commits

Author SHA1 Message Date
Sebastián Franco 758b01defc Merge "Adding the Launcher workspace team to the OWNERS file" into main 2023-11-30 23:51:55 +00:00
Schneider Victor-tulias 55bdb474c2 Merge "Fix ANR in TouchInteractionService" into main 2023-11-30 23:27:39 +00:00
Stefan Andonian df7ea42299 Merge "Revert "Update launcher preview icons on themed icon update"" into main 2023-11-30 23:01:22 +00:00
Sebastian Franco 9a35d45904 Adding the Launcher workspace team to the OWNERS file
Flag: NA
Bug: 314190226
Test: this LDAPs should apear as owners
Change-Id: Ia1e84fa3e3eeb2b94be256ad34833b330d469bd5
2023-11-30 22:28:09 +00:00
Holly Sun ac14c86c66 [ps] Add data source for launcher.
Bug: 298227797
Test: manual
Flag: aconfig com.google.android.apps.nexuslauncher.inject_private_space_tile DISABLED
Change-Id: Idb348fcd5373d4eae9d56432886ad9998fb0ec6e
2023-11-30 13:47:42 -08:00
Sebastián Franco dc3cb09765 Merge "Move expectFail to TestUtil" into main 2023-11-30 21:46:56 +00:00
Andy Wickham faa97d6224 Merge "Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag." into main 2023-11-30 20:17:42 +00:00
Stefan Andonian dd088daead Revert "Update launcher preview icons on themed icon update"
Revert submission 25242534-launcher-preview-update-themed-icon

Reason for revert: This change potentially breaks the launcher's database.

Reverted changes: /q/submissionid:25242534-launcher-preview-update-themed-icon

Change-Id: I90fd55695b24529752a82cb6bf001935204a53f7
2023-11-30 20:12:40 +00:00
Schneider Victor-tulias 7ab2c874c9 Update isLauncherInitialized check to wait until Launcher has stopped binding items
The current implementation of isLauncherInitialized allows TAPL tests to run while LoaderTask is still binding items. This can lead to interactions on a launcher that is not yet drawn/responsive.

Flag: N/A
Fixes: 313043156
Test: TaplAppIconMenuTest#testLaunchMenuItem
Change-Id: I4cb9276eb3852653517faa45be8517e659f39c00
2023-11-30 15:11:33 -05:00
Saumya Prakash 89b93d4bbd Merge "Add taskbar pinning education for new users and update other steps" into main 2023-11-30 20:08:13 +00:00
Federico Baron b89fde7a9a Merge "Update cell drop visualizer radius" into main 2023-11-30 20:07:47 +00:00
Vinit Nayak a2bf68fee2 Revert "Add logs for move pointer"
This reverts commit b39abc99cd.

Reason for revert: Test no longer failing

Change-Id: I461d91c88290b820a75bbb4771663558162692ab
2023-11-30 20:07:01 +00:00
Sunny Goyal b18392cbe9 Changing SystemUiProxy to kotlin
> Simplifying some try-catch stamtements
> Removing unnecessary interface implementation
> Using kotlin native null check, which also prevents NullpointExeception
  when using calling methods from a non-main thread

Bug: 314010650
Flag: N/A
Test: Presubmit
Change-Id: I435ace5df8d7a19a8bba4099408f6cc7257d1f1f
2023-11-30 12:05:28 -08:00
Jagrut Desai 7736ec8968 Merge "Decreasing the intensity of haptic feedback for taskbar invocation" into main 2023-11-30 19:29:45 +00:00
Vadim Tryshev c5d3b1c845 Merge "Disable flash detector" into main 2023-11-30 19:12:25 +00:00
Tracy Zhou aa759645cf Merge "Use enableSplitContextually() to guard split keyboard shortcut feature" into main 2023-11-30 18:43:13 +00:00
Schneider Victor-tulias b9341d1878 Fix ANR in TouchInteractionService
AccessibilityManager.registerSystemAction is a binder call that should be run on the ui helper thread. It is only used for the taskbar and likely ran slowly ON THE UI thread, causing an ANR.

Flag: N/A
Fixes: 313923168
Test: ran launcher
Change-Id: Icf8d7282df5bffd4aae2f4ec94f997b555c3b8c1
2023-11-30 13:05:37 -05:00
Sebastian Franco 38e8f83392 Move expectFail to TestUtil
Flag: NA
Bug: 298234173
Test: atest TaplWorkspaceTest
Change-Id: I7aadab92891ecdb9e8910601a6e1b417ffa5f605
2023-11-30 11:56:43 -06:00
Bill Yi 31ae3a5f83 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-11-30 17:46:44 +00:00
Bill Yi 62cd93cd06 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-11-30 17:46:44 +00:00
Sebastian Franco a7ff1558c9 Move logic only used on the reorder from the cellLayout to ReorderAlgorithm
This is a no-op thoroughly tested by ReorderAlgorithmUnitTest.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I9909477274aadbbf928c9fdeb4157d697c4c7175
2023-11-30 11:14:57 -06:00
Sunny Goyal dad66f4188 Revert "Removing unnecessary iconFactory class when generating b..."
Revert submission 25483550-themed-badge

Reason for revert: b/314097390

Reverted changes: /q/submissionid:25483550-themed-badge

Change-Id: I7ad16d7c5d5457d350ac6cff86d512c2f57dbcbf
2023-11-30 17:09:41 +00:00
Johannes Gallmann b1f522d1a7 Fix delayed taskbar animation for predictive back
Bug: 311613831
Flag: NONE
Test: Manual, i.e. testing predictive back to home and analysing taskbar animation
Change-Id: I87d9ba065a43ee99ff1c7b35478b2828a482bd7b
2023-11-30 15:40:23 +01:00
Jordan Silva 0734ef2d7c Merge "Revert "Make numFolderRows/numFolderColumns accept more values"" into main 2023-11-30 14:27:20 +00:00
Andreas Agvard 711f104409 Merge "Use NavHandleLongPressInputConsumer regardless of flags." into main 2023-11-30 13:32:00 +00:00
Thales Lima 09d42d5340 Revert "Make numFolderRows/numFolderColumns accept more values"
Revert submission 25438456-5x5_folder
Reason for revert: http://b/313567919
Reverted changes: /q/submissionid:25438456-5x5_folder

Revert "Use DeviceProfile numFolderRows and numFolderColumns"
Revert submission 25313018-numFolder
Reason for revert: http://b/313567919
Reverted changes: /q/submissionid:25313018-numFolder

Change-Id: I4890016e310c0a2122861f36fcdbf33e98e727c0
2023-11-30 11:47:37 +00:00
Pat Manning 2a350af739 Merge "Show taskbar pinning dialog on right-click." into main 2023-11-30 10:57:41 +00:00
Pat Manning 001d1cda52 Merge "Allow right-click of taskbar icons to launch long-click menu." into main 2023-11-30 10:56:46 +00:00
Anna Zhuravleva 94228b18db Merge "Add user_type field and log it in Launcher" into main 2023-11-30 10:28:45 +00:00
Johannes Gallmann 0c3b20b585 Merge "Use Decelerate Interpolator for predictive back to home window scaling" into main 2023-11-30 08:10:04 +00:00
Johannes Gallmann c07b1c92b0 Merge "Prevent scaled window from leaving screen bounds for back to home" into main 2023-11-30 08:09:39 +00:00
Tracy Zhou 6209f34b02 Use enableSplitContextually() to guard split keyboard shortcut feature
enableSplitFromFullscreenWithKeyboardShortcuts() depends on enableSplitContextually() from the product perspective, hence merging these two flags

Bug: 270394122
Test: N/A
Change-Id: Iecf46a62bfa21ed0c3bad9ca8c9e2646b3aebc78
2023-11-29 22:20:42 -08:00
Winson Chung abb4483f6f Merge "Add Launcher support for left-right splits on portrait foldables" into main 2023-11-30 05:52:57 +00:00
Jagrut Desai a5ad8bed64 Decreasing the intensity of haptic feedback for taskbar invocation
Test: Presubmit, Manual
Bug: 308496668
Flag: NONE
Change-Id: Ic8c28b8e84bf9f388a73c518c91840d958287546
2023-11-29 19:03:33 -08:00
Jon @ 95306b1502 Merge "Allow initial call to onLauncherVisibilityChanged when using home transition listener." into main 2023-11-30 01:15:26 +00:00
Andy Wickham c0c420a3c2 Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag.
This controls whether a haptic is played when search invocation
starts. The assumption is that the search app will play this
haptic if the flag is disabled (default).

Test: Manual
Bug: 310659178
Bug: 314005577
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT DISABLED
Change-Id: I406c18cfaf27d004e19de26f00c997c0a03de996
2023-11-29 17:07:20 -08:00
Brandon Dayauon e9c7f41920 Null check activityContext because the activityContext can be null when called from SearchDelegateView.
Bug: 312585134
Test: presubmit
Flag: None
Change-Id: Id31f05f0bbaa07bc8b740f6f423a66896e9de5ba
2023-11-29 16:31:58 -08:00
Sebastián Franco 033a335801 Merge "Revert^2 "Moving rearrangementExists to ReorderLogic since it's only used there"" into main 2023-11-30 00:09:47 +00:00
Vadim Tryshev 54dbd42cae Merge "Waiting for Launcher activity to stop when starting a Launchable" into main 2023-11-29 21:57:45 +00:00
Vadim Tryshev 1b058fd467 Waiting for Launcher activity to stop when starting a Launchable
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I8bed0225617a225c2dc9587a75d004b98395fe1f
2023-11-29 13:55:46 -08:00
Sebastián Franco 61fbd18e5d Revert^2 "Moving rearrangementExists to ReorderLogic since it's only used there"
This reverts commit 484a7ea4f3.

Reason for revert: Fixing build error 

Change-Id: I00dcbb831dc40a90d43ada7315969251413bb88b
2023-11-29 21:54:51 +00:00
fbaron 77e0faa670 Update cell drop visualizer radius
Fix: 313665319
Test: NONE
Flag: NONE
Change-Id: I1a6ab76f2feb8175eca3af5fa62efa2cf8be01ba
2023-11-29 13:49:48 -08:00
Holly Jiuyu Sun 1facb1eb52 Merge "[tile] Repurpose PEOPLE_TILE result type to QS_TILE" into main 2023-11-29 21:47:59 +00:00
Federico Baron f638d01063 Merge "Revert^2 "Update status bar scrim"" into main 2023-11-29 21:36:04 +00:00
Jon Miranda bd53046738 Allow initial call to onLauncherVisibilityChanged when using home transition listener.
Fixes: 308632502
Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TEAMFOOD
Test: HomeTransitionObserverTest
Change-Id: I8992f8f74cbfa7e98a79a136265ee6c4ad784c2c
2023-11-29 13:35:03 -08:00
Andy Wickham 3523154b07 Use NavHandleLongPressInputConsumer regardless of flags.
This way we can still log long press attempts even when the
feature flags or settings are disabled.

We always log LAUNCHER_LONG_PRESS_NAVBAR when a long press is
detected, even if nothing else happens.

Additionally, we log LAUNCHER_DEEP_PRESS_NAVBAR if the long
press was short-circuited by a deep press. In this case both
logs will appear.

If ENABLE_LPNH_DEEP_PRESS is false, it's possible that
LAUNCHER_DEEP_PRESS_NAVBAR will be logged without
LAUNCHER_LONG_PRESS_NAVBAR. This is because we log deep press
even if the feature is disabled, but it won't cause long press to
trigger immediately, so the user may release their finger before
the normal long press triggers.

Note: getLongPressRunnable will still return null if the flags or
other checks fail, so nothing will happen beyond logging.

Fix: 313477667
Fix: 310955078
Test: Manual with wwlogcat with flags in various states
Flag: NA
Change-Id: I40ceb5a22b364c2d5d6e4fdabb546b81c84354eb
2023-11-29 13:02:27 -08:00
Schneider Victor-tulias f67c54b48f Fix Keyboard quick switch screenshots and spliscreen launch
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 312449590
Fixes: 292182490
Test: TaplTestsKeyboardQuickSwitch, keyboard quick switched with split app pairs
Change-Id: I0faf2f7d58b39270ad6e5a065cf59f48e0dd23f0
2023-11-29 15:59:04 -05:00
fbaron 9efed13652 Add ACONFIG flag enable_unfolded_two_pane_picker
Bug: 301918659
Test: NONE
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT
Change-Id: I16e4cafb676564faa9da2d7402357cb815fd178e
2023-11-29 20:56:09 +00:00
Bill Yi 319caa3642 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4925744b7e1c3a48c6c6f94b0ab0bff0a5515572
2023-11-29 12:48:26 -08:00
Bill Yi b72796db31 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8827e64a1ba84eb28febabd33f591faf7113f362
2023-11-29 12:47:12 -08:00