Commit Graph

78507 Commits

Author SHA1 Message Date
Greg Kaiser 4144564af6 Merge "Revert "Moving rearrangementExists to ReorderLogic since it's only used there"" into main 2023-11-29 20:36:54 +00:00
Greg Kaiser 484a7ea4f3 Revert "Moving rearrangementExists to ReorderLogic since it's only used there"
This reverts commit 6890893a24.

Reason for revert: Many build breaks, like https://android-build.corp.google.com/artifact/submitted/11157014/mokey_go32-trunk_staging-userdebug/latest/view/logs%2Fbuild_error.log , seem related to this.

Change-Id: I049c94fbd1e089c65fd4e0abb4ac2c165f228c92
2023-11-29 20:26:47 +00:00
Winson Chung 104a4c8b69 Add Launcher support for left-right splits on portrait foldables
Bug: 291018646
Test: Manual
Flag: enable_left_right_split_in_portrait

Change-Id: I92af7ffd83770f7e942c3892a12b1611ff5b50f4
Signed-off-by: Winson Chung <winsonc@google.com>
2023-11-29 20:20:14 +00:00
Sebastián Franco 1c1c18ca28 Merge "Moving rearrangementExists to ReorderLogic since it's only used there" into main 2023-11-29 19:18:18 +00:00
Sebastián Franco 1f04ea22b7 Merge "Enabling ENABLE_NO_LONG_PRESS_DRAG" into main 2023-11-29 19:17:14 +00:00
Sebastian Franco 7a08e54eed Enabling ENABLE_NO_LONG_PRESS_DRAG
This is a simple flag, I don't think it requires the new
flagging system, I mainly added the flag for ease of debugging
if it breaks test on postsubmit.

This flag was already tested using enabled but it was disabled
before trunk stable, I think we can set this to true without risk
and then remove the flag.

Flag: LEGACY ENABLE_NO_LONG_PRESS_DRAG ENABLED
Fix: 299748096
Test: atest TaplDragTest
Change-Id: If99027d8cec7d75eee11012615da0e0d76951755
2023-11-29 10:09:57 -06:00
Alex Chau 4745e95ea7 Merge "Adjust app chip menu top margin." into main 2023-11-29 14:40:12 +00:00
Anna Zhuravleva 9c20381231 Add user_type field and log it in Launcher
Add new field user_type to decouple
work_profile and private_space users.
Deprecate is_work boolean field.

Bug: 312200869
Test: statsd_testdrive 19, output: https://paste.googleplex.com/5912695996416000
Flag: NA
Change-Id: Idc25f341b4353a85b8a93eab97c88195895baedc
2023-11-29 10:26:53 +00:00
Vinit Nayak eabb37822f Merge "Change SplitInstructionsView cancel from X to "Cancel"" into main 2023-11-29 00:18:42 +00:00
Holly Sun e76f092fa9 [tile] Repurpose PEOPLE_TILE result type to QS_TILE
Bug: 313696037
Test: manual
Flag: NA
Change-Id: Ia04654678e6eb146b532c1b81f51ecfb1afea1c5
2023-11-28 16:03:24 -08:00
Vinit Nayak 33a432a3c4 Pass through both the widget's pendingIntent and remoteView intent
* Both may be necessary to correctly launch a widget
* We pass it through as the second app's Bundle instead
of adding a new parameter.

Bug: 311263727
Test: Tested w/ 2 fresh launches, app + widget.
Also with existing task + widget.
Was not able to accurately test multiple tasks launched by the
widget since there are some issues with the allowlist check.
And the working case for multiple instances of Chrome didn't
work because none of the chrome widgets rely on the secondary
intent to launch any of the app's activities.
Flag: None, technically this code isn't reachable since widgets
are unsupported, but didn't seem worthwhile to add a separate flag
in the short duration we will begin supporting them again.
To run replace the early return in QuickstepInteractionHandler with
the call:
mLauncher.getSplitToWorkspaceController()
	.handleSecondWidgetSelectionForSplit(view, pendingIntent, options.first)

Change-Id: I1ebcb385b140d42a6a84368f589aba06c4bed2bd
2023-11-28 14:58:44 -08:00
Vinit Nayak e5277ab8e7 Remove unused animation of splitInstructionsView text
* The animation of the overall view is
sufficient and we don't need this separate one

Flag: None
Bug: 295983387
Test: Visually appears the same
Change-Id: I6e3fe7191df8af869a50abab820d30e95e23696c
2023-11-28 14:39:18 -08:00
Pat Manning ad6b044412 Adjust app chip menu top margin.
Include adjusting gap of menu when expanding app chip.

Fix: 313648444
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iea8ea76873ac008b90b6a8f183dc99cba9237041
2023-11-28 22:38:22 +00:00
Vinit Nayak d6efde5cbb Change SplitInstructionsView cancel from X to "Cancel"
* Styling (accent color) is still a TODO,
just made it bold for now.

Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off

Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
2023-11-28 14:34:12 -08:00
Charlie Anderson 89449a30b3 Merge "Add aconfig flag enable_launcher_br_metrics" into main 2023-11-28 21:54:39 +00:00
Sunny Goyal a481659e51 Merge "Merging widget item click listener to default click listener" into main 2023-11-28 21:36:15 +00:00
Sebastián Franco 27614fc8ce Merge "Making sure the Launcher is present when running the test" into main 2023-11-28 21:16:30 +00:00
Johannes Gallmann 8c197b9328 Merge "Fix task window losing scale when going back to home" into main 2023-11-28 20:35:13 +00:00
Johannes Gallmann b4f33ab7bb Merge "Fix crash in LauncherBackAnimationController" into main 2023-11-28 20:34:10 +00:00
Saumya Prakash 5feb491549 Add taskbar pinning education for new users and update other steps
This change updates the current transient taskbar education to include
the pinning feature and additional updates to Lottie animations. It also
removes the tutorial that teaches users to switch navigation modes. The
pinning education is gated behind an additional pinning education static flag.

Fixes: 302588455,300161174
Test: Went through taskbar education for persistent and transient
taskbar with the flag on and off.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I836467091bfe694eee89ac46c4be597c490e1b3f
2023-11-28 20:20:25 +00:00
Sunny Goyal 464509b375 Merging widget item click listener to default click listener
> Also removing check for dragHandle, since dragHandle is already removed

Bug: 307306823
Test: atest Launcher3Tests
Flag: N/A
Change-Id: I0b452dd1fbccf15ed686370471e8866b179fd77e
2023-11-28 12:07:16 -08:00
Schneider Victor-tulias 812bc2a9c5 Merge "Refactor LottieAnimationColorUtils to enforce proper usage" into main 2023-11-28 19:49:36 +00:00
Jordan Silva 837fb91423 Merge "Validate responsive specs using more than 100% of remainder space" into main 2023-11-28 19:49:30 +00:00
Schneider Victor-tulias 891865dd60 Merge "Fix NPE in TaskAnimationManager" into main 2023-11-28 19:49:22 +00:00
Jordan Silva 2b5bac90b8 Merge "Update where responsive grid cell icon size is defined" into main 2023-11-28 19:48:43 +00:00
Sunny Goyal eb67c99e5f Merge "Removing unnecessary iconFactory class when generating badged icon" into main 2023-11-28 19:02:02 +00:00
Vinit Nayak 2349efe50d Merge "Revert "Add logs for workspace long press"" into main 2023-11-28 18:51:23 +00:00
Holly Jiuyu Sun b265cf8fdd Merge "[PS] Add emphasized interpolators when clicking the PS tile to scroll to bottom." into main 2023-11-28 18:41:00 +00:00
Sebastian Franco afd0e4ab11 Making sure the Launcher is present when running the test
It seems that when a previous test fails this test starts failing
so we are not making sure we are in a correct state.

Bug: 303263644
Flag: NA
Test: will see if the flake rate goes down
Change-Id: I7ecdc0ea82914331d68fe20bf2665d2812bca46f
2023-11-28 12:35:39 -06:00
Sebastián Franco 4a708997a1 Merge "Moving the static initialization method from TaplTestsLauncher3 to AbstractLauncherUiTest" into main 2023-11-28 18:32:58 +00:00
Sergey Pinkevich d3087e3c16 Merge "Fix blinking for the active tile" into main 2023-11-28 18:31:07 +00:00
Tracy Zhou 898aec864d Merge "[taskbar/navbar unification] Do not shift back button after unlocking in phone mode" into main 2023-11-28 18:20:58 +00:00
Andy Wickham 9e6f276d41 Merge "Adds withPackageName to StatsLogger creation" into main 2023-11-28 17:15:55 +00:00
Schneider Victor-tulias e861fa05bc Merge "Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0" into main 2023-11-28 16:23:47 +00:00
Schneider Victor-tulias ed2eba9beb Refactor ActiveGestureLog and CompoundString in preparation for ProtoLog 2.0
We will need to send formatted strings to the ProtoLog api, so it is simpler to use CompoundString as the default string storage in ActiveGestureLog.

Refactored CompoundString to be able to be broken down into a formattable string.

Flag: N/A
Fixes: 313640579
Test: ran launcher, completed gestures, dumped gesture logs
Change-Id: I5f290d1860c6bac5047cbf361537829fbe986685
2023-11-28 16:23:38 +00:00
Jordan Silva 4c09958671 Validate responsive specs using more than 100% of remainder space
Fix: 313463517
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: ResponsiveSpecsProviderTest
Change-Id: Ic80846d27dabd8d57f43b35581174bd2f2f3611b
2023-11-28 15:11:27 +00:00
Jordan Silva 15cacd54c6 Update where responsive grid cell icon size is defined
This CL changes where the cell icon size, text size and drawable padding is defined to prevent an issue with taskbar.
The transient taskbar updates the DeviceProfile icon size with a different value than used for responsive grids, and this update wasn't working anymore because responsive grid implementation wasn't reading the value from iconSize inside the updateIconSize function, but from the responsive grid spec.

Bug: 313463280
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: manual
Test: NexusLauncherImageTests
Change-Id: I835a90d724c2d1b2d32f483b758b789be7cbdcfe
2023-11-28 14:42:06 +00:00
Helen Cheuk 4a6d4994c3 Merge "Remove excess entry before putting new item" into main 2023-11-28 13:03:53 +00:00
Sergey Pinkevich 6c7ddc9b90 Fix blinking for the active tile
Call of `buildAnimationController` within `View#onApplyWindowInsets` if endTarget is not null.

Bug: 312439564
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual - took a screen recording:
Before - https://drive.google.com/file/d/1P2GsTi0xCZFjAsTQKonMMADHGkKuxMe0/view?usp=sharing
After - https://drive.google.com/file/d/1xkbFa-2Xp1OwmPrKLcqE2cYshVRXY2YV/view?usp=sharing

Change-Id: I6eb2a48bb548e20c1d36a058921ff8e1a0983cad
2023-11-28 12:24:40 +00:00
Thales Lima 5fc47806f8 Merge "Make numFolderRows/numFolderColumns accept more values" into main 2023-11-28 11:22:27 +00:00
Johannes Gallmann 1de8952a30 Fix task window losing scale when going back to home
Bug: 305934426
Flag: NONE
Test: Manual, i.e. testing back to home with different devices and device orientations
Change-Id: I3eddbc918de95be713aecb469501b01e6b7b3d3b
2023-11-28 11:33:29 +01:00
Vadim Tryshev 8f2dc92364 Merge "Permanently demoting stress tests from presubmit to speed up presubmits" into main 2023-11-28 02:38:25 +00:00
Holly Sun 454590d7ea [PS] Add emphasized interpolators when clicking the PS tile to scroll to bottom.
UX spec: https://carbon.googleplex.com/google-material-3/pages/easing-and-duration/tokens-specs/bd8df608-11ee-48f9-b93d-90d74e3d35c8#5fa37127-0934-4c47-804e-cb2fbf47f73d. Use the first column "Emphasized" one.
Duration: 500ms

video: https://drive.google.com/file/d/1EYlkWVgiYFy0IB5WnQRVoQ9b_sbEkLj7/view?usp=sharing

Bug: 309522136
Test: manual
Flag: ACONFIG com.google.android.apps.nexuslauncher.inject_private_space_tile DEVELOPMENT
Change-Id: I178c075ebf5db8338f476d0607caabec7b8c7fde
2023-11-27 16:42:33 -08:00
Sebastián Franco 463131427d Merge "Add unit test for CellLayout making sure the reorder are valid and fix Multipage CellLyout" into main 2023-11-28 00:27:21 +00:00
Vinit Nayak fd66d09e94 Revert "Add logs for workspace long press"
This reverts commit 74fb544c27.

Reason for revert: b/311099513 is now no longer flaky. I suspect these logs may have improved a possibly existing race condition. Let's see if the flake returns w/o these logs.

Change-Id: Ib3a06b7d86f4eb5c3c95db9a68bc6eb15aead193
2023-11-28 00:22:02 +00:00
Federico Baron f378be865d Merge "Fix activity leak in QuickstepLauncher" into main 2023-11-28 00:02:30 +00:00
Sunny Goyal 0069e54f1e Removing unnecessary iconFactory class when generating badged icon
Bug: 276957152
Test: Verified on device
Flag: None
Change-Id: I31ca3ef939684b16c0134d19f0add574b4b59706
2023-11-27 15:44:31 -08:00
Sebastian Franco 6c7d817bc7 Add unit test for CellLayout making sure the reorder are valid and fix Multipage CellLyout
The new test generate hundreds of new boards using a fixed seed so the
test cases can be recreated if there is an error.

Some of the new clases where inside of CellLayoutBoard and moved
outside.

Flag: LEGACY FOLDABLE_SINGLE_PAGE DISABLED
Bug: 270395274
Test: ReorderAlgorithmUnitTest
Change-Id: I083fb6701b02b7c0b2cf24634ca71acb0c75902e
2023-11-27 17:12:43 -06:00
Sebastian Franco 6890893a24 Moving rearrangementExists to ReorderLogic since it's only used there
Also, simplify copyCurrentStateToSolution since it always gets false
as the second parameter.

Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I025566897246fa59ca513cb7de9a12465054498f
2023-11-27 16:36:44 -06:00
Vadim Tryshev 5feaf596e6 Permanently demoting stress tests from presubmit to speed up presubmits
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ib2edf419ad556d2a4bf5c77b5c026829f9b413b9
2023-11-27 11:54:22 -08:00