Commit Graph

78507 Commits

Author SHA1 Message Date
Sebastian Franco 9658523297 Removing debbug comments
Bug: 303263644
Flag: NA
Test: TaplWidgetPickerTest
Change-Id: I6ad428100b2455110315755cea4b75f46b7217c0
2023-12-11 10:01:16 -06:00
Sergey Pinkevich 83462a488b Update secondary grid translation
In order to properly animate task on the vertical axis we need to update `taskSecondaryTranslation`.

Bug: 304782953
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual

Change-Id: I1afe78d4eb1575e9c967ff594cffedd7d3620541
2023-12-11 15:25:29 +00:00
Thales Lima df643c4540 Merge changes from topic "numFolderRows" into main
* changes:
  Update dump tests
  Make numFolderRows/Columns accept more values
2023-12-11 10:54:04 +00:00
Jeremy Sim 0b070d9312 Fix clipping issue when dragging app pair icons
This CL changes AppPairIcon#getWorkspaceVisualDragBounds() to return the correct icon bounds, fixing an issue where the icon would appear clipped when being dragged.

Fixes: 312299947
Test: Icon is no longer clipped while dragging
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I103bdf53bf34d751147e1ba892f36145f04175e4
2023-12-11 17:17:00 +09:00
Tracy Zhou f3e5382042 Do not set isImmersive in TaskbarDelegate
allow_gesture and immersive_mode are opposite of each other, and currently we set one or another, check one or another in different places. We should consolidate the two. Hence, we are removing all references of immersive_mode (allow_gesture has more usages).

Bug: 313033827
Test: N/A
Change-Id: I52d86c37cb39ef0bc04a04a0fa78d2b051a0e56e
2023-12-10 21:18:22 -08:00
Jeremy Sim 23fcbf2f73 App Pairs: Launch animation
[App Pairs 7/?]

This patch implements the app pair launch animation from icon. Adds a new function, composeFadeInSplitLaunchAnimator(), in SplitAnimationController, that builds the combined launcher + shell animation.

Bug: 309618233
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I8e95f629ae2a71f1bd6cbb356f5e33233e5c2906
2023-12-11 13:09:06 +09:00
Jeremy Sim d761f5c3bd Merge "App Pairs: Implement Taskbar functionality" into main 2023-12-09 02:20:45 +00:00
Xin Li aa168f204e Merge "Merge Android 14 QPR1" into main 2023-12-09 00:12:03 +00:00
Vadim Tryshev 151751c014 Merge "Fixing non-sending wallpaper animation finish event" into main 2023-12-08 23:33:53 +00:00
Jeremy Sim 2987d95ba4 App Pairs: Implement Taskbar functionality
[App Pairs 8/?]

This CL adds taskbar functionality for app pairs:
- Ability to drag an app pair icon to Taskbar
- App pair launch from Home Taskbar
- App pair launch from Overview Taskbar
- App pair launch from in-app Taskbar

KNOWN ISSUES:
- Bug (b/315190686): if user is inside a running split pair and attempts to launch the same pair from an app pair icon on taskbar, Overview tiles get temporarily messed up (recoverable by leaving Overview)
- User can attempt to split with an app pair icon on the Taskbar. This should result in a "can't split with this" bounce animation on the SplitInstructionsView (to be implemented). Currently does nothing.

Bug: 274835596
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I5256547af236fc2deeb192d60bfe1f2b7ddc5647
2023-12-08 15:07:45 -08:00
Saumya Prakash 55fdc45ecc Merge "Ensure Taskbar stashes when launching an app from folder" into main 2023-12-08 22:59:45 +00:00
Sunny Goyal 41aca1e7b3 Adding support for getting task overlay
Test: Verified the flow in Launcher
Bug: 273828110
Flag: LEGACY USE_ACTIVITY_OVERLAY DISABLED

Change-Id: Ia61f4f165e328335820a33ceea2b810ac5e6c3af
2023-12-08 14:39:50 -08:00
Vinit Nayak fe22e7fa4d Merge "Only launch from split taskView if it's visible to user" into main 2023-12-08 22:34:33 +00:00
Vadim Tryshev 3277cbdb17 Fixing non-sending wallpaper animation finish event
Wallpaper animation may be interrupted with an animation to go to Normal state.
Then the animation won't succeed, but it will still end.

Bug: 315074923
Flag: N/A
Test: presubmit
Change-Id: I15a106de78030f6935978539d333cc85ee95b4e7
2023-12-08 14:11:55 -08:00
Thales Lima 0c9e869a8a Update dump tests
Bug: 309800141
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I75c6a07192f6af94adbea89a6dfdf03984272849
2023-12-08 22:00:51 +00:00
Thales Lima 1faa4edc42 Make numFolderRows/Columns accept more values
InvariantDeviceProfile hold values that are not related to current DP in use. Now other classes get the value correctly from DeviceProfile, and each posture can hold different values, making it akin to iconSize.

Fix: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I32295738585de67205dcd6c8942d08a3d07d169a
2023-12-08 22:00:48 +00:00
Xin Li 65e37d77fe Merge Android 14 QPR1
Merged-In: I7f5bca7edd18631b36f2b9213e17554cf769cbc6
Bug: 315507370
Change-Id: I53db199aae0b6104272ad9cdcf86fa878758124b
2023-12-08 13:14:20 -08:00
Saumya Prakash 86285d477d Ensure Taskbar stashes when launching an app from folder
We use the folder closing callback to trigger a call to stash the
taskbar if an app was launched. We can check whether an app was launched
from a folder based on whether a folder's view is open when
an app is launched. This ensures that the taskbar only stashes after the
folder is done animating.

Flag: NA
Fix: 295296529
Test: Launched an app in a folder on taskbar. Also ensured that other
taskbar behavior remains unchanged.

Change-Id: Ib5a797186978ee960e44b6b62c833eead03bccd0
2023-12-08 20:16:15 +00:00
Vadim Tryshev 5eac9a5d81 Waiting for wallpaper animation in widget tests only for Nexus Launcher and in postsubmit
This code flakes in postsubmit and presubmit, but the failure is
not reproducible in local and abtd runs. Landing the change to make postsubmit
flake; then I'll use tricks like tracing to debug the cause.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I77c324d43a2400fe1015f5cd0a4729e34552687c
2023-12-08 12:06:45 -08:00
Holly Jiuyu Sun d60f56c36e Merge "[tile] Update protos." into main 2023-12-08 19:26:50 +00:00
Vadim Tryshev 229a181771 Disabling ViewCaptureRule
Looks like vire capture needs some time to stabilize; for now,
 it sometimes generates empty view capture data.

Bug: 315482167
Flag: N/A
Test: presubmit
Change-Id: I864ffacf4a3a28cfc01b300ac1df71890f93c5e1
2023-12-08 10:44:48 -08:00
Anushree Ganjam 0d86f7859f Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY
Bug: 311370599
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: I25675cf65f8c7a53ea37d9ba317ddc6dbb271136
2023-12-08 10:17:42 -08:00
Sebastián Franco c811263007 Merge "Moving finishBindingItems to ModelCallbacks" into main 2023-12-08 16:06:32 +00:00
Sebastián Franco 4d548b5992 Merge "Make all tapl test start with Tapl" into main 2023-12-08 15:43:47 +00:00
Jordan Silva 558e5f8d88 Merge "Fix folder icon drawable padding for responsive grid" into main 2023-12-08 11:34:23 +00:00
Thales Lima 65cc1ff5a4 Merge "Adding test for folder preview loading" into main 2023-12-08 10:15:51 +00:00
Xin Li 92dc7eca5e [automerger skipped] Merge UQ1A.231205.015 am: 861ce33a59 -s ours am: f613df2750 -s ours
am skip reason: Merged-In I91dd8b4088f02af9dc5e603853d8e26606acc38f with SHA-1 c44b3cdda9 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25590965

Change-Id: If5344196c30aec6ca031a975533e833721db7d83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-08 08:51:05 +00:00
Xin Li f613df2750 [automerger skipped] Merge UQ1A.231205.015 am: 861ce33a59 -s ours
am skip reason: Merged-In I91dd8b4088f02af9dc5e603853d8e26606acc38f with SHA-1 c44b3cdda9 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25590965

Change-Id: I5aa12dfdfc1885337fa9a10a1cc79f44dff063d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-08 08:21:18 +00:00
Fengjiang Li 83a6a2cd42 Merge "Clear mOnInitialBindListener in Launcher#onDestroy()" into main 2023-12-08 04:05:28 +00:00
Fengjiang Li 17720f1699 Clear mOnInitialBindListener in Launcher#onDestroy()
Bug: 305643224
Test: manual
Flag: N/A
Change-Id: I8c5f670dc7d42eb03e0017a11a0beca2c5005cd3
2023-12-07 17:54:29 -08:00
Xin Li 861ce33a59 Merge UQ1A.231205.015
Bug: 308969284
Merged-In: I91dd8b4088f02af9dc5e603853d8e26606acc38f
Change-Id: I7f5bca7edd18631b36f2b9213e17554cf769cbc6
2023-12-07 15:48:03 -08:00
Vadim Tryshev d7dd3ca0a4 Merge "Better diagnosing when Launcher settings popup is visible" into main 2023-12-07 23:30:25 +00:00
Vinit Nayak 14f3a795e1 Only launch from split taskView if it's visible to user
* Same logic that fullscreen tasks use to launch.
* If not on-screen it will use default fade in animation

Test: Repro-steps don't produce crash
Fixes: 313911097
Flag: None
Change-Id: I4ada7137bffc7c567e4f8184bdd65bdf9bad481e
2023-12-07 15:04:16 -08:00
Vadim Tryshev 76dd9d4eb9 Inserting waiting for wallpaper animation into "back" gesture from app to workspace
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ib0f6d62de5caba00823618bdf661d0e4f27e5650
2023-12-07 14:50:42 -08:00
Vadim Tryshev d7ef3b4486 Merge "Waiting for Launcher stop when dropping a widget that starts an activity" into main 2023-12-07 22:41:50 +00:00
Sebastian Franco 957e4e513e Make all tapl test start with Tapl
Flag: NA
Bug: 298234173
Test: only test name change
Change-Id: Ib2e67a569599568cf1e681a7f1ac44924da83b84
2023-12-07 22:27:53 +00:00
Vadim Tryshev fd07533f37 Better diagnosing when Launcher settings popup is visible
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I27c28ae5914b8b4d96133afafefc93f650f2eda1
2023-12-07 14:00:53 -08:00
Hyunyoung Song a6a16220d4 Merge " ALLAPPS PREINFLATION to TEAMFOOD" into main 2023-12-07 21:59:07 +00:00
Will Leshner 531fc4985b Handle widget taps in WidgetPickerActivity.
Bug: 307306823
Test: atest Launcher3Tests
Flag: NA
Change-Id: I05cd42eae91447cfe99165096a735f6e04257203
2023-12-07 13:53:45 -08:00
Holly Sun 5225c2f870 [tile] Update protos.
Bug: 313696037
Test: manual
Flag: NA
Change-Id: Ic9e9d65b650a2e1f870359cfe59b52a138f53363
2023-12-07 13:04:23 -08:00
Sunny Goyal 522dfa139a Adding test for folder preview loading
Bug: 315352494
Test: atest FolderIconLoadTest
Flag: N/A
Change-Id: Idcef30427b8ea637eb98b1a7a0d2eda09abd0837
2023-12-07 12:11:38 -08:00
Brian Isganitis 23ef0eda05 Merge "Remove types PIN_IME_POPUP and TASKBAR_ALL_APPS from TYPE_ACCESSIBILE." into main 2023-12-07 20:09:05 +00:00
hyunyoungs 11d8641e8a ALLAPPS PREINFLATION to TEAMFOOD
This flag should be enabled again when there is guarantee that
the icons inflated in the background thread is guaranteed to be in the same
device profile as the device profile that is current on the main UI thread

Bug: 312126498
Test: manual
Flag: LEGACY ENABLE_ALL_APPS_RV_PREINFLATION TEAMFOOD
Flag: LEGACY ALL_APPS_GONE_VISIBILITY TEAMFOOD
Change-Id: I9b4dae4327d6bdee135360ca1f40bdec5234ed56
2023-12-07 12:04:10 -08:00
William Leshner 5836cec7ec Merge "Show Launcher's widget picker in an activity." into main 2023-12-07 19:23:58 +00:00
Jagrut Desai a473968d24 Merge "Fixing/Adding Support for "Move to top/left" and "Move to bottom/right" Talkback Menu Item Action" into main 2023-12-07 19:11:51 +00:00
Tony Wickham 1482ec384c Merge "Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support" into main 2023-12-07 19:11:07 +00:00
Vadim Tryshev 4bd8b8c60c Merge "Partially reverting waiting for animation when setting widget result" into main 2023-12-07 17:50:35 +00:00
Sebastian Franco 6196b9067f Moving finishBindingItems to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: TaplWorkspace
Change-Id: I4c35b540511c9655de1aa1fd0a808a75e7295c1b
2023-12-07 10:58:02 -06:00
Johannes Gallmann 661f96066e Fix predictive back to home with pinned taskbar
Bug: 309969400
Flag: ACONFIG com.android.window.flags.predictive_back_system_animations DISABLED
Test: Manual, i.e. testing predictive back with pinned taskbar
Change-Id: Ic6f747e87f8ebb2bed58f4783736ed4dca43fb7e
2023-12-07 15:51:46 +01:00
Greg Kaiser d806c0abd1 Merge "Revert^3 "Refactor/clean up Overview Actions buttons"" into main 2023-12-07 14:06:19 +00:00