Commit Graph

78507 Commits

Author SHA1 Message Date
Vadim Tryshev 82a67a1a2d Re-promoting some tests to postsubmit
Will watch their stability; may further promote to presubmit

Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: Idf3949b1f04b0ff761ef1216fa41e9e8d11e8cdd
2023-12-19 12:51:14 -08:00
Pat Manning 3e55896814 Merge "Do not process stashed taskbar hover actions when taskbar is not present." into main 2023-12-19 20:14:07 +00:00
Liran Binyamin beb70140f4 Handle recreate_taskbar in QuickstepTestInformationHandler
Currently only tests that use DebugQuickstepTestInformationHandle
are able to recreate the taskbar.

This change allows recreating the taskbar in system UI TAPL tests.

Bug: 273994695
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.BubbleBarTest
Flag: NA
Change-Id: Id97d26c0aa77db23cd9031f47cf8dd3f79e6a158
2023-12-19 15:05:11 -05:00
fbaron 7bc30906c4 Update folder preview dark theme color
Fix: 314843350
Test: Verify on device
Flag: NONE
Change-Id: I2a4cb62dacb05193412b99aca0d3bfabfb77f959
2023-12-19 19:21:59 +00:00
Brandon Dayauon 8fe6bd2572 Revert "Revert "Fix the badge in badge (triple badging), by simp..."
Revert submission 25263180-revert-24721954-cherrypick-removeBadgeInBadge-dia2ji7r7td-RZRSBRGYSA

Reason for revert: Fix the test that uses the work USERHANDLE that may cause this security exception https://paste.googleplex.com/5530091189698560

Reverted changes: /q/submissionid:25263180-revert-24721954-cherrypick-removeBadgeInBadge-dia2ji7r7td-RZRSBRGYSA

Change-Id: I82dbf155b7bc41a496d50884193f5f168cb46f31
2023-12-19 09:34:53 -08:00
Jagrut Desai 2d3e5d4e8f Merge "Correcting Logic of touch ouside of container." into main 2023-12-19 17:31:01 +00:00
Helen Cheuk c225b99be2 Merge "Add radius to widget internal focus to fit new focus outline design" into main 2023-12-19 16:59:50 +00:00
Tony Wickham 054d953a0d Merge "Log app launches via taskbar drag and drop" into main 2023-12-19 16:17:21 +00:00
Schneider Victor-tulias 4044669a90 Focus the first task in KQS when it is not currently running
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 316004088
Test: TaplTestsKeyboardQuickSwitch
Change-Id: I8a91ca0dd32c6fc2352d285934a2c4f79ba1bb13
2023-12-19 10:48:40 -05:00
Uwais Ashraf e0a4feb664 Rename Tapl tests that do not match *Test.(kt|java) for easier groups
Test: presubmits passing
Bug: 316551909
Flag: NA
Change-Id: Ib2070d7610927777376acf0ddefcbc90e582e6f6
2023-12-19 11:54:10 +00:00
Himanshu Gupta ce2b013d31 Merge "Adding methods to access LauncherApps APIs." into main 2023-12-19 11:27:09 +00:00
helencheuk 1b3b67d004 Add radius to widget internal focus to fit new focus outline design
Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I9b11e8bf21dbb5045586907f0fc13577e236c8e7
2023-12-19 11:27:04 +00:00
Rajeev Kumar b3c7d2efc5 Use the system component for the nearby sharing action if available.
Bug: 308014458
Fixes: 308014458
Flag: NA
Test: atest com.android.launcher3.AppSharingTest
Change-Id: I41ff4efd7153e4ec7591b7d34695766e5bc9f436
2023-12-19 03:23:33 -08:00
Sergey Pinkevich 102e54ba05 Merge "Split tasks in RTL mode" into main 2023-12-19 10:19:02 +00:00
Jeremy Sim fb7f7c5a6f Merge "Use fade-in launcher for app pair launches from in-app taskbar" into main 2023-12-19 06:20:55 +00:00
Jeremy Sim c2b598434c Use fade-in launcher for app pair launches from in-app taskbar
This CL temporarily patches a crash in this situation:

Inside of an app > Launch an unrelated app pair from Taskbar > Crash

The crash occurs because TaskbarActivityContext can't create a launcher animation (because Launcher isn't running). A different launch animation is needed for this case (similar to single apps), but for now, falling back to the fade-in launch at least allows the user to proceed without a crash.

Bug: 316485863
Test: Enter an app, launch an unrelated app pair, no crash
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I72b2956b5b44616367e24263f2287824ee1e8212
2023-12-19 11:27:04 +09:00
Jeremy Sim 34aa1c5366 Merge "Fixes two bugs with findLastActiveTasksAndRunCallback()" into main 2023-12-19 02:08:54 +00:00
Android Build Coastguard Worker f07a2cfc5b Snap for 11232546 from 014e9cb615 to 24Q2-release
Change-Id: I094f815b9ec53ecc545993004f315942782a267b
2023-12-19 00:22:02 +00:00
Jagrut Desai 6d34ffdeaa Correcting Logic of touch ouside of container.
Test: presubmit, manual
Bug: 311761184
Flag: NONE
Change-Id: Id014a16d67d06ebeed5e54358472890bb582ae89
2023-12-18 15:32:52 -08:00
Tony Wickham 1a8cf0a9f6 Log app launches via taskbar drag and drop
- This also goes through the app predictions pipeline to update
  hotseat predictions

Fixes: 316940471
Test: Drag apps to split screen, ensure taskbar predictions update
      (also verify by logging AppPredictor#notifyAppTargetEvent)
Flag: None
Change-Id: I844414ecb56b4e36a2c94d913c1fb37abf056593
2023-12-18 23:30:59 +00:00
Jagrut Desai 10473c5950 Merge "Refactoring testDragIcon() test" into main 2023-12-18 22:01:22 +00:00
Brandon Dayauon 6ac1d24876 Fix padding between text and (x) icon in work profile card.
- Simplified the .xml to just use linear layout and remove the extra relativelayout that was used for the button when it can just be a
Framelayout.

- Now according to spec https://www.figma.com/file/mf67dbMngw0a3aev2HTinD/Work-Profile-%26-Bluechip?type=design&node-id=2185-0&mode=design&t=n0pl6vP5rnSrTyyv-0
the additional padding is now included.

bug: 309120438
Test: Manual photos-
before: https://screenshot.googleplex.com/48kUpYCVQGYMwdm
after: https://screenshot.googleplex.com/AcisTmXQeZ3NT3C
Flag: None
Change-Id: I3c1850a20f49a2a4e809410b4aaef688ea9b3e2c
2023-12-18 13:37:16 -08:00
Vadim Tryshev 014e9cb615 Merge "Adding a rule so that @Stability annotation works presubmit" into main 2023-12-18 19:56:00 +00:00
Himanshu Gupta 6c25654e84 Adding methods to access LauncherApps APIs.
These methods are added to ApiWrapper class
so that Launcher can acess these APIs.

Bug: 308054233
Test: Presubmit
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Change-Id: Ic2e64b38cc8b0d262d3f6e9614e2b3fceb9d82a0
2023-12-18 19:47:13 +00:00
Charlie Anderson 511421c12f Adds logging for Launcher restore metrics in Launcher and LoaderTask
- Adds flag for indicating when we are loading after a restore, separate from the pending restore flag
- Adds many success/failure scenario metrics when loading and binding items

Flag: ACONFIG enable_launcher_br_metrics DEVELOPMENT
Test: locally verified
Bug: 307527314
Change-Id: I9d2660f6d9d7cd5813072201e96b1a64aec4ea4b
2023-12-18 19:32:02 +00:00
Himanshu Gupta 314afce4f9 Fixing UserHandle for AppTarget Event from Launcher.
Currently, every non-foreground user AppTarget Event
is assigned the first userhandle present in the list
of UserProfiles cached with Launcher.
This causes issues when more than one profile is
present, as then appevents from either profiles are
indistinguishable.
This chane fixes that, based upon the recent fixes to
make Launcher and ItemInfo user profile aware.

Bug: 314124511
Test: Manual by clicking diff app targets
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TEAMFOOD
Change-Id: I188c828eeeff9b617ddf9a75bccea9b9ab38e506
2023-12-18 19:10:23 +00:00
Sergey Pinkevich e0ccb4e618 Split tasks in RTL mode
For `translationX` in RTL (right to left layout) mode we should take into account `secondarySnapshotWidth`, not the primary one.

The same for `translationY` for foldable phone in folded mode

Known issue: there is still a wrong position for overview app icon, but it is not related to the task thumbnail, and will be fixed in a dedicated task
(Screenshot of the issue: https://screenshot.googleplex.com/9GHNWxQ5H6vJPn5)
Known issue task: b/315787393

Bug: 309452423
Flag: NONE
Test: manual

Tablet: https://drive.google.com/file/d/1WGUVcFq0sFTJYsAwcjE6E1SHMRe7_TaV/view?usp=sharing
Foldable phone: https://drive.google.com/file/d/1GvDgYg8R9OEoMSDKZaZVXSlsxh_qS-wW/view?usp=sharing

Change-Id: Iefe7fec586592e6a72c0f3be5933307213d92c7f
2023-12-18 18:41:27 +00:00
Vadim Tryshev 4f6602839e Adding a rule so that @Stability annotation works presubmit
Bug: 316588649
Test: presubmit
Flag: N/A
Change-Id: Ic82db1c30c97f2653f8c30fc322a248b2b409695
2023-12-18 10:17:14 -08:00
Vadim Tryshev 83d42f71ca Merge "Waiting for Launcher stop from quick switch gesture" into main 2023-12-18 18:04:49 +00:00
Vadim Tryshev b083ace4ad Merge "Waiting for Fallback Overview to stop after pressing Home" into main 2023-12-18 18:04:33 +00:00
Federico Baron a06a171874 Merge "Remove unused flag UNFOLDED_WIDGET_PICKER" into main 2023-12-18 17:57:21 +00:00
Treehugger Robot afdac4066d Merge "Removing myself from owners" into main 2023-12-18 17:38:23 +00:00
Greg Kaiser 486c96be87 Merge "Revert "App Pairs: Implement Overview Actions View button"" into main 2023-12-18 15:15:59 +00:00
Greg Kaiser 45ba84268c Revert "App Pairs: Implement Overview Actions View button"
Revert submission 25143701-app-pairs-action-button

Reason for revert: Causes P0 b/315292030

Reverted changes: /q/submissionid:25143701-app-pairs-action-button

Change-Id: I1fcbb9f333ca29c5db255232dc9475dec465ac81
2023-12-18 14:53:19 +00:00
Liran Binyamin ca516b0249 Merge "Make BubbleBarView initially hidden" into main 2023-12-18 14:23:57 +00:00
Thales Lima c66ebc2c5c Removing myself from owners
Change-Id: I2cbf1c5b428d7f22263dc68da7648fdf8cdad616
2023-12-18 14:15:34 +00:00
Jeremy Sim 789414190f Merge "App Pairs: Implement Overview Actions View button" into main 2023-12-18 05:07:36 +00:00
Vadim Tryshev e281a5fb7e Merge "Disabling a failing test from presubmit" into main 2023-12-18 03:02:43 +00:00
Jeremy Sim 42a44d7984 Fixes two bugs with findLastActiveTasksAndRunCallback()
This CL changes findLastActiveTasksAndRunCallback to return a fixed array rather than an ArrayList.

1) This fixes a (minor) crash with app pairs, where we performed get(0) on an empty array when no running tasks were found.
2) This also fixes a live bug where app pairs would launch apps in the wrong order if app 1 was not found in running tasks, but app 2 was.

The function should be more robust now, preserving the indexing of the input keys.

Fixes: 316053131
Test: Clear all tasks from Overview, launch an app pair, launch succeeds
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I51d8ba823a2ec57e9ecfeede956e0afce1d653f4
2023-12-18 11:39:33 +09:00
Jeremy Sim e1fcb5390b App Pairs: Implement Overview Actions View button
[App Pairs 6/?]

This patch includes:
- Ability to "save app pair" from Overview Actions
- The actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.

Note: This patch introduces a slight regression (b/315545418) where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Bug: 315545418
Bug: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I0eb1fa9520ba14074ede3480e771b340cf2f6e2c
2023-12-18 02:25:22 +00:00
Vadim Tryshev de1e88da74 Waiting for Fallback Overview to stop after pressing Home
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I1128ca6eabe29e02d8039445696f7a006f6448bf
2023-12-17 15:45:51 -08:00
Android Build Coastguard Worker 571d950ee1 Snap for 11228795 from c43435c063 to 24Q2-release
Change-Id: I9982a1c9540f60287f8d1e1b66942a542c3ca261
2023-12-16 22:20:08 +00:00
Android Build Coastguard Worker a2fc087fec Snap for 11227258 from ff2eec89ea to 24Q2-release
Change-Id: I21375c1b643bd33afcbfb6db12bc5d6cc12d1305
2023-12-16 02:18:57 +00:00
William Leshner c43435c063 Merge "Handle widget taps in WidgetPickerActivity." into main 2023-12-15 23:20:23 +00:00
fbaron e03af75df4 Remove unused flag UNFOLDED_WIDGET_PICKER
this flag was made long before we actually implemented unfolded two pane picker and by that point we migrated to using aconfig so this flag is not used.

Bug: 301918659
Flag: NONE
Test: NONE
Change-Id: Ibc541826d85ae251337567ae0275e1cd02c7bb43
2023-12-15 14:46:39 -08:00
Vadim Tryshev 149dc53f85 Waiting for Launcher stop from quick switch gesture
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I31ae3af36b71c73ed4750b92ccc3704df9714ea6
2023-12-15 13:57:38 -08:00
Federico Baron ff2eec89ea Merge "Stop interrupt to see if it fixes failing tests" into main 2023-12-15 21:26:54 +00:00
Liran Binyamin 447ddf0b63 Make BubbleBarView initially hidden
The BubbleBarView visibility is updated as part of the initial state change.
This CL fixes the issue where switching from floating bubbles to bubble bar
ends up in a state where both the handle and the bar are visible.

Note: once the initial TAPL tests land I will add a test for mode switching

Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Fixes: 316356971
Test: Manual
      - Add bubble in floating mode
      - Switch to bubble bar
      - Observe that the bubble bar is not visible (only the handle is)
Change-Id: Ib8fc76f90dbf1fee83e594b7f28eed00f1589ae1
2023-12-15 15:49:37 -05:00
fbaron e392955e37 Stop interrupt to see if it fixes failing tests
Bug: 316394228
Test: atest WidgetsListContentEntryTest
Flag: NONE
Change-Id: Iaabbcb0c00040f78ad4d6355fef9bc91f4b66ed7
2023-12-15 11:30:58 -08:00
Bill Yi 50c0b9a20c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e70a1cae2e -s ours am: 18372d32bd -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25648470

Change-Id: I531b1e0aa89d6064ad144b19578ea6a5962c3387
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-15 19:23:48 +00:00