Commit Graph

34630 Commits

Author SHA1 Message Date
Vadim Tryshev f078975e9d Merge "Logging the initial state for swiping up to home" into ub-launcher3-qt-qpr1-dev
am: c49ec38140

Change-Id: If74c630902a212270bae1a58b2085d8a30d2343f
2019-10-03 14:33:31 -07:00
Vadim Tryshev 12de08a3b1 Merge "Waiting until context menu goes away after attempting to close it." into ub-launcher3-qt-qpr1-dev
am: 7c09214298

Change-Id: If209a43004a41ca682473232789810a4d1828521
2019-10-03 14:33:04 -07:00
vadimt 1ac98548a7 resolve merge conflicts of 08776ada1e to ub-launcher3-qt-future-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I9a3b0f67ee874b5ec4ad67f41a46ec7876d19082
Merged-in: I9a3b0f67ee874b5ec4ad67f41a46ec7876d19082
2019-10-03 20:58:15 +00:00
vadimt a9d870828c resolve merge conflicts of 08776ada1e to ub-launcher3-qt-future-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I9a3b0f67ee874b5ec4ad67f41a46ec7876d19082
2019-10-03 20:52:44 +00:00
Pinyao Ting f2a3e79e76 Merge "correct naming and add comments for test case of custom shortcut." into ub-launcher3-qt-future-dev
am: 055c22e8e6

Change-Id: I64b7723a8ad9bbf9836b9b3c4d45add80b54107a
2019-10-03 11:04:37 -07:00
Pinyao Ting e72ba6b616 Merge "Fix the issue talkback feedback doesn't say anything when user long press on an app icon." into ub-launcher3-qt-future-dev
am: a61914194e

Change-Id: Ife1d71cdaf821705288a775c3ff6e3f8bbd8f454
2019-10-03 10:57:36 -07:00
TreeHugger Robot 055c22e8e6 Merge "correct naming and add comments for test case of custom shortcut." into ub-launcher3-qt-future-dev 2019-10-03 17:56:50 +00:00
Tony Wickham 2784315f7d Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
(cherry picked from commit c9654eb091)
2019-10-03 17:48:14 +00:00
TreeHugger Robot a61914194e Merge "Fix the issue talkback feedback doesn't say anything when user long press on an app icon." into ub-launcher3-qt-future-dev 2019-10-03 17:42:34 +00:00
Pinyao Ting d7fdcab612 correct naming and add comments for test case of custom shortcut.
Bug: 141934188
Change-Id: I69ce5f05214df10e2a376ff68c713efe8874df15
2019-10-03 10:15:30 -07:00
Pinyao Ting d9bef1f3f0 include integration test for adding shortcut widget
am: d625e49552

Change-Id: Id0b8963f2c34355de97ddb4cbb1daf10d2f78e0c
2019-10-03 09:48:00 -07:00
Pinyao Ting 52d0252150 Fix the issue talkback feedback doesn't say anything when user long
press on an app icon.

When user long press on an app icon, the a11y focus event wasn't
properly triggered on the container of deep shortcut, which is why
there wasn't any talkback feedback after long press on an app icon.

Bug: 140786694
Change-Id: Ib38db147faa5a163985f1ed74beec04c588b022c
2019-10-03 07:47:33 -07:00
Pinyao Ting d625e49552 include integration test for adding shortcut widget
this integration test help us catching app crashes when adding shortcut
widgets to the workplace. see b/141568904 for more context.

Bug: 141934188
Change-Id: I4d33d6127793efe2071d0d146aef24db6b676360
2019-10-03 07:46:50 -07:00
vadimt 233afe98e9 Dump view hierarchy before swiping to home
Bug: 141864547
Change-Id: Ifd444c4516f7f27b0dc19c0faa1d4c8716d2254a
2019-10-02 17:10:02 -07:00
Tracy Zhou c8611b3afe Merge "Live tile should switch to screenshot before finishing recents animation" into ub-launcher3-master 2019-10-03 00:08:09 +00:00
Tracy Zhou 387279d938 Live tile should switch to screenshot before finishing recents animation
Fixes: 139439373
Test: Launch a new app from shortcuts in Overview mode. Make sure the
live tile stays put (no hole). Same with touching empty space in
Overview to go home.

Change-Id: I6cacf2842e21f9856d0021cea9fddf4f870f09f0
2019-10-02 16:53:02 -07:00
Becky Qiu d53cb6333f Merge "Fill in LauncherTarget fields with values extracted from LauncherLogProto.Target." into ub-launcher3-qt-future-dev
am: 4a4755fc70

Change-Id: I6435b1e475b7a39e68a78dc893c2a6cc4f2b8d72
2019-10-02 16:36:52 -07:00
Sunny Goyal e7b00128c7 Removing static instance of LauncherAppsCompat and unnecessary wrapper classes
Bug: 141376165
Change-Id: I8c1f1ab7d83ec50fe9c7bf39960ef9c360025ec7
2019-10-02 16:20:22 -07:00
TreeHugger Robot 4a4755fc70 Merge "Fill in LauncherTarget fields with values extracted from LauncherLogProto.Target." into ub-launcher3-qt-future-dev 2019-10-02 23:09:52 +00:00
Sunny Goyal b0adac23e0 Removing access to LauncherModel.getCallbacks
Bug: 137568159
Change-Id: Ic074dec6a8981a4b9aabf028cf3b878b532abb11
2019-10-02 14:27:40 -07:00
Samuel Fufa a0db584e08 Add nullcheck for VelocityTracker
am: 0063204dbf

Change-Id: I46066ce3cb2810a743043a5a85012b70cf45de59
2019-10-02 13:28:57 -07:00
Tony Wickham 2cb71ee386 Update all apps fade interpolators for home <-> all app
am: c449a6417d

Change-Id: I34b27a6ec2c62fe657804e7e9f027e21a26568c9
2019-10-02 13:28:08 -07:00
Sunny Goyal 01615a69d2 Removing host deletion on startup and corresponding callbacks
> Launcher deletes the phantom widget ids in loader

Bug:141376165
Change-Id: Icf0542535f194f9abc67e7190f34cb60f69e9f66
2019-10-02 12:08:26 -07:00
Sunny Goyal 1456522cab Merge "Removing static listeners from PackageInstallerCompat" into ub-launcher3-master 2019-10-02 18:27:45 +00:00
Samuel Fufa 0063204dbf Add nullcheck for VelocityTracker
Bug:134712476
Change-Id:I7834507a4e9aadf4d89c0ed6f3eba812df7425cd
(cherry picked from commit 6ef5b8abf4)
2019-10-02 18:23:03 +00:00
Vadim Tryshev c49ec38140 Merge "Logging the initial state for swiping up to home" into ub-launcher3-qt-qpr1-dev 2019-10-02 17:43:00 +00:00
Tony Wickham c449a6417d Update all apps fade interpolators for home <-> all app
Previously, predictions faded in quickly but then all apps faded in
linerally over entire rest of the transition. Now, all apps fades in
quickly after reaching the overview threshold where predictions are
opaque.

Also implemented the reverse, so that predictions/all apps content
remain opaque when returning home until reaching the overview threshold
near the bottom, where they fade out as quickly as they faded in.

We do this for 3-button mode as well.

Bug: 141986013
Change-Id: Ia35ab3ac9714e89f754293445a7839e15da5313d
2019-10-02 09:51:51 -07:00
Vadim Tryshev 7c09214298 Merge "Waiting until context menu goes away after attempting to close it." into ub-launcher3-qt-qpr1-dev 2019-10-02 02:00:28 +00:00
vadimt 7458d4aa4a Logging the initial state for swiping up to home
Change-Id: Iff2003f7e6dfe4072613b775722166dc5fec9e02
2019-10-01 18:40:24 -07:00
vadimt 8ecf1b3dd3 Waiting until context menu goes away after attempting to close it.
Bug: 141770616
Change-Id: I528072e830627d825906ce7c1e3dbb914e2c814e
2019-10-01 18:28:46 -07:00
Andy Wickham b9efb9ad71 Merge "Some cleanup for SwipeDetector." into ub-launcher3-qt-future-dev
am: d39f7b51c8

Change-Id: Ifadf65abe4239a703c3d15eddc6ebd51a405a5e9
2019-10-01 14:57:43 -07:00
TreeHugger Robot d39f7b51c8 Merge "Some cleanup for SwipeDetector." into ub-launcher3-qt-future-dev 2019-10-01 21:47:46 +00:00
Andy Wickham 769c795edf Some cleanup for SwipeDetector.
It is now organized as follows:
 - private constants
 - public constants
 - private final fields
 - private variable fields
 - constructors
 - public methods
 - private methods
 - public interface/abstract class

This is intended to be a functional no-op.

Bug: 141939911
Change-Id: Iad5a9b3b73b35641f8a4f1d52ada6adef3825c47
Tested: Built and sanity checked manually.
2019-10-01 14:38:56 -07:00
TreeHugger Robot ef2ef310c3 Merge "Unifying activity tracker callback" into ub-launcher3-master 2019-10-01 21:01:54 +00:00
Sunny Goyal e84c5b82be Unifying activity tracker callback
> Using a common class for both Launcher and RecentsActivity
> Removing static refenrece to LauncherModel and using a common pattern for
  tracking activities

Bug: 141376165
Bug: 137568159
Change-Id: Ic1897abe6913ec78e25725118eedf5b468d5ec70
2019-10-01 13:54:26 -07:00
Tony Wickham 32fbb634e5 Merge "Don't allow scrolling RecentsView outside navbar during quickswitch" into ub-launcher3-qt-future-dev
am: e8d064a3c1

Change-Id: I0110540875ceece81fb00d39a152377efb822b72
2019-10-01 13:25:04 -07:00
Samuel Fufa 7eb59b9f47 App title in Widget list shouldn't be actionable by a11y methods
am: 1f3a847011

Change-Id: Ib4e0b8b0c614e2b286acd3a5abdf8f7677bf81e7
2019-10-01 13:24:47 -07:00
TreeHugger Robot 08776ada1e Merge "Waiting for Launcher model load in out-of-proc tests." into ub-launcher3-qt-qpr1-dev 2019-10-01 19:48:05 +00:00
vadimt 7371e4da68 Waiting for Launcher model load in out-of-proc tests.
Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
Merged-in: Ia9caf20e4a2d93298adf4249ca815ad79bced802
2019-10-01 19:18:14 +00:00
Vadim Tryshev f7a2971530 Merge "Waiting for Launcher model load in out-of-proc tests." into ub-launcher3-master 2019-10-01 18:43:24 +00:00
Tony Wickham e8d064a3c1 Merge "Don't allow scrolling RecentsView outside navbar during quickswitch" into ub-launcher3-qt-future-dev 2019-10-01 17:52:54 +00:00
vadimt 542b7df7fd Waiting for Launcher model load in out-of-proc tests.
Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
2019-10-01 17:46:35 +00:00
Samuel Fufa 1f3a847011 App title in Widget list shouldn't be actionable by a11y methods
Bug:139913027
Test:Manual
Change-Id: I2a5d5551d09ee2bc96444164ed77225a3b4a829a
(cherry picked from commit d3720c210b)
2019-10-01 17:33:18 +00:00
Tony Wickham c9654eb091 Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
2019-10-01 10:16:26 -07:00
Pinyao Ting 44151960bf Revert "Revert "Revert "cache shourtcut image"""
am: 52908c9adc

Change-Id: I597a9e3a314887b668f482e74a4d2f548cca1da9
2019-10-01 10:09:11 -07:00
Pinyao Ting 52908c9adc Revert "Revert "Revert "cache shourtcut image"""
This reverts commit d13f0c5c45.

Reason for revert: app crashes when adding widgets automatically b/141568904

Change-Id: I5b97f440716c93b1bd93c899e3e1d40e8bbd2885
2019-10-01 09:44:11 -07:00
Vinit Nayak a62de7aa88 Merge "Set exclusion rect for launcher before it gains focus" into ub-launcher3-master 2019-10-01 15:54:05 +00:00
Sunny Goyal 045b4fab76 Removing static listeners from PackageInstallerCompat
Bug: 141376165
Change-Id: I2b49d53a05a04c622ed5a7b723109a6cc230d230
2019-09-30 23:17:15 -07:00
Vinit Nayak 9a8462117d Set exclusion rect for launcher before it gains focus
Back gesture still shows if user attempts to swipe
back while we're animating to launcher state normal.
Focus is only granted after the animation has
completed, but the user can interact w/ the back
edge panels while it's ongoing.

fixes: 138622418
Test: Open app, swipe home and quickly swipe from
the edge of the screen. Should go to -1 screen and
not see back arrow.

Change-Id: I32228370c7ec1bdb75474fdff2d1c99cb677fa6a
2019-09-30 16:04:57 -07:00
Vadim Tryshev 67138875fa Merge "Not unlocking phone on the test start" into ub-launcher3-qt-qpr1-dev am: 872a380b59
am: 4c420047cf

Change-Id: I23f87d541771baa7ba3e5857999a5e5c96c301ce
2019-09-30 14:01:37 -07:00