Commit Graph

34630 Commits

Author SHA1 Message Date
Tony Wickham eec392b67a [automerger skipped] Merge "Fix quickswitch flickers/ignored swipes" into qt-qpr1-dev am: a9012ea717
am: 15280b902c -s ours
am skip reason: change_id I5b392d9726a81c51718d2f94eee6cd4f78b61f69 with SHA1 8e8a376a62 is in history

Change-Id: I3b50408c4c8a8aa6ec0112194ffbc44bf9223cd6
2019-10-09 13:42:26 -07:00
Tony Wickham b0ee81da4a Don't allow scrolling RecentsView outside navbar during quickswitch am: 80090d579f
am: afbb4a8a09

Change-Id: Idd9963af8223d7f88f406328956f6540d29efafe
2019-10-09 13:39:34 -07:00
Tony Wickham 15280b902c Merge "Fix quickswitch flickers/ignored swipes" into qt-qpr1-dev
am: a9012ea717

Change-Id: I06b5e3b8baa2a4d1041dfe9a99ad530c02d2229d
2019-10-09 13:37:16 -07:00
Tony Wickham afbb4a8a09 Don't allow scrolling RecentsView outside navbar during quickswitch
am: 80090d579f

Change-Id: Ib26bde87b9070a1a07e5bc12c11896e9d1bf4337
2019-10-09 13:36:40 -07:00
TreeHugger Robot a9012ea717 Merge "Fix quickswitch flickers/ignored swipes" into qt-qpr1-dev 2019-10-09 20:20:25 +00:00
Tony Wickham 4d86c804ba Fix quickswitch flickers/ignored swipes
- Don't set current page to running task when applying load plan,
  if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
  the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
  already on it. This was setting mNextPage so the first check
  was falsing.

Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
Merged-In: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
(cherry picked from commit af33f2c9d4)
2019-10-09 15:28:23 +00:00
Tony Wickham 80090d579f Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
(cherry picked from commit c9654eb091)
(cherry picked from commit 2784315f7d)
2019-10-09 05:38:20 +00:00
TreeHugger Robot 012fbc78b4 Merge "Using SpringAnimationBuilder instead of SpringObjectAnimator in StaggeredWorkspaceAnim" into ub-launcher3-master 2019-10-08 22:53:50 +00:00
Winson Chung d7269bf8b6 8/ Rename ActivityControlHelper
- ActivityControlHelper -> BaseActivityInterface
  LauncherActivityControlHelper -> LauncherActivityInterface
  FallbackActivityControlHelper -> FallbackActivityInterface
  QuickCaptureTouchConsumer -> QuickCaptureInputConsumer
- Move gestures to use the activity interface from the gesture state

Bug: 141886704
Change-Id: I6f12daeb03d564143404767dfe4576e3e5da2a1d
2019-10-08 13:39:13 -07:00
Winson Chung d3da92ac66 7/ Rename RecentsAnimationWrapper
- Move the recents animation classes out of util into base quickstep pkg
- Clean up some local var names

Bug: 141886704
Change-Id: I1556179e203cbb43b77ea58e6fe520aa9944099b
2019-10-08 13:30:27 -07:00
Sunny Goyal d7b9db7bda Using SpringAnimationBuilder instead of SpringObjectAnimator in StaggeredWorkspaceAnim
Change-Id: I3a7b38e3f866c95a92fbb314f0a79b0735f38c9d
2019-10-08 13:21:03 -07:00
Winson Chung 9e876a34ee 6/ Update recents animation classes to have their respective responsibilities
- RecentsAnimationTargets: manages information about the targets only
  RecentsAnimationCallbacks: manages callbacks from WM about the animation
  RecentsAnimationWrapper: manages calls into WM to update the animation
                           (to be renamed accordingly in a follow up CL)
- Create the Callbacks as a part of starting the recents animation, and
  have the callbacks create the controller wrapper and the targets, which
  are both notified to the listeners through the callbacks.
- Instead of passing through a callback for recents animation finished,
  have it be a part of the recents animation callbacks.

Bug: 141886704

Change-Id: I4ff26a175654e82efe059fa74d1f310e93961dc9
2019-10-08 13:15:15 -07:00
Winson Chung bfcee430fe 5/ Remove OverviewInteractionState
- We can move the background call to UiThreadHelper, the last sysui flags
  and back button alpha to SystemUiProxy (and dedupe values there as well)

Bug: 141886704

Change-Id: I22183608700c6d71355597c7a08eefa19f4381fd
2019-10-08 13:15:15 -07:00
Winson Chung 8ff53f7e65 4/ Move SystemUiProxy to its own singleton instead of routing through the model
Bug: 141886704
Change-Id: I415b9ef7b57b525407e3a341b946e3ca66125102
2019-10-08 13:15:13 -07:00
Winson Chung 629c87283f 3/ Move touch interaction log to its own class
Bug: 141886704
Change-Id: I5f27faf83ccacc2d2eb2914f15e860d07628c37c
2019-10-08 12:16:48 -07:00
James O'Leary 8d46a3dc00 Merge "Add feature flag + leftward swipe for Compose access." into ub-launcher3-master 2019-10-08 19:03:04 +00:00
TreeHugger Robot f31dab5e02 Merge "Removing static instance of LauncherAppsCompat and unnecessary wrapper classes" into ub-launcher3-master 2019-10-08 18:49:36 +00:00
Jeff Pierce e4607587ed Add feature flag + leftward swipe for Compose access.
Stole ag/9453040 from jspierce@ and added a feature flag.

ag/9453040: Exploratory prototype to test leftward swipe access to
Compose across home screen, launcher, and lock screen. Requires Compose
APK (installed separately).

Change-Id: I15a045976b1eb41392795d3a4f0743f365dec1d2
2019-10-08 14:00:53 -04:00
vadimt 4b5c1ef71b Adding support for intentionally leaking views.
Bug: 139137636
Change-Id: I923d1781daee9ae47eb306ee8fa3c44790c6993f
2019-10-08 17:04:26 +00:00
Tony Wickham 8e8a376a62 Fix quickswitch flickers/ignored swipes
- Don't set current page to running task when applying load plan,
  if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
  the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
  already on it. This was setting mNextPage so the first check
  was falsing.

Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
(cherry picked from commit af33f2c9d4)
2019-10-08 16:55:31 +00:00
TreeHugger Robot 6369136f33 Merge changes I2ade7f48,I78485a16 into ub-launcher3-master
* changes:
  2/ Move device state logic to its own class
  1/ Renaming some classes for clarity
2019-10-08 16:42:13 +00:00
TreeHugger Robot 86017c9611 Merge "Removing access to LauncherModel.getCallbacks" into ub-launcher3-master 2019-10-08 16:26:12 +00:00
TreeHugger Robot 8ae1151387 Merge "Reduce risk of flakes in memory leak detection tests." into ub-launcher3-master 2019-10-08 16:24:34 +00:00
Winson Chung 75eb0e0f20 2/ Move device state logic to its own class
- Feed the class down to the input consumers and related gesture classes
  instead of specific sysui state flags

Bug: 141886704

Change-Id: I2ade7f48555c9d0ba0d3fac5c1f2dae694624224
2019-10-07 20:49:08 -07:00
Winson Chung 92a015f2fc 1/ Renaming some classes for clarity
- SwipeAnimationTargetSet -> RecentsAnimationTargets
- RemoteAnimationTargetSet -> RemoteAnimationTargets
- RecentsAnimationListenerSet -> RecentsAnimationCallbacks
- SwipeAnimationTargetSet.SwipeAnimationListener -> RecentsAnimationCallbacks.RecentsAnimationListener
- ClipAnimationHelper -> AppWindowAnimationHelper
- AssistantTouchConsumer -> AssistantInputConsumer

Bug: 141886704

Change-Id: I78485a1651bb360ffbac2d0c462855931a995ee1
2019-10-07 20:49:08 -07:00
Samuel Fufa 023188e424 Merge "Scale Icon badges for shortcut and widgets" into ub-launcher3-qt-future-dev
am: f2d486e5b0

Change-Id: I5c2c115b1ee42489d969ff30c48abf00d4a5a3f7
2019-10-07 18:56:02 -07:00
Samuel Fufa f2d486e5b0 Merge "Scale Icon badges for shortcut and widgets" into ub-launcher3-qt-future-dev 2019-10-08 01:41:53 +00:00
vadimt 1b92f6d964 Reduce risk of flakes in memory leak detection tests.
Now performing jreck@-style garbage collection prior to getting Launcher
PSS. The reduces PSS noise from ~700KB to ~250KB (std dev).

The tests (MemoryTests) run outside of Launcher process and
communicate with Launcher via RPC.

The change is in the RPC handler that lives in Launcher and returns
Launcher PSS to the test.

Bug: 139137636
Change-Id: I457e590b005dac53345f4223d972c7961754938c
2019-10-08 01:05:41 +00:00
Tony Wickham 1ab5de3fc8 Merge "Fix quickswitch flickers/ignored swipes" into ub-launcher3-qt-future-dev
am: 9788183962

Change-Id: I153fe569fd3f2c8ad065282eed56f9f13c5ab0d4
2019-10-07 14:27:22 -07:00
Tony Wickham 9788183962 Merge "Fix quickswitch flickers/ignored swipes" into ub-launcher3-qt-future-dev 2019-10-07 21:08:34 +00:00
Tony Wickham af33f2c9d4 Fix quickswitch flickers/ignored swipes
- Don't set current page to running task when applying load plan,
  if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
  the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
  already on it. This was setting mNextPage so the first check
  was falsing.

Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
2019-10-07 21:08:04 +00:00
TreeHugger Robot fedd5f1fd7 Merge "Removing host deletion on startup and corresponding callbacks" into ub-launcher3-master 2019-10-07 18:28:44 +00:00
android-build-team Robot 28d752990d Snap for 5922838 from 2784315f7d to rvc-release
Change-Id: Ia7155fc106e393293ebd1a61039240b165cda41b
2019-10-05 23:13:47 +00:00
vadimt 7f791a868d Increasing wait time for navigation mode switch. am: d230af4e09
am: 4f56803bd0

Change-Id: I0dfc2072d6ea810cb023b61ac5a4e8f29786d261
2019-10-04 18:10:56 -07:00
vadimt 4f56803bd0 Increasing wait time for navigation mode switch.
am: d230af4e09

Change-Id: Ia5150735244249dd76c1993ff588036e4f18402b
2019-10-04 18:03:17 -07:00
vadimt d230af4e09 Increasing wait time for navigation mode switch.
Sometimes this fails in Cuttlefish.

Change-Id: Ifa2ffed5165625d51441fc3b203185fc55f7d53f
2019-10-04 17:12:26 -07:00
Samuel Fufa aa038af6b3 Scale Icon badges for shortcut and widgets
Test: Manual
Bug: 141262820
Change-Id: I03edc986e3fe1876b6b7ed179b96864d587cb137
2019-10-04 17:06:33 -07:00
Samuel Fufa 5e6741828f Merge "Decouple grid size and widget preview size in WidgetsRecyclerView" into ub-launcher3-qt-future-dev
am: e5865a03bb

Change-Id: I72ff45bd7080a7bb6ca4ab681423d6bd1da8a291
2019-10-04 16:45:48 -07:00
TreeHugger Robot e5865a03bb Merge "Decouple grid size and widget preview size in WidgetsRecyclerView" into ub-launcher3-qt-future-dev 2019-10-04 23:36:22 +00:00
Samuel Fufa f1424a3b38 Decouple grid size and widget preview size in WidgetsRecyclerView
Test: Manual
Bug:142148773
Change-Id: I59aa29e95ddb7d6002a88cf853bae5fcf9811154
2019-10-04 15:15:58 -07:00
Vadim Tryshev 7949c5a7e4 Merge "Diagnosing anomalies prior to swiping up to Home" into ub-launcher3-qt-qpr1-dev am: c3a4819b8c
am: af754b9a9a

Change-Id: I9a65f1c85623f801adbd380c85a039b5c55526bf
2019-10-03 18:18:33 -07:00
Vadim Tryshev af754b9a9a Merge "Diagnosing anomalies prior to swiping up to Home" into ub-launcher3-qt-qpr1-dev
am: c3a4819b8c

Change-Id: Ifc6a781cea4dc38b58435314b8760e89b327446a
2019-10-03 18:11:32 -07:00
Vadim Tryshev c3a4819b8c Merge "Diagnosing anomalies prior to swiping up to Home" into ub-launcher3-qt-qpr1-dev 2019-10-04 00:48:34 +00:00
vadimt f4255c6c1b Dump view hierarchy before swiping to home am: 233afe98e9
am: 3878d3ef09

Change-Id: Ief39f3c713dd94b93b6dfa2f1e0732c810ba5d3a
2019-10-03 17:41:35 -07:00
vadimt 3878d3ef09 Dump view hierarchy before swiping to home
am: 233afe98e9

Change-Id: Ib67aa2247ae43f4e875deb07a9d8b53aa5e6f181
2019-10-03 17:35:28 -07:00
vadimt 43c3d2d40a Diagnosing anomalies prior to swiping up to Home
Bug: 141864547
Change-Id: I5f3814c6a90df85136484813ca4ee684da101016
2019-10-03 17:09:16 -07:00
Tracy Zhou cdb72146e8 Handle app switch in Overview
- Transfer screenshot from WM to launcher when recents animation gets cancelled due to stack order change
- Transform two live windows when app open animation happens from recents

Fixes: 139258979
Fixes: 139259253
Test: switch task in overview

Change-Id: I80bafb8d45b9250fda937223254e365596a7f538
2019-10-03 16:53:43 -07:00
Vadim Tryshev 35d9ac924c Merge "Logging the initial state for swiping up to home" into ub-launcher3-qt-qpr1-dev am: c49ec38140
am: f078975e9d

Change-Id: I7cff417f917643adb1835eb4b7ccad0e75cb22ce
2019-10-03 14:40:14 -07:00
Vadim Tryshev aef50a5985 Merge "Waiting until context menu goes away after attempting to close it." into ub-launcher3-qt-qpr1-dev am: 7c09214298
am: 12de08a3b1

Change-Id: I34cf6e29d2ed39efabca6d43eaccf62763e67693
2019-10-03 14:39:58 -07:00
vadimt 26761e722e [automerger skipped] resolve merge conflicts of 08776ada1e to ub-launcher3-qt-future-dev
am: 1ac98548a7 -s ours
am skip reason: change_id I9a3b0f67ee874b5ec4ad67f41a46ec7876d19082 with SHA1 a9d870828c is in history

Change-Id: I0db7aa760ba1d1f871cd0936a12f40f2e8311eab
2019-10-03 14:39:36 -07:00