Commit Graph

34630 Commits

Author SHA1 Message Date
Andy Wickham fb578e4528 Fades out Assistant when entering Overview.
This makes the transition smoother, since
the Assistant goes away at the end of it.

Note this only applies to the transition
while an app other than Launcher is live.

Before: https://drive.google.com/open?id=18SOWTtTUzt19TReAYnofQLIShJ2I-odP
After: https://drive.google.com/open?id=1hqsikXSlCnSvNg0ZQYHxP-OIbS5yt9aW

Bug: 136282913
Change-Id: Ia53c2407c82725c776f27b0d6e80a34554b4a303
Merged-In: Ia53c2407c82725c776f27b0d6e80a34554b4a303
Tested: Manually
2019-10-14 16:04:33 -07:00
Pinyao Ting b9f25e631b include error log to debug the issue custom shortcut not working
Bug: 141568904
Change-Id: I7e6b9aa4c3e1314aee18cbea81efa881b574923c
2019-10-14 15:55:21 -07:00
TreeHugger Robot 6a3a09940f Merge "Fades out Assistant when entering Overview." into ub-launcher3-master 2019-10-14 22:43:26 +00:00
Andy Wickham 68e01dda46 Fades out Assistant when entering Overview.
This makes the transition smoother, since
the Assistant goes away at the end of it.

Note this only applies to the transition
while an app other than Launcher is live.

Before: https://drive.google.com/open?id=18SOWTtTUzt19TReAYnofQLIShJ2I-odP
After: https://drive.google.com/open?id=1hqsikXSlCnSvNg0ZQYHxP-OIbS5yt9aW

Bug: 136282913
Change-Id: Ia53c2407c82725c776f27b0d6e80a34554b4a303
Tested: Manually
2019-10-14 15:33:59 -07:00
TreeHugger Robot 6c12641bee Merge "Unifying various tracing calls" into ub-launcher3-master 2019-10-14 22:29:59 +00:00
Tracy Zhou 7cb721fa81 Merging ub-launcher3-master, build 5938524
Test: Manual
Bug:123904290 P2 Remove magic constants from TAPL
Bug:130294785 P3 Can no longer long press to open settings in hotseat area
Bug:131115553 P2 Enable CacheDataUpdatedTaskTest tests
Bug:134712476 P4 Add Duo contact to home screen, icon froze and vanished while over home screen
Bug:136278866 P2 Temporary workarounds to make tests pass on Cuttlefish
Bug:136829198 P2 Scrolling Overview During Quickswitch causes switch with weird animation
Bug:137568159 P4 Refactor LauncherCallback to support multiple clients
Bug:137777105 P1 Make clearcut launcher logging feature parity with westworld logging
Bug:137851409 P4 Jank during swipe up due to inflation
Bug:138620399 P1 Quick switch flicker / artifacts
Bug:139016518 P2 [PinnedStackController] Move shelf offset into sysui
Bug:139137636 P2 Create memory tests for Launcher
Bug:139258979 P2 Switch to the screenshot mode when then system passes ThumbnailData back upon RecentsAnimation cancelation
Bug:139259253 P2 Transform multiple app surfaces during app open animation from overview
Bug:139439373 P2 Live tile should switch to screenshot before finishing recents animation
Bug:139828243 P2 Create a prototype for Overview screenshot actions with a SystemUI plugin
Bug:139888225 P2 Convert custom widget into plugins
Bug:139913027 P2 [a11y] App title in Widget list shouldn't be actionable by a11y methods. (It would cause Pixel launcher crash.)
Bug:139917483 P1 [B1C1][Dec19_QPR][CTS_Verifier_10_r1]Pixel launcher crash observed in Device owner test-> Lock Task UI
Bug:139941530 P2 Lab-only Flake: Launcher switches to All Apps after pressing Recents button
Bug:140212732 P2 [PO Cable] Strange launcher behavior after restore
Bug:140242324 P2 Cache shortcutInfo icons in Launcher
Bug:140246642 P4 Add binder tests for launcher interactions
Bug:140311911 P2 Flake in Launcher tests: java.lang.AssertionError: Stable state != state: OverviewState, LauncherState
Bug:140406263 P2 [a11y] Unable to scroll to the left of the main Home screen to Display google app by Voice access or Switch access.
Bug:140539007 P3 After apply the wallpaper on wallpaper picker, the screen will stay on wallpaper picker about 2 second
Bug:140626334 P4 Pass wallpaper SC to launcher for animation during launch and swipe up
Bug:140635319 P1 [Flaky test] testPromiseIcon_addedFromEligibleSession failing due to NPE on Launcher#getStateManager
Bug:140786694 P2 [A11y]No talkback feedback when long pressing on an app at home screen
Bug:140935140 P1 Launcher force close observed while accessing app info shortcuts.
Bug:141260670 P3 Drag and drop preview doesn't match the destination grid size
Bug:141262820 P3 [Grid] icon badge size should scale as the grid size changes
Bug:141265063 P2 Long press on homescreen in between icons doesn't bring up home settings
Bug:141275518 P2 Test WellbeingTests.testPauseAppFromOverview flakes on Cuttlefish
Bug:141315387 P1 [Failing test] 3P launchers + 2 button mode: failed goToOverviewFromHome and goToOverviewFromApp
Bug:141376165 P2 Remove static initializations in Launcher
Bug:141390432 P1 [Failing test] TaplTestsLauncher3 in 2-button mode
Bug:141517004 P1 FallbackRecentsTest.goToOverviewFromHome Failure
Bug:141522764 P1 DefaultLayoutProviderTest failures
Bug:141523101 P1 TaplTestsQuickstep#testAllAppsFromHome,testAllAppsFromOverview failures
Bug:141524555 P1 FallbackRecentsTest.testOverview flake
Bug:141576561 P2 Fix FlagOverrideSampleTest inside robolectric test
Bug:141576665 P2 AddWorkspaceItemsTaskTest broken
Bug:141577881 P2 FileLogTest broken
Bug:141579810 P1 ViewInflationDuringSwipeUp test failures
Bug:141580748 P2 FallbackRecentsTest#testOverview failure
Bug:141697444 P1 TaplTestsLauncher3#testWidgets test failure
Bug:141770616 P2 Flake: Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/deep_shortcuts_container\E'] (visible state: AllApps),
Bug:141772190 P2 Flake: Context menu is still visible afterswiping up to home
Bug:141864547 P2 calendar-stable sometimes fails dialog dismissal on cuttlefish
Bug:141886704 P2 Use app targets to determine input consumer instead of launcher state
Bug:141934188 P2 Automation Test for adding widget automatically
Bug:141939911 P3 Clean up SwipeDetector
Bug:141986013 P2 Update all apps fade interpolators
Bug:142068081 P1 Quick Switch touch swipe dropped, flicker ensues
Bug:142120338 P2 Gmail app (work profile) icon not drawing
Bug:142148773 P2 grid size should not affect widget padding in WidgetsRecyclerView
Bug:142351228 P1 public void testSwipeUp_with_list_widgets() is failing for merge CL
Bug:79868152 P3 Fade out caret with workspace and back in when in Overview
Change-Id: I1160b808b0972c9ea20644d48cf8ea2f9dfc4905
2019-10-14 14:59:59 -07:00
Sunny Goyal 17c72fbb60 Unifying various tracing calls
Change-Id: Iedf6662ad1d7281b850bdc43b3a1e373ce535ac6
2019-10-14 14:23:19 -07:00
Tony Wickham 2f767469ae Merge "Add tests for quick switch from an app and home" into ub-launcher3-qt-future-dev
am: 7a2076e3ab

Change-Id: Id525dae6616757688ccf0e203fefeb9bd6ef08ff
2019-10-14 12:20:37 -07:00
Sreyas Rangaraju 413b0defc0 [automerger skipped] Merge "Create hooks for Recents Card plugin. This adds another card in the Recents Overview space which can show various items." into ub-launcher3-qt-future-dev
am: 65d208211d -s ours
am skip reason: change_id Ifc36639ece8aa6b554bdbd3256f4195b1b220d68 with SHA1 59b148a440 is in history

Change-Id: I67b3ec9b2a9643cadbf5a250aeea7f37c37b07b4
2019-10-14 12:14:49 -07:00
Tony Wickham 7a2076e3ab Merge "Add tests for quick switch from an app and home" into ub-launcher3-qt-future-dev 2019-10-14 19:07:37 +00:00
TreeHugger Robot e1c8f87c46 Merge "Adding tracing for a lab-only flake" into ub-launcher3-master 2019-10-14 18:52:42 +00:00
Tony Wickham 1e73e320b7 Add tests for quick switch from an app and home
Bug: 140252765
Change-Id: I5621b614ae2d8cd3db03cae818cf8b8c1c6cb20f
2019-10-14 11:51:19 -07:00
Sreyas Rangaraju 65d208211d Merge "Create hooks for Recents Card plugin. This adds another card in the Recents Overview space which can show various items." into ub-launcher3-qt-future-dev 2019-10-14 18:41:19 +00:00
vadimt ce25a2bf68 Adding tracing for a lab-only flake
Bug: 142514365
Change-Id: I9c93ecabbcbad6d4683d595587831d8465e62ee8
2019-10-14 11:34:38 -07:00
TreeHugger Robot d2b03972f5 Merge "Suppress ViewInflationDuringSwipeUp test." into ub-launcher3-master 2019-10-14 18:10:34 +00:00
Zak Cohen eb27edffc2 Suppress ViewInflationDuringSwipeUp test.
Test is failing and blocking drop.
Only failing on TH, passing locally.
Tracked in b/141579810

Bug:141579810
Change-Id: Iadf8098cad22835b026984c0a9ea5122054b484b
2019-10-14 10:55:15 -07:00
TreeHugger Robot 4be6169d4e Merge "Fix test bug where launcher throws NPE because it isnt loaded yet." into ub-launcher3-master 2019-10-14 17:49:41 +00:00
android-build-team Robot b478f9a2e1 Snap for 5936682 from 4a1e218bb2 to rvc-release
Change-Id: I37383c1f7b9a72a737dc53f1fb8f222ff1bb0ede
2019-10-12 23:17:30 +00:00
TreeHugger Robot 4009493f3c Merge "Wait for the task to be in recents before validation" into ub-launcher3-master 2019-10-12 00:20:10 +00:00
Winson Chung c062580b5a Wait for the task to be in recents before validation
- There are two issues:
  1) Currently the system does not add the task to the task list until
     the activity starting the task has been resumed (to be fixed in a
     follow up platform CL). When the three activities are started in
     sequence, it's possible for one of the activities to not reach the
     resumed state leading to an unexpected number of recent tasks the
     next time it's fetched.
  2) When swiping up, it may take time for getTasks to return and call
     applyLoadPlan, so try and wait until the task views have had a
     chance to be applied before continuing.
  3) Use the launcher activity tracker instead of activity rule since it
     will return the same activity even after the activity is destroyed
- Move the margin handling to the caller instead of the scroll method

Bug: 141580748
Change-Id: I2b7634f5ac6869ba4b369b3bd60e0f63747c0f0b
2019-10-11 17:10:38 -07:00
Sreyas 8e02d17fa2 Create hooks for Recents Card plugin.
This adds another card in the Recents Overview space which can show various items.

Change-Id: Ifc36639ece8aa6b554bdbd3256f4195b1b220d68
Merged-In: Ifc36639ece8aa6b554bdbd3256f4195b1b220d68
2019-10-11 21:05:08 +00:00
Sreyas Rangaraju 9b2ae4c244 Merge "Create hooks for Recents Card plugin. This adds another card in the Recents Overview space which can show various items." into ub-launcher3-master 2019-10-11 21:03:31 +00:00
Jon Miranda 4d6038e63a Merge "Wait until listeners/end runnable is created before checking icon result." into ub-launcher3-qt-future-dev
am: 3d97fdcfdf

Change-Id: I22b11d50b86da3e50726dada351797a5774f3b3f
2019-10-11 11:53:30 -07:00
Sreyas 59b148a440 Create hooks for Recents Card plugin.
This adds another card in the Recents Overview space which can show various items.

Change-Id: Ifc36639ece8aa6b554bdbd3256f4195b1b220d68
2019-10-11 11:48:22 -07:00
TreeHugger Robot 3d97fdcfdf Merge "Wait until listeners/end runnable is created before checking icon result." into ub-launcher3-qt-future-dev 2019-10-11 18:37:59 +00:00
Bill Yi a55d0e79b4 [automerger skipped] Import translations. DO NOT MERGE am: 76b2775eee -s ours am: 3b4c152218 -s ours
am: 31bb57db5b -s ours
am skip reason: subject contains skip directive

Change-Id: Ibd43c74b6da117af92ab6c208d6d3f9adb94bbd9
2019-10-11 11:17:47 -07:00
Bill Yi c131d69bde [automerger skipped] Import translations. DO NOT MERGE am: e72b993b91 -s ours
am: bb9d555305 -s ours
am skip reason: subject contains skip directive

Change-Id: Ibc5eac1dcc31f89424644f8ce3bcf57481313d1e
2019-10-11 11:17:24 -07:00
Bill Yi 31bb57db5b [automerger skipped] Import translations. DO NOT MERGE am: 76b2775eee -s ours
am: 3b4c152218 -s ours
am skip reason: subject contains skip directive

Change-Id: I2d99bb4269806a217a23c9c212888c725ba75c39
2019-10-11 11:12:45 -07:00
Bill Yi bb9d555305 [automerger skipped] Import translations. DO NOT MERGE
am: e72b993b91 -s ours
am skip reason: subject contains skip directive

Change-Id: I3a5a43d20969a1cef2170edc3be725aa9efb9a4d
2019-10-11 11:12:23 -07:00
Bill Yi 3b4c152218 [automerger skipped] Import translations. DO NOT MERGE
am: 76b2775eee -s ours
am skip reason: subject contains skip directive

Change-Id: If89a18a90a0f7a869340890b22410c25286baf81
2019-10-11 11:10:21 -07:00
Jon Miranda 1dd2e48190 Wait until listeners/end runnable is created before checking icon result.
This prevents the case where original icon is in hidden state, then the
view gets recycled and since there is no listener/end runnable the original
icon is left in the hidden state.

Bug: 142120338
Change-Id: I5f5bfa2a7c70d10869f51edf5c40bbaab1ef93bc
2019-10-11 11:03:26 -07:00
Bill Yi 20ae6826e8 [automerger skipped] Import translations. DO NOT MERGE
am: e2c21704eb -s ours
am skip reason: subject contains skip directive

Change-Id: I314f9f020aa0aadaaee6560083ec807f323d02ba
2019-10-11 10:52:21 -07:00
Bill Yi e2c21704eb Import translations. DO NOT MERGE
Change-Id: I2ce1448b6a7ee5cb455a2fc044336c37e03093aa
Auto-generated-cl: translation import
2019-10-11 08:19:31 -07:00
Bill Yi e72b993b91 Import translations. DO NOT MERGE
Change-Id: Ie268b67529ed9728f79745402d430d007f0f3286
Auto-generated-cl: translation import
2019-10-11 08:15:45 -07:00
Bill Yi 76b2775eee Import translations. DO NOT MERGE
Change-Id: I9dc5e28b5460a89b6b43f114aa4462f65f834d50
Auto-generated-cl: translation import
2019-10-11 08:11:57 -07:00
Xin Li 4a1e218bb2 [automerger skipped] Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" am: db68a15812 am: f73d33c1fc am: a45baaa6f5
am: 20067eb669 -s ours
am skip reason: subject contains skip directive

Change-Id: Iab011b345d2a753c1f567b0781b3fe28b23496ab
2019-10-10 22:08:43 -07:00
Xin Li ba575a150f [automerger skipped] DO NOT MERGE - Merge QP1A.191005.007 into master am: 272ecdce0b am: 87ff33d584 am: ca81ca46e5
am: 57f0330698 -s ours
am skip reason: subject contains skip directive

Change-Id: If6510e9c22a2ecc9bb6cc420270c11cd2c410b9d
2019-10-10 21:51:47 -07:00
Xin Li 20067eb669 Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" am: db68a15812 am: f73d33c1fc
am: a45baaa6f5

Change-Id: I64ec016aa1472ec03f5b9ce3fd758eba506ac327
2019-10-10 21:51:17 -07:00
Xin Li a45baaa6f5 Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" am: db68a15812
am: f73d33c1fc

Change-Id: I36a018d3b0ca376f2afcc934e8e57381e2b46143
2019-10-10 21:38:18 -07:00
Xin Li 57f0330698 DO NOT MERGE - Merge QP1A.191005.007 into master am: 272ecdce0b am: 87ff33d584
am: ca81ca46e5

Change-Id: Ief1a288837d491c74edad5a764247d68a341cdca
2019-10-10 21:33:57 -07:00
Xin Li f73d33c1fc Merge "DO NOT MERGE - Merge QP1A.191005.007 into master"
am: db68a15812

Change-Id: I671da88e2f1229b6e61787ceff16f56fb0978fbb
2019-10-10 21:27:48 -07:00
Xin Li ca81ca46e5 DO NOT MERGE - Merge QP1A.191005.007 into master am: 272ecdce0b
am: 87ff33d584

Change-Id: Ie9a283dec133135d7d85866f4452d1ba172fc657
2019-10-10 21:21:42 -07:00
Xin Li 87ff33d584 DO NOT MERGE - Merge QP1A.191005.007 into master
am: 272ecdce0b

Change-Id: Ie04781fc9e73dac178495bbc1e031f868d36f90a
2019-10-10 21:11:18 -07:00
Xin Li db68a15812 Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" 2019-10-11 02:56:39 +00:00
Winson Chung c039634c25 Workaround for failing test & fix scrolling in tests
- Workaround issue where instrumentation will fail to finish an activity
  causing the activity to linger longer than expected (leading to issues
  with ordering of static resources like the app widget host registration)
- Fix calculation for scrolling the screen, the previous calculation
  would result in the gesture starting at the left gesture margin due
  to rounding which can trigger a back action instead of the desired
  scroll

Bug: 142351228
Change-Id: I34bdb471030518d2b983cac2badd4d8b0e7d571b
2019-10-10 17:31:38 -07:00
Xin Li 272ecdce0b DO NOT MERGE - Merge QP1A.191005.007 into master
Bug: 142297020
Change-Id: I8ee6a4e97c145226a5a943a0882925c8c9525c81
2019-10-10 22:53:35 +00:00
android-build-team Robot 63791b9a67 Snap for 5931403 from eec392b67a to rvc-release
Change-Id: I752d199c874c1bd84ee7f08b90f00b8cb72250e5
2019-10-10 03:09:29 +00:00
android-build-team Robot d65611bf85 Merge cherrypicks of [9530040, 9530338, 9530339, 9530041, 9530042, 9530043, 9530784, 9530785, 9530786] into qt-qpr1-release
Change-Id: If7383c1979c3fb734669080f52a14f942be49341
2019-10-10 00:46:12 +00:00
Tony Wickham ddd057e87c Fix quickswitch flickers/ignored swipes
- Don't set current page to running task when applying load plan,
  if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
  the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
  already on it. This was setting mNextPage so the first check
  was falsing.

Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
Merged-In: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
(cherry picked from commit af33f2c9d4)
(cherry picked from commit 4d86c804ba)
2019-10-10 00:45:35 +00:00
Tony Wickham 05be86068f Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
(cherry picked from commit c9654eb091)
(cherry picked from commit 2784315f7d)
(cherry picked from commit 80090d579f)
2019-10-10 00:45:29 +00:00